[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218942035 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,54 @@ private static final

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218939333 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -98,21 +98,32 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218930135 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,43 @@ private static final

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218926387 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -77,17 +82,43 @@ private static final

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218925291 --- Diff: common/network-common/src/test/java/org/apache/spark/network/ChunkFetchRequestHandlerSuite.java --- @@ -0,0 +1,102 @@ +/* + * Licensed

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218924768 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218924588 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -173,5 +213,14 @@ private TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218874415 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +284,44 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218812564 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +284,44 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218812503 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +284,44 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218811827 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java --- @@ -32,7 +41,6 @@ import

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218811721 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java --- @@ -24,6 +24,15 @@ import

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r21885 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,134 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-19 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218807868 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,134 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218621553 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218590278 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218562181 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218559203 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218508374 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218466733 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218533001 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218465153 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218468244 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218533702 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218462401 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218467664 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218465817 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +163,21 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218490559 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +163,21 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218494508 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java --- @@ -24,15 +24,27 @@ import

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218463768 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -88,6 +97,16 @@ public TransportContext(

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-18 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218466397 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-17 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r218163618 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216074852 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216069578 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216068689 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216004740 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216063759 --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java --- @@ -0,0 +1,136 @@ +/* + *

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216006120 --- Diff: common/network-common/src/test/java/org/apache/spark/network/ExtendedChannelPromise.java --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216057933 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216005883 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216005916 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-09-07 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r216005137 --- Diff: common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java --- @@ -281,4 +282,31 @@ public Properties cryptoConf() {

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-08-24 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r212639516 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +161,17 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-08-22 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22173#discussion_r212070669 --- Diff: common/network-common/src/main/java/org/apache/spark/network/TransportContext.java --- @@ -144,14 +161,17 @@ public TransportChannelHandler

[GitHub] spark pull request #22173: [SPARK-24335] Spark external shuffle server impro...

2018-08-21 Thread redsanket
GitHub user redsanket opened a pull request: https://github.com/apache/spark/pull/22173 [SPARK-24335] Spark external shuffle server improvement to better handle block fetch requests. ## What changes were proposed in this pull request? This is a continuation PR from