[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23148 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236858392 --- Diff: dev/.scalafmt.conf --- @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236830497 --- Diff: dev/.scalafmt.conf --- @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236824453 --- Diff: dev/.scalafmt.conf --- @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236813956 --- Diff: dev/.scalafmt.conf --- @@ -0,0 +1,24 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236423672 --- Diff: .scalafmt.conf --- @@ -0,0 +1,24 @@ +# --- End diff -- Sure, moved ---

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user koeninger commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236423438 --- Diff: pom.xml --- @@ -156,6 +156,10 @@ 3.2.2 2.12.7 2.12 +1.5.1 --- End diff -- I moved the scalafmt

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236421304 --- Diff: .scalafmt.conf --- @@ -0,0 +1,24 @@ +# --- End diff -- Can this file live in dev/? I tried to stuff as many things in there as I

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23148#discussion_r236421583 --- Diff: pom.xml --- @@ -156,6 +156,10 @@ 3.2.2 2.12.7 2.12 +1.5.1 --- End diff -- If these are all just

[GitHub] spark pull request #23148: [SPARK-26177] Automated formatting for Scala code

GitHub user koeninger opened a pull request: https://github.com/apache/spark/pull/23148 [SPARK-26177] Automated formatting for Scala code ## What changes were proposed in this pull request? Add a maven plugin and wrapper script at ./dev/scalafmt to use scalafmt to format