cloud-fan closed pull request #45704: [SPARK-47476][SQL] Support REPLACE
function to work with collated strings
URL: https://github.com/apache/spark/pull/45704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cloud-fan commented on PR #45704:
URL: https://github.com/apache/spark/pull/45704#issuecomment-2079601554
the Spark Connect test failure is flaky and unrelated here, I'm merging it
to master, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
uros-db commented on PR #45704:
URL: https://github.com/apache/spark/pull/45704#issuecomment-2049812864
heads up: we’ve done some major code restructuring in
https://github.com/apache/spark/pull/45978, so please sync these changes before
moving on
@miland-db you’ll likely need to
mihailom-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1550983282
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -735,23 +735,43 @@ case class EndsWith(left: Expression,
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1550968988
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -735,23 +735,43 @@ case class EndsWith(left: Expression, right:
miland-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1549660968
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1549420147
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,56 @@ public UTF8String replace(UTF8String search, UTF8String
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1547414846
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1547414846
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1547414846
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
miland-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1547378344
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546514048
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,57 @@ public UTF8String replace(UTF8String search, UTF8String
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546514048
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,57 @@ public UTF8String replace(UTF8String search, UTF8String
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546513659
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -179,12 +179,26 @@ public static StringSearch getStringSearch(
miland-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r154632
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546263792
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala:
##
@@ -740,18 +740,39 @@ case class StringReplace(srcExpr:
uros-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1546263160
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
miland-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1539225999
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
cloud-fan commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1539215853
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
miland-db commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1538955710
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
cloud-fan commented on code in PR #45704:
URL: https://github.com/apache/spark/pull/45704#discussion_r1538624688
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -1136,6 +1136,104 @@ public UTF8String replace(UTF8String search, UTF8String
21 matches
Mail list logo
