Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-10 Thread via GitHub
cloud-fan closed pull request #45945: [SPARK-47775][SQL] Support remaining scalar types in the variant spec. URL: https://github.com/apache/spark/pull/45945 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-10 Thread via GitHub
cloud-fan commented on PR #45945: URL: https://github.com/apache/spark/pull/45945#issuecomment-2047765218 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-10 Thread via GitHub
chenhao-db commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1559545416 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala: ## @@ -248,9 +253,10 @@ case object VariantGet {

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-10 Thread via GitHub
cloud-fan commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1558932654 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/variant/variantExpressions.scala: ## @@ -248,9 +253,10 @@ case object VariantGet {

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-09 Thread via GitHub
chenhao-db commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1558098749 ## common/variant/src/main/java/org/apache/spark/types/variant/Variant.java: ## @@ -89,6 +97,37 @@ public BigDecimal getDecimal() { return

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-09 Thread via GitHub
cloud-fan commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1557634726 ## common/variant/src/main/java/org/apache/spark/types/variant/Variant.java: ## @@ -89,6 +97,37 @@ public BigDecimal getDecimal() { return

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-09 Thread via GitHub
cloud-fan commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1557634726 ## common/variant/src/main/java/org/apache/spark/types/variant/Variant.java: ## @@ -89,6 +97,37 @@ public BigDecimal getDecimal() { return

Re: [PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-09 Thread via GitHub
cloud-fan commented on code in PR #45945: URL: https://github.com/apache/spark/pull/45945#discussion_r1557628324 ## common/variant/src/main/java/org/apache/spark/types/variant/Variant.java: ## @@ -89,6 +97,37 @@ public BigDecimal getDecimal() { return

[PR] [SPARK-47775][SQL] Support remaining scalar types in the variant spec. [spark]

2024-04-08 Thread via GitHub
chenhao-db opened a new pull request, #45945: URL: https://github.com/apache/spark/pull/45945 ### What changes were proposed in this pull request? This PR adds support for the remaining scalar types defined in the variant spec (DATE, TIMESTAMP, TIMESTAMP_NTZ, FLOAT, BINARY). The