Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
HyukjinKwon closed pull request #46155: [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic URL: https://github.com/apache/spark/pull/46155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
HyukjinKwon commented on PR #46155: URL: https://github.com/apache/spark/pull/46155#issuecomment-2071421918 Merged to master. For naming, I will send an email soon. For others, please leave the comments. I will followup. -- This is an automated message from the Apache Git

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
HyukjinKwon commented on code in PR #46155: URL: https://github.com/apache/spark/pull/46155#discussion_r1575562214 ## python/pyspark/ml/connect/functions.py: ## @@ -15,7 +15,7 @@ # limitations under the License. # from pyspark.ml import functions as PyMLFunctions -from

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
HyukjinKwon commented on code in PR #46155: URL: https://github.com/apache/spark/pull/46155#discussion_r1575561525 ## python/pyspark/ml/stat.py: ## @@ -22,7 +22,8 @@ from pyspark.ml.common import _java2py, _py2java from pyspark.ml.linalg import Matrix, Vector from

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
ueshin commented on code in PR #46155: URL: https://github.com/apache/spark/pull/46155#discussion_r1575225973 ## python/pyspark/ml/stat.py: ## @@ -22,7 +22,8 @@ from pyspark.ml.common import _java2py, _py2java from pyspark.ml.linalg import Matrix, Vector from

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #46155: URL: https://github.com/apache/spark/pull/46155#issuecomment-2070288112 Sure, please proceed it. We can discuss the naming separately, @HyukjinKwon . -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-22 Thread via GitHub
HyukjinKwon commented on PR #46155: URL: https://github.com/apache/spark/pull/46155#issuecomment-2068933950 Let me run this naming stuff separately (maybe sending an email to the dev mailing list) because Spark Classic has been used in other places lately in any event. -- This is an

[PR] [SPARK-47933][PYTHON] Parent Column class for Spark Connect and Spark Classic [spark]

2024-04-21 Thread via GitHub
HyukjinKwon opened a new pull request, #46155: URL: https://github.com/apache/spark/pull/46155 ### What changes were proposed in this pull request? Same as https://github.com/apache/spark/pull/46129 but for `Column` class. ### Why are the changes needed? Same as