Re: [PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-17 Thread via GitHub
panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568360558 ## common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala: ## @@ -63,83 +68,122 @@ object LogKey extends Enumeration { val CSV_SCHEMA_FIELD_NAME =

Re: [PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-17 Thread via GitHub
panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568352067 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CheckpointFileManager.scala: ## @@ -274,7 +275,8 @@ class

Re: [PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-17 Thread via GitHub
panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568326394 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala: ## @@ -354,9 +355,13 @@ private[sql] class

Re: [PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-17 Thread via GitHub
panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568270967 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousTextSocketSource.scala: ## @@ -179,7 +180,7 @@ class

Re: [PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-16 Thread via GitHub
panbingkun commented on code in PR #46057: URL: https://github.com/apache/spark/pull/46057#discussion_r1568232939 ## common/utils/src/main/scala/org/apache/spark/internal/LogKey.scala: ## @@ -172,12 +228,16 @@ object LogKey extends Enumeration { val TOPIC_PARTITION = Value

[PR] [WIP][SPARK-47584][SQL] SQL core: Migrate logWarn with variables to structured logging framework [spark]

2024-04-15 Thread via GitHub
panbingkun opened a new pull request, #46057: URL: https://github.com/apache/spark/pull/46057 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How