[GitHub] spark pull request: [SPARK-2752]spark sql cli should not exit when...

2014-07-31 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1661#discussion_r15627250 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -288,33 +288,36 @@ private[hive]

[GitHub] spark pull request: SPARK-2766: ScalaReflectionSuite throw an lleg...

2014-07-31 Thread witgo
GitHub user witgo opened a pull request: https://github.com/apache/spark/pull/1683 SPARK-2766: ScalaReflectionSuite throw an llegalArgumentException in JDK 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/witgo/spark

[GitHub] spark pull request: [SPARK-2010] [PySpark] [SQL] support nested st...

2014-07-31 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1598#issuecomment-50716626 Sure, sounds good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2550][MLLIB][APACHE SPARK] Support regu...

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1624#discussion_r15627450 --- Diff: python/pyspark/mllib/regression.py --- @@ -109,18 +109,45 @@ class LinearRegressionModel(LinearRegressionModelBase): True

[GitHub] spark pull request: [SPARK-2550][MLLIB][APACHE SPARK] Support regu...

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1624#discussion_r15627458 --- Diff: python/pyspark/mllib/regression.py --- @@ -109,18 +109,45 @@ class LinearRegressionModel(LinearRegressionModelBase): True

[GitHub] spark pull request: [SPARK-2550][MLLIB][APACHE SPARK] Support regu...

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1624#discussion_r15627471 --- Diff: python/pyspark/mllib/regression.py --- @@ -109,18 +109,45 @@ class LinearRegressionModel(LinearRegressionModelBase): True

[GitHub] spark pull request: [SPARK-2550][MLLIB][APACHE SPARK] Support regu...

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1624#discussion_r15627468 --- Diff: python/pyspark/mllib/regression.py --- @@ -109,18 +109,45 @@ class LinearRegressionModel(LinearRegressionModelBase): True

[GitHub] spark pull request: [SPARK-2550][MLLIB][APACHE SPARK] Support regu...

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1624#discussion_r15627480 --- Diff: python/pyspark/mllib/regression.py --- @@ -109,18 +109,45 @@ class LinearRegressionModel(LinearRegressionModelBase): True

[GitHub] spark pull request: [SQL][SPARK-2212]Hash Outer Join

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1147#issuecomment-50716934 QA tests have started for PR 1147. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17560/consoleFull ---

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/1673#issuecomment-50716977 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2737] Add retag() method for changing R...

2014-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627517 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -69,25 +73,32 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627507 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -69,25 +73,32 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627514 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -69,25 +73,32 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627527 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -100,16 +111,57 @@ object DecisionTreeRunner { }

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627524 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -100,16 +111,57 @@ object DecisionTreeRunner { }

[GitHub] spark pull request: [SPARK-2752]spark sql cli should not exit when...

2014-07-31 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1661#discussion_r15627597 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -288,33 +288,36 @@ private[hive]

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627594 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -100,16 +111,57 @@ object DecisionTreeRunner { }

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50717598 QA tests have started for PR 1681. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17562/consoleFull ---

[GitHub] spark pull request: [SPARK-2010] [PySpark] [SQL] support nested st...

2014-07-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/1598#issuecomment-50717628 This feature will slow down normal access (by attribute or position), so I did not put it in. User still can use position to access the field with special names (such as

[GitHub] spark pull request: [SPARK-2010] [PySpark] [SQL] support nested st...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1598#issuecomment-50717656 QA tests have started for PR 1598. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17563/consoleFull ---

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1671#issuecomment-50718111 QA results for PR 1671:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50718143 QA results for PR 1256:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: [SPARK-1812] [WIP] Scala 2.11 support

2014-07-31 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/1649#issuecomment-50718152 Hey Anand, This looks like a very nice effort !, It would be very convenient if you can break this pull request into smaller subtasks. For example

[GitHub] spark pull request: SPARK-2632, SPARK-2576. Fixed by only importin...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1635#issuecomment-50718130 QA results for PR 1635:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: SPARK-2532: Minimal shuffle consolidation fixe...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1678#issuecomment-50718100 QA results for PR 1678:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: SPARK-2532: Minimal shuffle consolidation fixe...

2014-07-31 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/spark/pull/1678#issuecomment-50718425 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627787 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -100,16 +111,57 @@ object DecisionTreeRunner { }

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-31 Thread witgo
Github user witgo commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50718557 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627842 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -100,16 +111,57 @@ object DecisionTreeRunner { }

[GitHub] spark pull request: [SPARK-1740] [PySpark] kill the python worker

2014-07-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/1643#issuecomment-50718757 Good question, it's dangerous to mix threads and fork(), it may be cause dead lock in child process. But in this case, because of GIL, then fork() happens, monitor thread

[GitHub] spark pull request: SPARK-2532: Minimal shuffle consolidation fixe...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1678#issuecomment-50718818 QA tests have started for PR 1678. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17565/consoleFull ---

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50718809 QA tests have started for PR 1256. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17564/consoleFull ---

[GitHub] spark pull request: [SPARK-1740] [PySpark] kill the python worker

2014-07-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/1643#issuecomment-50718956 I will wait for your patch, and think about using PIDs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627893 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/DecisionTreeRunner.scala --- @@ -48,11 +50,13 @@ object DecisionTreeRunner {

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15627927 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -598,9 +598,12 @@ object DecisionTree extends Serializable with Logging {

[GitHub] spark pull request: Remove unnecessary Code from spark-shell.cmd

2014-07-31 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/666#issuecomment-50719523 Close this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: Remove unnecessary Code from spark-shell.cmd

2014-07-31 Thread techaddict
Github user techaddict closed the pull request at: https://github.com/apache/spark/pull/666 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-1812] [WIP] Scala 2.11 support

2014-07-31 Thread avati
Github user avati commented on the pull request: https://github.com/apache/spark/pull/1649#issuecomment-50720340 I will split this up into multiple PRs. I will start with a small pull request for akka upgrade to 2.3. However as Sean mentioned, I guess we are stuck on the

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628159 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -612,27 +615,31 @@ object DecisionTree extends Serializable with Logging

[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...

2014-07-31 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1615#issuecomment-50720702 @rxin @javadba - I believe this is covered already in the maven docs: http://spark.apache.org/docs/latest/building-with-maven.html#spark-tests-in-maven --- If

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628197 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -815,20 +822,10 @@ object DecisionTree extends Serializable with Logging

[GitHub] spark pull request: SPARK-2712 - Add a small note to maven doc tha...

2014-07-31 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1615#issuecomment-50720880 maybe it would make sense to just enhance the existing section and clearly show that you need to run mvn package and then mvn test with a similar code block to the one

[GitHub] spark pull request: [WIP] [SPARK-2764] Simplify daemon.py process ...

2014-07-31 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/1680#discussion_r15628219 --- Diff: python/pyspark/daemon.py --- @@ -176,13 +120,30 @@ def handle_sigchld(*args): try: while not should_exit():

[GitHub] spark pull request: [SPARK-2752]spark sql cli should not exit when...

2014-07-31 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/1661#discussion_r15628242 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -288,33 +288,36 @@ private[hive]

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628238 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -845,33 +842,15 @@ object DecisionTree extends Serializable with Logging

[GitHub] spark pull request: [SPARK-2752]spark sql cli should not exit when...

2014-07-31 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/1661#issuecomment-50721059 LGTM except some styling issues. Thanks for working on this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [WIP] [SPARK-2764] Simplify daemon.py process ...

2014-07-31 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/1680#discussion_r15628262 --- Diff: python/pyspark/daemon.py --- @@ -176,13 +120,30 @@ def handle_sigchld(*args): try: while not should_exit():

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628281 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingRegression.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50721262 LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [WIP] [SPARK-2764] Simplify daemon.py process ...

2014-07-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/1680#issuecomment-50721351 Why we had multiple listen process before? How about the performance of fork() in EC2? I met that fork() will take 200ms in Xen VM. --- If your project is set up for it,

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628342 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala --- @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628354 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/regression/StreamingLinearRegressionSuite.scala --- @@ -0,0 +1,127 @@ +/* + * Licensed to

[GitHub] spark pull request: [WIP] [SPARK-2764] Simplify daemon.py process ...

2014-07-31 Thread jey
Github user jey commented on the pull request: https://github.com/apache/spark/pull/1680#issuecomment-50721572 I agree with this design; the preforking was basically vestigial and should have been removed. I'll review this PR later this week. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-2523] [SQL] Hadoop table scan bug fixin...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1669#issuecomment-50721673 QA results for PR 1669:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628373 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingRegression.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628387 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingRegression.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628405 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingRegression.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628426 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingLinearRegression.scala --- @@ -0,0 +1,104 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628435 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala --- @@ -91,4 +91,59 @@ class Node ( } } } + +

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628444 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala --- @@ -91,4 +91,59 @@ class Node ( } } } + +

[GitHub] spark pull request: Streaming mllib [SPARK-2438][MLLIB]

2014-07-31 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/1361#discussion_r15628448 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/regression/StreamingRegression.scala --- @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1681#discussion_r15628468 --- Diff: docs/sql-programming-guide.md --- @@ -769,3 +769,15 @@ To start the Spark SQL CLI, run the following in the Spark directory: Configuration of

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628483 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala --- @@ -91,4 +91,59 @@ class Node ( } } } + +

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628492 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala --- @@ -91,4 +91,59 @@ class Node ( } } } + +

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread pwendell
Github user pwendell commented on a diff in the pull request: https://github.com/apache/spark/pull/1681#discussion_r15628521 --- Diff: docs/sql-programming-guide.md --- @@ -769,3 +769,15 @@ To start the Spark SQL CLI, run the following in the Spark directory: Configuration of

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628533 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala --- @@ -91,4 +91,59 @@ class Node ( } } } + +

[GitHub] spark pull request: [SPARK-2314][SQL] Override collect and take in...

2014-07-31 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/1592#issuecomment-50722408 @staple Could you hold it one more days until we merge the changes in #1598 about serialization between Java and Python? --- If your project is set up for it, you can

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50722530 QA tests have started for PR 1681. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17567/consoleFull ---

[GitHub] spark pull request: automatically set master according to `spark.m...

2014-07-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628610 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -31,6 +30,18 @@ import

[GitHub] spark pull request: [SPARK-2314][SQL] Override collect and take in...

2014-07-31 Thread staple
Github user staple commented on the pull request: https://github.com/apache/spark/pull/1592#issuecomment-50722658 Sure, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-2756] [mllib] Decision tree bug fixes

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1673#discussion_r15628659 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/tree/DecisionTreeSuite.scala --- @@ -602,12 +609,78 @@ class DecisionTreeSuite extends FunSuite with

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50723566 QA results for PR 1681:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2010] [PySpark] [SQL] support nested st...

2014-07-31 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1598#issuecomment-50723544 Ah okay, then I'm fine leaving that out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread CrazyJvm
Github user CrazyJvm commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50723525 thanks @pwendell , already fixed according to your suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-2670] FetchFailedException should be th...

2014-07-31 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1578#discussion_r15628876 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockFetcherIterator.scala --- @@ -199,15 +199,22 @@ object BlockFetcherIterator { // Get

[GitHub] spark pull request: SPARK-2532: Minimal shuffle consolidation fixe...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1678#issuecomment-50724029 QA results for PR 1678:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1671#issuecomment-50724374 QA tests have started for PR 1671. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17569/consoleFull ---

[GitHub] spark pull request: Fix conflict between code and doc in YarnClien...

2014-07-31 Thread li-zhihui
GitHub user li-zhihui opened a pull request: https://github.com/apache/spark/pull/1684 Fix conflict between code and doc in YarnClientSchedulerBackend.scala Doc say: system properties override environment variables.

[GitHub] spark pull request: Fix conflict between code and doc in YarnClien...

2014-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1684#issuecomment-50725105 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-2098: All Spark processes should support...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1256#issuecomment-50725686 QA results for PR 1256:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: [SQL][SPARK-2212]Hash Outer Join

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1147#issuecomment-50725881 QA results for PR 1147:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brtrait

[GitHub] spark pull request: [SPARK-2288] Hide ShuffleBlockManager behind S...

2014-07-31 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1241#issuecomment-50725957 @colorant thanks for doing this, but we should probably wait to merge it until after 1.1, since it doesn't add critical fixes for 1.1. I'll take a look at it after I'm

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1671#discussion_r15629090 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/IDF.scala --- @@ -0,0 +1,194 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-2010] [PySpark] [SQL] support nested st...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1598#issuecomment-50726056 QA results for PR 1598:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: [SPARK-2752]spark sql cli should not exit when...

2014-07-31 Thread scwf
Github user scwf commented on a diff in the pull request: https://github.com/apache/spark/pull/1661#discussion_r15629155 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala --- @@ -288,33 +288,36 @@ private[hive] class

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1671#discussion_r15629148 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1671#issuecomment-50726519 Looks good to me API-wise, though I haven't checked the math in detail. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: SPARK-2134: Report metrics before application ...

2014-07-31 Thread mateiz
Github user mateiz commented on a diff in the pull request: https://github.com/apache/spark/pull/1076#discussion_r15629314 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala --- @@ -154,6 +154,8 @@ private[spark] class Master( } override

[GitHub] spark pull request: SPARK-2134: Report metrics before application ...

2014-07-31 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1076#issuecomment-50726663 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-2134: Report metrics before application ...

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1076#issuecomment-50726957 QA tests have started for PR 1076. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17570/consoleFull ---

[GitHub] spark pull request: [SPARK-2022] Fix extra java config to spark cl...

2014-07-31 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/1622#issuecomment-50728294 @pwendell I wonder how do I get reviews on patches? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-1812] akka 2.3.4

2014-07-31 Thread avati
GitHub user avati opened a pull request: https://github.com/apache/spark/pull/1685 [SPARK-1812] akka 2.3.4 Upgrade to akka 2.3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/avati/spark SPARK-1812-akka-2.3 Alternatively you

[GitHub] spark pull request: [SPARK-1812] akka 2.3.4

2014-07-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1685#issuecomment-50728629 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: add cacheTable guide

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1681#issuecomment-50728800 QA results for PR 1681:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2729] [SQL] Forgot to match Timestamp t...

2014-07-31 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/1636#issuecomment-50729675 @chutium Michael is right, `NullableColumnBuilderSuite` doesn't call `ColumnBuilder.apply`, thus it always passes. But adding `TIMESTAMP` still makes sense. Actually,

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1671#issuecomment-50729982 QA results for PR 1671:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brclass

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1671#issuecomment-50730369 QA tests have started for PR 1671. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17571/consoleFull ---

[GitHub] spark pull request: [SPARK-2511][MLLIB] add HashingTF and IDF

2014-07-31 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/1671#discussion_r15630475 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/HashingTF.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   3   4   5   6   >