[GitHub] spark pull request: [WIP] [SPARK-4031] Make torrent broadcast read...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2871#issuecomment-60040371 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22018/consoleFull) for PR 2871 at commit

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19195658 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [WIP] [SPARK-4031] Make torrent broadcast read...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2871#issuecomment-60040376 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3161][MLLIB] Adding a node Id caching m...

2014-10-22 Thread codedeft
Github user codedeft commented on a diff in the pull request: https://github.com/apache/spark/pull/2868#discussion_r19195671 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala --- @@ -553,7 +589,26 @@ object DecisionTree extends Serializable with Logging

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2882#issuecomment-60040386 This is nice work overall. I like the thorough tests, especially the decoupling of the writer / reader tests so that you can test the components separately and as

[GitHub] spark pull request: [WIP][SPARK-3795] Heuristics for dynamically s...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-60040481 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22020/consoleFull) for PR 2746 at commit

[GitHub] spark pull request: [WIP][SPARK-3795] Heuristics for dynamically s...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-60040484 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60040650 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22022/consoleFull) for PR 2851 at commit

[GitHub] spark pull request: [WIP][SPARK-3795] Heuristics for dynamically s...

2014-10-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-60040691 Hey Andrew - I looked at this and I had some small suggestions around naming. However, there is a big open question here relating to the semantics of

[GitHub] spark pull request: [SPARK-4016] Allow user to show/hide UI metric...

2014-10-22 Thread kayousterhout
Github user kayousterhout commented on the pull request: https://github.com/apache/spark/pull/2867#issuecomment-60041059 @ash211 that's a great idea, I'll add that and incorporate @andrewor14's suggestion about a drop-down menu. Thanks all! --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60041142 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-22 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-60041268 Not sure which is better ! Creating an empty project with just a pom file in it. Or depending on random jar from maven central. ? I prefer first approach. --- If

[GitHub] spark pull request: [WIP][SPARK-3795] Heuristics for dynamically s...

2014-10-22 Thread sryza
Github user sryza commented on the pull request: https://github.com/apache/spark/pull/2746#issuecomment-60041418 YARN provides (2). After an app makes a request for X executors, YARN keeps track of them until the app goes away. In fact, the API to YARN isn't I want X more

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60041575 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22023/consoleFull) for PR 2851 at commit

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60042970 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22022/consoleFull) for PR 2851 at commit

[GitHub] spark pull request: [SPARK-4033][Examples]Input of the SparkPi too...

2014-10-22 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/2874#discussion_r19196544 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkPi.scala --- @@ -27,7 +27,7 @@ object SparkPi { val conf = new

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60042976 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4033][Examples]Input of the SparkPi too...

2014-10-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2874#issuecomment-60043115 @SaintBacchus sure, maybe this is used as a load test in some situations. What if n map tasks computed 10 iterations each (or some smaller quantum)? rather than

[GitHub] spark pull request: [SPARK-4033][Examples]Input of the SparkPi too...

2014-10-22 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/2874#discussion_r19196652 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkPi.scala --- @@ -27,7 +27,7 @@ object SparkPi { val conf = new

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread liancheng
GitHub user liancheng opened a pull request: https://github.com/apache/spark/pull/2887 [SPARK-4037][SQL] Removes the SessionState instance created in HiveThriftServer2 `HiveThriftServer2` creates a global singleton `SessionState` instance and overrides `HiveContext` to inject the

[GitHub] spark pull request: [GraphX] Modify option name according to examp...

2014-10-22 Thread GraceH
GitHub user GraceH opened a pull request: https://github.com/apache/spark/pull/2888 [GraphX] Modify option name according to example doc in SynthBenchmark Now graphx.SynthBenchmark example has an option of iteration number named as niter. However, in its document, it is named as

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60043829 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22024/consoleFull) for PR 2887 at commit

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60043790 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22023/consoleFull) for PR 2851 at commit

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-60043845 I'll just publish an empty jar in maven central - we can use it forever. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: Fix for sampling error in NumPy v1.9 [SPARK-39...

2014-10-22 Thread freeman-lab
GitHub user freeman-lab opened a pull request: https://github.com/apache/spark/pull/2889 Fix for sampling error in NumPy v1.9 [SPARK-3995][PYSPARK] Change maximum value for default seed during RDD sampling so that it is strictly less than 2 ** 32. This prevents a bug in the most

[GitHub] spark pull request: [GraphX] Modify option name according to examp...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2888#issuecomment-60043984 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: Fix for sampling error in NumPy v1.9 [SPARK-39...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2889#issuecomment-60044143 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22025/consoleFull) for PR 2889 at commit

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/2890 [SPARK-3426] Fix sort-based shuffle error when spark.shuffle.compress and spark.shuffle.spill.compress settings are different This PR fixes SPARK-3426, an issue where sort-based shuffle crashes

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60043794 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2890#issuecomment-60044314 FYI, this should be backported to `branch-1.1`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3812] [BUILD] Adapt maven build to publ...

2014-10-22 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2673#issuecomment-60044464 I created a jar you can use. It might take a couple of hours to propagate to maven central: ``` groupIdorg.spark-project.spark/groupId

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2890#issuecomment-60044465 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22026/consoleFull) for PR 2890 at commit

[GitHub] spark pull request: [SPARK-3537][SPARK-3914][SQL] Refines in-memor...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2860#issuecomment-60044460 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22027/consoleFull) for PR 2860 at commit

[GitHub] spark pull request: Update JavaCustomReceiver.java

2014-10-22 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2699#issuecomment-60044780 LGTM. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread ScrapCodes
Github user ScrapCodes commented on a diff in the pull request: https://github.com/apache/spark/pull/771#discussion_r19197267 --- Diff: core/src/main/scala/org/apache/spark/deploy/master/PersistenceEngine.scala --- @@ -26,35 +30,58 @@ package org.apache.spark.deploy.master *

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2890#discussion_r19197345 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala --- @@ -259,7 +264,7 @@ private[spark] class ExternalSorter[K, V, C](

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/2890#discussion_r19197366 --- Diff: core/src/test/scala/org/apache/spark/ShuffleSuite.scala --- @@ -242,6 +242,28 @@ abstract class ShuffleSuite extends FunSuite with Matchers with

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/2890#issuecomment-60045095 This LGTM pending a few minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [WIP] [SPARK-4031] Make torrent broadcast read...

2014-10-22 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/2871#discussion_r19197492 --- Diff: core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala --- @@ -63,12 +63,22 @@ private[spark] class TorrentBroadcast[T: ClassTag](

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19197515 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [Spark-4041][SQL]attributes names in table sca...

2014-10-22 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2884#discussion_r19197580 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTableScan.scala --- @@ -81,7 +81,8 @@ case class HiveTableScan( //

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19197661 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19197745 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19197871 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogManager.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19197947 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/util/WriteAheadLogWriter.scala --- @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19198008 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: Update JavaCustomReceiver.java

2014-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2699 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/2882#discussion_r19198019 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/util/WriteAheadLogSuite.scala --- @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60046864 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60046859 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22024/consoleFull) for PR 2887 at commit

[GitHub] spark pull request: [SPARK-4026][Streaming] Write ahead log manage...

2014-10-22 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/2882#issuecomment-60047058 Yes, the deletion is completely application specific and it is left for the application of the WAL to decide when to cleanup. In case of Spark Streaming, the

[GitHub] spark pull request: Sbt and Maven builds pass on Linux boxes with ...

2014-10-22 Thread luchesar
Github user luchesar commented on the pull request: https://github.com/apache/spark/pull/2883#issuecomment-60047780 I have a Linux box with encrypted home folder on ext4 File system. Ext4's max file name length is 255 bytes. scalac will generate class file names like that for

[GitHub] spark pull request: [SPARK-3957]: show broadcast variable resource...

2014-10-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2851#issuecomment-60048094 Can't we just have a general block reporting mechanism rather than special casing for broadcast? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: Sbt and Maven builds pass on Linux boxes with ...

2014-10-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/2883#issuecomment-60048089 I wonder if this has any other implications for the build though, as class names generated by the build could be different from those generated by, say, compiling with a

[GitHub] spark pull request: use isRunningLocally rather than runningLocall...

2014-10-22 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/2879#issuecomment-60048272 Merging in master. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/771#issuecomment-60048629 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22028/consoleFull) for PR 771 at commit

[GitHub] spark pull request: [SPARK-3537][SPARK-3914][SQL] Refines in-memor...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2860#issuecomment-60048900 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3537][SPARK-3914][SQL] Refines in-memor...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2860#issuecomment-60048895 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22027/consoleFull) for PR 2860 at commit

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/771#issuecomment-60048869 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22028/consoleFull) for PR 771 at commit

[GitHub] spark pull request: [SPARK-3959][SPARK-3960][SQL] SqlParser fails ...

2014-10-22 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2816#issuecomment-60049213 @yhuai I could fix what you pointed. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/771#issuecomment-60049581 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22030/consoleFull) for PR 771 at commit

[GitHub] spark pull request: [SPARK-3959][SPARK-3960][SQL] SqlParser fails ...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2816#issuecomment-60049567 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22029/consoleFull) for PR 2816 at commit

[GitHub] spark pull request: Fix for sampling error in NumPy v1.9 [SPARK-39...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2889#issuecomment-60049796 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22025/consoleFull) for PR 2889 at commit

[GitHub] spark pull request: Fix for sampling error in NumPy v1.9 [SPARK-39...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2889#issuecomment-60049804 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread sarutak
GitHub user sarutak opened a pull request: https://github.com/apache/spark/pull/2891 [SPARK-4045][SQL] BinaryArithmetic cannot implicitly cast StringType to DoubleType If we use StringType for a operand for BinaryArithmetic, the operand is coerced to be DoubleType. I think,

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2890#issuecomment-60050565 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22026/consoleFull) for PR 2890 at commit

[GitHub] spark pull request: [SPARK-3426] Fix sort-based shuffle error when...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2890#issuecomment-60050570 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-4041][SQL]attributes names in table sca...

2014-10-22 Thread scwf
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/2884#issuecomment-60050626 @yhuai, it's hard to make a unit test for this since ```addColumnMetadataToConf``` and ```hiveExtraConf``` both can not accessed in test case, they are private. Actually i

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60050953 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22031/consoleFull) for PR 2891 at commit

[GitHub] spark pull request: [SPARK-3537][SPARK-3914][SQL] Refines in-memor...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2860#issuecomment-60051402 @marmbrus This is ready to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60051452 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22032/consoleFull) for PR 2887 at commit

[GitHub] spark pull request: [SPARK-3891][SQL] Add array support to percent...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2802#issuecomment-60052001 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: use isRunningLocally rather than runningLocall...

2014-10-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2879 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4000][BUILD] Sends archived unit tests ...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2845#issuecomment-60052480 @pwendell This should be ready to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [Spark-4041][SQL]attributes names in table sca...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2884#issuecomment-60052699 I think this change is generally a safe. LGTM, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60054489 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60054481 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22031/consoleFull) for PR 2891 at commit

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/771#issuecomment-60055292 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: SPARK-1830 Deploy failover, Make Persistence e...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/771#issuecomment-60055285 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22030/consoleFull) for PR 771 at commit

[GitHub] spark pull request: [SPARK-3959][SPARK-3960][SQL] SqlParser fails ...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2816#issuecomment-60055358 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22029/consoleFull) for PR 2816 at commit

[GitHub] spark pull request: [SPARK-3959][SPARK-3960][SQL] SqlParser fails ...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2816#issuecomment-60055364 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [HOTFIX][SQL] missing golden file for SPARK-38...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2821#issuecomment-60056640 It's true. Picked [a Jenkins build log](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22027/consoleFull) and searched for select from thrift based

[GitHub] spark pull request: [SPARK-3939][SQL] NPE caused by SessionState.o...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2812#issuecomment-60056957 Sorry, didn't notice this PR and also worked on this issue in #2887, which I think is a more fundamental solution. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-4003] [SQL] add 3 types for java SQL co...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2850#issuecomment-60057804 Good catch! LGTM, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3939][SQL] NPE caused by SessionState.o...

2014-10-22 Thread adrian-wang
Github user adrian-wang closed the pull request at: https://github.com/apache/spark/pull/2812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3939][SQL] NPE caused by SessionState.o...

2014-10-22 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/2812#issuecomment-60057848 Never mind, I'll close this then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60058036 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4037][SQL] Removes the SessionState ins...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2887#issuecomment-60058029 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22032/consoleFull) for PR 2887 at commit

[GitHub] spark pull request: [ SPARK-1812] Adjust build system and tests to...

2014-10-22 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/spark/pull/2615#issuecomment-60058177 Hey Jason, Thanks for offering to help, In short, I need help from scala-internals so that it is possible to customize user supplied wrappers. I tried my bit in

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60058868 When the data types of both sides are string, the coercion sule ends up with a dead loop and runs until max iteration number (100) exceeded. That's why dozen's of

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60060295 Also, I think the reason why string is always coerced to double is because of Hive compatibility, as illustrated by the [test

[GitHub] spark pull request: [SPARK-3816][SQL] Add table properties from st...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2677#issuecomment-60060432 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60062034 Ah, I see. So, we should explicitly cast if we don't like unwilling coerce right? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3953][SQL][Minor] Confusable variable n...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2807#issuecomment-60062138 Good catch, LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SQL][DOC] Wrong package name scala.math.sql...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2873#issuecomment-60062226 Good catch! LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3911] [SQL] HiveSimpleUdf can not be op...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2771#issuecomment-60062451 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60062719 Yes I think so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3911] [SQL] HiveSimpleUdf can not be op...

2014-10-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2771#issuecomment-60062994 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22033/consoleFull) for PR 2771 at commit

[GitHub] spark pull request: Sbt and Maven builds pass on Linux boxes with ...

2014-10-22 Thread luchesar
Github user luchesar commented on the pull request: https://github.com/apache/spark/pull/2883#issuecomment-60065574 Do you mean API interoperability or just random problems? I guess the generated class names are purely used by the compiler and are not related to any public classes so

[GitHub] spark pull request: [SPARK-4045][SQL] BinaryArithmetic cannot impl...

2014-10-22 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2891#issuecomment-60067825 O.K, I close this PR. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

  1   2   3   4   >