[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69270641 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [WIP][SPARK-4912][SQL] Persistent tables for t...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69272469 [Test build #25277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25277/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2015-01-08 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2634#discussion_r22693139 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/metrics/FastEuclideanOps.scala --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2015-01-08 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2634#discussion_r22693112 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/metrics/FastEuclideanOps.scala --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69279963 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69279959 [Test build #25279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25279/consoleFull) for PR 3431 at commit

[GitHub] spark pull request: [SPARK-4989][CORE] avoid wrong eventlog conf c...

2015-01-08 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/3824#issuecomment-69280380 @andrewor14 , I received an email of your comment about creating other PRs to fix this issue for other older branches, but not found on this page. I think you

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3939 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4697][YARN]System properties should ove...

2015-01-08 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the pull request: https://github.com/apache/spark/pull/3557#issuecomment-69282649 @vanzin Note what I note :-) Note: In test cases I didn't use SparkConf.setAppName in application code. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3431#discussion_r22697822 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/sources/ddl.scala --- @@ -83,10 +118,73 @@ private[sql] class DDLParser extends StandardTokenParsers

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-69282680 [Test build #25281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25281/consoleFull) for PR 3638 at commit

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-69282684 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22693295 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -80,69 +50,157 @@ class LogisticRegression extends

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693876 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -456,10 +459,18 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69275198 [Test build #25279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25279/consoleFull) for PR 3431 at commit

[GitHub] spark pull request: Spark 3299 add to SQLContext API to show table...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3872#issuecomment-69278134 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Spark 3299 add to SQLContext API to show table...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3872#issuecomment-69278128 [Test build #25276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25276/consoleFull) for PR 3872 at commit

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3961#issuecomment-69279153 [Test build #25280 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25280/consoleFull) for PR 3961 at commit

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-69279237 Ah never mind, I found the abort

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3961#issuecomment-69279159 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69281768 The wiki location seems fine. Maybe others disagree. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69286150 [Test build #25284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25284/consoleFull) for PR 3607 at commit

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69286154 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4990][Deploy]to find default properties...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3823#issuecomment-69287254 [Test build #25286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25286/consoleFull) for PR 3823 at commit

[GitHub] spark pull request: [SPARK-4990][Deploy]to find default properties...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3823#issuecomment-69287260 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69287974 Okie doke, thank you @andrewor14. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-3586][streaming]Support nested director...

2015-01-08 Thread wangxiaojing
Github user wangxiaojing commented on the pull request: https://github.com/apache/spark/pull/2765#issuecomment-69288062 @tdas rebase the latest master and update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4033][Examples]Input of the SparkPi too...

2015-01-08 Thread SaintBacchus
Github user SaintBacchus commented on the pull request: https://github.com/apache/spark/pull/2874#issuecomment-69289017 @andrewor14 I had explained why it can not use `Long` instead of `Int`. Not only the `Range` but also the `Partition` only can be appropriate with `Int`, and can't

[GitHub] spark pull request: [SPARK-4955]With executor dynamic scaling enab...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3962#issuecomment-69289902 [Test build #25291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25291/consoleFull) for PR 3962 at commit

[GitHub] spark pull request: [SPARK-4955]With executor dynamic scaling enab...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3962#issuecomment-69289908 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4048] Enhance and extend hadoop-provide...

2015-01-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/2982#discussion_r22691343 --- Diff: yarn/pom.xml --- @@ -131,13 +131,6 @@ skiptrue/skip /configuration /plugin - plugin -

[GitHub] spark pull request: [SPARK-3910] Remove pyspark/mllib/ from sys.pa...

2015-01-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/3940#issuecomment-69270182 @mengxr I think so, it's better to back port that into 1.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-3541][MLLIB] New ALS implementation wit...

2015-01-08 Thread coderxiang
Github user coderxiang commented on a diff in the pull request: https://github.com/apache/spark/pull/3720#discussion_r22692999 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -0,0 +1,964 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22692953 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2015-01-08 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2634#issuecomment-69272196 @derrickburns I like the improvements implemented in this PR. But as @srowen mentioned, we have to resolve conflicts with the master branch before we can merge any PR. I

[GitHub] spark pull request: [WIP][SPARK-4912][SQL] Persistent tables for t...

2015-01-08 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/3960 [WIP][SPARK-4912][SQL] Persistent tables for the Spark SQL data sources api This one subsumes #3752. It current contains changes made in #3431. Will clean it up once #3431 is in. You can merge this

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22693428 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22693403 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -80,69 +50,157 @@ class LogisticRegression extends

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693927 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala --- @@ -456,10 +459,18 @@ private[spark] class TaskSetManager(

[GitHub] spark pull request: [WIP][SPARK-4912][SQL] Persistent tables for t...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69276273 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP][SPARK-4912][SQL] Persistent tables for t...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69276271 [Test build #25277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25277/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69277310 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69277301 [Test build #25275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25275/consoleFull) for PR 3939 at commit

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3921#discussion_r22695485 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -520,6 +520,7 @@

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69280879 [Test build #25283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25283/consoleFull) for PR 3431 at commit

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r22697617 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ClientArguments.scala --- @@ -87,6 +92,21 @@ private[spark] class ClientArguments(args:

[GitHub] spark pull request: [SPARK-4955]With executor dynamic scaling enab...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3962#issuecomment-69285225 [Test build #25290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25290/consoleFull) for PR 3962 at commit

[GitHub] spark pull request: [SPARK-4955]With executor dynamic scaling enab...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3962#issuecomment-69285227 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69286990 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69286987 [Test build #25285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25285/consoleFull) for PR 3607 at commit

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread guowei2
Github user guowei2 commented on the pull request: https://github.com/apache/spark/pull/3921#issuecomment-69290028 i think i should remove the test case for `stored as parquet ` only can pass in hive-0.13 --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-5145][Mllib] Add BLAS.dsyr and use it i...

2015-01-08 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/3949#issuecomment-69290026 @jkbradley Thanks. The unit test is added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5123] Expose only one version of the da...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3958#issuecomment-69267461 [Test build #25272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25272/consoleFull) for PR 3958 at commit

[GitHub] spark pull request: [SPARK-3541][MLLIB] New ALS implementation wit...

2015-01-08 Thread coderxiang
Github user coderxiang commented on a diff in the pull request: https://github.com/apache/spark/pull/3720#discussion_r22692604 --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala --- @@ -0,0 +1,964 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-3218, SPARK-3219, SPARK-3261, SPARK-342...

2015-01-08 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/2634#discussion_r22693062 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/package.scala --- @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22693073 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala --- @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4789] [SPARK-4942] [SPARK-5031] [mllib]...

2015-01-08 Thread etrain
Github user etrain commented on a diff in the pull request: https://github.com/apache/spark/pull/3637#discussion_r22693524 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/sharedParams.scala --- @@ -17,6 +17,10 @@ package org.apache.spark.ml.param +/*

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693713 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -249,13 +250,12 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693694 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -266,8 +266,21 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22695144 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -865,26 +865,6 @@ class DAGScheduler( } if

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22695628 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -266,8 +266,21 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22696100 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -209,6 +210,42 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-69278693 @mccheah @JoshRosen high level question. So what happens now when a task is not serializable? Before it would throw a loud exception and fail the task, but now we

[GitHub] spark pull request: [MLLIB] [spark-2352] Implementation of an Arti...

2015-01-08 Thread loachli
Github user loachli commented on the pull request: https://github.com/apache/spark/pull/1290#issuecomment-69278665 Hi jkbradley: Could you tell the jira number related to ”new spark.ml package and its design doc” 发件人: jkbradley

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22696128 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -251,23 +288,8 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4989][CORE] avoid wrong eventlog conf c...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3824#issuecomment-69280965 Yes that would be great. It seems that not all of the changes in this PR are applicable there, however. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r22697722 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -68,8 +68,6 @@ private[spark] class

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69282417 [Test build #25285 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25285/consoleFull) for PR 3607 at commit

[GitHub] spark pull request: [SPARK-4989][CORE] avoid wrong eventlog conf c...

2015-01-08 Thread liyezhang556520
Github user liyezhang556520 commented on the pull request: https://github.com/apache/spark/pull/3824#issuecomment-69283439 ok, I'll make new PRs for those old branches 1.0, 1.1, and 1.2. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4951][Core] Fix the issue that a busy e...

2015-01-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/3783#issuecomment-69284237 Can you explain how (1) is related to SPARK-4951? It seems to me that (2) is sufficient in triggering the issue. The original implementation will mark an

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69285760 [Test build #25283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25283/consoleFull) for PR 3431 at commit

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69285764 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4048] Enhance and extend hadoop-provide...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2982#issuecomment-69269314 [Test build #25273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25273/consoleFull) for PR 2982 at commit

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3959#issuecomment-69270938 [Test build #25274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25274/consoleFull) for PR 3959 at commit

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69270905 [Test build #25275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25275/consoleFull) for PR 3939 at commit

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694937 --- Diff: core/src/main/scala/org/apache/spark/TaskNotSerializableException.scala --- @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694961 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -865,26 +865,6 @@ class DAGScheduler( } if

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3921#discussion_r22695098 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -520,6 +520,7 @@

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3921#discussion_r22695310 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -520,6 +520,7 @@

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3959#issuecomment-69277801 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3959#issuecomment-69277796 [Test build #25274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25274/consoleFull) for PR 3959 at commit

[GitHub] spark pull request: [WIP][SPARK-4912][SQL] Persistent tables for t...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3960#issuecomment-69280036 [Test build #25282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25282/consoleFull) for PR 3960 at commit

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3607#issuecomment-69281668 [Test build #25284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25284/consoleFull) for PR 3607 at commit

[GitHub] spark pull request: [SPARK-1953][YARN]yarn client mode Application...

2015-01-08 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request: https://github.com/apache/spark/pull/3607#discussion_r22697386 --- Diff: yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala --- @@ -68,8 +68,6 @@ private[spark] class

[GitHub] spark pull request: [SPARK-5122] Remove Shark from spark-ec2

2015-01-08 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/3939#issuecomment-69281611 Ok LGTM I'm merging this into master thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5163] [CORE] Load properties from confi...

2015-01-08 Thread YanTangZhai
GitHub user YanTangZhai opened a pull request: https://github.com/apache/spark/pull/3963 [SPARK-5163] [CORE] Load properties from configuration file for example spark-defaults.conf when creating SparkConf object I create and run a Spark program which does not use SparkSubmit.

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69288718 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4574][SQL] Adding support for defining ...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3431#issuecomment-69288714 [Test build #25287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25287/consoleFull) for PR 3431 at commit

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread guowei2
Github user guowei2 commented on a diff in the pull request: https://github.com/apache/spark/pull/3921#discussion_r22700232 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala --- @@ -520,6 +520,7 @@

[GitHub] spark pull request: [SPARK-5088] Use spark-class for running execu...

2015-01-08 Thread jongyoul
Github user jongyoul commented on the pull request: https://github.com/apache/spark/pull/3897#issuecomment-69289262 @JoshRosen @tgravescs @andrewor14 Could anyone review this PR? That makes mesos codes clean --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4284] BinaryClassificationMetrics preci...

2015-01-08 Thread Lewuathe
Github user Lewuathe commented on the pull request: https://github.com/apache/spark/pull/3933#issuecomment-69273220 @mengxr @srowen Thank you for reviewing. I agree to the reason why `pr` method is also reasonable in terms of drawing curve. I'll keep it as-is. But anyway I want

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694007 --- Diff: core/src/test/scala/org/apache/spark/scheduler/NotSerializableFakeTask.scala --- @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693981 --- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala --- @@ -887,6 +891,23 @@ class RDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22693969 --- Diff: core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala --- @@ -887,6 +891,23 @@ class RDDSuite extends FunSuite with SharedSparkContext {

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694761 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -266,8 +266,21 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694839 --- Diff: core/src/main/scala/org/apache/spark/TaskNotSerializableException.scala --- @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/3638#discussion_r22694827 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -266,8 +266,21 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark pull request: [SPARK-4737] Task set manager properly handles...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3638#issuecomment-69277042 [Test build #25281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25281/consoleFull) for PR 3638 at commit

[GitHub] spark pull request: [Spark-3490] Disable SparkUI for tests (backpo...

2015-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3961#issuecomment-69277048 [Test build #25280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25280/consoleFull) for PR 3961 at commit

[GitHub] spark pull request: [SPARK-5118][SQL] Fix: create table test store...

2015-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/3921#discussion_r22695453 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -68,6 +68,17 @@ class SQLQuerySuite extends QueryTest {

  1   2   3   4   5   6   7   8   >