[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159086472 **[Test build #46557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46557/consoleFull)** for PR 9917 at commit

[GitHub] spark pull request: [SPARK-9866][SQL] Speed up VersionsSuite by us...

2015-11-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9624#issuecomment-159088227 Sweet, thanks. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-23 Thread markhamstra
Github user markhamstra commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159088257 Beyond that, the message is actually somewhat misleading. The "Stopping" message occurs in `stop()`, which is responsible for stopping the messageScheduler,

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159091950 **[Test build #46556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46556/consoleFull)** for PR 9141 at commit

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159092083 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159093878 No problem @jkbradley, I think this is good to go now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159095679 **[Test build #46560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46560/consoleFull)** for PR 9919 at commit

[GitHub] spark pull request: [SPARK-11865] [network] Avoid returning inacti...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9524#discussion_r45668289 --- Diff: mllib/pom.xml --- @@ -125,6 +125,10 @@ org.apache.spark spark-test-tags_${scala.binary.version} + +

[GitHub] spark pull request: [SPARK-10387][ML][WIP] Add code gen for gbt

2015-11-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/9524#discussion_r45669204 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/codeGenerator.scala --- @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159085374 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5337][Mesos][Standalone] respect spark....

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8610#issuecomment-159085218 **[Test build #46549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46549/consoleFull)** for PR 8610 at commit

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159085929 /cc @rxin @zsxwing While this problem also exists in 1.6, I didn't make this patch with the intent of putting it there. If there's a desire to fix this in 1.6,

[GitHub] spark pull request: [SPARK-9866][SQL] Speed up VersionsSuite by us...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9624#issuecomment-159087618 @vanzin, I've updated this patch to introduce a `SPARK_VERSIONS_SUITE_IVY_PATH` environment variable which can be used to configure a fixed directory instead of a

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-159088695 Build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-159088540 **[Test build #46544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46544/consoleFull)** for PR 9613 at commit

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090248 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090250 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159091594 Reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11293] Fix shuffle memory leaks in Spil...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9427#issuecomment-159091597 @davies, I've updated this to address your comment; PTAL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11343] [ML] Documentation of float and ...

2015-11-23 Thread felixcheung
Github user felixcheung commented on the pull request: https://github.com/apache/spark/pull/9598#issuecomment-159091586 looks good, perhaps reuse `predictionColName` and `labelColName`, instead of `$(predictionCol)` and `$(labelCol)`, but it is minor --- If your project is set up

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159092086 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159092215 **[Test build #46555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46555/consoleFull)** for PR 9141 at commit

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/9919 [SPARK-11933][SQL] Rename mapGroup -> mapGroups and flatMapGroup -> flatMapGroups. Based on feedback from Matei, this is more consistent with mapPartitions in Spark. Also addresses some of

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159092353 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-23 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at: https://github.com/apache/spark/pull/9763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-11694] [SQL] Backports #9754

2015-11-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/9763#issuecomment-159095287 Oh. Right. Thanks! Closing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread mbautin
Github user mbautin commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159099184 @rxin updated -- sorry for the delay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-11569] [ML] Fix StringIndexer to handle...

2015-11-23 Thread jliwork
GitHub user jliwork opened a pull request: https://github.com/apache/spark/pull/9920 [SPARK-11569] [ML] Fix StringIndexer to handle null value properly I was having some problem with rebase on https://github.com/apache/spark/pull/9709, so I had to close that PR and creating a new

[GitHub] spark pull request: [SPARK-10560] [PySpark] [MLlib] [Docs] Make St...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9141#issuecomment-159087888 **[Test build #46555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46555/consoleFull)** for PR 9141 at commit

[GitHub] spark pull request: [SPARK-9866][SQL] Speed up VersionsSuite by us...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9624#issuecomment-159088942 **[Test build #46558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46558/consoleFull)** for PR 9624 at commit

[GitHub] spark pull request: [SPARK-11897][SQL] Add @scala.annotations.vara...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9918#issuecomment-159088830 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11031][SPARKR] Method str() on a DataFr...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9613#issuecomment-159088696 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9793#issuecomment-159090033 **[Test build #46547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46547/consoleFull)** for PR 9793 at commit

[GitHub] spark pull request: [SPARK-11293] Fix shuffle memory leaks in Spil...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9427#issuecomment-159094315 [Test build #46559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46559/consoleFull) for PR 9427 at commit

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159096459 **[Test build #46561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46561/consoleFull)** for PR 5622 at commit

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/9921 [SPARK-11934] [SQL] Adding joinType into joinWith Except inner join, maybe the other join types are also useful when users are using the joinWith function. Thus, added the joinType into the

[GitHub] spark pull request: [SPARK-11569] [ML] Fix StringIndexer to handle...

2015-11-23 Thread jliwork
Github user jliwork closed the pull request at: https://github.com/apache/spark/pull/9709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11569] [ML] Fix StringIndexer to handle...

2015-11-23 Thread jliwork
Github user jliwork commented on the pull request: https://github.com/apache/spark/pull/9709#issuecomment-159098271 @dragos thanks for pointing it out. i am having some problem with rebase and will close this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-23 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-159077566 Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-23 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/9530 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3533][Core] Add saveAsTextFileByKey() m...

2015-11-23 Thread utkarsh2012
Github user utkarsh2012 commented on the pull request: https://github.com/apache/spark/pull/8375#issuecomment-159078940 @saurfang Do you plan to merge this or you are waiting for @silasdavis's changes? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159077637 Are you sure that we want this feature? Isn't this better handled by the user via one of the many browser extensions for auto-refresh? I feel like this would

[GitHub] spark pull request: [SPARK-11631][Scheduler] Adding 'Starting DAGS...

2015-11-23 Thread xguo27
Github user xguo27 commented on the pull request: https://github.com/apache/spark/pull/9603#issuecomment-159079918 @andrewor14 What is your take on Jacek's comment? I don't think it's a bad idea to make it more consistent with a matching log message. Please let me know. Thx! ---

[GitHub] spark pull request: [SPARK-11401] [MLLIB] PMML export for Logistic...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9397#issuecomment-159081795 **[Test build #46554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46554/consoleFull)** for PR 9397 at commit

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159101436 **[Test build #46563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46563/consoleFull)** for PR 9308 at commit

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145470 **[Test build #46571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46571/consoleFull)** for PR 5622 at commit

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159145523 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145911 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147862 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151618 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145840 **[Test build #46577 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46577/consoleFull)** for PR 9909 at commit

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159145910 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147801 **[Test build #46579 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46579/consoleFull)** for PR 9924 at commit

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159147861 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/5622#issuecomment-159149102 If anything, this seemed to make thing slower. Closing for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-7041] Avoid writing empty files in Bypa...

2015-11-23 Thread JoshRosen
Github user JoshRosen closed the pull request at: https://github.com/apache/spark/pull/5622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150999 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150934 **[Test build #46576 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46576/consoleFull)** for PR 7753 at commit

[GitHub] spark pull request: [SPARK-9104][SPARK-9105][SPARK-9106][SPARK-910...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7753#issuecomment-159150997 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151566 **[Test build #46582 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46582/consoleFull)** for PR 9917 at commit

[GitHub] spark pull request: [SPARK-11866] [network] [core] Make sure timed...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9917#issuecomment-159151619 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698452 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45698964 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: [SPARK-11805] free the array in UnsafeExternal...

2015-11-23 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9793#discussion_r45699105 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -489,10 +495,6 @@ public void loadNext() throws

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159157786 I "mimic" what we have on Jenkins for instance. I understand your points guys. I just thought it's a convenient feature for users ;) --- If your project is set up for

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159158329 **[Test build #2099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2099/consoleFull)** for PR 9919 at commit

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159159471 LGTM except a minor code style comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9308#discussion_r45699604 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1997,4 +1997,35 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45699792 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9840#issuecomment-159163316 **[Test build #46583 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46583/consoleFull)** for PR 9840 at commit

[GitHub] spark pull request: [SPARK-11521] [ML] [DOC] Document that Logisti...

2015-11-23 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/9927 [SPARK-11521] [ML] [DOC] Document that Logistic, Linear Regression summaries ignore weight col Doc for 1.6 that the summaries mostly ignore the weight column. To be corrected for 1.7

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/9919#issuecomment-159164011 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45699959 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45700102 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -610,9 +610,9 @@ class Analyzer( */

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159164089 > Do you mean a LDAModel.load(path) which can load both local and distributed LDAModel? We can create a jira. Yes, that's what I had in mind. That way, most

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9924#issuecomment-159165834 I've merged this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11933][SQL] Rename mapGroup -> mapGroup...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9919 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11903] Remove --skip-java-test

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9924 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45700402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val

[GitHub] spark pull request: [SPARK-11521] [ML] [DOC] Document that Logisti...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9927#issuecomment-159168803 **[Test build #46584 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46584/consoleFull)** for PR 9927 at commit

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45700482 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9308#issuecomment-159167719 I'm going to merge this. The style thing is good to have, but probably doesn't worth another roundtrip. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-10707] [SQL] Fix nullability computatio...

2015-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159170379 LGTM. @hhbyyh Thanks for the updates! Is there anything left to do? If not, can you please remove the "WIP" label? I can then merge it. --- If your project is

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/9921#discussion_r45701047 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -412,7 +418,7 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-11934] [SQL] Adding joinType into joinW...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9921#issuecomment-159171315 **[Test build #46585 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46585/consoleFull)** for PR 9921 at commit

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45701500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val

[GitHub] spark pull request: [SPARK-11847] [ML] Model export/import for spa...

2015-11-23 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/9894#issuecomment-159171948 @jkbradley removed. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159172624 So, what do we do about this ? First, let me go back to the checkbox (probably better IMHO in term of UI). @JoshRosen I agree that using pushed async update

[GitHub] spark pull request: SPARK-5106 - Add refresh checkbox on the UI

2015-11-23 Thread jbonofre
Github user jbonofre commented on the pull request: https://github.com/apache/spark/pull/9860#issuecomment-159172833 Rebase and back on the checkbox (instead of the button). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...

2015-11-23 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/9844#discussion_r45702258 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -661,7 +666,9 @@ class Analyzer( val

[GitHub] spark pull request: [SPARK-11929] [core] Make the repl log4j confi...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9816#issuecomment-159104877 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11929] [core] Make the repl log4j confi...

2015-11-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9816#issuecomment-159104875 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11638] [Mesos + Docker Bridge networkin...

2015-11-23 Thread radekg
Github user radekg commented on a diff in the pull request: https://github.com/apache/spark/pull/9608#discussion_r45681436 --- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala --- @@ -42,10 +42,11 @@ private[spark] class HttpFileServer( fileDir.mkdir()

[GitHub] spark pull request: [SPARK-11563] [core] [repl] Use RpcEnv to tran...

2015-11-23 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/9923 [SPARK-11563] [core] [repl] Use RpcEnv to transfer REPL-generated classes. This avoids bringing up yet another HTTP server on the driver, and instead reuses the file server already managed by the

[GitHub] spark pull request: [SPARK-11926][SQL] unify GetStructField and Ge...

2015-11-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9909#issuecomment-159113367 **[Test build #46568 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46568/consoleFull)** for PR 9909 at commit

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9894#discussion_r45683880 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -486,6 +487,61 @@ class LocalLDAModel private[ml] (

[GitHub] spark pull request: [WIP] [SPARK-11847] [ML] Model export/import f...

2015-11-23 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/9894#discussion_r45683892 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/LDA.scala --- @@ -593,7 +686,8 @@ class DistributedLDAModel private[ml] ( @Since("1.6.0")

<    1   2   3   4   5   6   >