[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169926993 **[Test build #49008 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49008/consoleFull)** for PR 10630 at commit

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169927020 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10660#discussion_r49165377 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/FromClauseParser.g --- @@ -151,8 +151,8 @@ fromSource @after {

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169927573 Both failure are not related to this PR. They are caused by the test case `randomSplit on reordered partitions` in https://github.com/apache/spark/pull/10626.

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169928271 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12709][SQL]Create local Except operator

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10661#issuecomment-169928431 **[Test build #49010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49010/consoleFull)** for PR 10661 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928634 **[Test build #49005 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49005/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12662][SQL] Fix DataFrame.randomSplit t...

2016-01-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/10626#issuecomment-169929536 @gatorsmile it seems like your PR is changing the behavior of SQL intersect that this test relies on. I can take a closer look at the PR but if you think this

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169931210 **[Test build #49012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49012/consoleFull)** for PR 10630 at commit

[GitHub] spark pull request: [SPARK-12662][SQL] Fix DataFrame.randomSplit t...

2016-01-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10626#issuecomment-169931662 It is best for us to use local collection's intersect rather than relying on dataframe's. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [DOCUMENTATION] doc fix of job scheduling

2016-01-08 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/10657#issuecomment-169934023 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12662][SQL] Fix DataFrame.randomSplit t...

2016-01-08 Thread sameeragarwal
Github user sameeragarwal commented on the pull request: https://github.com/apache/spark/pull/10626#issuecomment-169935761 @gatorsmile I pulled your changes and verified that the new intersect implementation fails even when there is a deterministic sampling operator in the plan,

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169936735 **[Test build #49012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49012/consoleFull)** for PR 10630 at commit

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169936845 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169936843 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12692][BUILD] Scala style: check no whi...

2016-01-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10643#issuecomment-169936503 Yes I'll do it. Should I fix the style issues in this change? I was going to fix in another PR. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-12692][BUILD] Scala style: check no whi...

2016-01-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10643#issuecomment-169938070 Another PR is fine. I'm going to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49168326 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -200,41 +200,62 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-12692][BUILD] Scala style: check no whi...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10643 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-10386] [MLlib] Model import/export for ...

2016-01-08 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/10664 [SPARK-10386] [MLlib] Model import/export for PrefixSpan ```PrefixSpanModel``` supports ```save/load```. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49168529 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -200,41 +200,62 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49168686 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -200,41 +200,62 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-169940382 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-169940381 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-169943071 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-169943074 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12710][SQL]Create local CoGroup operato...

2016-01-08 Thread mwws
GitHub user mwws opened a pull request: https://github.com/apache/spark/pull/10662 [SPARK-12710][SQL]Create local CoGroup operator You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwws/spark LocalNode-CoGroup Alternatively you

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-169927019 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4628][BUILD] Remove all non-Maven-Centr...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10659#issuecomment-169927053 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4628][BUILD] Remove all non-Maven-Centr...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10659#issuecomment-169927052 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread yoshidakuy
GitHub user yoshidakuy opened a pull request: https://github.com/apache/spark/pull/10663 [SPARK-12708][UI] Sorting task error in Stages Page when yarn mode. If sort column contains slash(e.g. "Executor ID / Host") when yarn mode,sort fail with following message.

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928804 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-169928806 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12662][SQL] Fix DataFrame.randomSplit t...

2016-01-08 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/10626#issuecomment-169928530 I might not pick up your latest code changes. Let me merge the code. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/10663#discussion_r49166120 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -100,7 +101,19 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-12710][SQL]Create local CoGroup operato...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10662#issuecomment-169929038 **[Test build #49011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49011/consoleFull)** for PR 10662 at commit

[GitHub] spark pull request: [SPARK-12692][BUILD] Scala style: check no whi...

2016-01-08 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/10643#issuecomment-169930643 OK this looks good. Would you have time to fix the issues too? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/10663#discussion_r49167186 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -100,7 +101,19 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169934471 ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stag...

2016-01-08 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169934802 @yoshidakuy Does this issue affect both `yarn-client` and `yarn-cluster` right? Also, could you show the screen shot after applying this patch. --- If your

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169937600 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169937602 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169937305 **[Test build #49013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49013/consoleFull)** for PR 10663 at commit

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10663#issuecomment-169937595 **[Test build #49013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49013/consoleFull)** for PR 10663 at commit

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10577#discussion_r49168792 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -200,41 +200,62 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-169942793 **[Test build #49009 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49009/consoleFull)** for PR 10660 at commit

[GitHub] spark pull request: [SPARK-10386] [MLlib] PrefixSpanModel supports...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10664#issuecomment-169942726 **[Test build #49015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49015/consoleFull)** for PR 10664 at commit

[GitHub] spark pull request: [SPARK-12709][SQL]Create local Except operator

2016-01-08 Thread mwws
GitHub user mwws opened a pull request: https://github.com/apache/spark/pull/10661 [SPARK-12709][SQL]Create local Except operator You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwws/spark LocalNode-Except Alternatively you can

[GitHub] spark pull request: [SPARK-4628][BUILD] Remove all non-Maven-Centr...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10659#issuecomment-169926956 **[Test build #49006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49006/consoleFull)** for PR 10659 at commit

[GitHub] spark pull request: [SPARK-12558][SQL][WIP] AnalysisException when...

2016-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10520#discussion_r49219243 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveShim.scala --- @@ -125,6 +125,12 @@ private[hive] object HiveShim { // for

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-170082147 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12295] [SQL] external spilling for wind...

2016-01-08 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/10605#discussion_r49219913 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala --- @@ -307,27 +314,63 @@ case class Window( // Collect all the

[GitHub] spark pull request: [SPARK-12614][Core]Don't throw non fatal excep...

2016-01-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10568#issuecomment-170085558 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12504][SQL] Masking credentials in the ...

2016-01-08 Thread sureshthalamati
Github user sureshthalamati commented on the pull request: https://github.com/apache/spark/pull/10452#issuecomment-170095510 Thanks for merging this to 2.0, Michael , I will create PR against 1.6 branch. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-12701] [CORE] FileAppender should use j...

2016-01-08 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10654#issuecomment-170095605 No problem! Thanks @zsxwing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097654 **[Test build #49022 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49022/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-9835] [ML] IterativelyReweightedLeastSq...

2016-01-08 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/10639#discussion_r49226861 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/GLMFamilies.scala --- @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10274#issuecomment-170090232 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12701] [CORE] FileAppender should use j...

2016-01-08 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/10654#issuecomment-170093754 Yeah, that variable is no longer needed - I already removed it. Did you mean `@volatile private var markedForStopped`? That one is still used to trigger the

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/10663#discussion_r49225126 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -100,7 +101,20 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-170098200 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-170098199 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49217415 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49217997 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12701] [CORE] FileAppender should use j...

2016-01-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10654#issuecomment-170085232 You can also remove `@volatile private var stopped = false`, right? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12701] [CORE] FileAppender should use j...

2016-01-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10654#issuecomment-170094361 Oh, sorry. Didn't notice that you already removed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-12654] sc.wholeTextFiles with spark.had...

2016-01-08 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/10651#issuecomment-170094787 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...

2016-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10541#discussion_r49225349 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala --- @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170070628 **[Test build #49022 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49022/consoleFull)** for PR 10649 at commit

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10660 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/10570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12591][Streaming]Register OpenHashMapBa...

2016-01-08 Thread zsxwing
Github user zsxwing closed the pull request at: https://github.com/apache/spark/pull/10656 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-12687][SQL] Support from clause surroun...

2016-01-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/10660#issuecomment-170072949 Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-12618] [CORE] [STREAMING] [SQL] Clean u...

2016-01-08 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/10570#issuecomment-170072468 Merged to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-12577][SQL] Better support of parenthes...

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10620#discussion_r49215653 --- Diff: sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/ExpressionParser.g --- @@ -223,7 +223,12 @@ precedenceUnaryPrefixExpression

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-170070656 **[Test build #49021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49021/consoleFull)** for PR 10577 at commit

[GitHub] spark pull request: [SPARK-12577][SQL] Better support of parenthes...

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10620#discussion_r49216358 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -936,6 +936,35 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10630#issuecomment-170081871 **[Test build #49020 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49020/consoleFull)** for PR 10630 at commit

[GitHub] spark pull request: [SPARK-12656] [SQL] Implement Intersect with L...

2016-01-08 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/10630#discussion_r49227379 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -388,57 +441,14 @@ class Analyzer(

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49216499 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -309,6 +309,46 @@ object functions extends LegacyFunctions {

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49217078 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49217495 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-9297][SQL] Add covar_pop and covar_samp

2016-01-08 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/10029#discussion_r49217530 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Covariance.scala --- @@ -0,0 +1,212 @@ +/* + * Licensed to

[GitHub] spark pull request: [SPARK-12614][Core]Don't throw non fatal excep...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10568#issuecomment-170089997 **[Test build #49024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49024/consoleFull)** for PR 10568 at commit

[GitHub] spark pull request: [SPARK-12230][ML] WeightedLeastSquares.fit() s...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10274#issuecomment-170090236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12708][UI] Sorting task error in Stages...

2016-01-08 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/10663#discussion_r49223834 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -100,7 +101,20 @@ private[ui] class StagePage(parent: StagesTab) extends

[GitHub] spark pull request: [SPARK-12701] [CORE] FileAppender should use j...

2016-01-08 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10654#issuecomment-170095377 LGTM. Merging to master. Thanks, @BryanCutler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...

2016-01-08 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/10541#issuecomment-170096777 Let's also create a jira for supporting persisted data source tables. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-12616] [SQL] Making Logical Operator `U...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10577#issuecomment-170097898 **[Test build #49021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49021/consoleFull)** for PR 10577 at commit

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097979 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12576][SQL] Enable expression parsing i...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10649#issuecomment-170097976 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12593][SQL] Converts resolved logical p...

2016-01-08 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/10541#discussion_r49229231 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -63,7 +63,9 @@ abstract class Optimizer extends

[GitHub] spark pull request: removed redundant variable numVertices from tr...

2016-01-08 Thread udoklein
Github user udoklein closed the pull request at: https://github.com/apache/spark/pull/10642 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: removed redundant variable numVertices from tr...

2016-01-08 Thread udoklein
Github user udoklein commented on the pull request: https://github.com/apache/spark/pull/10642#issuecomment-170105923 Fixed it as suggested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-10873] Support column sort and search f...

2016-01-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10648#issuecomment-170112745 **[Test build #49025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/49025/consoleFull)** for PR 10648 at commit

[GitHub] spark pull request: [SPARK-12177] [STREAMING] Update KafkaDStreams...

2016-01-08 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/10294#issuecomment-170112625 Is there any feature / perf improvement / etc., in 0.9 that makes this upgrade worth the update? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-6332] [MLlib] compute calibration curve...

2016-01-08 Thread robert-dodier
GitHub user robert-dodier opened a pull request: https://github.com/apache/spark/pull/10666 [SPARK-6332] [MLlib] compute calibration curve for binary classifiers This PR is a revised, updated version of the previous ([PR #5025](https://github.com/apache/spark/pull/5025)), which was

[GitHub] spark pull request: [SPARK-11780][SQL] Add type aliases backwards ...

2016-01-08 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/10635#issuecomment-170122685 I could be missing something, but it seems like since you had to manually exclude things here to make it compile, users are going to run into problems. Can you

[GitHub] spark pull request: [SPARK-4819] Remove Guava's "Optional" from pu...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10513#issuecomment-170126258 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4819] Remove Guava's "Optional" from pu...

2016-01-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10513#issuecomment-170126255 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

  1   2   3   4   >