[GitHub] spark pull request #14567: [SPARK-16992][PYSPARK] Python Pep8 formatting and...

2016-08-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14567#discussion_r76961377 --- Diff: dev/py-validate.sh --- @@ -0,0 +1,110 @@ +#!/usr/bin/env bash --- End diff -- @davies what do you think about including this vs

[GitHub] spark pull request #14567: [SPARK-16992][PYSPARK] Python Pep8 formatting and...

2016-08-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14567#discussion_r76961264 --- Diff: dev/isort.cfg --- @@ -1,9 +1,9 @@ # Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements.

[GitHub] spark issue #14826: [SPARK-17311] [MLLIB] Standardize Python-Java MLlib API ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14826 **[Test build #64714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64714/consoleFull)** for PR 14826 at commit

[GitHub] spark issue #14826: [SPARK-17311] [MLLIB] Standardize Python-Java MLlib API ...

2016-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14826 This is bisecting k-means? and the .mllib version? I think that's all this change could affect. All of the .ml classes have their own higher-level seed handling mechanism that would randomly pick a

[GitHub] spark pull request #14826: [SPARK-17311] [MLLIB] Standardize Python-Java MLl...

2016-08-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14826#discussion_r76959584 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala --- @@ -126,13 +126,14 @@ private[python] class PythonMLLibAPI extends

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64711/ Test PASSed. ---

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64713/consoleFull)** for PR 14712 at commit

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64711 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64711/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14862: [SPARK-17295][SQL] Create TestHiveSessionState use refle...

2016-08-31 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/14862 @yhuai Could you review this PR please? Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14858: [SPARK-17219][ML] Add NaN value handling in Bucke...

2016-08-31 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14858#discussion_r76953758 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala --- @@ -114,11 +114,9 @@ final class QuantileDiscretizer @Since("1.6.0")

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14891 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64708/ Test PASSed. ---

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14891 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14891 **[Test build #64708 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64708/consoleFull)** for PR 14891 at commit

[GitHub] spark pull request #9571: [SPARK-11373] [CORE] Add metrics to the History Se...

2016-08-31 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/9571#discussion_r76952864 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -664,6 +707,116 @@ private[history] class

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS

2016-08-31 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/14659 This context is just something passed over IPC to provide a general string for the audit logs, the main actual access of it is in the HDFS audit log ``` HdfsAuditLogger

[GitHub] spark pull request #14659: [SPARK-16757] Set up Spark caller context to HDFS

2016-08-31 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/14659#discussion_r76952473 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2418,6 +2418,18 @@ private[spark] object Utils extends Logging {

[GitHub] spark pull request #14659: [SPARK-16757] Set up Spark caller context to HDFS

2016-08-31 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/14659#discussion_r76951863 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -2418,6 +2418,18 @@ private[spark] object Utils extends Logging {

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14889 It seems okay with minimal version. It seems 3.1+ (if my understanding is correct, https://github.com/hadley/testthat/blob/v1.0.0/DESCRIPTION#L13). I will try to look into this deeper. --- If

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14783 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14783 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64712/ Test FAILed. ---

[GitHub] spark pull request #14874: [SPARK-17180][SPARK-17309][SPARK-17323][SQL] crea...

2016-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14783 **[Test build #64712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64712/consoleFull)** for PR 14783 at commit

[GitHub] spark issue #14874: [SPARK-17180][SPARK-17309][SPARK-17323][SQL] create Alte...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14874 thanks for the review, merging to master! I'll send a new PR for 2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14784: [SPARK-17210][SPARKR] sparkr.zip is not distribut...

2016-08-31 Thread zjffdu
Github user zjffdu commented on a diff in the pull request: https://github.com/apache/spark/pull/14784#discussion_r76950704 --- Diff: R/pkg/R/sparkR.R --- @@ -365,6 +365,10 @@ sparkR.session <- function( } overrideEnvs(sparkConfigMap, paramMap) } + if

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64711/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14892: [SPARK-17329] [BUILD] Don't build PRs with -Pyarn unless...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14892 **[Test build #64710 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64710/consoleFull)** for PR 14892 at commit

[GitHub] spark pull request #14892: [SPARK-17329] [BUILD] Don't build PRs with -Pyarn...

2016-08-31 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/14892 [SPARK-17329] [BUILD] Don't build PRs with -Pyarn unless YARN code changed ## What changes were proposed in this pull request? Only build PRs with -Pyarn if YARN code was modified.

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14783 **[Test build #64712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64712/consoleFull)** for PR 14783 at commit

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14889 shane knapp manages Jenkins, he should know. Does the newer testthat have any minimal R version requirement? We are running R 3.1.1 (the minimal required R version) in Jenkins. --- If

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14712 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64709/ Test FAILed. ---

[GitHub] spark issue #14892: [SPARK-17329] [BUILD] Don't build PRs with -Pyarn unless...

2016-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14892 CC @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64709 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64709/consoleFull)** for PR 14712 at commit

[GitHub] spark issue #14859: [SPARK-17200][PROJECT INFRA][BUILD][SPARKR] Automate bui...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14859 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64702/ Test PASSed. ---

[GitHub] spark issue #14859: [SPARK-17200][PROJECT INFRA][BUILD][SPARKR] Automate bui...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14859 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14859: [SPARK-17200][PROJECT INFRA][BUILD][SPARKR] Automate bui...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14859 **[Test build #64702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64702/consoleFull)** for PR 14859 at commit

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14712 **[Test build #64709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64709/consoleFull)** for PR 14712 at commit

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76949035 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -168,6 +169,81 @@ class StatisticsSuite extends QueryTest with

[GitHub] spark issue #14885: [SPARK-17320] add build_profile_flags entry to mesos bui...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14885 **[Test build #3239 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3239/consoleFull)** for PR 14885 at commit

[GitHub] spark issue #14862: [SPARK-17295][SQL] Create TestHiveSessionState use refle...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14862 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14890: [MINOR][SPARKR] Verbose the build comment in WIND...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14890#discussion_r76948645 --- Diff: R/WINDOWS.md --- @@ -4,13 +4,23 @@ To build SparkR on Windows, the following steps are required 1. Install R (>= 3.1) and

[GitHub] spark issue #14862: [SPARK-17295][SQL] Create TestHiveSessionState use refle...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14862 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64701/ Test PASSed. ---

[GitHub] spark issue #14862: [SPARK-17295][SQL] Create TestHiveSessionState use refle...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14862 **[Test build #64701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64701/consoleFull)** for PR 14862 at commit

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-31 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r76948258 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -140,7 +145,12 @@ private[hive] case class MetastoreRelation(

[GitHub] spark issue #14873: [SPARK-17308]Improved the spark core code by replacing a...

2016-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14873 No, I'd leave it open for some time for comments in any event, especially if someone has expressed doubts about it. I'd like to wait some time for more comments before considering merging it. ---

[GitHub] spark issue #14874: [SPARK-17180][SPARK-17309][SPARK-17323][SQL] create Alte...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14874: [SPARK-17180][SPARK-17309][SPARK-17323][SQL] create Alte...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64703/ Test PASSed. ---

[GitHub] spark issue #14874: [SPARK-17180][SPARK-17309][SPARK-17323][SQL] create Alte...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14874 **[Test build #64703 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64703/consoleFull)** for PR 14874 at commit

[GitHub] spark pull request #10225: [SPARK-12196][Core] Store/retrieve blocks in diff...

2016-08-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10225#discussion_r76946878 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -50,35 +50,98 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14889 @felixcheung It seems due to the differences of `testthat` version..? It seems this printing is added from `testthat` 1.0.0 (with this

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-31 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/1 @hvanhovell,can you please have a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14889 thanks for fixing this. I thought skipped tests are easy to miss so it would be great (maybe as a separate PR) if there is a way we could detect what's being skipped from within Jenkins. ---

[GitHub] spark issue #14773: [SPARK-17203][SQL] data source options should always be ...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14773 I'll back on it after we unify the `path` option and the `locationUri` for data source and hive serde tables. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14891 I think this kind of thing is fine to call out, but we haven't used this convention, quite, elsewhere. The APIs are all "Scala-specific" unless otherwise noted. Even then they're callable from Java,

[GitHub] spark pull request #10225: [SPARK-12196][Core] Store/retrieve blocks in diff...

2016-08-31 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/10225#discussion_r76942560 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -50,35 +50,98 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14531 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64699/ Test PASSed. ---

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #64699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64699/consoleFull)** for PR 14531 at commit

[GitHub] spark pull request #10225: [SPARK-12196][Core] Store/retrieve blocks in diff...

2016-08-31 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/10225#discussion_r7694 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -50,35 +50,98 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark issue #11119: [SPARK-10780][ML][WIP] Add initial model to kmeans

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64705/ Test PASSed. ---

[GitHub] spark issue #11119: [SPARK-10780][ML][WIP] Add initial model to kmeans

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/9 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms shou...

2016-08-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13584#discussion_r76940615 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #11119: [SPARK-10780][ML][WIP] Add initial model to kmeans

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #64705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64705/consoleFull)** for PR 9 at commit

[GitHub] spark pull request #13584: [SPARK-15509][ML][SparkR] R MLlib algorithms shou...

2016-08-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/13584#discussion_r76940367 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/RWrapperUtils.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14889 It seems SparkR always runs the tests all? I will check this out. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14889 @felixcheung I remember in case of PySpark/Scala, only fixed and related modules are tested by tracking the changed/related modules via changed files in the PR with Jenkins (within

[GitHub] spark pull request #14890: [MINOR][SPARKR] Verbose the build comment in WIND...

2016-08-31 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/14890#discussion_r76939962 --- Diff: R/WINDOWS.md --- @@ -4,13 +4,23 @@ To build SparkR on Windows, the following steps are required 1. Install R (>= 3.1) and

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64707/ Test PASSed. ---

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64707 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64707/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64706/ Test PASSed. ---

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64706/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64704/ Test PASSed. ---

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14890 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14783: SPARK-16785 R dapply doesn't return array or raw columns

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14783 should we have a test against DataFrame with binary column? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64704 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64704/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specifi...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14891 **[Test build #64708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64708/consoleFull)** for PR 14891 at commit

[GitHub] spark issue #14856: [SPARK-17241][SparkR][MLlib] SparkR spark.glm should hav...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14856 LGTM - I guess it would be good to sanity check the test value with Scala. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14889 btw, do you know why the "skipped" message is not in the Jenkins log? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request #14891: [SQL][DOC][MINOR] Add (Scala-specific) and (Java-...

2016-08-31 Thread jaceklaskowski
GitHub user jaceklaskowski opened a pull request: https://github.com/apache/spark/pull/14891 [SQL][DOC][MINOR] Add (Scala-specific) and (Java-specific) ## What changes were proposed in this pull request? Adds (Scala-specific) and (Java-specific) to Scaladoc. ## How

[GitHub] spark issue #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionState to...

2016-08-31 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14883 It sounds good to me! Will make a change tomorrow. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64707/consoleFull)** for PR 14890 at commit

[GitHub] spark pull request #14744: [SPARK-17178][SPARKR][SPARKSUBMIT] Allow to set s...

2016-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14889 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64700/ Test PASSed. ---

[GitHub] spark pull request #10225: [SPARK-12196][Core] Store/retrieve blocks in diff...

2016-08-31 Thread yucai
Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/10225#discussion_r76935911 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala --- @@ -50,35 +50,98 @@ private[spark] class DiskBlockManager(conf: SparkConf,

[GitHub] spark issue #14744: [SPARK-17178][SPARKR][SPARKSUBMIT] Allow to set sparkr s...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14744 LGTM, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #14883: [SPARK-17319] [SQL] Move addJar from HiveSessionState to...

2016-08-31 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/14883 ok maybe we should update the document and say that `ADD JAR` is cross-session, also move the `addJar` method to `SharedState`? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bu...

2016-08-31 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14531#discussion_r76935703 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala --- @@ -58,18 +63,32 @@ case class CreateTableLikeCommand(

[GitHub] spark issue #14659: [SPARK-16757] Set up Spark caller context to HDFS

2016-08-31 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14659 I'm not sure I know enough about the APIs and need for this to say I would review and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14889 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14889 **[Test build #64700 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64700/consoleFull)** for PR 14889 at commit

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64706/consoleFull)** for PR 14890 at commit

[GitHub] spark issue #14889: [SPARK-17326][SPARKR] Fix tests with HiveContext in Spar...

2016-08-31 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14889 LGTM thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #11119: [SPARK-10780][ML][WIP] Add initial model to kmeans

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/9 **[Test build #64705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64705/consoleFull)** for PR 9 at commit

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14890 **[Test build #64704 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64704/consoleFull)** for PR 14890 at commit

[GitHub] spark pull request #14890: [MINOR][SPARKR] Verbose the build comment in WIND...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/14890#discussion_r76934575 --- Diff: R/WINDOWS.md --- @@ -4,13 +4,21 @@ To build SparkR on Windows, the following steps are required 1. Install R (>= 3.1) and

[GitHub] spark issue #14890: [MINOR][SPARKR] Verbose the build comment in WINDOWS.md ...

2016-08-31 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14890 Could you please check if this is sensible @shivaram ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #14890: [MINOR][SPARKR] Verbose the build comment in WIND...

2016-08-31 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14890 [MINOR][SPARKR] Verbose the build comment in WINDOWS.md rather than promoting default build without Hive ## What changes were proposed in this pull request? This PR fixes `WINDOWS.md`

<    1   2   3   4   5   6   7   >