[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88591439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -603,7 +603,14 @@ case class

[GitHub] spark issue #15916: [SPARK-18487][SQL] Add completion listener to HashAggreg...

2016-11-17 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15916 Did you actually see an issue with memory leak? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88591283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -574,7 +574,12 @@ object ScalaReflection extends

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88591241 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -603,7 +603,14 @@ case class

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88591177 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -603,7 +603,14 @@ case class

[GitHub] spark issue #15835: [SPARK-17059][SQL] Allow FileFormat to specify partition...

2016-11-17 Thread pwoody
Github user pwoody commented on the issue: https://github.com/apache/spark/pull/15835 Hey - yeah definitely a real concern as it needs driver heap to scale with the size of the metadata of the table you are going to read in. We could be creative to add heuristics around

[GitHub] spark issue #15925: [SPARK-18436][SQL]isin with a empty list throw exception

2016-11-17 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15925 Wouldn't this change the behavior for isin? If there is a problem with jdbc we should just not generate isin in those. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #15922: [SPARK-18462] Fix ClassCastException in SparkListenerDri...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15922 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15922: [SPARK-18462] Fix ClassCastException in SparkListenerDri...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15922 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68810/ Test PASSed. ---

[GitHub] spark issue #15926: [SPARK-16803] [SQL] SaveAsTable does not work when targe...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15926 **[Test build #68822 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68822/consoleFull)** for PR 15926 at commit

[GitHub] spark pull request #15926: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-11-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15926#discussion_r88590486 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/MetastoreDataSourcesSuite.scala --- @@ -413,6 +413,40 @@ class MetastoreDataSourcesSuite

[GitHub] spark issue #15922: [SPARK-18462] Fix ClassCastException in SparkListenerDri...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15922 **[Test build #68810 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68810/consoleFull)** for PR 15922 at commit

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88590439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -574,7 +574,12 @@ object ScalaReflection extends

[GitHub] spark pull request #15926: [SPARK-16803] [SQL] SaveAsTable does not work whe...

2016-11-17 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/15926 [SPARK-16803] [SQL] SaveAsTable does not work when target table is a Hive serde table ### What changes were proposed in this pull request? In Spark 2.0, `SaveAsTable` does not work

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15907 **[Test build #68821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68821/consoleFull)** for PR 15907 at commit

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15923 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68813/ Test FAILed. ---

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15923 **[Test build #68813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68813/consoleFull)** for PR 15923 at commit

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15923 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15907 **[Test build #68820 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68820/consoleFull)** for PR 15907 at commit

[GitHub] spark issue #15901: [SPARK-18467][SQL] Extracts method for preparing argumen...

2016-11-17 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15901 LGTM cc @cloud-fan for another check. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68809/ Test PASSed. ---

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88589179 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/SortBenchmark.scala --- @@ -80,7 +80,7 @@ class SortBenchmark extends

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68809/consoleFull)** for PR 15852 at commit

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88589188 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java --- @@ -176,7 +176,7 @@ public ShuffleSorterIterator getSortedIterator()

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88589145 --- Diff: core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala --- @@ -73,22 +73,22 @@ class RadixSortSuite extends

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15907 **[Test build #68819 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68819/consoleFull)** for PR 15907 at commit

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88589051 --- Diff: core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala --- @@ -73,22 +73,22 @@ class RadixSortSuite extends

[GitHub] spark issue #15925: [SPARK-18436][SQL]isin with a empty list throw exception

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15925 **[Test build #68817 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68817/consoleFull)** for PR 15925 at commit

[GitHub] spark issue #15916: [SPARK-18487][SQL] Add completion listener to HashAggreg...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15916 **[Test build #68818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68818/consoleFull)** for PR 15916 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68808/ Test PASSed. ---

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-17 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r88588544 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -574,7 +574,12 @@ object ScalaReflection extends

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68808 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68808/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14650 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68805/ Test PASSed. ---

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14650 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15925: [SPARK-18436][SQL]isin with a empty list throw ex...

2016-11-17 Thread windpiger
GitHub user windpiger opened a pull request: https://github.com/apache/spark/pull/15925 [SPARK-18436][SQL]isin with a empty list throw exception ## What changes were proposed in this pull request? when the list of `isin` is empty, the compileFilter will generate the sql

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14650 **[Test build #68805 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68805/consoleFull)** for PR 14650 at commit

[GitHub] spark issue #15916: [SPARK-18487][SQL] Consume all elements for Dataset.show...

2016-11-17 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15916 @hvanhovell Thanks for the hint. I am trying it. However this listener would be in operators case by case, e.g., HashAggregate here. If there are any other operators needed to release resources

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68807/ Test PASSed. ---

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15852 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68807/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68816/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/15874 @Yunni I think if we are using this 2-independent hash family we should provide that reference you mention in the Scaladoc, and also mention it approximates min-wise independent. --- If your

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13065 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13065 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68804/ Test PASSed. ---

[GitHub] spark issue #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13065 **[Test build #68804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68804/consoleFull)** for PR 13065 at commit

[GitHub] spark issue #15835: [SPARK-17059][SQL] Allow FileFormat to specify partition...

2016-11-17 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/15835 This creates huge problems when the table is big doesn't it? We just did a big change to get rid of the per table file status cache, because its existence made Spark unstable with dealing with tables

[GitHub] spark issue #15924: Spark-18498 [SQL] Revise HDFSMetadataLog API for better ...

2016-11-17 Thread uncleGen
Github user uncleGen commented on the issue: https://github.com/apache/spark/pull/15924 I think you can convert "Spark-18498" to "[SPARK-18498]" in title to keep the same format with others. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #15924: Spark-18498 [SQL] Revise HDFSMetadataLog API for better ...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15924 **[Test build #68815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68815/consoleFull)** for PR 15924 at commit

[GitHub] spark issue #15880: [SPARK-17913][SQL] compare long and string type column m...

2016-11-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/15880 I agree implicit cast is kind of evil, and for the example in SPARK-18489, it's better to follow postgres and fail the query because we can't cast "s" to integer. But this will break hive

[GitHub] spark pull request #15924: Spark-18498 [SQL] Revise HDFSMetadataLog API for ...

2016-11-17 Thread tcondie
GitHub user tcondie opened a pull request: https://github.com/apache/spark/pull/15924 Spark-18498 [SQL] Revise HDFSMetadataLog API for better testing ## What changes were proposed in this pull request? Revise HDFSMetadataLog API such that metadata object serialization and

[GitHub] spark pull request #15812: [SPARK-18360][SQL] default table path of tables i...

2016-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #15812: [SPARK-18360][SQL] default table path of tables in defau...

2016-11-17 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15812 LGTM. Merging to master and branch 2.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...

2016-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15923#discussion_r88584590 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -305,35 +312,82 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...

2016-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15923#discussion_r88584496 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -305,35 +312,82 @@ final class ShuffleBlockFetcherIterator(

[GitHub] spark issue #15896: [SPARK-18465] Uncache table shouldn't throw an exception...

2016-11-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/15896 I see. Thank you for informing that, @brkyvz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88581369 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -245,4 +284,25 @@ object

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88581282 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLogSuite.scala --- @@ -0,0 +1,34 @@ +/* + *

[GitHub] spark pull request #15852: Spark-18187 [SQL] CompactibleFileStreamLog should...

2016-11-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/15852#discussion_r88580974 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala --- @@ -330,34 +331,51 @@ trait StreamTest extends QueryTest with

[GitHub] spark issue #15921: [SPARK-18493] Add missing python APIs: withWatermark and...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15921 **[Test build #68814 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68814/consoleFull)** for PR 15921 at commit

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88581499 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleInMemorySorter.java --- @@ -176,7 +176,7 @@ public ShuffleSorterIterator getSortedIterator()

[GitHub] spark pull request #15907: [SPARK-18458][CORE] Fix signed integer overflow p...

2016-11-17 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/15907#discussion_r88581480 --- Diff: core/src/test/scala/org/apache/spark/util/collection/unsafe/sort/RadixSortSuite.scala --- @@ -73,22 +73,22 @@ class RadixSortSuite extends

[GitHub] spark issue #15820: [SPARK-18373][SS][Kafka]Make failOnDataLoss=false work w...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15820 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15907: [SPARK-18458][CORE] Fix signed integer overflow problem ...

2016-11-17 Thread ericl
Github user ericl commented on the issue: https://github.com/apache/spark/pull/15907 Looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15820: [SPARK-18373][SS][Kafka]Make failOnDataLoss=false work w...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15820 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68811/ Test PASSed. ---

[GitHub] spark issue #15820: [SPARK-18373][SS][Kafka]Make failOnDataLoss=false work w...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15820 **[Test build #68811 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68811/consoleFull)** for PR 15820 at commit

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88581043 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -103,5 +109,182 @@ case class GenerateExec( }

[GitHub] spark pull request #13065: [SPARK-15214][SQL] Code-generation for Generate

2016-11-17 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/13065#discussion_r88580906 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -113,4 +117,25 @@ class WholeStageCodegenSuite extends

[GitHub] spark issue #15923: [SPARK-4105] retry the fetch or stage if shuffle block i...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15923 **[Test build #68813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68813/consoleFull)** for PR 15923 at commit

[GitHub] spark issue #15894: [SPARK-18188] Add checksum for shuffle blocks

2016-11-17 Thread davies
Github user davies commented on the issue: https://github.com/apache/spark/pull/15894 Due to complexity and overhead here, close it in favor of https://github.com/apache/spark/pull/15923/. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request #15894: [SPARK-18188] Add checksum for shuffle blocks

2016-11-17 Thread davies
Github user davies closed the pull request at: https://github.com/apache/spark/pull/15894 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15923: [SPARK-4105] retry the fetch or stage if shuffle ...

2016-11-17 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/15923 [SPARK-4105] retry the fetch or stage if shuffle block is corrupt ## What changes were proposed in this pull request? There is an outstanding issue that existed for a long time: Sometimes

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15821 **[Test build #68812 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68812/consoleFull)** for PR 15821 at commit

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15821 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68812/ Test FAILed. ---

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15821 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15821 **[Test build #68812 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68812/consoleFull)** for PR 15821 at commit

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68803/ Test PASSed. ---

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15874 **[Test build #68803 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68803/consoleFull)** for PR 15874 at commit

[GitHub] spark issue #15820: [SPARK-18373][SS][Kafka]Make failOnDataLoss=false work w...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15820 **[Test build #68811 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68811/consoleFull)** for PR 15820 at commit

[GitHub] spark issue #15922: [SPARK-18462] Fix ClassCastException in SparkListenerDri...

2016-11-17 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/15922 lgtm pending jenkins --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15874 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68802/ Test PASSed. ---

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15874 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15874 **[Test build #68802 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68802/consoleFull)** for PR 15874 at commit

[GitHub] spark issue #15922: [SPARK-18462] Fix ClassCastException in SparkListenerDri...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15922 **[Test build #68810 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68810/consoleFull)** for PR 15922 at commit

[GitHub] spark pull request #15922: [SPARK-18462] Fix ClassCastException in SparkList...

2016-11-17 Thread JoshRosen
GitHub user JoshRosen opened a pull request: https://github.com/apache/spark/pull/15922 [SPARK-18462] Fix ClassCastException in SparkListenerDriverAccumUpdates event ## What changes were proposed in this pull request? This patch fixes a `ClassCastException:

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68809/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68808 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68808/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15831: [SPARK-18385][ML] Make the transformer's natively in ml ...

2016-11-17 Thread techaddict
Github user techaddict commented on the issue: https://github.com/apache/spark/pull/15831 @sethah I agree, 2nd approach is much more reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #15852: Spark-18187 [SQL] CompactibleFileStreamLog should not us...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15852 **[Test build #68807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68807/consoleFull)** for PR 15852 at commit

[GitHub] spark issue #15874: [Spark-18408][ML] API Improvements for LSH

2016-11-17 Thread Yunni
Github user Yunni commented on the issue: https://github.com/apache/spark/pull/15874 Hi @jkbradley, **MinHash** Yes, I agree that I shouldn't have said it's perfect hashing. Theoretically, it should be Min-wise Independent Permutation Family. What we used here is

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15821 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15821 **[Test build #68806 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68806/consoleFull)** for PR 15821 at commit

[GitHub] spark issue #14650: [SPARK-17062][MESOS] add conf option to mesos dispatcher

2016-11-17 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/14650 @vanzin I updated the PR. Thank you for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15840: [SPARK-18398][SQL] Fix nullabilities of MapObjects and o...

2016-11-17 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/15840 @hvanhovell I'd like to revert some of commits in this pr which replace null checking with `ctx.nullSafeExec()` to focus on the original purpose of this pr, and send another pr to discuss null

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15821 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68806/ Test FAILed. ---

[GitHub] spark issue #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to increa...

2016-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15821 **[Test build #68806 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/68806/consoleFull)** for PR 15821 at commit

[GitHub] spark pull request #14650: [SPARK-17062][MESOS] add conf option to mesos dis...

2016-11-17 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/14650#discussion_r88572655 --- Diff: core/src/main/scala/org/apache/spark/util/CommandLineUtils.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #15896: [SPARK-18465] Uncache table shouldn't throw an exception...

2016-11-17 Thread brkyvz
Github user brkyvz commented on the issue: https://github.com/apache/spark/pull/15896 On hold on my side. Will try to get back to it On Nov 17, 2016 3:31 PM, "Dongjoon Hyun" wrote: > Hi, @brkyvz and @gatorsmile

<    1   2   3   4   5   6   >