[GitHub] spark issue #15918: [SPARK-18122][SQL][WIP]Fallback to Kryo for unsupported ...

2016-11-27 Thread koertkuipers
Github user koertkuipers commented on the issue: https://github.com/apache/spark/pull/15918 @srowen and @rxin what is the default behavior that is changed here? i see a current situation where an implicit encoder is provided that simply cannot handle the task at hand and this leads

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89690455 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -590,7 +591,11 @@ object ScalaReflection extends

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16021 I am fine with this in terms of the change I proposed in the PR before except that the comment above. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #16022: [SPARK-18598][SQL] Fixed inconsistent bean proper...

2016-11-27 Thread hamishmorgan
GitHub user hamishmorgan opened a pull request: https://github.com/apache/spark/pull/16022 [SPARK-18598][SQL] Fixed inconsistent bean property inference ## What changes were proposed in this pull request? `JavaTypeInference#inferDataType` used a different bean property

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69202 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69202/consoleFull)** for PR 16018 at commit

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16022 **[Test build #69203 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69203/consoleFull)** for PR 16022 at commit

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69202/ Test FAILed. ---

[GitHub] spark pull request #15975: [SPARK-18538] [SQL] Fix Concurrent Table Fetching...

2016-11-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/15975#discussion_r89693478 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala --- @@ -220,22 +228,14 @@ class DataFrameReader private[sql](sparkSession:

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16022 **[Test build #69203 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69203/consoleFull)** for PR 16022 at commit

[GitHub] spark issue #16023: [SPARK-18599] Add Spectral LDA algorithm

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16023 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69204 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69204/consoleFull)** for PR 16018 at commit

[GitHub] spark issue #16021: JDBCRDD returns incorrect results for filters on CHAR of...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 cc @maropu , @viirya , @HyukjinKwon , @rxin . This is a backport to resolve SPARK-18593 in `branch-1.6`. Although this is a correctness issue, there is a workaround for this

[GitHub] spark pull request #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect resu...

2016-11-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16021#discussion_r89690682 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRDD.scala --- @@ -165,8 +165,64 @@ private[sql] object JDBCRDD extends

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/16018 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #15620: [SPARK-18091] [SQL] Deep if expressions cause Generated ...

2016-11-27 Thread kapilsingh5050
Github user kapilsingh5050 commented on the issue: https://github.com/apache/spark/pull/15620 I have been able to reproduce the failures using sbt. Investigating the cause. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69202 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69202/consoleFull)** for PR 16018 at commit

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89691656 --- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala --- @@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double])

[GitHub] spark pull request #16017: [SPARK-18592][ML] Move DT/RF/GBT Param setter met...

2016-11-27 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/16017#discussion_r89694871 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala --- @@ -52,33 +52,49 @@ class DecisionTreeClassifier

[GitHub] spark issue #16021: JDBCRDD returns incorrect results for filters on CHAR of...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69201 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69201/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16022 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread skanjila
Github user skanjila commented on the issue: https://github.com/apache/spark/pull/15848 Yes the plan is to comment out the failures for now but keep the rest of the changes, fix the Python unit tests with local[4] and then come back and fix the rest of the failures, let me know if

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16018 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect resu...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16021#discussion_r89688101 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala --- @@ -210,6 +220,16 @@ class JDBCSuite extends SparkFunSuite

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/16021 @dongjoon-hyun Thanks for letting me know! I'm not familiar with a backport policy in spark though, if we can, I think it'd be better to do because it seems there are still some of users use spark

[GitHub] spark issue #16013: [SPARK-3359][DOCS] Make javadoc8 working for unidoc/genj...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16013 @srowen Thank you for your comments. I will try to handle them at my best. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89691484 --- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala --- @@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double])

[GitHub] spark issue #13909: [SPARK-16213][SQL] Reduce runtime overhead of a program ...

2016-11-27 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13909 @cloud-fan , @hvanhovell @viirya could you please review this again except if the current `Array[Byte]` is OK? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16022 Given the comment it sounds like this change could cause tests to fail. We'll find out shortly. It seems like a good change because indeed bean properties are defined by getters and/or setters so it

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16022 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16022 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69203/ Test FAILed. ---

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16022 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss ...

2016-11-27 Thread windpiger
Github user windpiger commented on a diff in the pull request: https://github.com/apache/spark/pull/15994#discussion_r89687890 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -128,66 +128,49 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89690490 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -590,7 +591,11 @@ object ScalaReflection extends

[GitHub] spark pull request #13909: [SPARK-16213][SQL] Reduce runtime overhead of a p...

2016-11-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r89691689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala --- @@ -412,7 +412,8 @@ object CatalystTypeConverters {

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16021 @dongjoon-hyun Thanks for cc'ing me. Combined with https://github.com/apache/spark/commit/b22b20db640e9fac20c5d54cc83964dc74393821, I think it is worth backporting this to branch-1.6. --- If your

[GitHub] spark pull request #16013: [SPARK-3359][DOCS] Make javadoc8 working for unid...

2016-11-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/16013#discussion_r89691571 --- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala --- @@ -152,10 +152,12 @@ class DoubleRDDFunctions(self: RDD[Double]) extends

[GitHub] spark pull request #16023: [SPARK-18599] Add Spectral LDA algorithm

2016-11-27 Thread jli05
GitHub user jli05 opened a pull request: https://github.com/apache/spark/pull/16023 [SPARK-18599] Add Spectral LDA algorithm The Spectral LDA algorithm transforms the LDA problem to an orthogonal tensor decomposition problem. [[Anandkumar 2012]] establishes theoretical guarantee

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69201 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69201/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69201/ Test PASSed. ---

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89690557 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -405,10 +406,11 @@ case class WrapOption(child:

[GitHub] spark pull request #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss ...

2016-11-27 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/15994#discussion_r89690706 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala --- @@ -128,66 +128,49 @@ final class DataFrameNaFunctions

[GitHub] spark pull request #15780: [SPARK-18284][SQL] Make ExpressionEncoder.seriali...

2016-11-27 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/15780#discussion_r89695627 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -405,10 +406,11 @@ case class WrapOption(child:

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/16022 We can't do this since it breaks compatibility now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Oops. I didn't replace `spark` with `sqlContext`. I'll fix soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69207 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69207/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69207/ Test FAILed. ---

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/15780 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69208 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69208/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16021 Actually @dongjoon-hyun, this is a rather a question. Should we include other JIRAs in the title which this PR includes to backport? --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Hmm. Ur, @HyukjinKwon , maybe, the Spark script might not work like that I mentioned. Anyway, in that case, the committer should backport these 6 commits separately instead of this

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15848 This is actually what I was worried of initially. So, you mean you are going to fix the failure tests here in this PR at the end? --- If your project is set up for it, you can reply to this

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do push-down predicates to right side...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16026 **[Test build #69211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69211/consoleFull)** for PR 16026 at commit

[GitHub] spark issue #16026: [SPARK-18597][SQL] Do push-down predicates to right side...

2016-11-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16026 cc @dongjoon-hyun could you take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15848 In my personal opinion, I think we should fix here together. Maybe we could - Run the tests with `--fail-never` flag in the maven in order to list up the failed tests. If they are few

[GitHub] spark pull request #15848: [SPARK-9487] Use the same num. worker threads in ...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/15848#discussion_r89705936 --- Diff: streaming/src/test/java/org/apache/spark/streaming/JavaAPISuite.java --- @@ -1244,7 +1244,15 @@ public void testCountByValue() {

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/15848 I saw several PRs time to time to run automatic Jenkins tests. So, I _think_ it is fine to keep this open and push some commits/run some tests to detect the failure tests if you are proceeding

[GitHub] spark pull request #16027: Make sure CollapseWindow returns the attributes i...

2016-11-27 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/16027 Make sure CollapseWindow returns the attributes in the same order. ## What changes were proposed in this pull request? The `CollapseWindow` optimizer rule changes the order of output

[GitHub] spark issue #16027: Make sure CollapseWindow returns the attributes in the s...

2016-11-27 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/16027 cc @dongjoon-hyun --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16027: Make sure CollapseWindow returns the attributes in the s...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16027 **[Test build #69212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69212/consoleFull)** for PR 16027 at commit

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16025 **[Test build #69210 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69210/consoleFull)** for PR 16025 at commit

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69210/ Test PASSed. ---

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16025 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #15916: [SPARK-18487][SQL] Add completion listener to HashAggreg...

2016-11-27 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/15916 ping @rxin Appreciate your feedback if you can let me know what you think of my suggestion. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69214/consoleFull)** for PR 15994 at commit

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69208 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69208/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16024: [MINOR][DOCS] Updates to the Accumulator example in the ...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69209/ Test PASSed. ---

[GitHub] spark issue #16024: [MINOR][DOCS] Updates to the Accumulator example in the ...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16024 **[Test build #69209 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69209/consoleFull)** for PR 16024 at commit

[GitHub] spark issue #16024: [MINOR][DOCS] Updates to the Accumulator example in the ...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16024 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69208/ Test PASSed. ---

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Only your commits will be in `branch-1.6` with the original titles. Since this PR has nothing, this PR will disappear completely when the committer merge this. I think so. --- If your

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/16021 ( I was just curious as I just remember tracking down with the blame button. It is no strong opinion.) --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #16026: [SPARK-18597][SQL] Do push-down predicates to rig...

2016-11-27 Thread hvanhovell
GitHub user hvanhovell opened a pull request: https://github.com/apache/spark/pull/16026 [SPARK-18597][SQL] Do push-down predicates to right side for a LEFT ANTI join ## What changes were proposed in this pull request? We currently push down join predicates for a Left Anti join

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread skanjila
Github user skanjila commented on the issue: https://github.com/apache/spark/pull/15848 Sorry I meant Pyspark failures from unit tests , pardon my typos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread skanjila
Github user skanjila commented on the issue: https://github.com/apache/spark/pull/15848 @HyujkinKwon I saw at least 3 to 4 failures in unit tests that happened in Jenkins but not locally (meaning the test succeeded locally). I completely agree with you about not marking something

[GitHub] spark issue #15994: [SPARK-18555][SQL]DataFrameNaFunctions.fill miss up orig...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15994 **[Test build #69213 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69213/consoleFull)** for PR 15994 at commit

[GitHub] spark pull request #16003: [SPARK-18482][SQL] make sure Spark can access the...

2016-11-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16003#discussion_r89701384 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogBackwardCompatibilitySuite.scala --- @@ -0,0 +1,251 @@ +/* + *

[GitHub] spark issue #16003: [SPARK-18482][SQL] make sure Spark can access the table ...

2016-11-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16003 LGTM except a minor comment. We can address it in a separate PR for checking 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16025 **[Test build #69210 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69210/consoleFull)** for PR 16025 at commit

[GitHub] spark issue #16025: [SPARK-18602] Set the version of org.codehaus.janino:com...

2016-11-27 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/16025 @kiszk want to take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16025: [SPARK-18602] Set the version of org.codehaus.jan...

2016-11-27 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/16025 [SPARK-18602] Set the version of org.codehaus.janino:commons-compiler to 3.0.0 to match the version of org.codehaus.janino:janino ## What changes were proposed in this pull request?

[GitHub] spark issue #16012: [SPARK-17251][SQL] Support `OuterReference` in projectio...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16012 Hi, @hvanhovell and @nsyca . I created a JIRA issue for Option 2 with simple and complex example (@hvanhovell 's). * https://issues.apache.org/jira/browse/SPARK-18603

[GitHub] spark issue #15848: [SPARK-9487] Use the same num. worker threads in Java/Sc...

2016-11-27 Thread skanjila
Github user skanjila commented on the issue: https://github.com/apache/spark/pull/15848 The plan is to comment out the tests causing Jenkins failures for now, fix the Python unit tests to work with local[4] and then come back and fix these other Jenkins failures, make sense? ---

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/16012 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #15780: [SPARK-18284][SQL] Make ExpressionEncoder.serializer.nul...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/15780 **[Test build #69205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69205/consoleFull)** for PR 15780 at commit

[GitHub] spark issue #15963: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...

2016-11-27 Thread AnthonyTruchet
Github user AnthonyTruchet commented on the issue: https://github.com/apache/spark/pull/15963 Hello @srowen , sorry not to have updated this lately, I've been taken by other emergencies at work. I'll update this on Monday. Actually I'll submit a variant of treeAggregate in core that

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16022 Yes, all but one of the failures arise because `LabeledPoint` is used as a bean class but it's a case class. It would be straightforward to add `def getFeatures = features` and `def getLabel =

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16021 Thank you, @maropu , @HyukjinKwon , @viirya . I'll update like that. @maropu . I think we don't need to remove that here at least for this issue. We don't expect Apache Spark

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69204/ Test PASSed. ---

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16018 **[Test build #69204 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69204/consoleFull)** for PR 16018 at commit

[GitHub] spark issue #16018: [SPARK-18594] [SQL] Name Validation of Databases/Tables

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16018 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16012: [SPARK-17251][SQL] Support `OuterReference` in pr...

2016-11-27 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/16012#discussion_r89699139 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -989,7 +989,7 @@ class Analyzer(

[GitHub] spark pull request #15986: [SPARK-18553][CORE][branch-2.0] Fix leak of TaskS...

2016-11-27 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/15986#discussion_r89699182 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -335,38 +337,38 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread hamishmorgan
Github user hamishmorgan commented on the issue: https://github.com/apache/spark/pull/16022 Thanks @srowen - I see you were right. Not sure how proceed. Some options: * Update failing tests to load their data a different way. * Update the relevant beans (used in the

[GitHub] spark issue #16021: [SPARK-18593][SQL] JDBCRDD returns incorrect results for...

2016-11-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16021 **[Test build #69206 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69206/consoleFull)** for PR 16021 at commit

[GitHub] spark issue #16022: [SPARK-18598][SQL] Fixed inconsistent bean property infe...

2016-11-27 Thread hamishmorgan
Github user hamishmorgan commented on the issue: https://github.com/apache/spark/pull/16022 Probably. Worst case, we should be able to at least fail faster with more helpful message. And maybe there's something better. I'll have a poke around and see. --- If your project is set up

[GitHub] spark issue #12420: [SPARK-14585][ML][WIP] Provide accessor methods for Pipe...

2016-11-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/12420 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

  1   2   3   >