[GitHub] spark pull request #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is ...

2017-01-27 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16670#discussion_r98267056 --- Diff: R/pkg/R/utils.R --- @@ -756,12 +756,12 @@ varargsToJProperties <- function(...) { props } -launchScript <- function(script,

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16720 @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #16720: [SPARK-19387][SPARKR] Tests do not run with Spark...

2017-01-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/16720 [SPARK-19387][SPARKR] Tests do not run with SparkR source package in CRAN check ## What changes were proposed in this pull request? - this is cause by changes in SPARK-18444,

[GitHub] spark pull request #16712: [SPARK-18873][SQL][TEST] New test cases for scala...

2017-01-27 Thread kevinyu98
Github user kevinyu98 commented on a diff in the pull request: https://github.com/apache/spark/pull/16712#discussion_r98079046 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/scalar-subquery/scalar-subquery-select.sql.out --- @@ -0,0 +1,198 @@ +--

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/16720 Hmm - another fix could be that in the test cases whenever we create `spark.session` we always pass in `master=local` ? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16720 **[Test build #72082 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72082/testReport)** for PR 16720 at commit

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16694 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16694 **[Test build #72080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72080/testReport)** for PR 16694 at commit

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16694 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72080/ Test PASSed. ---

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16706 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16706 **[Test build #72083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72083/testReport)** for PR 16706 at commit

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72081 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72081/testReport)** for PR 16686 at commit

[GitHub] spark pull request #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is ...

2017-01-27 Thread shivaram
Github user shivaram commented on a diff in the pull request: https://github.com/apache/spark/pull/16670#discussion_r98264755 --- Diff: R/pkg/inst/tests/testthat/test_Windows.R --- @@ -20,7 +20,7 @@ test_that("sparkJars tag in SparkContext", { if (.Platform$OS.type !=

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72081 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72081/testReport)** for PR 16686 at commit

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16694 **[Test build #72080 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72080/testReport)** for PR 16694 at commit

[GitHub] spark pull request #14725: [SPARK-17161] [PYSPARK][ML] Add PySpark-ML JavaWr...

2017-01-27 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/14725#discussion_r98257954 --- Diff: python/pyspark/ml/wrapper.py --- @@ -16,6 +16,10 @@ # from abc import ABCMeta, abstractmethod +import sys --- End diff

[GitHub] spark issue #16625: [SPARK-17874][core] Add SSL port configuration.

2017-01-27 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16625 @sarutak want to look at this since you looked at the somewhat mildly related PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(l, r)` ...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16719 **[Test build #72076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72076/testReport)** for PR 16719 at commit

[GitHub] spark issue #16717: [SPARK-19220][UI] Make redirection to HTTPS apply to all...

2017-01-27 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/16717 Merging to 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #16717: [SPARK-19220][UI] Make redirection to HTTPS apply...

2017-01-27 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/spark/pull/16717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(l, r)` ...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16719 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72076/ Test PASSed. ---

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(l, r)` ...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16719 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/16706 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16709: [SPARK-19333][SPARKR] Add Apache License headers to R fi...

2017-01-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16709 merged to master, branch-2.1, branch-2.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16709: [SPARK-19333][SPARKR] Add Apache License headers ...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16709 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72081/ Test PASSed. ---

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16720 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98278557 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -75,10 +107,14 @@ class

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98280054 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -78,14 +78,18 @@ object Canonicalize

[GitHub] spark issue #16497: [SPARK-19118] [SQL] Percentile support for frequency dis...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16497 **[Test build #72079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72079/testReport)** for PR 16497 at commit

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r98283223 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -17,7 +17,8 @@ package org.apache.spark.scheduler

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r98281415 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -187,6 +199,17 @@ private[scheduler] class BlacklistTracker (

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r98281426 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -187,6 +199,17 @@ private[scheduler] class BlacklistTracker (

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72085/testReport)** for PR 16686 at commit

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(l, r)` ...

2017-01-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16719 Hi, @lw-lin . Thank you for pining me. I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16720 yes, that is described in the PR description: " fix is to add check to the beginning of each test and vignettes; the same would also work by changing `sparkR.session()` to

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16720 I think better would be the approach being taken in PR 16330 - has a first run test that prepare and run these kind of thing

[GitHub] spark issue #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is getting...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16670 **[Test build #72084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72084/testReport)** for PR 16670 at commit

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16720 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72082/ Test PASSed. ---

[GitHub] spark issue #16720: [SPARK-19387][SPARKR] Tests do not run with SparkR sourc...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16720 **[Test build #72082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72082/testReport)** for PR 16720 at commit

[GitHub] spark issue #16497: [SPARK-19118] [SQL] Percentile support for frequency dis...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16497 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72079/ Test PASSed. ---

[GitHub] spark issue #16497: [SPARK-19118] [SQL] Percentile support for frequency dis...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16497 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(l, r)` ...

2017-01-27 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/16719 The original logic was designed to be safe for changing the caller bottom-up code,

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r98283147 --- Diff: core/src/test/scala/org/apache/spark/scheduler/BlacklistTrackerSuite.scala --- @@ -456,4 +459,61 @@ class BlacklistTrackerSuite extends

[GitHub] spark pull request #16650: [SPARK-16554][CORE] Automatically Kill Executors ...

2017-01-27 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/16650#discussion_r98281375 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -173,6 +174,17 @@ private[scheduler] class BlacklistTracker (

[GitHub] spark issue #16650: [SPARK-16554][CORE] Automatically Kill Executors and Nod...

2017-01-27 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/16650 I think this is basically ready, perhaps one more test case. @tgravescs any other comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is getting...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16670 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72084/ Test PASSed. ---

[GitHub] spark issue #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is getting...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16670 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16670: [SPARK-19324][SPARKR] Spark VJM stdout output is getting...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16670 **[Test build #72084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72084/testReport)** for PR 16670 at commit

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72086/testReport)** for PR 16686 at commit

[GitHub] spark pull request #16721: [SPARKR][DOCS] update R API doc for subset/extrac...

2017-01-27 Thread felixcheung
GitHub user felixcheung opened a pull request: https://github.com/apache/spark/pull/16721 [SPARKR][DOCS] update R API doc for subset/extract ## What changes were proposed in this pull request? With extract `[[` or replace `[[<-`, the parameter `i` is a column index, that

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72089/ Test PASSed. ---

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72085/testReport)** for PR 16686 at commit

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72085/ Test FAILed. ---

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16706 **[Test build #72083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72083/testReport)** for PR 16706 at commit

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16706 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16706: [SPARK-19365][Core]Optimize RequestMessage serialization

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16706 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72083/ Test PASSed. ---

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16721 **[Test build #72090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72090/testReport)** for PR 16721 at commit

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread actuaryzhang
Github user actuaryzhang commented on the issue: https://github.com/apache/spark/pull/16699 @zhengruifeng Thanks for the suggestions. Added casting and instrumentation. @imatiach-msft Thanks for the clarification! It is probably worth another PR to clean up all tests in GLM.

[GitHub] spark issue #16724: [SPARK-19352][WIP][SQL] Keep sort order of rows after ex...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16724 **[Test build #72096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72096/testReport)** for PR 16724 at commit

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16700 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread imatiach-msft
Github user imatiach-msft commented on the issue: https://github.com/apache/spark/pull/16699 @actuaryzhang thank you for updating the PR - I agree with your first two points. With regards to the method of RDD[Instance] also working with RDD[OffsetInstance], I think it should work,

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72086/ Test PASSed. ---

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16686 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16686 **[Test build #72086 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72086/testReport)** for PR 16686 at commit

[GitHub] spark pull request #16706: [SPARK-19365][Core]Optimize RequestMessage serial...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16281: [SPARK-13127][SQL] Update Parquet to 1.9.0

2017-01-27 Thread julienledem
Github user julienledem commented on the issue: https://github.com/apache/spark/pull/16281 FYI: Parquet 1.8.2 vote thread passed: https://mail-archives.apache.org/mod_mbox/parquet-dev/201701.mbox/%3CCAO4re1mHLT%2BLYn8s1RTEDZK8-9WSVugY8-HQqAN%2BtU%3DBOi1L9w%40mail.gmail.com%3E --- If

[GitHub] spark issue #16694: [SPARK-19336][ML][Pyspark]: LinearSVC Python API

2017-01-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16694 LGTM, thank you! Merging with master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72093/ Test FAILed. ---

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72093/testReport)** for PR 16722 at commit

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r98317696 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -839,6 +839,26 @@ private[spark] class

[GitHub] spark issue #15768: [SPARK-18080][ML][PySpark] Locality Sensitive Hashing (L...

2017-01-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/15768 Btw, @yanboliang and @Yunni did you sync? I'm fine with the takeover, but don't want to stomp on toes. Both can be listed as authors when this gets merged. Should we close this issue with the

[GitHub] spark issue #14725: [SPARK-17161] [PYSPARK][ML] Add PySpark-ML JavaWrapper c...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14725 **[Test build #72092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72092/testReport)** for PR 14725 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72091/testReport)** for PR 16722 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72091/ Test FAILed. ---

[GitHub] spark issue #16636: [SPARK-19279] [SQL] Block Creating a Hive Table With an ...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16636 : ) Done. Found a solution to infer the schema of Hive Serde tables. Let me clean the code now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark issue #16650: [SPARK-16554][CORE] Automatically Kill Executors and Nod...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16650 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16043: [SPARK-18601][SQL] Simplify Create/Get complex expressio...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16043 **[Test build #72088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72088/testReport)** for PR 16043 at commit

[GitHub] spark issue #16650: [SPARK-16554][CORE] Automatically Kill Executors and Nod...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16650 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72087/ Test PASSed. ---

[GitHub] spark pull request #16690: [SPARK-19347] ReceiverSupervisorImpl can add bloc...

2017-01-27 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/16690#discussion_r98297209 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEndpointRef.scala --- @@ -63,8 +65,48 @@ private[spark] abstract class RpcEndpointRef(conf: SparkConf)

[GitHub] spark pull request #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/16699#discussion_r98299104 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -336,14 +361,15 @@ class

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16721 **[Test build #72090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72090/testReport)** for PR 16721 at commit

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16721 **[Test build #72089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72089/testReport)** for PR 16721 at commit

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16722 **[Test build #72093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72093/testReport)** for PR 16722 at commit

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r98317671 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -839,6 +839,26 @@ private[spark] class

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r98317719 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -899,6 +919,21 @@ private[spark] class

[GitHub] spark issue #16650: [SPARK-16554][CORE] Automatically Kill Executors and Nod...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16650 **[Test build #72087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72087/testReport)** for PR 16650 at commit

[GitHub] spark pull request #16699: [SPARK-18710][ML] Add offset in GLM

2017-01-27 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/16699#discussion_r98300999 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -743,6 +743,84 @@ class

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16721 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72090/ Test PASSed. ---

[GitHub] spark issue #16721: [SPARKR][DOCS] update R API doc for subset/extract

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16721 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16722: [SPARK-9478][ML][MLlib] Add sample weights to decision t...

2017-01-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16722 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #16723: [SPARK-19389][ML][PYTHON][DOC] Minor doc fixes fo...

2017-01-27 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/16723 [SPARK-19389][ML][PYTHON][DOC] Minor doc fixes for ML Python Params and LinearSVC ## What changes were proposed in this pull request? * Removed Since tags in Python Params since they

[GitHub] spark issue #16723: [SPARK-19389][ML][PYTHON][DOC] Minor doc fixes for ML Py...

2017-01-27 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16723 **[Test build #72094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72094/testReport)** for PR 16723 at commit

[GitHub] spark issue #16723: [SPARK-19389][ML][PYTHON][DOC] Minor doc fixes for ML Py...

2017-01-27 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/16723 @wangmiao1981 Would you mind checking this? It has small fixes I noticed when reviewing your PR for Python LinearSVC. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r98317878 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -899,6 +919,21 @@ private[spark] class

[GitHub] spark pull request #16700: [SPARK-19359][SQL]clear useless path after rename...

2017-01-27 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16700#discussion_r98317808 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -899,6 +919,21 @@ private[spark] class

[GitHub] spark issue #16686: [SPARK-18682][SS] Batch Source for Kafka

2017-01-27 Thread tcondie
Github user tcondie commented on the issue: https://github.com/apache/spark/pull/16686 jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   >