Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853389
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user mariusvniekerk commented on the issue:
https://github.com/apache/spark/pull/15666
Seems to be something in pyspark.SparkContext.addJar:10: ERROR: Unexpected
indentation. ?
what exactly does it want in that docstring?
---
If your project is set up for it, you can
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/10506
Is anyone still working on this and if not, can you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1172,20 +1226,11 @@ class Analyzer(
}
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/10506
OK fine to leave this open then (I don't have the time or expertise to
review this unfortunately)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858555
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -604,7 +604,14 @@ class Analyzer(
def
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/17127
Merged into master, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103862351
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -86,7 +86,7 @@ case class DataSource(
lazy
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17124#discussion_r103865389
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
---
@@ -295,6 +295,28 @@ class StateStoreSuite
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/17124#discussion_r103864707
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala
---
@@ -282,8 +282,12 @@
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103865522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/17083
Ping @vanzin , do you have any further comments? Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16944
**[Test build #73725 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73725/testReport)**
for PR 16944 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850482
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103850635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852913
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103853075
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -361,6 +363,36 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/16959#discussion_r103854313
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/OutputCommitCoordinator.scala ---
@@ -158,13 +158,17 @@ private[spark] class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16954
@dilipbiswal I did one more pass. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103855766
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1172,20 +1226,11 @@ class Analyzer(
}
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103858494
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -77,6 +77,10 @@ trait CodegenSupport extends SparkPlan {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103858474
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -69,6 +69,7 @@ trait BaseLimitExec extends UnaryExecNode with
GitHub user stanzhai opened a pull request:
https://github.com/apache/spark/pull/17131
[SPARK-19766][SQL][BRANCH-2.0] Constant alias columns in INNER JOIN should
not be folded by FoldablePropagation rule
This PR fix for branch-2.0
Refer #17099
@gatorsmile
You
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103860938
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +207,13 @@ trait CodegenSupport extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103860895
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -77,6 +77,7 @@ trait CodegenSupport extends SparkPlan {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103861992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -122,7 +122,7 @@ case class DataSource(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103862631
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -364,7 +364,12 @@ case class DataSource(
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17122
**[Test build #73734 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73734/testReport)**
for PR 17122 at commit
Github user wojtek-szymanski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17075#discussion_r103864520
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/MathFunctionsSuite.scala ---
@@ -233,6 +233,18 @@ class MathFunctionsSuite extends
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17076
@yanboliang yeah I agree we can do it in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17128
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103840075
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -442,11 +453,15 @@ case class RangeExec(range:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844548
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -245,7 +245,7 @@ object
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16944
**[Test build #73725 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73725/testReport)**
for PR 16944 at commit
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103849859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -202,14 +194,9 @@ trait CheckAnalysis extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16944
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73725/
Test PASSed.
---
Github user windpiger commented on the issue:
https://github.com/apache/spark/pull/17081
cc @cloud-fan @gatorsmile could you help to review this?thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852210
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103853209
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103853263
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -27,6 +27,8 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17119
**[Test build #73727 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73727/testReport)**
for PR 17119 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17128
**[Test build #73729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73729/testReport)**
for PR 17128 at commit
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103858210
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -361,6 +363,36 @@ class
Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103858261
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -27,6 +27,8 @@ import
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/16938
thanks, merging to master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103861241
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +207,13 @@ trait CodegenSupport extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73726/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17081
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17095#discussion_r103862062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -254,7 +254,18 @@ class SessionCatalog(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103863428
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,16 @@ trait CodegenSupport extends
Github user wojtek-szymanski commented on a diff in the pull request:
https://github.com/apache/spark/pull/17075#discussion_r103863771
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -223,12 +223,24 @@ final class Decimal extends
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103863856
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17034
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73731/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17034
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/17076
@imatiach-msft `LinearRegression`, `LogisticRegression` and
`AFTSurvivalRegression` do not have the `lazy` - they only do `private val
gradientSumArray ...` so would need to be updated.
---
If
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103865408
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103865312
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16909
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73723/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16909
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/16909
@hvanhovell @dongjoon-hyun @davies @viirya : I have incorporated your
feedback. Can you please take a look ? Thanks !!
---
If your project is set up for it, you can reply to this email and
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17081#discussion_r103859650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -364,7 +364,8 @@ case class DataSource(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103862749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,16 @@ trait CodegenSupport extends SparkPlan
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103862946
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,16 @@ trait CodegenSupport extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16910
**[Test build #73735 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73735/testReport)**
for PR 16910 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103863975
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/17034#discussion_r103864147
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/AFTSurvivalRegressionSuite.scala
---
@@ -27,6 +27,9 @@ import
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17132
**[Test build #3591 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3591/testReport)**
for PR 17132 at commit
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/16910#discussion_r103864544
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -1588,6 +1590,153 @@ class HiveDDLSuite
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17128
**[Test build #73729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73729/testReport)**
for PR 17128 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17122
**[Test build #73737 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73737/testReport)**
for PR 17122 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17128
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73729/
Test PASSed.
---
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/17122
This optimization looks good and the improvement is great. I have some
comments regarding the changes of `shouldStopRequired`.
---
If your project is set up for it, you can reply to this email and
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103841503
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
@@ -69,6 +69,7 @@ trait BaseLimitExec extends UnaryExecNode with
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/15505
@witgo OK I'll hold off on doing another pass on the code until you have
the test results.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852419
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103852353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/17088
Can you please file a JIRA for the flaky jenkins failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kayousterhout commented on the issue:
https://github.com/apache/spark/pull/16855
@GavinGavinNo1 are you ZhengYaofeng on JIRA? I want to correctly give you
credit on JIRA for fixing this.
---
If your project is set up for it, you can reply to this email and have your
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103854902
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1208,63 +1253,39 @@ class Analyzer(
//
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/10506
Hi @kayousterhout , I guess the issue still exists, but unfortunately
there's no one reviewing this patch. I could rebase the code if someone could
review it.
---
If your project is set up for
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858978
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103858997
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/17131
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103859056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17125#discussion_r103860516
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala ---
@@ -128,6 +129,15 @@ case class CreateViewCommand(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17001#discussion_r103863070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -30,7 +33,7 @@ import
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r103839637
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -442,11 +453,15 @@ case class RangeExec(range:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73721/
Test FAILed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/QuantileSummaries.scala
---
@@ -176,17 +176,21 @@ class QuantileSummaries(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844105
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -91,7 +99,9 @@ object StatFunctions extends Logging {
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/16971#discussion_r103844048
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
---
@@ -78,7 +81,12 @@ object StatFunctions extends Logging {
101 - 200 of 562 matches
Mail list logo
