[GitHub] spark pull request #19388: [SPARK-22162] Executors and the driver should use...

2017-09-29 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19388#discussion_r141924015 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -524,6 +525,13 @@ class PairRDDFunctionsSuite extends SparkFunSuite

[GitHub] spark issue #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet should no...

2017-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19382 @gatorsmile . Whiling testing, I noticed that Parquet ignores table properties in case of `convertMetastoreParquet=false`, too. For that case, we need to proceed in another JIRA issue.

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-29 Thread adrian-ionescu
Github user adrian-ionescu commented on the issue: https://github.com/apache/spark/pull/19149 I think the idea is good, but maybe the fix can be refined by identifying which are the rules that conflict with `InferFilterFromConstraints` and only rerunning those ones? Seems like a

[GitHub] spark issue #19388: [SPARK-22162] Executors and the driver should use consis...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19388 **[Test build #82325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82325/testReport)** for PR 19388 at commit

[GitHub] spark pull request #19388: [SPARK-22162] Executors and the driver should use...

2017-09-29 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/19388#discussion_r141921618 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -524,6 +525,13 @@ class PairRDDFunctionsSuite extends SparkFunSuite

[GitHub] spark pull request #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet sh...

2017-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19382#discussion_r141920280 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1437,30 +1439,75 @@ class HiveDDLSuite }

[GitHub] spark pull request #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet sh...

2017-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19382#discussion_r141919885 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1437,30 +1439,75 @@ class HiveDDLSuite }

[GitHub] spark issue #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet should no...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19382 **[Test build #82324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82324/testReport)** for PR 19382 at commit

[GitHub] spark pull request #19382: [SPARK-22158][SQL] convertMetastoreOrc/Parquet sh...

2017-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19382#discussion_r141919805 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -189,12 +189,12 @@ case class RelationConversions(

[GitHub] spark issue #19149: [SPARK-21652][SQL][FOLLOW-UP] Fix rule conflict between ...

2017-09-29 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/19149 Can we add a test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19388: [SPARK-22162] Executors and the driver should use...

2017-09-29 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/19388#discussion_r141917674 --- Diff: core/src/test/scala/org/apache/spark/rdd/PairRDDFunctionsSuite.scala --- @@ -524,6 +525,13 @@ class PairRDDFunctionsSuite extends SparkFunSuite

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19263 **[Test build #82323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82323/testReport)** for PR 19263 at commit

[GitHub] spark pull request #19263: [SPARK-22050][CORE] Allow BlockUpdated events to ...

2017-09-29 Thread michaelmior
Github user michaelmior commented on a diff in the pull request: https://github.com/apache/spark/pull/19263#discussion_r141916752 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -66,6 +67,7 @@ private[spark] class EventLoggingListener(

[GitHub] spark issue #18760: [SPARK-21560][Core] Add hold mode for the LiveListenerBu...

2017-09-29 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/18760 > I use offer(non-blocking) to control the empty rate in the configuration. Won't that just block all posts until you hit the empty rate? I don't see a lot of difference. But yeah,

[GitHub] spark pull request #19263: [SPARK-22050][CORE] Allow BlockUpdated events to ...

2017-09-29 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19263#discussion_r141915135 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -66,6 +67,7 @@ private[spark] class EventLoggingListener(

[GitHub] spark issue #19392: [SPARK-22169][SQL] table name with numbers and character...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19392 **[Test build #82322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82322/testReport)** for PR 19392 at commit

[GitHub] spark issue #19392: [SPARK-22169][SQL] table name with numbers and character...

2017-09-29 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19392 cc @hvanhovell @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19392: [SPARK-22169][SQL] table name with numbers and ch...

2017-09-29 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19392 [SPARK-22169][SQL] table name with numbers and characters should parsed successfuly ## What changes were proposed in this pull request? By definition the table name in Spark can be

[GitHub] spark pull request #19382: [SPARK-22158][SQL] convertMetastoreOrc should not...

2017-09-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19382#discussion_r141908151 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -1438,39 +1438,44 @@ class HiveDDLSuite }

[GitHub] spark pull request #19391: [SPARK-22146] FileNotFoundException while reading...

2017-09-29 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/19391 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19391 yes, thank you @srowen! It has been backported now! Sorry for wasting your time with this wrong PR. And thank you again for your help. ---

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141906843 --- Diff: python/pyspark/sql/group.py --- @@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None): jgd = self._jgd.pivot(pivot_col,

[GitHub] spark issue #19368: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19368 @mgaido91 I just pushed it to 2.2 branch, since the risk of this fix is small. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19386: [SPARK-22161] [SQL] Add Impala-modified TPC-DS qu...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19386 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19386: [SPARK-22161] [SQL] Add Impala-modified TPC-DS queries

2017-09-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19386 Thanks! Merged to master/2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19391 Oh we just back-port the original PR then. Do you need in 2.2? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #19272: [Spark-21842][Mesos] Support Kerberos ticket renewal and...

2017-09-29 Thread ArtRand
Github user ArtRand commented on the issue: https://github.com/apache/spark/pull/19272 Hello @vanzin Thanks for taking a look at this. Good to know that there can be downstream errors depending on the situation. Would very much appreciate a proper review on this

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19391 @srowen Yes, it cherry-picked cleanly, why? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19391 Did the original PR not cherry-pick cleanly? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19391 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19391: [SPARK-22146] FileNotFoundException while reading ORC fi...

2017-09-29 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19391 This is a backport to branch 2.2 for SPARK-22146 which has already been merged to master. cc @dongjoon-hyun @gatorsmile ---

[GitHub] spark issue #19270: [SPARK-21809] : Change Stage Page to use datatables to s...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19270 **[Test build #82321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82321/testReport)** for PR 19270 at commit

[GitHub] spark pull request #19391: [SPARK-22146] FileNotFoundException while reading...

2017-09-29 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19391 [SPARK-22146] FileNotFoundException while reading ORC files containing special characters ## What changes were proposed in this pull request? Reading ORC files containing special

[GitHub] spark issue #19290: [SPARK-22063][R] Upgrades lintr to latest commit sha1 ID

2017-09-29 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/19290 hey all, i'm here. was out sick for the past few days and trying to get caught up. sorry about that! so... what version of lintr do we need to put on the workers? On Fri,

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141892887 --- Diff: python/pyspark/sql/group.py --- @@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None): jgd = self._jgd.pivot(pivot_col,

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141892238 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java --- @@ -139,4 +139,44 @@ public int compare(

[GitHub] spark pull request #19359: [SPARK-22129][SPARK-22138] Release script improve...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19359 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18732: [SPARK-20396][SQL][PySpark] groupby().apply() with panda...

2017-09-29 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/18732 Thanks all for the initial review! I will address some comments and upload a new version today. --- - To unsubscribe,

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141891357 --- Diff: python/pyspark/sql/group.py --- @@ -194,6 +194,28 @@ def pivot(self, pivot_col, values=None): jgd = self._jgd.pivot(pivot_col,

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19263 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19263 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82316/ Test PASSed. ---

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19263 **[Test build #82316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82316/testReport)** for PR 19263 at commit

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141886413 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ArrowEvalPythonExec.scala --- @@ -44,14 +44,17 @@ case class

[GitHub] spark issue #19386: [SPARK-22161] [SQL] Add Impala-modified TPC-DS queries

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on the issue: https://github.com/apache/spark/pull/19386 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141885324 --- Diff: python/pyspark/sql/tests.py --- @@ -3376,6 +3377,74 @@ def test_vectorized_udf_empty_partition(self): res =

[GitHub] spark pull request #18732: [SPARK-20396][SQL][PySpark] groupby().apply() wit...

2017-09-29 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/18732#discussion_r141883671 --- Diff: python/pyspark/sql/functions.py --- @@ -2206,6 +2207,10 @@ def pandas_udf(f=None, returnType=StringType()): | 8| JOHN

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13493 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82319/ Test FAILed. ---

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13493 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13493 **[Test build #82319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82319/testReport)** for PR 13493 at commit

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82320/ Test PASSed. ---

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82320/testReport)** for PR 19390 at commit

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82318/testReport)** for PR 19390 at commit

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82318/ Test PASSed. ---

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82320/testReport)** for PR 19390 at commit

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13493 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13493 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82315/ Test FAILed. ---

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13493 **[Test build #82315 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82315/testReport)** for PR 13493 at commit

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82318/testReport)** for PR 19390 at commit

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13493 **[Test build #82319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82319/testReport)** for PR 13493 at commit

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19390 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82317/ Test PASSed. ---

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82317/testReport)** for PR 19390 at commit

[GitHub] spark pull request #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrow...

2017-09-29 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/13493#discussion_r141852693 --- Diff: python/pyspark/mllib/tests.py --- @@ -1762,6 +1763,18 @@ def test_pca(self): self.assertEqualUpToSign(pcs.toArray()[:, k

[GitHub] spark issue #19390: [SPARK-18935][MESOS] Fix dynamic reservations on mesos

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19390 **[Test build #82317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82317/testReport)** for PR 19390 at commit

[GitHub] spark pull request #19390: [SPARK-18935][MESOS] Fix dynamic reservations

2017-09-29 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/19390 [SPARK-18935][MESOS] Fix dynamic reservations ## What changes were proposed in this pull request? - Solves the issue described in the ticket by preserving reservation and allocation info.

[GitHub] spark issue #19263: [SPARK-22050][CORE] Allow BlockUpdated events to be opti...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19263 **[Test build #82316 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82316/testReport)** for PR 19263 at commit

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19263: [SPARK-22050][CORE] Allow BlockUpdated events to ...

2017-09-29 Thread michaelmior
Github user michaelmior commented on a diff in the pull request: https://github.com/apache/spark/pull/19263#discussion_r141849398 --- Diff: core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala --- @@ -66,6 +67,7 @@ private[spark] class EventLoggingListener(

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82314/ Test FAILed. ---

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82314/testReport)** for PR 19344 at commit

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13493 **[Test build #82315 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82315/testReport)** for PR 13493 at commit

[GitHub] spark issue #13493: [SPARK-15750][MLLib][PYSPARK] Constructing FPGrowth fail...

2017-09-29 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/13493 ping @zjffdu Looks reasonable fix, But pls resolve the conflicts! Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19287 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19287 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82313/ Test PASSed. ---

[GitHub] spark issue #19287: [SPARK-22074][Core] Task killed by other attempt task sh...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19287 **[Test build #82313 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82313/testReport)** for PR 19287 at commit

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843276 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java --- @@ -139,4 +139,44 @@ public int

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843447 --- Diff: core/src/test/scala/org/apache/spark/memory/TestMemoryManager.scala --- @@ -58,11 +58,15 @@ class TestMemoryManager(conf: SparkConf)

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843414 --- Diff: core/src/test/scala/org/apache/spark/memory/TestMemoryManager.scala --- @@ -58,11 +58,15 @@ class TestMemoryManager(conf: SparkConf)

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843193 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java --- @@ -139,4 +139,44 @@ public int

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141842424 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java --- @@ -85,7 +85,7 @@ private final

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141842918 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -503,6 +511,39 @@ public void

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141842522 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -162,14 +162,25 @@ private int

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141842730 --- Diff: core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorter.java --- @@ -162,14 +162,25 @@ private int

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843914 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -19,10 +19,18 @@

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843227 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeInMemorySorterSuite.java --- @@ -139,4 +139,44 @@ public int

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843046 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -503,6 +511,39 @@ public void

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141842948 --- Diff: core/src/test/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorterSuite.java --- @@ -503,6 +511,39 @@ public void

[GitHub] spark pull request #19181: [SPARK-21907][CORE] oom during spill

2017-09-29 Thread juliuszsompolski
Github user juliuszsompolski commented on a diff in the pull request: https://github.com/apache/spark/pull/19181#discussion_r141843494 --- Diff: core/src/test/scala/org/apache/spark/memory/TestMemoryManager.scala --- @@ -58,11 +58,15 @@ class TestMemoryManager(conf: SparkConf)

[GitHub] spark issue #19290: [SPARK-22063][R] Upgrades lintr to latest commit sha1 ID

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19290 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82312/ Test PASSed. ---

[GitHub] spark issue #19290: [SPARK-22063][R] Upgrades lintr to latest commit sha1 ID

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19290 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19290: [SPARK-22063][R] Upgrades lintr to latest commit sha1 ID

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19290 **[Test build #82312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82312/testReport)** for PR 19290 at commit

[GitHub] spark pull request #19344: [SPARK-22122][SQL] Use analyzed logical plans to ...

2017-09-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19344#discussion_r141836921 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -66,24 +64,11 @@ object TPCDSQueryBenchmark

[GitHub] spark pull request #19344: [SPARK-22122][SQL] Use analyzed logical plans to ...

2017-09-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19344#discussion_r141836639 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala --- @@ -66,24 +64,11 @@ object TPCDSQueryBenchmark

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19344 **[Test build #82314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82314/testReport)** for PR 19344 at commit

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19389 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82310/ Test PASSed. ---

[GitHub] spark issue #19389: [SPARK-22165][SQL] Resolve type conflicts between decima...

2017-09-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19389 **[Test build #82310 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82310/testReport)** for PR 19389 at commit

[GitHub] spark issue #19344: [SPARK-22122][SQL] Use analyzed logical plans to count i...

2017-09-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19344 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82311/ Test PASSed. ---

<    1   2   3   4   >