[GitHub] spark pull request #19649: [SPARK-22405][SQL] Add more ExternalCatalogEvent

2017-11-03 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/19649#discussion_r148810633 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -619,8 +619,10 @@ private[spark] class

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19532 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19653 I think there is an infra issue. The error for the failed test job seems to me: ``` chmod: cannot access `target/*': No such file or directory ``` I am not sure what is happening...

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19651 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19653 **[Test build #83408 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83408/testReport)** for PR 19653 at commit

[GitHub] spark pull request #19646: [SPARK-22147][PYTHON] Fix for createDataFrame fro...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19646#discussion_r148784896 --- Diff: python/pyspark/sql/session.py --- @@ -512,9 +557,7 @@ def createDataFrame(self, data, schema=None, samplingRatio=None, verifySchema=Tr

[GitHub] spark pull request #19390: [SPARK-18935][MESOS] Fix dynamic reservations on ...

2017-11-03 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/19390#discussion_r148786663 --- Diff: dev/deps/spark-deps-hadoop-2.6 --- @@ -138,7 +138,7 @@ lz4-java-1.4.0.jar machinist_2.11-0.6.1.jar macro-compat_2.11-1.1.1.jar

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/19653 [SPARK-22418][SQL][TEST] Add test cases for NULL Handling ## What changes were proposed in this pull request? Added a test class to check NULL handling behavior. The expected behavior

[GitHub] spark pull request #19630: wip: [SPARK-22409] Introduce function type argume...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19630#discussion_r148804761 --- Diff: python/pyspark/sql/functions.py --- @@ -2279,7 +2174,36 @@ def pandas_udf(f=None, returnType=StringType()): .. note:: The

[GitHub] spark pull request #19630: wip: [SPARK-22409] Introduce function type argume...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19630#discussion_r148806731 --- Diff: python/pyspark/rdd.py --- @@ -56,6 +56,22 @@ __all__ = ["RDD"] +class PythonEvalType(object): +""" +

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/19653 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19630: wip: [SPARK-22409] Introduce function type argume...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19630#discussion_r148810140 --- Diff: python/pyspark/sql/udf.py --- @@ -0,0 +1,136 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19651 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83404/ Test FAILed. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83403/ Test FAILed. ---

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19651 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19532 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19532 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83405/ Test FAILed. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19653 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83406/ Test FAILed. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19653 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19645: [SPARK-22429][STREAMING] Streaming checkpointing code do...

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19645 **[Test build #3978 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3978/testReport)** for PR 19645 at commit

[GitHub] spark pull request #19649: [SPARK-22405][SQL] Add more ExternalCatalogEvent

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19649#discussion_r148782419 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -158,7 +173,13 @@ abstract class

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2017-11-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19222 ping @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83400/ Test FAILed. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19653 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19630: wip: [SPARK-22409] Introduce function type argument in p...

2017-11-03 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/19630 Ping @cloud-fan @ueshin @HyukjinKwon any thoughts on this? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19653 I suspect the problem is related with dropped path in some Jenkins machines (we met this few times before). I roughly guess worker 2, 6 and 7. I reported this to Jenkins admin. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19653 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19630: wip: [SPARK-22409] Introduce function type argument in p...

2017-11-03 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/19630 Thanks @cloud-fan. I will continue to finish the TODO items. Decide the best naming probably needs a bit more careful thinking. I can remove unimplemented types. However, I think it'd be

[GitHub] spark issue #19639: [SPARK-22423][SQL] Scala test source files like TestHive...

2017-11-03 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/19639 I have fixed all four instances and update the PR title. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19646: [SPARK-22147][PYTHON] Fix for createDataFrame fro...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19646#discussion_r148778328 --- Diff: python/pyspark/sql/session.py --- @@ -416,6 +417,50 @@ def _createFromLocal(self, data, schema): data = [schema.toInternal(row) for

[GitHub] spark pull request #19630: wip: [SPARK-22409] Introduce function type argume...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19630#discussion_r148803174 --- Diff: python/pyspark/sql/functions.py --- @@ -2208,16 +2093,26 @@ def udf(f=None, returnType=StringType()): | 8| JOHN DOE|

[GitHub] spark pull request #19630: wip: [SPARK-22409] Introduce function type argume...

2017-11-03 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19630#discussion_r148805721 --- Diff: python/pyspark/sql/functions.py --- @@ -2279,7 +2174,36 @@ def pandas_udf(f=None, returnType=StringType()): .. note:: The

[GitHub] spark issue #19586: [SPARK-22367][WIP][CORE] Separate the serialization of c...

2017-11-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19586 also cc @WeichenXu123 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19651 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19651: [SPARK-20682][SPARK-15474][SPARK-21791] Add new ORCFileF...

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19651 **[Test build #83407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83407/testReport)** for PR 19651 at commit

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83412/ Test FAILed. ---

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19647 **[Test build #83417 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83417/testReport)** for PR 19647 at commit

[GitHub] spark pull request #19582: [SPARK-20644][core] Initial ground work for kvsto...

2017-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19582#discussion_r148713957 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -528,4 +544,21 @@ private class AppStatusListener(kvstore: KVStore)

[GitHub] spark pull request #19582: [SPARK-20644][core] Initial ground work for kvsto...

2017-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19582#discussion_r148836744 --- Diff: core/src/main/scala/org/apache/spark/status/LiveEntity.scala --- @@ -37,8 +37,11 @@ import org.apache.spark.util.kvstore.KVStore */

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83409/ Test FAILed. ---

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19532 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19654 **[Test build #83416 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83416/testReport)** for PR 19654 at commit

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19653 thanks @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19647 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pus...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19647#discussion_r148832366 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -332,32 +332,18 @@ object LimitPushDown extends

[GitHub] spark pull request #19623: [SPARK-22078][SQL] clarify exception behaviors fo...

2017-11-03 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/19623#discussion_r148848619 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/ReadSupport.java --- @@ -30,6 +30,9 @@ /** * Creates a {@link

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83415/ Test FAILed. ---

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19653 > * in SparkSQL, the standard SQL UNION clause is rewritten as UNION + DISTINCT ```Scala case SqlBaseParser.UNION if all => Union(left, right) case

[GitHub] spark pull request #19623: [SPARK-22078][SQL] clarify exception behaviors fo...

2017-11-03 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/19623#discussion_r148848790 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/DataReader.java --- @@ -34,11 +35,17 @@ /** * Proceed to next

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19647 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83414/ Test FAILed. ---

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83413/ Test FAILed. ---

[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19647 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19653#discussion_r148833289 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19653#discussion_r148843186 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL Handlin...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19653 Thank you for taking this JIRA! Could you summarize the behavior of our Spark SQL in the PR description? --- - To

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19653#discussion_r148838496 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19582: [SPARK-20644][core] Initial ground work for kvsto...

2017-11-03 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19582#discussion_r148842854 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -528,4 +544,21 @@ private class AppStatusListener(kvstore: KVStore)

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19532 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83410/ Test FAILed. ---

[GitHub] spark issue #19532: [DOC]update the API doc and modify the stage API descrip...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19532 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83411/ Test FAILed. ---

[GitHub] spark issue #19647: [SPARK-22211][SQL] Remove incorrect FOJ limit pushdown

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19647 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19654 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19653#discussion_r148831326 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19654 **[Test build #83416 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83416/testReport)** for PR 19654 at commit

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83416/ Test PASSed. ---

[GitHub] spark issue #19654: [SPARK-22437][PYSPARK] default mode for jdbc is wrongly ...

2017-11-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19654 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19582: [SPARK-20644][core] Initial ground work for kvsto...

2017-11-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19582#discussion_r148847694 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -528,4 +544,21 @@ private class AppStatusListener(kvstore: KVStore)

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-11-03 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r148863673 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala --- @@ -63,9 +74,22 @@ private[parquet]

[GitHub] spark pull request #19634: [SPARK-22412][SQL] Fix incorrect comment in DataS...

2017-11-03 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19634#discussion_r148875065 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -469,7 +469,7 @@ case class FileSourceScanExec(

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148859381 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -252,19 +252,29 @@ object CrossValidator extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148859168 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -252,19 +252,29 @@ object CrossValidator extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148860542 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -108,6 +108,13 @@ abstract class MLWriter extends BaseReadWrite with

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148859543 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -325,14 +328,19 @@ object CrossValidatorModel extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148859043 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala --- @@ -252,19 +252,29 @@ object CrossValidator extends

[GitHub] spark pull request #19208: [SPARK-21087] [ML] CrossValidator, TrainValidatio...

2017-11-03 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19208#discussion_r148857274 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tuning/TrainValidationSplit.scala --- @@ -276,12 +315,32 @@ object TrainValidationSplitModel extends

[GitHub] spark pull request #19653: [SPARK-22418][SQL][TEST] Add test cases for NULL ...

2017-11-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19653#discussion_r148865915 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/NullHandlingSuite.scala --- @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #19641: [SPARK-21911][ML][FOLLOW-UP] Fix doc for parallel ML Tun...

2017-11-03 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/19641 LGTM pending tests --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19648: [SPARK-14516][ML][FOLLOW-UP] Move ClusteringEvalu...

2017-11-03 Thread yanboliang
Github user yanboliang commented on a diff in the pull request: https://github.com/apache/spark/pull/19648#discussion_r148861446 --- Diff: mllib/src/test/scala/org/apache/spark/ml/evaluation/ClusteringEvaluatorSuite.scala --- @@ -22,15 +22,21 @@ import

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-11-03 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r148866084 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala --- @@ -63,9 +74,22 @@ private[parquet]

[GitHub] spark pull request #19623: [SPARK-22078][SQL] clarify exception behaviors fo...

2017-11-03 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/19623#discussion_r148875607 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/writer/DataSourceV2Writer.java --- @@ -50,28 +53,34 @@ /** * Creates

[GitHub] spark pull request #19623: [SPARK-22078][SQL] clarify exception behaviors fo...

2017-11-03 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/19623#discussion_r148849054 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/ReadTask.java --- @@ -36,14 +36,24 @@ /** * The preferred locations

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

2017-11-03 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148852449 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

2017-11-03 Thread sethah
Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148852081 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-11-03 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/16578 @viirya Can you please take a look at my latest revisions and replies to your comments? Cheers. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19638: [SPARK-22422][ML] Add Adjusted R2 to RegressionMe...

2017-11-03 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/19638#discussion_r148869278 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala --- @@ -764,13 +764,17 @@ class LinearRegressionSuite

[GitHub] spark pull request #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-11-03 Thread mallman
Github user mallman commented on a diff in the pull request: https://github.com/apache/spark/pull/16578#discussion_r148725152 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaPruning.scala --- @@ -0,0 +1,147 @@ +/* + *

[GitHub] spark issue #19646: [SPARK-22147][PYTHON] Fix for createDataFrame from panda...

2017-11-03 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19646 @BryanCutler is this tagged to the right JIRA? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4   >