[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84603/ Test FAILed. ---

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84607 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84607/testReport)** for PR 19861 at commit

[GitHub] spark pull request #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nest...

2017-12-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19813#discussion_r155578442 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala --- @@ -0,0 +1,237 @@ +/* + *

[GitHub] spark issue #19890: [SPARK-22688][SQL] Upgrade Janino version to 3.0.8

2017-12-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19890 We'll need to back port to 2.2/2.1 to match the previous janino update. I'll do that. A different PR will be required for 2.1 ---

[GitHub] spark issue #19920: [SPARK-21672][CORE] Remove SHS-specific application / at...

2017-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19920 Please clean up all of the template from the PR description. ok to test --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

2017-12-07 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155587468 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -479,4 +481,32 @@ class

[GitHub] spark pull request #19864: [SPARK-22673][SQL] InMemoryRelation should utiliz...

2017-12-07 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/19864#discussion_r155587431 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/columnar/InMemoryColumnarQuerySuite.scala --- @@ -479,4 +481,32 @@ class

[GitHub] spark issue #19864: [SPARK-22673][SQL] InMemoryRelation should utilize exist...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19864 **[Test build #84608 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84608/testReport)** for PR 19864 at commit

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

2017-12-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155561210 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -332,8 +332,41 @@ case

[GitHub] spark pull request #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nest...

2017-12-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19813#discussion_r155574067 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/ExpressionCodegen.scala --- @@ -0,0 +1,237 @@ +/* + *

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-07 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/19717 Thanks to all the reviewers, @liyinan926 and @mccheah for the comments & fixes. This looks real close! @ifilonenko - if we could get our integration tests to run once against this PR this week

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-07 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 great! Thanks @gatorsmile , @cloud-fan. Yes. I would be happy to open a new PR to add the rest of them. If I compare with the getXXX types in SparkConf, it looks like the only

[GitHub] spark issue #19864: [SPARK-22673][SQL] InMemoryRelation should utilize exist...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19864 **[Test build #84608 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84608/testReport)** for PR 19864 at commit

[GitHub] spark issue #19864: [SPARK-22673][SQL] InMemoryRelation should utilize exist...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19864 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84608/ Test FAILed. ---

[GitHub] spark issue #19864: [SPARK-22673][SQL] InMemoryRelation should utilize exist...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19864 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19499: [SPARK-22279][SQL] Turn on spark.sql.hive.convertMetasto...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19499 **[Test build #84604 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84604/testReport)** for PR 19499 at commit

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

2017-12-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155564302 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -332,8 +332,41 @@ case

[GitHub] spark issue #19854: [SPARK-22660][BUILD] Use position() and limit() to fix a...

2017-12-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19854 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-07 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/19717 LGTM too, thanks for the awesome work! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19783: [SPARK-21322][SQL] support histogram in filter cardinali...

2017-12-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19783 LGTM overall --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19783: [SPARK-21322][SQL] support histogram in filter ca...

2017-12-07 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19783#discussion_r155571394 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala --- @@ -359,7 +371,7 @@ class

[GitHub] spark issue #19920: [SPARK-21672][CORE] Remove SHS-specific application / at...

2017-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19920 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19920: [SPARK-21672][CORE] Remove SHS-specific application / at...

2017-12-07 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/19920 PR description was cleaned, thanks for catching it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155596370 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2O...

2017-12-07 Thread skambha
GitHub user skambha opened a pull request: https://github.com/apache/spark/pull/19921 [SPARK-22452][SQL] Add getDouble to DataSourceV2Options - Implemented getDouble method in DataSourceV2Options - Add unit test You can merge this pull request into a Git repository by running:

[GitHub] spark issue #19921: [SPARK-22452][SQL] Add getDouble to DataSourceV2Options

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19921 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155600929 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155591920 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155592359 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155592201 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155592072 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19893 Also, what happens when you run tests in the sql and hive modules? Those try to keep the same session alive for multiple suites, so I'd expect a bunch of threads to trigger this code when they

[GitHub] spark issue #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean to Dat...

2017-12-07 Thread skambha
Github user skambha commented on the issue: https://github.com/apache/spark/pull/19902 Opened a new PR to add the getDouble method. https://github.com/apache/spark/pull/19921 --- - To unsubscribe, e-mail:

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19912 **[Test build #84605 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84605/testReport)** for PR 19912 at commit

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-07 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19912 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155601696 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155602584 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155598719 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155599671 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84605/ Test PASSed. ---

[GitHub] spark issue #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19912 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19912: [SPARK-22719][SQL]Refactor ConstantPropagation

2017-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19912 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155603848 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155606762 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark issue #19811: [SPARK-18016][SQL] Code Generation: Constant Pool Limit ...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19811 **[Test build #84611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84611/testReport)** for PR 19811 at commit

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155609528 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -29,6 +29,7 @@ import org.apache.spark.executor.TaskMetrics

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-07 Thread henryr
Github user henryr commented on the issue: https://github.com/apache/spark/pull/19683 My guess is that it's safe to do so in our case because of the immediate projection that happens. In general, emitting JoinedRows where the RHS row is shared between all JoinedRows could be a

[GitHub] spark pull request #19911: [SPARK-22729][SQL] Add getTruncateQuery to JdbcDi...

2017-12-07 Thread danielvdende
Github user danielvdende commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155622687 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155605695 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155608281 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19861 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84607/ Test PASSed. ---

[GitHub] spark issue #19911: [SPARK-22729][SQL] Add getTruncateQuery to JdbcDialect

2017-12-07 Thread danielvdende
Github user danielvdende commented on the issue: https://github.com/apache/spark/pull/19911 @dongjoon-hyun ok made the changes, also replaced the test that was in place for `isCascadingTruncateTable` with one for the `getTruncateQuery` method. Right now, I've left the method in

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-07 Thread liyinan926
Github user liyinan926 commented on the issue: https://github.com/apache/spark/pull/19717 With some bug fixes in https://github.com/apache/spark/pull/19717/commits/83d0b9cc29eec2654308344ac8b2208e5e3f08df, I was able to run `SparkPi` on a GKE cluster. ---

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/19893 Yeah, this is fully true. This enhancement is definitely will not solve the issues once and for all. The problems were hidden till now and we would like to make a step ahead and make it at

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155603153 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -188,11 +188,11 @@ class HistoryServer( } def

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155603588 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala --- @@ -25,6 +25,7 @@ import scala.collection.JavaConverters._ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155604279 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155603886 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155603905 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155603357 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -29,6 +29,7 @@ import org.apache.spark.executor.TaskMetrics import

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19893 > All in all if you have an approach which solves context reuse feel free to share. I don't have one, but it feels sub-optimal to add code that will knowingly trigger false positives in a

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155609975 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155610181 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -29,6 +29,7 @@ import org.apache.spark.executor.TaskMetrics import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155610889 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155611800 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155611738 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

[GitHub] spark issue #19864: [SPARK-22673][SQL] InMemoryRelation should utilize exist...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19864 **[Test build #84612 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84612/testReport)** for PR 19864 at commit

[GitHub] spark issue #19861: [SPARK-22387][SQL] Propagate session configs to data sou...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19861 **[Test build #84607 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84607/testReport)** for PR 19861 at commit

[GitHub] spark issue #19717: [SPARK-22646] [Submission] Spark on Kubernetes - basic s...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19717 **[Test build #84613 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84613/testReport)** for PR 19717 at commit

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19683 **[Test build #84614 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84614/testReport)** for PR 19683 at commit

[GitHub] spark pull request #19911: [SPARK-22729][SQL] Add getTruncateQuery to JdbcDi...

2017-12-07 Thread bolkedebruin
Github user bolkedebruin commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155619800 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #19911: [SPARK-22729][SQL] Add getTruncateQuery to JdbcDi...

2017-12-07 Thread bolkedebruin
Github user bolkedebruin commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155619721 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-07 Thread uzadude
Github user uzadude commented on the issue: https://github.com/apache/spark/pull/19683 @henryr I understand what you're saying. I'm not sure why there is the UnsafeProject in the end of the function, but it's commented in this PR that fixes [SPARK-13476] without much elaboration.

[GitHub] spark pull request #19911: [SPARK-22729][SQL] Add getTruncateQuery to JdbcDi...

2017-12-07 Thread bolkedebruin
Github user bolkedebruin commented on a diff in the pull request: https://github.com/apache/spark/pull/19911#discussion_r155624133 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/DB2Dialect.scala --- @@ -48,5 +48,7 @@ private object DB2Dialect extends JdbcDialect {

[GitHub] spark pull request #19922: [SPARK-22688][SQL][HOTFIX] Upgrade Janino version...

2017-12-07 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/19922 [SPARK-22688][SQL][HOTFIX] Upgrade Janino version to 3.0.8 ## What changes were proposed in this pull request? Hotfix inadvertent change to xmlbuilder dep when updating Janino. See

[GitHub] spark issue #19884: [WIP][SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19884 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84616/ Test FAILed. ---

[GitHub] spark issue #19884: [WIP][SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19884 **[Test build #84616 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84616/testReport)** for PR 19884 at commit

[GitHub] spark pull request #19884: [WIP][SPARK-22324][SQL][PYTHON] Upgrade Arrow to ...

2017-12-07 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/19884#discussion_r155626249 --- Diff: python/pyspark/sql/types.py --- @@ -1658,13 +1657,13 @@ def from_arrow_type(at): spark_type = FloatType() elif at ==

[GitHub] spark pull request #19893: [SPARK-16139][TEST] Add logging functionality for...

2017-12-07 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/19893#discussion_r155626333 --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala --- @@ -34,12 +36,53 @@ abstract class SparkFunSuite with Logging { //

[GitHub] spark issue #19884: [WIP][SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19884 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19811: [SPARK-18016][SQL] Code Generation: Constant Pool Limit ...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19811 **[Test build #84610 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84610/testReport)** for PR 19811 at commit

[GitHub] spark issue #19811: [SPARK-18016][SQL] Code Generation: Constant Pool Limit ...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84610/ Test FAILed. ---

[GitHub] spark pull request #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite su...

2017-12-07 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19843#discussion_r155629359 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite su...

2017-12-07 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/19843#discussion_r155629428 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18995 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155631788 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala --- @@ -25,6 +25,7 @@ import scala.collection.JavaConverters._ import

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155631687 --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusListener.scala --- @@ -29,6 +29,7 @@ import org.apache.spark.executor.TaskMetrics

[GitHub] spark issue #19906: [SPARK-22516][SQL] Bump up Univocity version to 2.5.9

2017-12-07 Thread smurakozi
Github user smurakozi commented on the issue: https://github.com/apache/spark/pull/19906 Thanks for your help and reviews @HyukjinKwon, @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19843: [SPARK-22644][ML][TEST][WIP] Make ML testsuite su...

2017-12-07 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19843#discussion_r155636618 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark issue #19884: [WIP][SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19884 **[Test build #84616 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84616/testReport)** for PR 19884 at commit

[GitHub] spark issue #19922: [SPARK-22688][SQL][HOTFIX] Upgrade Janino version to 3.0...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19922 **[Test build #84615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84615/testReport)** for PR 19922 at commit

[GitHub] spark issue #19811: [SPARK-18016][SQL] Code Generation: Constant Pool Limit ...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19811 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

2017-12-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18995 **[Test build #84609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84609/testReport)** for PR 18995 at commit

[GitHub] spark issue #18995: [SPARK-21787][SQL] Support for pushing down filters for ...

2017-12-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18995 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84609/ Test PASSed. ---

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155631377 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala --- @@ -188,11 +188,11 @@ class HistoryServer( }

[GitHub] spark pull request #19920: [SPARK-21672][CORE] Remove SHS-specific applicati...

2017-12-07 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/19920#discussion_r155632345 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala --- @@ -24,27 +24,32 @@ import

<    1   2   3   4   5