[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-21 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158368554 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,63 @@ object SparkHiveExample {

[GitHub] spark pull request #20018: SPARK-22833 [Improvement] in SparkHive Scala Exam...

2017-12-21 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20018#discussion_r158366994 --- Diff: examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala --- @@ -102,8 +101,63 @@ object SparkHiveExample {

[GitHub] spark issue #20048: [SPARK-22862] Docs on lazy elimination of columns missin...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20048 **[Test build #85282 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85282/testReport)** for PR 20048 at commit

[GitHub] spark pull request #20048: [SPARK-22862] Docs on lazy elimination of columns...

2017-12-21 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/20048 [SPARK-22862] Docs on lazy elimination of columns missing from an encoder This behavior has confused some users, so lets clarify it. You can merge this pull request into a Git repository by

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85275/ Test PASSed. ---

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19715 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19993 **[Test build #85281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85281/testReport)** for PR 19993 at commit

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #85275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85275/testReport)** for PR 19715 at commit

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2017-12-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19993 thanks @hhbyyh, I removed the 2 too strict checks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158361417 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -56,7 +56,36 @@ import

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158361160 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala --- @@ -321,7 +322,12 @@ case class IsNull(child:

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20047 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20047 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85271/ Test PASSed. ---

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20047 **[Test build #85271 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85271/testReport)** for PR 20047 at commit

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20047 **[Test build #85280 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85280/testReport)** for PR 20047 at commit

[GitHub] spark issue #19591: [SPARK-11035][core] Add in-process Spark app launcher.

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19591 **[Test build #85279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85279/testReport)** for PR 19591 at commit

[GitHub] spark issue #19946: [SPARK-22648] [K8S] Spark on Kubernetes - Documentation

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19946 **[Test build #85278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85278/testReport)** for PR 19946 at commit

[GitHub] spark pull request #19946: [SPARK-22648] [K8S] Spark on Kubernetes - Documen...

2017-12-21 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/19946#discussion_r158357822 --- Diff: docs/running-on-yarn.md --- @@ -18,7 +18,8 @@ Spark application's configuration (driver, executors, and the AM when running in There

[GitHub] spark issue #19591: [SPARK-11035][core] Add in-process Spark app launcher.

2017-12-21 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/19591 > you're talking about removing the System.exit() in SparkSubmit? Yes, and also potentially changing error messages currently printed to the terminal into exceptions when running through the

[GitHub] spark issue #20045: [Spark-22360][SQL] Add unit tests for Window Specificati...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20045 **[Test build #85277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85277/testReport)** for PR 20045 at commit

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #85276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85276/testReport)** for PR 20046 at commit

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-21 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158355602 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -210,8 +209,13 @@ int getPort() { * Removes the client handle

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85269/ Test PASSed. ---

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85269/testReport)** for PR 20020 at commit

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2017-12-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20046 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20045: [Spark-22360][SQL] Add unit tests for Window Specificati...

2017-12-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20045 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19993: [SPARK-22799][ML] Bucketizer should throw exception if s...

2017-12-21 Thread MLnick
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/19993 Yes featurehasher doesn’t need inputCol and inputCols - since it is a new multi column transformer. We may see this more in future - as I think new transformers should be able to work on

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-21 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158351004 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -260,24 +264,30 @@ private long getConnectionTimeout() { }

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-21 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158349922 --- Diff: launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java --- @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20020 How about the command `SaveIntoDataSourceCommand`? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #19715: [SPARK-22397][ML]add multiple columns support to Quantil...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19715 **[Test build #85275 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85275/testReport)** for PR 19715 at commit

[GitHub] spark pull request #19715: [SPARK-22397][ML]add multiple columns support to ...

2017-12-21 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/19715#discussion_r158347717 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala --- @@ -386,19 +382,16 @@ class QuantileDiscretizerSuite

[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20034 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85270/ Test PASSed. ---

[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20034 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20034 **[Test build #85270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85270/testReport)** for PR 20034 at commit

[GitHub] spark pull request #19993: [SPARK-22799][ML] Bucketizer should throw excepti...

2017-12-21 Thread hhbyyh
Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/19993#discussion_r158344862 --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala --- @@ -249,6 +250,31 @@ object ParamValidators { def

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158344919 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala --- @@ -148,7 +148,8 @@ object HiveAnalysis extends Rule[LogicalPlan] {

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158344489 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -479,14 +468,15 @@ case class DataSource(

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158341954 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158341832 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -27,7 +27,7 @@ import

[GitHub] spark pull request #19973: [SPARK-22779] FallbackConfigEntry's default value...

2017-12-21 Thread rxin
Github user rxin closed the pull request at: https://github.com/apache/spark/pull/19973 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20047 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20047 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85274/ Test FAILed. ---

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20047 **[Test build #85274 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85274/testReport)** for PR 20047 at commit

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19977 LGTM except the comments left above by @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #17619: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2017-12-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17619 Sorry I am only just looking at this now -- I am not so sure this is doing what you think. I think the notion of "task" in MesosCoarseGrainedSchedulerBackend might be something different,

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158339454 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -48,17 +48,37 @@ import

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20047 **[Test build #85274 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85274/testReport)** for PR 20047 at commit

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158337643 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -73,17 +93,27 @@ case class

[GitHub] spark pull request #19940: [SPARK-22750][SQL] Reuse mutable states when poss...

2017-12-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19940#discussion_r158336014 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1193,7 +1196,8 @@ case class

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19940 **[Test build #85273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85273/testReport)** for PR 19940 at commit

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85272/testReport)** for PR 20020 at commit

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20047 Looks good but you have to fix conflicts now. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20039: [SPARK-22850][core] Ensure queued events are deli...

2017-12-21 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20039#discussion_r158333948 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -124,13 +127,19 @@ private[spark] class LiveListenerBus(conf:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158333591 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,44 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark pull request #20034: [SPARK-22846][SQL] Fix table owner is null when c...

2017-12-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20034#discussion_r158333472 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -186,7 +186,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredic...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20041 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20034: [SPARK-22846][SQL] Fix table owner is null when c...

2017-12-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20034#discussion_r158332740 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -186,7 +186,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #20008: [SPARK-22822][TEST] Basic tests for WindowFrameCo...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20008 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20041 LGTM Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20008: [SPARK-22822][TEST] Basic tests for WindowFrameCoercion ...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20008 The test failure is not related to this PR. LGTM Thanks! Merged to master. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85267/ Test PASSed. ---

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20019 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20019 **[Test build #85267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85267/testReport)** for PR 20019 at commit

[GitHub] spark pull request #17980: [SPARK-20728][SQL] Make ORCFileFormat configurabl...

2017-12-21 Thread dongjoon-hyun
Github user dongjoon-hyun closed the pull request at: https://github.com/apache/spark/pull/17980 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #17980: [SPARK-20728][SQL] Make ORCFileFormat configurable betwe...

2017-12-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/17980 Almost codes inside this PR are merged now except #19943 . --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19981: [SPARK-22786][SQL] only use AppStatusPlugin in hi...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19981 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19981 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158329715 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -56,7 +56,36 @@ import

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158329686 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,44 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85266/ Test PASSed. ---

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85266/testReport)** for PR 20020 at commit

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158328435 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -118,10 +118,10 @@ abstract class Expression

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158327829 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -658,6 +660,30 @@ object TypeCoercion {

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20047 **[Test build #85271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85271/testReport)** for PR 20047 at commit

[GitHub] spark issue #20047: [SPARK-22861][SQL] SQLAppStatusListener handles multi-jo...

2017-12-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20047 @vanzin @carsonwang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20047: [SPARK-22861][SQL] SQLAppStatusListener handles m...

2017-12-21 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/20047 [SPARK-22861][SQL] SQLAppStatusListener handles multi-job executions. When one execution has multiple jobs, we need to append to the set of stages, not replace them on every job. Added

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158327166 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -73,17 +93,27 @@ case class

[GitHub] spark issue #20046: Adding unit tests for missing aggregate functions

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20046 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158326164 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -48,17 +48,37 @@ import

[GitHub] spark pull request #19681: [SPARK-20652][sql] Store SQL UI data in the new a...

2017-12-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19681#discussion_r158326122 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala --- @@ -0,0 +1,366 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19981 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20046: Adding unit tests for missing aggregate functions

2017-12-21 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20046#discussion_r158326073 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala --- @@ -154,6 +154,217 @@ class DataFrameWindowFunctionsSuite

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20041 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20041 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85265/ Test PASSed. ---

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85263/ Test PASSed. ---

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158325851 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -48,17 +48,37 @@ import

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20041 **[Test build #85265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85265/testReport)** for PR 20041 at commit

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19981 **[Test build #85263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85263/testReport)** for PR 19981 at commit

[GitHub] spark pull request #20046: Adding unit tests for missing aggregate functions

2017-12-21 Thread attilapiros
GitHub user attilapiros opened a pull request: https://github.com/apache/spark/pull/20046 Adding unit tests for missing aggregate functions ## What changes were proposed in this pull request? Improving the test coverage of window functions focusing on missing test for

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19940 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19940: [SPARK-22750][SQL] Reuse mutable states when poss...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19940#discussion_r158324941 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1193,7 +1196,8 @@ case class

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85264/ Test PASSed. ---

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20043 **[Test build #85264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85264/testReport)** for PR 20043 at commit

[GitHub] spark pull request #19940: [SPARK-22750][SQL] Reuse mutable states when poss...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19940#discussion_r158323966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -195,6 +195,14 @@ class

[GitHub] spark issue #19884: [SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-21 Thread wesm
Github user wesm commented on the issue: https://github.com/apache/spark/pull/19884 @BryanCutler can you give me a minimal repro for the timestamp issue you cited above? --- - To unsubscribe, e-mail:

[GitHub] spark issue #19802: [SPARK-22594][CORE] Handling spark-submit and master ver...

2017-12-21 Thread Jiri-Kremser
Github user Jiri-Kremser commented on the issue: https://github.com/apache/spark/pull/19802 I've also added tests and removed "WIP" from the label? Do you guys want the change or would you like to have something more elaborated, like an initial handshake? One note about the

<    1   2   3   4   5   6   >