[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20034 **[Test build #85270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85270/testReport)** for PR 20034 at commit

[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20034 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20034: [SPARK-22846][SQL] Fix table owner is null when creating...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20034 can you add a test? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19865: [SPARK-22668][SQL] Ensure no global variables in ...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19865 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20021: [SPARK-22668][SQL] Ensure no global variables in ...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20021 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20034: [SPARK-22846][SQL] Fix table owner is null when c...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20034#discussion_r158319646 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -186,7 +186,7 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request #19938: [SPARK-22747][SQL] Localize lifetime of mutable s...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19938 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20021 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158316971 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -210,8 +209,13 @@ int getPort() { * Removes the client handle

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85269/testReport)** for PR 20020 at commit

[GitHub] spark issue #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt docs/s...

2017-12-21 Thread easel
Github user easel commented on the issue: https://github.com/apache/spark/pull/20042 Thanks @srowen! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20042 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85262/ Test PASSed. ---

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20021 **[Test build #85262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85262/testReport)** for PR 20021 at commit

[GitHub] spark issue #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt docs/s...

2017-12-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20042 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20039: [SPARK-22850][core] Ensure queued events are deli...

2017-12-21 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/20039#discussion_r158309818 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -124,13 +127,19 @@ private[spark] class LiveListenerBus(conf:

[GitHub] spark pull request #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked fro...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20040 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19591: [SPARK-11035][core] Add in-process Spark app laun...

2017-12-21 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19591#discussion_r158307838 --- Diff: launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java --- @@ -210,8 +209,13 @@ int getPort() { * Removes the client handle

[GitHub] spark issue #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt j...

2017-12-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20040 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt j...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20040 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85257/ Test PASSed. ---

[GitHub] spark issue #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt j...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20040 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt j...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20040 **[Test build #85257 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85257/testReport)** for PR 20040 at commit

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158304105 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala --- @@ -32,6 +32,217 @@ import

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158304013 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -246,13 +246,23 @@ class

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread smurakozi
Github user smurakozi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158303978 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -246,13 +246,23 @@ class

[GitHub] spark issue #19218: [SPARK-21786][SQL] The 'spark.sql.parquet.compression.co...

2017-12-21 Thread fjh100456
Github user fjh100456 commented on the issue: https://github.com/apache/spark/pull/19218 @gatorsmile Could you help to review it? Thanks very much! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt docs/s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20042 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt docs/s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20042 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85256/ Test PASSed. ---

[GitHub] spark issue #20042: [SPARK-22855][BUILD] Add -no-java-comments to sbt docs/s...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20042 **[Test build #85256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85256/testReport)** for PR 20042 at commit

[GitHub] spark pull request #19872: WIP: [SPARK-22274][PySpark] User-defined aggregat...

2017-12-21 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r158302645 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/AggregateInPandasExec.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to

[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20038 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20038 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85259/ Test PASSed. ---

[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20038 **[Test build #85259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85259/testReport)** for PR 20038 at commit

[GitHub] spark pull request #19872: WIP: [SPARK-22274][PySpark] User-defined aggregat...

2017-12-21 Thread icexelloss
Github user icexelloss commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r158301996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -48,29 +48,46 @@ object

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20020 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85268/ Test FAILed. ---

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85268/testReport)** for PR 20020 at commit

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19940 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19940 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85261/ Test PASSed. ---

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19940 **[Test build #85261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85261/testReport)** for PR 19940 at commit

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158299743 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala --- @@ -347,7 +353,14 @@ case class IsNotNull(child:

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158299679 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala --- @@ -321,7 +322,12 @@ case class IsNull(child:

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158292663 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala --- @@ -32,6 +32,217 @@ import

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85268/testReport)** for PR 20020 at commit

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158298186 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -246,13 +246,23 @@ class

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20045#discussion_r158298350 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala --- @@ -246,13 +246,23 @@ class

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85255/ Test PASSed. ---

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20043 **[Test build #85255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85255/testReport)** for PR 20043 at commit

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20036 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85260/ Test PASSed. ---

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85260/testReport)** for PR 20036 at commit

[GitHub] spark issue #20039: [SPARK-22850][core] Ensure queued events are delivered t...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20039 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20039: [SPARK-22850][core] Ensure queued events are delivered t...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20039 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85258/ Test FAILed. ---

[GitHub] spark issue #20044: [SPARK-22857] Optimize code by inspecting code

2017-12-21 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20044 Ok, I remove some changes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20039: [SPARK-22850][core] Ensure queued events are delivered t...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20039 **[Test build #85258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85258/testReport)** for PR 20039 at commit

[GitHub] spark issue #20044: [SPARK-22857] Optimize code by inspecting code

2017-12-21 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/spark/pull/20044 ok --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158290698 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSink.scala --- @@ -118,13 +118,14 @@ class FileStreamSink(

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158290491 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -57,4 +59,6 @@ trait DataWritingCommand extends

[GitHub] spark pull request #20019: [SPARK-22361][SQL][TEST] Add unit test for Window...

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20019#discussion_r158290356 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala --- @@ -0,0 +1,381 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20019 ExpressionParserSuite window related part is a bit reorganized and enhanced. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20019 **[Test build #85267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85267/testReport)** for PR 20019 at commit

[GitHub] spark pull request #20019: [SPARK-22361][SQL][TEST] Add unit test for Window...

2017-12-21 Thread gaborgsomogyi
Github user gaborgsomogyi commented on a diff in the pull request: https://github.com/apache/spark/pull/20019#discussion_r158289422 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala --- @@ -0,0 +1,381 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #20045: [Spark-22360][SQL] Add unit tests for Window Specificati...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20045 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20045: [Spark-22360][SQL] Add unit tests for Window Spec...

2017-12-21 Thread smurakozi
GitHub user smurakozi opened a pull request: https://github.com/apache/spark/pull/20045 [Spark-22360][SQL] Add unit tests for Window Specifications ## What changes were proposed in this pull request? Improve the test coverage of window specifications. New tests

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158288419 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala --- @@ -87,6 +87,51 @@ case class ExecutedCommandExec(cmd:

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20041 **[Test build #85265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85265/testReport)** for PR 20041 at commit

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20020 **[Test build #85266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85266/testReport)** for PR 20020 at commit

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20020 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20041 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20043 **[Test build #85264 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85264/testReport)** for PR 20043 at commit

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 Oh, already re-testing. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 Thanks @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20026: [SPARK-22838][Core] Avoid unnecessary copying of data

2017-12-21 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/20026 I'll update it tomorrow. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20026: [SPARK-22838][Core] Avoid unnecessary copying of ...

2017-12-21 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/20026#discussion_r158279099 --- Diff: core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java --- @@ -61,6 +61,7 @@ private boolean refill() throws IOException {

[GitHub] spark issue #20044: [SPARK-22857] Optimize code by inspecting code

2017-12-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20044 In the past we've said 'no' to random small changes to the code like this. Some changes like _ to null probably aren't worth it at all. (0) to .head is the same, I think. Removing unused

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19981 **[Test build #85263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85263/testReport)** for PR 19981 at commit

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19981 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20041 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85254/ Test FAILed. ---

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20041 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20021 **[Test build #85262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85262/testReport)** for PR 20021 at commit

[GitHub] spark issue #20041: [SPARK-22042] [FOLLOW-UP] [SQL] ReorderJoinPredicates ca...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20041 **[Test build #85254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85254/testReport)** for PR 20041 at commit

[GitHub] spark issue #20021: [SPARK-22668][SQL] Ensure no global variables in argumen...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20021 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20044: [SPARK-22857] Optimize code by inspecting code

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20044 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20044: [SPARK-22857] Optimize code by inspecting code

2017-12-21 Thread xubo245
GitHub user xubo245 opened a pull request: https://github.com/apache/spark/pull/20044 [SPARK-22857] Optimize code by inspecting code Optimize code by inspecting code, including: remove some unused import change invoking array size method to length method use head method

[GitHub] spark pull request #20002: [SPARK-22465][Core][WIP] Add a safety-check to RD...

2017-12-21 Thread sujithjay
Github user sujithjay commented on a diff in the pull request: https://github.com/apache/spark/pull/20002#discussion_r158267365 --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala --- @@ -67,6 +71,16 @@ object Partitioner { } } } + +

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19940 **[Test build #85261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85261/testReport)** for PR 19940 at commit

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/19940 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19940 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19940 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85252/ Test FAILed. ---

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19940 **[Test build #85252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85252/testReport)** for PR 19940 at commit

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19981 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85251/ Test FAILed. ---

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19981 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19981: [SPARK-22786][SQL] only use AppStatusPlugin in history s...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19981 **[Test build #85251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85251/testReport)** for PR 19981 at commit

[GitHub] spark pull request #20026: [SPARK-22838][Core] Avoid unnecessary copying of ...

2017-12-21 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20026#discussion_r158260332 --- Diff: core/src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java --- @@ -61,6 +61,7 @@ private boolean refill() throws IOException {

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85260/testReport)** for PR 20036 at commit

[GitHub] spark issue #20038: [SPARK-22836][ui] Show driver logs in UI when available.

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20038 **[Test build #85259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85259/testReport)** for PR 20038 at commit

[GitHub] spark issue #20040: [SPARK-22852][BUILD] Exclude -Xlint:unchecked from sbt j...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20040 **[Test build #85257 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85257/testReport)** for PR 20040 at commit

<    1   2   3   4   5   6   >