[GitHub] spark pull request #20278: [SPARK-23079][SQL]Fix query constraints propagati...

2018-01-17 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20278#discussion_r161981051 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -160,64 +161,6 @@ class

[GitHub] spark issue #20277: [SPARK-23090][SQL] polish ColumnVector

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20277 **[Test build #86254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86254/testReport)** for PR 20277 at commit

[GitHub] spark pull request #20278: [SPARK-23079][SQL]Fix query constraints propagati...

2018-01-17 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20278#discussion_r161984758 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -160,64 +161,6 @@ class

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-17 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161979518 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20224: [SPARK-23032][SQL] Add a per-query codegenStageId...

2018-01-17 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20224#discussion_r161979484 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -312,6 +313,24 @@ case class InputAdapter(child:

[GitHub] spark issue #20224: [SPARK-23032][SQL] Add a per-query codegenStageId to Who...

2018-01-17 Thread rednaxelafx
Github user rednaxelafx commented on the issue: https://github.com/apache/spark/pull/20224 Thanks @gatorsmile ! Will add a new test case in `HiveExplainSuite`. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20291: Ignore Flaky Test: SparkLauncherSuite.testInProce...

2018-01-17 Thread sameeragarwal
GitHub user sameeragarwal opened a pull request: https://github.com/apache/spark/pull/20291 Ignore Flaky Test: SparkLauncherSuite.testInProcessLauncher ## What changes were proposed in this pull request? Temporarily ignoring flaky test

[GitHub] spark pull request #20265: [SPARK-21783][SQL] Turn on ORC filter push-down b...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20265#discussion_r161980753 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/FilterPushdownBenchmark.scala --- @@ -0,0 +1,243 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20224: [SPARK-23032][SQL] Add a per-query codegenStageId...

2018-01-17 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20224#discussion_r161980740 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -575,7 +609,10 @@ case class

[GitHub] spark pull request #20227: [SPARK-23035][SQL] Fix improper information of Te...

2018-01-17 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20227#discussion_r161981394 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala --- @@ -31,7 +31,7 @@ class

[GitHub] spark issue #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* for UDFs ...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20288 Will try to double check and clean up soon. Comments so far above look all valid. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r161983722 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +225,18 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark issue #20265: [SPARK-21783][SQL] Turn on ORC filter push-down by defau...

2018-01-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20265 ORC performs further better when the number of columns is small. Maybe also add test cases back to show this observations? ---

[GitHub] spark pull request #20278: [SPARK-23079][SQL]Fix query constraints propagati...

2018-01-17 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20278#discussion_r161985424 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/InferFiltersFromConstraintsSuite.scala --- @@ -34,6 +34,7 @@ class

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20300 **[Test build #86294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86294/testReport)** for PR 20300 at commit

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20284 **[Test build #86295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86295/testReport)** for PR 20284 at commit

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86284/testReport)** for PR 20243 at commit

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20282 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86285/ Test PASSed. ---

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/20282 LGTM. Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20239 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20295 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86290/ Test FAILed. ---

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20295 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20300 Thanks @srowen, I honestly tried to look for more and was surprised this was all I could find! --- - To unsubscribe,

[GitHub] spark pull request #20301: [SPARK-23131][CORE][WIP] Stackoverflow using ML a...

2018-01-17 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/20301 [SPARK-23131][CORE][WIP] Stackoverflow using ML and Kryo serializer ## What changes were proposed in this pull request? Update chill to 0.9.2, Kryo to 4.0.x, to get bug fixes and

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20255#discussion_r162199330 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -1089,6 +1101,300 @@ streamingDf.join(staticDf, "type", "right_join") # right outer join

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20225 **[Test build #86283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86283/testReport)** for PR 20225 at commit

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20284 It is actually. Before, negative values (empty metrics all have value "-1") would show up when starting iteration from 0, and now they don't. ```

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20243 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20243 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86284/ Test PASSed. ---

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread tdas
Github user tdas commented on the issue: https://github.com/apache/spark/pull/20225 LGTM. Merging this to master and 2.3 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20288: [SPARK-23122][PYTHON][SQL] Deprecate register* fo...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20288#discussion_r162198033 --- Diff: python/pyspark/sql/catalog.py --- @@ -224,92 +224,20 @@ def dropGlobalTempView(self, viewName): """

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86296/testReport)** for PR 20243 at commit

[GitHub] spark issue #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to NullableM...

2018-01-17 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20239 Thanks for everyone for review! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20300 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20255: [SPARK-23064][DOCS][SS] Added documentation for s...

2018-01-17 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20255#discussion_r162212307 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -1089,6 +1101,300 @@ streamingDf.join(staticDf, "type", "right_join") # right outer join

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20225 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20225: [SPARK-23033][SS] Don't use task level retry for continu...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20225 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86283/ Test PASSed. ---

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 Ah, thanks for the explanation! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20282: [SPARK-23093][SS] Don't change run id when reconfiguring...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20282 **[Test build #86285 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86285/testReport)** for PR 20282 at commit

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19247 Thanks! Merging to master and 2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/20226 Jenkins retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20269: [SPARK-23029] [DOCS] Specifying default units of configu...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20269 **[Test build #4058 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4058/testReport)** for PR 20269 at commit

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86299/testReport)** for PR 20226 at commit

[GitHub] spark issue #20275: [SPARK-23085][ML] API parity for mllib.linalg.Vectors.sp...

2018-01-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20275 Unless someone like @jkbradley or @MLnick objects, I think this doesn't hurt and actually makes things a little more consistent. ---

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20297 **[Test build #86289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86289/testReport)** for PR 20297 at commit

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20299 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86291/ Test FAILed. ---

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20299 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20225: [SPARK-23033][SS] Don't use task level retry for ...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20225 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20295: [WIP][SPARK-23011] Support alternative function form wit...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20295 **[Test build #86290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86290/testReport)** for PR 20295 at commit

[GitHub] spark pull request #20239: [SPARK-23047][PYTHON][SQL] Change MapVector to Nu...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20239 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.imag...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20294 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20301: [SPARK-23131][CORE][WIP] Stackoverflow using ML and Kryo...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20301 **[Test build #86297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86297/testReport)** for PR 20301 at commit

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20300 **[Test build #86294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86294/testReport)** for PR 20300 at commit

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19247 **[Test build #86288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86288/testReport)** for PR 19247 at commit

[GitHub] spark issue #20226: [SPARK-23034][SQL] Override `nodeName` for all *ScanExec...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20226 **[Test build #86300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86300/testReport)** for PR 20226 at commit

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20299 **[Test build #86291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86291/testReport)** for PR 20299 at commit

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20299 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19885: [SPARK-22587] Spark job fails if fs.defaultFS and applic...

2018-01-17 Thread merlintang
Github user merlintang commented on the issue: https://github.com/apache/spark/pull/19885 @jerryshao can you backport this to branch 2.2 as well. thanks --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
GitHub user BryanCutler opened a pull request: https://github.com/apache/spark/pull/20300 [MINOR] Fix typos in ML scaladocs ## What changes were proposed in this pull request? Fixed some typos found in ML scaladocs ## How was this patch tested? NA You can

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20300 ping @holdenk @MLnick --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20284: [SPARK-23103][core] Ensure correct sort order for negati...

2018-01-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20284 @vanzin The unit test fix is not related to the sorting issue right? Also it's totally fine to include it in this PR since it's minor. ---

[GitHub] spark pull request #20282: [SPARK-23093][SS] Don't change run id when reconf...

2018-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20282 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20294 Merged to master and branch-2.3. Thanks for reviewing this, @srowen, @imatiach-msft, @MrBago and @BryanCutler. ---

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20300 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86294/ Test PASSed. ---

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20300 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20243: [SPARK-23052][SS] Migrate ConsoleSink to data source V2 ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20243 **[Test build #86298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86298/testReport)** for PR 20243 at commit

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86288/ Test PASSed. ---

[GitHub] spark issue #19247: [Spark-21996][SQL] read files with space in name for str...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19247 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20300: [MINOR] Fix typos in ML scaladocs

2018-01-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20300 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20297: [SPARK-23020][CORE] Fix races in launcher code, test.

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20297 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86289/ Test PASSed. ---

[GitHub] spark issue #20299: [SPARK-23135][ui] Fix rendering of accumulators in the s...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20299 **[Test build #86301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86301/testReport)** for PR 20299 at commit

[GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r162047640 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -39,18 +38,20 @@ object

[GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r162047620 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala --- @@ -27,7 +27,6 @@ import

[GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r162047382 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -333,16 +339,19 @@ abstract class SparkStrategies extends

[GitHub] spark issue #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregation func...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19872 Only few nits. LGTM but let me leave it to @ueshin. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #19872: [SPARK-22274][PYTHON][SQL] User-defined aggregati...

2018-01-17 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r162047655 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -360,9 +369,23 @@ abstract class SparkStrategies extends

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20294 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86268/ Test PASSed. ---

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20294 **[Test build #86268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86268/testReport)** for PR 20294 at commit

[GitHub] spark issue #20294: [SPARK-23132][PYTHON][ML] Run doctests in ml.image when ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20294 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20257 **[Test build #86269 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86269/testReport)** for PR 20257 at commit

[GitHub] spark issue #20257: [SPARK-23048][ML] Add OneHotEncoderEstimator document an...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20257 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86269/ Test PASSed. ---

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162048685 --- Diff: docs/sql-programming-guide.md --- @@ -1795,6 +1795,11 @@ options. - Since Spark 2.3, when all inputs are binary, SQL `elt()` returns

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2018-01-17 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/19893 @vanzin @squito @srowen @jiangxb1987 @henryr Big thanks to everybody for the constructive comments, learned a lot from them. I'll take a look at further possibilities like the

[GitHub] spark issue #20019: [SPARK-22361][SQL][TEST] Add unit test for Window Frames

2018-01-17 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20019 @gatorsmile @jiangxb1987 @smurakozi Thanks for the help! --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162049277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -93,41 +97,76 @@ object DecimalPrecision

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162049618 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -242,18 +278,36 @@ object DecimalPrecision

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162050062 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -242,18 +278,36 @@ object DecimalPrecision

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162050678 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala --- @@ -136,10 +137,52 @@ object DecimalType extends AbstractDataType

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162051075 --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimals.sql --- @@ -0,0 +1,53 @@ +-- +-- Licensed to the Apache Software Foundation

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162051255 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala --- @@ -242,18 +278,36 @@ object DecimalPrecision

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162051884 --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimals.sql --- @@ -0,0 +1,53 @@ +-- +-- Licensed to the Apache Software Foundation (ASF)

[GitHub] spark issue #20023: [SPARK-22036][SQL] Decimal multiplication with high prec...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20023 LGTM. One thing we can improve is the golden file test framework. I found we sometimes repeat the test cases with a config on and off. We should write the test cases once and list the

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162052779 --- Diff: sql/core/src/test/resources/sql-tests/inputs/decimals.sql --- @@ -0,0 +1,53 @@ +-- +-- Licensed to the Apache Software Foundation

[GitHub] spark pull request #20023: [SPARK-22036][SQL] Decimal multiplication with hi...

2018-01-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20023#discussion_r162052996 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DecimalType.scala --- @@ -136,10 +137,52 @@ object DecimalType extends AbstractDataType {

[GitHub] spark issue #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaConsumer ...

2018-01-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18143 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18143: [SPARK-20919][SS] Simplificaiton of CachedKafkaConsumer ...

2018-01-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18143 **[Test build #86270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86270/testReport)** for PR 18143 at commit

<    1   2   3   4   5   6   7   >