[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21155 **[Test build #92334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92334/testReport)** for PR 21155 at commit

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21155 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21155: [SPARK-23927][SQL] Add "sequence" expression

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21155 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92334/ Test PASSed. ---

[GitHub] spark pull request #21589: [SPARK-24591][CORE] Number of cores and executors...

2018-06-26 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21589#discussion_r198174777 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackend.scala --- @@ -446,6 +446,8 @@

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #92336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92336/testReport)** for PR 20345 at commit

[GitHub] spark pull request #21626: [SPARK-24642][SQL] New function infers schema for...

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21626#discussion_r198152922 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -25,12 +25,36 @@ import

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92335/ Test PASSed. ---

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21553 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21553 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/485/

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21553 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21553 **[Test build #92344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92344/testReport)** for PR 21553 at commit

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21553 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92344/ Test FAILed. ---

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21598 I don't think it's too discretionary. We have a safeguard to control the behaviour. Spark mentions it in the migration guide. In case of changing public interface which breaks binary or source

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21598 @rxin, I understand the concerns about having behaviour changes. I discussed about this with other committers and community a lot. So, do you basically imply that we should support to

[GitHub] spark issue #20641: [SPARK-23464][MESOS] Fix mesos cluster scheduler options...

2018-06-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20641 yap, that sounds like a good idea --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-06-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21260 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21626: [SPARK-24642][SQL] New function infers schema for JSON c...

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21626 Do you prefer add Python / Scala one here or separately? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21639: [SPARK-24631][tests] Avoid cross-job pollution in...

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/21639#discussion_r198186779 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -173,21 +173,23 @@ private[spark] object TestUtils { * Run some code

[GitHub] spark issue #21626: [SPARK-24642][SQL] New function infers schema for JSON c...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21626 **[Test build #92338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92338/testReport)** for PR 21626 at commit

[GitHub] spark pull request #21589: [SPARK-24591][CORE] Number of cores and executors...

2018-06-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21589#discussion_r198219194 --- Diff: R/pkg/R/context.R --- @@ -25,6 +25,22 @@ getMinPartitions <- function(sc, minPartitions) { as.integer(minPartitions) }

[GitHub] spark pull request #21644: [SPARK-24660][SHS] Show correct error pages when ...

2018-06-26 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21644 [SPARK-24660][SHS] Show correct error pages when downloading logs ## What changes were proposed in this pull request? SHS is showing bad errors when trying to download logs is not

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

2018-06-26 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21644 cc @attilapiros @jerryshao @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21553 **[Test build #92344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92344/testReport)** for PR 21553 at commit

[GitHub] spark pull request #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/21624#discussion_r198189239 --- Diff: docs/configuration.md --- @@ -456,6 +456,13 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark issue #21624: [SPARK-24639][DOC] Add three config in the doc

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21624 cc @zsxwing --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21626: [SPARK-24642][SQL] New function infers schema for JSON c...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21626 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21626: [SPARK-24642][SQL] New function infers schema for JSON c...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21626 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92338/ Test PASSed. ---

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-06-26 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r198208026 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,51 @@ object ReorderJoin extends

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92337/testReport)** for PR 21596 at commit

[GitHub] spark issue #21639: [SSPARK-24653][tests] Avoid cross-job pollution in TestU...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21639 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/486/

[GitHub] spark issue #21639: [SSPARK-24653][tests] Avoid cross-job pollution in TestU...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21639 **[Test build #92345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92345/testReport)** for PR 21639 at commit

[GitHub] spark issue #21639: [SSPARK-24653][tests] Avoid cross-job pollution in TestU...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21639 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-26 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21598 Here: https://en.wikipedia.org/wiki/Bug_compatibility On Tue, Jun 26, 2018 at 9:28 AM Reynold Xin wrote: > It’s actually common software engineering practice to keep

[GitHub] spark pull request #21626: [SPARK-24642][SQL] New function infers schema for...

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21626#discussion_r198151731 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/InferSchema.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21644 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/484/

[GitHub] spark pull request #21570: [SPARK-24564][TEST] Add test suite for RecordBina...

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/21570#discussion_r198177547 --- Diff: sql/core/src/test/java/test/org/apache/spark/sql/execution/sort/RecordBinaryComparatorSuite.java --- @@ -0,0 +1,255 @@ +/* + *

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21643: [SPARK-24659][SQL] GenericArrayData.equals should...

2018-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21643#discussion_r198189030 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala --- @@ -104,4 +104,13 @@ class ComplexDataSuite extends

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92336/ Test PASSed. ---

[GitHub] spark issue #17267: [SPARK-19926][PYSPARK] Make pyspark exception more user-...

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/17267 @dataknocker do you want to take over this one? then we can continue with #18324 --- - To unsubscribe, e-mail:

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21260 **[Test build #92346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92346/testReport)** for PR 21260 at commit

[GitHub] spark issue #21639: [SPARK-24631][tests] Avoid cross-job pollution in TestUt...

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21639 Seems the JIRA number is not related? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21603: [SPARK-17091][SQL] Add rule to convert IN predicate to e...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21603 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21603: [SPARK-17091][SQL] Add rule to convert IN predicate to e...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21603 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92340/ Test PASSed. ---

[GitHub] spark pull request #21560: [SPARK-24386][SS] coalesce(1) aggregates in conti...

2018-06-26 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/21560#discussion_r198222671 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousCoalesceRDD.scala --- @@ -0,0 +1,108 @@ +/*

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21623 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/483/

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21623 **[Test build #92342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92342/testReport)** for PR 21623 at commit

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21623 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21631: [SPARK-24645][SQL] Skip parsing when csvColumnPruning en...

2018-06-26 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21631 v2.5.9 also have the same behaviour? Anyway, it'd be better to ask the author ;) I asked before and I got quick response. --- -

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92335 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92335/testReport)** for PR 21643 at commit

[GitHub] spark pull request #21611: [SPARK-24569][SQL] Aggregator with output type Op...

2018-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21611#discussion_r198185052 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -333,4 +406,28 @@ class DatasetAggregatorSuite extends

[GitHub] spark pull request #21644: [SPARK-24660][SHS] Show correct error pages when ...

2018-06-26 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/21644#discussion_r198185350 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala --- @@ -148,38 +148,36 @@ private[v1] trait BaseAppResource extends

[GitHub] spark pull request #21611: [SPARK-24569][SQL] Aggregator with output type Op...

2018-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21611#discussion_r198184841 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetAggregatorSuite.scala --- @@ -148,6 +148,79 @@ object VeryComplexResultAgg extends

[GitHub] spark issue #21631: [SPARK-24645][SQL] Skip parsing when csvColumnPruning en...

2018-06-26 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21631 > v2.5.9 also have the same behaviour? yes, it is the same. > Anyway, it'd be better to ask the author ;) I asked before and I got quick response. ok. I will create an

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-06-26 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r198206001 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,50 @@ object ReorderJoin extends

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16677 **[Test build #92339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92339/testReport)** for PR 16677 at commit

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16677: [SPARK-19355][SQL] Use map output statistics to improve ...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16677 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92339/ Test FAILed. ---

[GitHub] spark issue #21639: [SSPARK-24653][tests] Avoid cross-job pollution in TestU...

2018-06-26 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21639 Oops, no idea how I got the wrong bug. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21644 **[Test build #92343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92343/testReport)** for PR 21644 at commit

[GitHub] spark issue #21644: [SPARK-24660][SHS] Show correct error pages when downloa...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21644 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21553: [SPARK-24215][PySpark][Follow Up] Implement eager evalua...

2018-06-26 Thread xuanyuanking
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/21553 @gatorsmile I address the comments in the last commit, but maybe it should be done in a independent PR and Jira? --- - To

[GitHub] spark pull request #21643: [SPARK-24659][SQL] GenericArrayData.equals should...

2018-06-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21643#discussion_r198186283 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/GenericArrayData.scala --- @@ -122,7 +122,7 @@ class GenericArrayData(val

[GitHub] spark pull request #21553: [SPARK-24215][PySpark][Follow Up] Implement eager...

2018-06-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/21553#discussion_r198185807 --- Diff: python/pyspark/sql/conf.py --- @@ -64,6 +64,96 @@ def _checkType(self, obj, identifier): (identifier, obj,

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21596 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92337/ Test PASSed. ---

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-06-26 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r198209435 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,50 @@ object ReorderJoin extends

[GitHub] spark pull request #21639: [SPARK-24653][tests] Avoid cross-job pollution in...

2018-06-26 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21639#discussion_r198210412 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -173,21 +173,23 @@ private[spark] object TestUtils { * Run some code involving

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-26 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21598 It’s actually common software engineering practice to keep “buggy” semantics if a bug has been out there long enough and a lot of applications depend on the semantics. On Tue, Jun

[GitHub] spark pull request #21553: [SPARK-24215][PySpark][Follow Up] Implement eager...

2018-06-26 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21553#discussion_r198218069 --- Diff: docs/configuration.md --- @@ -456,33 +456,6 @@ Apart from these, the following properties are also available, and may be useful from

[GitHub] spark issue #21631: [SPARK-24645][SQL] Skip parsing when csvColumnPruning en...

2018-06-26 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21631 Here is the test for uniVocity parser: https://github.com/MaxGekk/univocity_tests . For the first line, `parseLine` outputs empty array but `null`s for the next calls. What do you think should I

[GitHub] spark pull request #21639: [SPARK-24631][tests] Avoid cross-job pollution in...

2018-06-26 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/21639#discussion_r198188319 --- Diff: core/src/main/scala/org/apache/spark/TestUtils.scala --- @@ -173,21 +173,23 @@ private[spark] object TestUtils { * Run some code

[GitHub] spark issue #18900: [SPARK-21687][SQL] Spark SQL should set createTime for H...

2018-06-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/18900 can you check if hive DESC TABLE output the create time of partitions? We can regenerate the output files for `SQLQueryTestSuite` if needed. ---

[GitHub] spark issue #21603: [SPARK-17091][SQL] Add rule to convert IN predicate to e...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21603 **[Test build #92340 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92340/testReport)** for PR 21603 at commit

[GitHub] spark issue #21598: [SPARK-24605][SQL] size(null) returns null instead of -1

2018-06-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21598 I don't object about the default value here if it's specific to this JIRA and PR for clarification as I said above. If this says about general stuff, to me it sounds it needs a separate

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-06-26 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21589 what's the convention here, I thought SparkContext has get* methods instead --- - To unsubscribe, e-mail:

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21260 **[Test build #92346 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92346/testReport)** for PR 21260 at commit

[GitHub] spark pull request #21346: [SPARK-6237][NETWORK] Network-layer changes to al...

2018-06-26 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/21346#discussion_r198236456 --- Diff: common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java --- @@ -207,9 +400,67 @@ private void

[GitHub] spark pull request #21623: [SPARK-24638][SQL] StringStartsWith support push ...

2018-06-26 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21623#discussion_r198244664 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -270,6 +277,29 @@ private[parquet] class

[GitHub] spark issue #19410: [SPARK-22184][CORE][GRAPHX] GraphX fails in case of insu...

2018-06-26 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/19410 Hi @szhem. Thanks for the kind reminder and thanks for your contribution. I'm sorry I did not respond sooner. I no longer work where I regularly used the checkpointing code with large

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21260 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92346/ Test PASSed. ---

[GitHub] spark issue #21260: [SPARK-23529][K8s] Support mounting volumes

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21260 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21482: [SPARK-24393][SQL] SQL builtin: isinf

2018-06-26 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/21482 Hey I have an additional thought on this. Will leave it in the next ten mins. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21346: [SPARK-6237][NETWORK] Network-layer changes to allow str...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21346 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21346: [SPARK-6237][NETWORK] Network-layer changes to allow str...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21346 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/487/

[GitHub] spark issue #21346: [SPARK-6237][NETWORK] Network-layer changes to allow str...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21346 **[Test build #92347 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92347/testReport)** for PR 21346 at commit

[GitHub] spark pull request #21623: [SPARK-24638][SQL] StringStartsWith support push ...

2018-06-26 Thread rdblue
Github user rdblue commented on a diff in the pull request: https://github.com/apache/spark/pull/21623#discussion_r198230713 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -270,6 +277,29 @@ private[parquet] class

[GitHub] spark pull request #21346: [SPARK-6237][NETWORK] Network-layer changes to al...

2018-06-26 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/21346#discussion_r198233111 --- Diff: common/network-common/src/test/java/org/apache/spark/network/RpcIntegrationSuite.java --- @@ -207,9 +400,67 @@ private void

[GitHub] spark issue #21638: [SPARK-22357][CORE] SparkContext.binaryFiles ignore minP...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21638 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21638: [SPARK-22357][CORE] SparkContext.binaryFiles ignore minP...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21638 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/490/

[GitHub] spark issue #21638: [SPARK-22357][CORE] SparkContext.binaryFiles ignore minP...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21638 **[Test build #92350 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92350/testReport)** for PR 21638 at commit

[GitHub] spark issue #21397: [SPARK-24334] Fix race condition in ArrowPythonRunner ca...

2018-06-26 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/21397 @vamaral1 , I've seen this error too and I'm trying to remember what the cause was.. I think it can happen when there is some files get mixed up when updating/building. If you're building your

[GitHub] spark pull request #21643: [SPARK-24659][SQL] GenericArrayData.equals should...

2018-06-26 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21643#discussion_r198268375 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ComplexDataSuite.scala --- @@ -104,4 +104,38 @@ class ComplexDataSuite extends

[GitHub] spark pull request #21598: [SPARK-24605][SQL] size(null) returns null instea...

2018-06-26 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21598#discussion_r198280518 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -75,28 +75,44 @@ trait

[GitHub] spark pull request #21623: [SPARK-24638][SQL] StringStartsWith support push ...

2018-06-26 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/21623#discussion_r198241792 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -270,6 +277,29 @@ private[parquet]

[GitHub] spark issue #21623: [SPARK-24638][SQL] StringStartsWith support push down

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21623 **[Test build #92342 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92342/testReport)** for PR 21623 at commit

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21643 **[Test build #92353 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92353/testReport)** for PR 21643 at commit

[GitHub] spark issue #21643: [SPARK-24659][SQL] GenericArrayData.equals should respec...

2018-06-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21643 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/493/

  1   2   3   4   5   >