[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/700/

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21667 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21667: [SPARK-24691][SQL]Dispatch the type support check in Fil...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21667 **[Test build #92639 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92639/testReport)** for PR 21667 at commit

[GitHub] spark pull request #21667: [SPARK-24691][SQL]Dispatch the type support check...

2018-07-05 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21667#discussion_r200255604 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala --- @@ -152,6 +152,11 @@ trait FileFormat { }

[GitHub] spark issue #21049: [SPARK-23957][SQL] Remove redundant sort operators from ...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21049 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21049: [SPARK-23957][SQL] Remove redundant sort operators from ...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21049 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/699/

[GitHub] spark pull request #21530: [spark][pyspark][sql] Correcting code for Documen...

2018-07-05 Thread DaniHoon
Github user DaniHoon closed the pull request at: https://github.com/apache/spark/pull/21530 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21713: [SPARK-24737][SQL] Type coercion between StructTy...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21713#discussion_r200251401 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -166,6 +166,30 @@ object TypeCoercion {

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/698/

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92638/testReport)** for PR 21713 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21713 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21658 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21658 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92634/ Test FAILed. ---

[GitHub] spark issue #21584: [SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21584 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92637/ Test FAILed. ---

[GitHub] spark issue #21584: [SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21584 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92635/ Test FAILed. ---

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21713 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92636/ Test FAILed. ---

[GitHub] spark issue #21584: [SPARK-24433][K8S][WIP] Initial R Bindings for SparkR on...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21584 **[Test build #92635 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92635/testReport)** for PR 21584 at commit

[GitHub] spark issue #21658: [SPARK-24678][Spark-Streaming] Give priority in use of '...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21658 **[Test build #92634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92634/testReport)** for PR 21658 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92637/testReport)** for PR 21405 at commit

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21713 **[Test build #92636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92636/testReport)** for PR 21713 at commit

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249847 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -240,7 +244,11 @@

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249732 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread HeartSaVioR
Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200249261 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200248889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala --- @@ -240,7 +244,11 @@ private[state]

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200249108 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -118,10 +119,10 @@ object JavaCode { /**

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200249000 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class CodeBlockSuite

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200247398 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200247248 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200246934 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -427,16 +245,122 @@ object

[GitHub] spark pull request #21556: [SPARK-24549][SQL] Support Decimal type push down...

2018-07-05 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/21556#discussion_r200246162 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -82,6 +120,30 @@ private[parquet] class

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92632/ Test PASSed. ---

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20345 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21552 ah, I see. It seems we should do that. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200245418 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala --- @@ -133,4 +133,55 @@ class

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200245212 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -427,16 +245,122 @@ object

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20345 **[Test build #92632 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92632/testReport)** for PR 20345 at commit

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200244688 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/FilterPushdownBenchmark.scala --- @@ -44,8 +49,33 @@ object

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200244488 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -118,10 +119,10 @@ object JavaCode {

[GitHub] spark pull request #21405: [SPARK-24361][SQL] Polish code block manipulation...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21405#discussion_r200244308 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -291,5 +328,8 @@ class LiteralValue(val

[GitHub] spark pull request #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBe...

2018-07-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21677#discussion_r200244218 --- Diff: sql/core/benchmarks/FilterPushdownBenchmark-results.txt --- @@ -0,0 +1,556 @@ +[ Pushdown for many distinct

[GitHub] spark issue #21713: [SPARK-24737][SQL] Type coercion between StructTypes.

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21713 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21552: [SPARK-24544][SQL] Print actual failure cause when look ...

2018-07-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21552 Why Spark doesn't fail when create this function? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242174 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #21700: [SPARK-24717][SS] Split out max retain version of...

2018-07-05 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/spark/pull/21700#discussion_r200242876 --- Diff: sql/core/src/main/java/org/apache/spark/sql/streaming/state/BoundedSortedMap.java --- @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21677 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21677 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92633/ Test PASSed. ---

[GitHub] spark issue #21677: [SPARK-24692][TESTS] Improvement FilterPushdownBenchmark

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21677 **[Test build #92633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92633/testReport)** for PR 21677 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21405 **[Test build #92637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92637/testReport)** for PR 21405 at commit

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/697/

[GitHub] spark issue #21405: [SPARK-24361][SQL] Polish code block manipulation API

2018-07-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21405 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

<    1   2   3   4