[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22184 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22234: [SPARK-25241][SQL] Configurable empty values when...

2018-08-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22234#discussion_r212825429 --- Diff: python/pyspark/sql/readwriter.py --- @@ -345,11 +345,11 @@ def text(self, paths, wholetext=False, lineSep=None): @since(2.0) def

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22184 **[Test build #95262 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95262/testReport)** for PR 22184 at commit

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95262/ Test PASSed. ---

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22184 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22184: [SPARK-25132][SQL][DOC] Add migration doc for case-insen...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22184 **[Test build #95262 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95262/testReport)** for PR 22184 at commit

[GitHub] spark issue #22234: [SPARK-25241][SQL] Configurable empty values when readin...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22234 **[Test build #95259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95259/testReport)** for PR 22234 at commit

[GitHub] spark issue #22234: [SPARK-25241][SQL] Configurable empty values when readin...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22234 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22234: [SPARK-25241][SQL] Configurable empty values when readin...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22234 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95259/ Test PASSed. ---

[GitHub] spark issue #20901: [SPARK-23792][DOCS] Documentation improvements for datet...

2018-08-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/20901 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22236 [SPARK-10697][ML] Add lift to Association rules ## What changes were proposed in this pull request? The PR adds the lift measure to Association rules. ## How was this patch

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95263/testReport)** for PR 22236 at commit

[GitHub] spark pull request #20901: [SPARK-23792][DOCS] Documentation improvements fo...

2018-08-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20901 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22222: [SPARK-25083][SQL] Remove the type erasure hack in data ...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/2 **[Test build #95261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95261/testReport)** for PR 2 at commit

[GitHub] spark issue #22222: [SPARK-25083][SQL] Remove the type erasure hack in data ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95261/ Test PASSed. ---

[GitHub] spark issue #22222: [SPARK-25083][SQL] Remove the type erasure hack in data ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/2 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95263/testReport)** for PR 22236 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95263/ Test FAILed. ---

[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22235 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95260/ Test PASSed. ---

[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22235 **[Test build #95260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95260/testReport)** for PR 22235 at commit

[GitHub] spark issue #22235: [SPARK-23698][PYTHON][FOLLOWUP] Resolve undefiend names ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22235 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in SQL fun...

2018-08-26 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/18447 @HyukjinKwon I also neutral since I don't have potential use cases for the function. --- - To unsubscribe, e-mail:

[GitHub] spark issue #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in SQL fun...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18447 @MaxGekk, I was thinking we could use this instead of `schema_of` somehow --- - To unsubscribe, e-mail:

[GitHub] spark issue #18447: [SPARK-21232][SQL][SparkR][PYSPARK] New built-in SQL fun...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18447 @mmolimar, let's leave this closed if there's no explicit positive feedback within few days. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22198: [SPARK-25121][SQL] Supports multi-part table name...

2018-08-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22198#discussion_r212822215 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameJoinSuite.scala --- @@ -191,6 +195,48 @@ class DataFrameJoinSuite extends QueryTest

[GitHub] spark pull request #17745: [SPARK-17159][Streaming] optimise check for new f...

2018-08-26 Thread steveloughran
Github user steveloughran commented on a diff in the pull request: https://github.com/apache/spark/pull/17745#discussion_r212822877 --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/FileInputDStream.scala --- @@ -196,29 +191,29 @@ class FileInputDStream[K, V,

[GitHub] spark issue #22186: [SPARK-25183][SQL][WIP] Spark HiveServer2 to use Spark S...

2018-08-26 Thread steveloughran
Github user steveloughran commented on the issue: https://github.com/apache/spark/pull/22186 my local maven build *did* work, so maybe its a javac/JVM version thing. Will move back to a java class callback. --- -

[GitHub] spark pull request #22233: [SPARK-25240][SQL] Fix for a deadlock in RECOVER ...

2018-08-26 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22233#discussion_r212834324 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand(

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22238 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22237 **[Test build #95269 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95269/testReport)** for PR 22237 at commit

[GitHub] spark issue #22234: [SPARK-25241][SQL] Configurable empty values when readin...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22234 **[Test build #95271 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95271/testReport)** for PR 22234 at commit

[GitHub] spark pull request #22198: [SPARK-25121][SQL] Supports multi-part table name...

2018-08-26 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22198#discussion_r212844578 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala --- @@ -47,20 +49,39 @@ object ResolveHints { *

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-08-26 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22237 [SPARK-25243][SQL] Use FailureSafeParser in from_json ## What changes were proposed in this pull request? In the PR, I propose to switch `from_json` on `FailureSafeParser`, and to make

[GitHub] spark pull request #20637: [SPARK-23466][SQL] Remove redundant null checks i...

2018-08-26 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20637#discussion_r212832680 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -223,8 +223,9 @@ trait

[GitHub] spark pull request #22218: [SPARK-25228][CORE]Add executor CPU time metric.

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22218#discussion_r212833235 --- Diff: core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala --- @@ -17,11 +17,13 @@ package org.apache.spark.executor

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 > @viirya did you try to run TakeOrderedAndProjectSuite? I am pretty sure that will fail now ;)... Not yet. Let me try. ---

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832846 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832850 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-08-26 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Sorry for dropping message again, but could someone please have a look at this change. This is a problem that I am having constantly and a validation from senior committers will be really

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22237 **[Test build #95267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95267/testReport)** for PR 22237 at commit

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22236 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95265/ Test FAILed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22236 **[Test build #95265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95265/testReport)** for PR 22236 at commit

[GitHub] spark pull request #22238: [SPARK-25245][DOCS][SS] Explain regarding limitin...

2018-08-26 Thread HeartSaVioR
GitHub user HeartSaVioR opened a pull request: https://github.com/apache/spark/pull/22238 [SPARK-25245][DOCS][SS] Explain regarding limiting modification on "spark.sql.shuffle.partitions" for structured streaming ## What changes were proposed in this pull request? This

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22237 **[Test build #95267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95267/testReport)** for PR 22237 at commit

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22237 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95267/ Test FAILed. ---

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22237 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22237 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22184: [SPARK-25132][SQL][DOC] Add migration doc for cas...

2018-08-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22184#discussion_r212834477 --- Diff: docs/sql-programming-guide.md --- @@ -1895,6 +1895,10 @@ working with timestamps in `pandas_udf`s to get the best performance, see -

[GitHub] spark pull request #22233: [SPARK-25240][SQL] Fix for a deadlock in RECOVER ...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22233#discussion_r212831774 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand(

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832734 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22221: [SPARK-25231] : Fix synchronization of executor h...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/1#discussion_r212833953 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -465,7 +465,7 @@ private[spark] class TaskSchedulerImpl( var

[GitHub] spark issue #22221: [SPARK-25231] : Fix synchronization of executor heartbea...

2018-08-26 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/1 We would appreciate it if you would describe some detail on `further analysis` for removing lock on the whole object. > On further analysis of the heartbeat receiver method, it turns out

[GitHub] spark pull request #22219: [SPARK-25224][SQL] Improvement of Spark SQL Thrif...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22219#discussion_r212834287 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3237,6 +3237,20 @@ class Dataset[T] private[sql]( files.toSet.toArray

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22197 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22197 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95264/ Test PASSed. ---

[GitHub] spark pull request #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22236#discussion_r212833449 --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala --- @@ -338,7 +355,16 @@ object FPGrowthModel extends MLReadable[FPGrowthModel] {

[GitHub] spark pull request #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22236#discussion_r212833419 --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala --- @@ -217,9 +217,13 @@ object FPGrowth extends DefaultParamsReadable[FPGrowth] {

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22237 jenkins, retest this, please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22238 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22238 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22238 **[Test build #95268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95268/testReport)** for PR 22238 at commit

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832795 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark issue #22197: [SPARK-25207][SQL] Case-insensitve field resolution for ...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22197 **[Test build #95264 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95264/testReport)** for PR 22197 at commit

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22237 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #16677: [SPARK-19355][SQL] Use map output statistics to i...

2018-08-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/16677#discussion_r212844439 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -93,25 +96,93 @@ trait BaseLimitExec extends UnaryExecNode with

[GitHub] spark pull request #22198: [SPARK-25121][SQL] Supports multi-part table name...

2018-08-26 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22198#discussion_r212844390 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -144,7 +144,7 @@ class Analyzer( lazy val

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22239 **[Test build #95272 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95272/testReport)** for PR 22239 at commit

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 cc @cloud-fan for a sanity check. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 @viirya did you try to run `TakeOrderedAndProjectSuite`? I am pretty sure that will fail now ;)... --- - To unsubscribe,

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #95275 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95275/testReport)** for PR 22198 at commit

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95275/ Test PASSed. ---

[GitHub] spark issue #22236: [SPARK-10697][ML] Add lift to Association rules

2018-08-26 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22236 cc @holdenk @srowen @yanboliang --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22237 **[Test build #95266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95266/testReport)** for PR 22237 at commit

[GitHub] spark issue #22048: [SPARK-25108][SQL] Fix the show method to display the wi...

2018-08-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22048 Ping @xuejianbest --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22238 **[Test build #95268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95268/testReport)** for PR 22238 at commit

[GitHub] spark issue #22238: [SPARK-25245][DOCS][SS] Explain regarding limiting modif...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22238 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95268/ Test PASSed. ---

[GitHub] spark issue #22234: [SPARK-25241][SQL] Configurable empty values when readin...

2018-08-26 Thread mmolimar
Github user mmolimar commented on the issue: https://github.com/apache/spark/pull/22234 @MaxGekk I added what you suggested as well. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22234: [SPARK-25241][SQL] Configurable empty values when...

2018-08-26 Thread mmolimar
Github user mmolimar commented on a diff in the pull request: https://github.com/apache/spark/pull/22234#discussion_r212842706 --- Diff: python/pyspark/sql/readwriter.py --- @@ -345,11 +345,11 @@ def text(self, paths, wholetext=False, lineSep=None): @since(2.0)

[GitHub] spark pull request #22239: [SPARK-19355][SQL][Followup] Remove the child.out...

2018-08-26 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/22239 [SPARK-19355][SQL][Followup] Remove the child.outputPartitioning check ## What changes were proposed in this pull request? This is based on the discussion

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 cc @hvanhovell --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22239 @hvanhovell I can set `spark.sql.limit.flatGlobalLimit` to false to match `TakeOrderedAndProjectExec` semantics at the beginning of `TakeOrderedAndProjectSuite`. Or you prefer to add an explicit

[GitHub] spark pull request #20844: [SPARK-23707][SQL] Don't need shuffle exchange wi...

2018-08-26 Thread ConeyLiu
Github user ConeyLiu closed the pull request at: https://github.com/apache/spark/pull/20844 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20844: [SPARK-23707][SQL] Don't need shuffle exchange with sing...

2018-08-26 Thread ConeyLiu
Github user ConeyLiu commented on the issue: https://github.com/apache/spark/pull/20844 thanks for all. Closes it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22063: [WIP][SPARK-25044][SQL] Address translation of LMF closu...

2018-08-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22063 **[Test build #4293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4293/testReport)** for PR 22063 at commit

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-08-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22237#discussion_r212847031 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -554,18 +554,22 @@ case class JsonToStructs(

[GitHub] spark pull request #22197: [SPARK-25207][SQL] Case-insensitve field resoluti...

2018-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22197#discussion_r212848096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala --- @@ -350,25 +356,38 @@ private[parquet]

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22239 Setting `spark.sql.limit.flatGlobalLimit` to `false` works for me. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22184: [SPARK-25132][SQL][DOC] Add migration doc for cas...

2018-08-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22184#discussion_r212849852 --- Diff: docs/sql-programming-guide.md --- @@ -1895,6 +1895,10 @@ working with timestamps in `pandas_udf`s to get the best performance, see -

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-08-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22237#discussion_r212849989 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -469,4 +470,23 @@ class JsonFunctionsSuite extends QueryTest

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2018-08-26 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r212850054 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/DataWritingCommand.scala --- @@ -20,30 +20,32 @@ package

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22239: [SPARK-19355][SQL][Followup] Remove the child.outputPart...

2018-08-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22239 Test PASSed. Refer to this link for build results (access rights to CI server needed):

  1   2   3   >