Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r212832680
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -223,8 +223,9 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks with PlanTestBa
}
} else {
val lit = InternalRow(expected, expected)
+ val dtAsNullable = expression.dataType.asNullable
--- End diff --
I understood what you said but this is not what I have experienced. I
applied your patch on current master. Then I reverted #22126. What I saw (and
this is what I'd expect indeed) is that:
- with your patch as it is (ie. with `asNullable`) the test failed because
the result is incorrect;
- without `asNullable` the test failed with a NPE.
Probably someone else can also try and check who is wrong here. cc @ueshin
@cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
