[GitHub] [spark] cloud-fan commented on issue #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table

2020-02-16 Thread GitBox
cloud-fan commented on issue #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table URL: https://github.com/apache/spark/pull/27538#issuecomment-586848000 please use `CREATE TABLE LIKE` instead of `CTL` in PR description. `CTL` is not a

[GitHub] [spark] imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables.

2020-02-16 Thread GitBox
imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables. URL: https://github.com/apache/spark/pull/27532#discussion_r380013327 ## File path:

[GitHub] [spark] HyukjinKwon commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
HyukjinKwon commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586847733 Nice! This is an automated

[GitHub] [spark] cloud-fan commented on a change in pull request #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table URL: https://github.com/apache/spark/pull/27538#discussion_r380012960 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167 URL: https://github.com/apache/spark/pull/27492#discussion_r380012529 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala

[GitHub] [spark] AmplabJenkins removed a comment on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#issuecomment-586846567 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins removed a comment on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#issuecomment-586846560 Merged build finished. Test PASSed.

[GitHub] [spark] HyukjinKwon closed pull request #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
HyukjinKwon closed pull request #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602 This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash

2020-02-16 Thread GitBox
HyukjinKwon commented on a change in pull request #27601: [SPARK-30847][SQL] Take productPrefix into account in MurmurHash3.productHash URL: https://github.com/apache/spark/pull/27601#discussion_r380012000 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server URL: https://github.com/apache/spark/pull/27552#issuecomment-586846551 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
HyukjinKwon commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586846503 Merged to master, since the tests have nothing related to this.

[GitHub] [spark] AmplabJenkins commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#issuecomment-586846567 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server URL: https://github.com/apache/spark/pull/27552#issuecomment-586846544 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server URL: https://github.com/apache/spark/pull/27552#issuecomment-586846544 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#issuecomment-586846560 Merged build finished. Test PASSed.

[GitHub] [spark] xuanyuanking commented on issue #27549: [SPARK-30803][DOCS] Fix the home page link for Scala API document

2020-02-16 Thread GitBox
xuanyuanking commented on issue #27549: [SPARK-30803][DOCS] Fix the home page link for Scala API document URL: https://github.com/apache/spark/pull/27549#issuecomment-586846313 Thanks for reviewing. This is an automated

[GitHub] [spark] AmplabJenkins commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server URL: https://github.com/apache/spark/pull/27552#issuecomment-586846551 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-02-16 Thread GitBox
SparkQA commented on issue #27552: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server URL: https://github.com/apache/spark/pull/27552#issuecomment-586846187 **[Test build #118543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118543/testReport)**

[GitHub] [spark] SparkQA commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
SparkQA commented on issue #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#issuecomment-586846201 **[Test build #118542 has

[GitHub] [spark] cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167 URL: https://github.com/apache/spark/pull/27492#discussion_r380011292 ## File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala

[GitHub] [spark] xuanyuanking commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
xuanyuanking commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#discussion_r380009637 ## File path:

[GitHub] [spark] xuanyuanking commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs

2020-02-16 Thread GitBox
xuanyuanking commented on a change in pull request #27579: [SPARK-30829][SQL] Define LegacyBehaviorPolicy enumeration as the common value for result change configs URL: https://github.com/apache/spark/pull/27579#discussion_r380009687 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27492: [SPARK-30755][SQL] Update migration guide for HIVE-15167 URL: https://github.com/apache/spark/pull/27492#discussion_r380009753 ## File path: docs/sql-migration-guide.md ## @@ -330,6 +330,8 @@ license: | - Since

[GitHub] [spark] cloud-fan commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables.

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables. URL: https://github.com/apache/spark/pull/27532#discussion_r380009091 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#discussion_r380008658 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586842564 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586842558 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
SparkQA removed a comment on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586837700 **[Test build #118539 has

[GitHub] [spark] imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables.

2020-02-16 Thread GitBox
imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables. URL: https://github.com/apache/spark/pull/27532#discussion_r380008030 ## File path:

[GitHub] [spark] AmplabJenkins commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586842564 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586842558 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586842437 **[Test build #118539 has

[GitHub] [spark] cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r380007905 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r380007309 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] Ngone51 commented on a change in pull request #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-16 Thread GitBox
Ngone51 commented on a change in pull request #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#discussion_r380004885 ## File path:

[GitHub] [spark] Ngone51 commented on a change in pull request #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-16 Thread GitBox
Ngone51 commented on a change in pull request #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#discussion_r380005750 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586838074 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586838077 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586838040 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586838036 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586838036 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586838040 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586838074 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586838077 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-16 Thread GitBox
SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-586837700 **[Test build #118539 has

[GitHub] [spark] SparkQA commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning

2020-02-16 Thread GitBox
SparkQA commented on issue #27581: [SPARK-11150][SQL][FOLLOWUP] Move sql/dynamicpruning to sql/execution/dynamicpruning URL: https://github.com/apache/spark/pull/27581#issuecomment-586837681 **[Test build #118541 has

[GitHub] [spark] SparkQA commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
SparkQA commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586837703 **[Test build #118540 has

[GitHub] [spark] cloud-fan commented on a change in pull request #27584: [SPARK-30814][SQL] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added

2020-02-16 Thread GitBox
cloud-fan commented on a change in pull request #27584: [SPARK-30814][SQL] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added URL: https://github.com/apache/spark/pull/27584#discussion_r380003308 ## File path:

[GitHub] [spark] Ngone51 commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table

2020-02-16 Thread GitBox
Ngone51 commented on issue #27597: [SPARK-30844][SQL]Static partition should also follow StoreAssignmentPolicy when insert into table URL: https://github.com/apache/spark/pull/27597#issuecomment-586836775 Jenkins, retest this please.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586836109 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586836116 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586836116 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586836109 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
SparkQA commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586835809 **[Test build #118538 has

[GitHub] [spark] yma11 commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines

2020-02-16 Thread GitBox
yma11 commented on issue #27546: [SPARK-30773][ML]Support NativeBlas for level-1 routines URL: https://github.com/apache/spark/pull/27546#issuecomment-586835613 Hi @srowen and @mengxr , With MKL_NUM_THREADS/OPENBLAS_NUM_THREADS set 1, I have tested 10-element, 100-element, 1000-element

[GitHub] [spark] maropu commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
maropu commented on issue #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602#issuecomment-586834962 cc: @cloud-fan @HyukjinKwon

[GitHub] [spark] maropu opened a new pull request #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline

2020-02-16 Thread GitBox
maropu opened a new pull request #27602: [MINOR] Update the PR template for adding a link to the configuration naming guideline URL: https://github.com/apache/spark/pull/27602 ### What changes were proposed in this pull request? This is a follow-up of #27577. This pr

[GitHub] [spark] maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r38649 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] AmplabJenkins removed a comment on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#issuecomment-586834168 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#issuecomment-586834171 Test PASSed. Refer to this link for build results (access

[GitHub] [spark] AmplabJenkins commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#issuecomment-586834168 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#issuecomment-586834171 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-586834127 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-586834124 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586834069 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586834066 Merged build finished. Test PASSed. This is an automated message from the Apache Git

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

2020-02-16 Thread GitBox
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds URL: https://github.com/apache/spark/pull/27543#issuecomment-586833966 I've merged https://github.com/apache/spark/pull/27596 , let's see if tests still pass here.

[GitHub] [spark] AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-586834124 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-586834127 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

2020-02-16 Thread GitBox
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds URL: https://github.com/apache/spark/pull/27543#issuecomment-586833991 retest it please This is an

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586834066 Merged build finished. Test PASSed. This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586834069 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
SparkQA commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-586833776 **[Test build #118536 has

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586833775 **[Test build #118535 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118535/testReport)** for PR 27600 at commit

[GitHub] [spark] SparkQA commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
SparkQA commented on issue #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#issuecomment-586833788 **[Test build #118537 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586833013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] maropu commented on issue #27577: [DOC] add config naming guideline

2020-02-16 Thread GitBox
maropu commented on issue #27577: [DOC] add config naming guideline URL: https://github.com/apache/spark/pull/27577#issuecomment-586833416 >> btw, if we want to remind developers to follow the naming rule, how about adding a link to this >> guideline in the PR template, too? > Yea this

[GitHub] [spark] AmplabJenkins removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586833003 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586833013 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586833003 Merged build finished. Test PASSed. This is an automated

[GitHub] [spark] xuanyuanking commented on a change in pull request #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior

2020-02-16 Thread GitBox
xuanyuanking commented on a change in pull request #27478: [SPARK-25829][SQL] Add config `spark.sql.legacy.allowDuplicatedMapKeys` and change the default behavior URL: https://github.com/apache/spark/pull/27478#discussion_r37008 ## File path:

[GitHub] [spark] iRakson commented on a change in pull request #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-16 Thread GitBox
iRakson commented on a change in pull request #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#discussion_r379998771 ## File path:

[GitHub] [spark] SparkQA removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
SparkQA removed a comment on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586799832 **[Test build #118521 has

[GitHub] [spark] SparkQA commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-16 Thread GitBox
SparkQA commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-586832445 **[Test build #118521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118521/testReport)** for

[GitHub] [spark] gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r379997584 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
maropu commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r379997276 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] cloud-fan commented on issue #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year

2020-02-16 Thread GitBox
cloud-fan commented on issue #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year URL: https://github.com/apache/spark/pull/27596#issuecomment-586830698 LGTM, merging to master/3.0! This is an automated

[GitHub] [spark] cloud-fan closed pull request #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year

2020-02-16 Thread GitBox
cloud-fan closed pull request #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year URL: https://github.com/apache/spark/pull/27596 This is an automated message from the Apache Git Service. To respond

[GitHub] [spark] gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r379996732 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586830044 Merged build finished. Test PASSed. This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586830051 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-16 Thread GitBox
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r379996688 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586830044 Merged build finished. Test PASSed. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586829753 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586830051 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586829746 Merged build finished. Test FAILed. This is an automated message from the Apache

[GitHub] [spark] SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
SparkQA removed a comment on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586827771 **[Test build #118533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118533/testReport)** for PR 27600 at commit

[GitHub] [spark] SparkQA commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
SparkQA commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586829723 **[Test build #118533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118533/testReport)** for PR 27600 at commit

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586829746 Merged build finished. Test FAILed. This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-16 Thread GitBox
AmplabJenkins commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-586829753 Test FAILed. Refer to this link for build results (access rights to CI server needed):

<    1   2   3   4   5   6   7   >