[GitHub] [spark] AmplabJenkins commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638878302 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638660123 **[Test build #123522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123522/testReport)** for PR 28585 at commit

[GitHub] [spark] SparkQA commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638881794 **[Test build #123528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123528/testReport)** for PR 28727 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638886787 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638886787 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] attilapiros commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435374818 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -121,12 +121,28 @@ private class ShuffleStatus(numPartitions: Int) {

[GitHub] [spark] attilapiros commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638950902 > Hey @attilapiros can you explain to my why you think we need to test the different kinds of block fetches? When we migrate we're always migrating to disk so I'm not

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638970542 **[Test build #123537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit

[GitHub] [spark] yaooqinn commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
yaooqinn commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638970227 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] attilapiros commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435394891 ## File path: core/src/main/scala/org/apache/spark/storage/RDDBlockSavedOnDecommissionedBlockManagerException.scala ## @@ -0,0 +1,21 @@ +/* + *

[GitHub] [spark] SparkQA commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638978237 **[Test build #123533 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123533/testReport)** for PR 28727 at commit

[GitHub] [spark] holdenk commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638998676 So @attilapiros looking at the Jenkins console logs we aren't leaking any threads during testing (nor would I expect us to). But I'll add something to more aggressively stop

[GitHub] [spark] attilapiros commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639004563 > So @attilapiros looking at the Jenkins console logs we aren't leaking any threads during testing (nor would I expect us to). But I'll add something to more aggressively

[GitHub] [spark] attilapiros commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435276424 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -121,12 +121,28 @@ private class ShuffleStatus(numPartitions: Int) {

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-63533 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638992217 **[Test build #123538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123538/testReport)** for PR 28728 at commit

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638886114 **[Test build #123534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638894124 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638901603 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] yaooqinn commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
yaooqinn commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435409142 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -126,7 +126,7 @@ object DateFormatter {

[GitHub] [spark] AmplabJenkins commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-638861233 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-04 Thread GitBox
SparkQA commented on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638877000 **[Test build #123522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123522/testReport)** for PR 28585 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638883167 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638883167 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn opened a new pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
yaooqinn opened a new pull request #28728: URL: https://github.com/apache/spark/pull/28728 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

[GitHub] [spark] SparkQA commented on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
SparkQA commented on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638897712 **[Test build #123532 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123532/testReport)** for PR 28719 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638898118 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] attilapiros commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435375916 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1790,6 +1817,100 @@ private[spark] class BlockManager( }

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638971155 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638971155 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638979325 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638979325 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638989196 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638989196 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435425845 ## File path: core/src/main/scala/org/apache/spark/storage/RDDBlockSavedOnDecommissionedBlockManagerException.scala ## @@ -0,0 +1,21 @@ +/* + * Licensed

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28585: [SPARK-31765][WEBUI][test-maven] Upgrade HtmlUnit >= 2.37.0

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28585: URL: https://github.com/apache/spark/pull/28585#issuecomment-638878302 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638894124 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA commented on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638892230 **[Test build #123529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123529/testReport)** for PR 28727 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638760446 **[Test build #123529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123529/testReport)** for PR 28727 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638898129 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435325729 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala ## @@ -418,15 +417,7 @@ class

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638920180 **[Test build #123536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123536/testReport)** for PR 28728 at commit

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435425022 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -650,6 +657,19 @@ private[spark] class BlockManager( blockId:

[GitHub] [spark] SparkQA removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638753726 **[Test build #123528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123528/testReport)** for PR 28727 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-63520 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-63520 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638806938 **[Test build #123532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123532/testReport)** for PR 28719 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28719: [SPARK-31899][SQL] Forbid datetime pattern letter u

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28719: URL: https://github.com/apache/spark/pull/28719#issuecomment-638898118 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435324570 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala ## @@ -234,22 +234,22 @@ private object

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435325539 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateFormatterSuite.scala ## @@ -199,4 +197,8 @@ class DateFormatterSuite

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638962379 **[Test build #123534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638962545 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638886114 **[Test build #123534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123534/testReport)** for PR 28728 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638962545 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] yaooqinn commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
yaooqinn commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435410059 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -36,11 +36,8 @@ Spark uses pattern letters in the following table for date and timestamp parsing

[GitHub] [spark] SparkQA commented on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-04 Thread GitBox
SparkQA commented on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-638859524 **[Test build #123530 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123530/testReport)** for PR 28635 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28635: [SPARK-31337][SQL]Support MS SQL Kerberos login in JDBC connector

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28635: URL: https://github.com/apache/spark/pull/28635#issuecomment-638782831 **[Test build #123530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123530/testReport)** for PR 28635 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638896336 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638896336 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] attilapiros commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
attilapiros commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-638916984 I just found a bug in my `BlockManagerSuite` test which is caused by this line:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638962556 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435405771 ## File path: docs/sql-ref-datetime-pattern.md ## @@ -36,11 +36,8 @@ Spark uses pattern letters in the following table for date and timestamp parsing

[GitHub] [spark] SparkQA removed a comment on pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28727: URL: https://github.com/apache/spark/pull/28727#issuecomment-638820055 **[Test build #123533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123533/testReport)** for PR 28727 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
cloud-fan commented on a change in pull request #28728: URL: https://github.com/apache/spark/pull/28728#discussion_r435406205 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ## @@ -126,7 +126,7 @@ object DateFormatter {

[GitHub] [spark] xuanyuanking commented on pull request #28707: [SPARK-31894][SS] Introduce UnsafeRow format validation for streaming state store

2020-06-04 Thread GitBox
xuanyuanking commented on pull request #28707: URL: https://github.com/apache/spark/pull/28707#issuecomment-638985570 @HeartSaVioR After taking a further look. Instead of dealing with the iterator, how about adding the invalidation for all state store operations in `StateStoreProvider`?

[GitHub] [spark] MaxGekk commented on pull request #28705: [SPARK-30808][SQL] Enable Java 8 time API in in Thriftserver SQL CLI

2020-06-04 Thread GitBox
MaxGekk commented on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-639007307 Here is the PR https://github.com/apache/spark/pull/28729 where I enabled Java 8 time API as @juliuszsompolski proposed.

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639007997 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639007969 **[Test build #123539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123539/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639007990 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435446889 ## File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ## @@ -479,6 +497,16 @@ private[spark] class MapOutputTrackerMaster( }

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435447040 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -1725,6 +1725,16 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] AmplabJenkins commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639071950 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639071931 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28166/

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-639071798 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] MaxGekk commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-06-04 Thread GitBox
MaxGekk commented on a change in pull request #28671: URL: https://github.com/apache/spark/pull/28671#discussion_r435517420 ## File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala ## @@ -811,6 +811,61 @@ class

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639095400 **[Test build #123541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123541/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639014498 **[Test build #123541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123541/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639026461 **[Test build #123542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123542/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639117314 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639117770 **[Test build #123542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123542/testReport)** for PR 28708 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639117310 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639116348 **[Test build #123543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123543/testReport)** for PR 28710 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28729: URL: https://github.com/apache/spark/pull/28729#issuecomment-639007694 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] viirya commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
viirya commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435438297 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -1725,6 +1725,16 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in in Thrift server

2020-06-04 Thread GitBox
SparkQA commented on pull request #28729: URL: https://github.com/apache/spark/pull/28729#issuecomment-639010818 **[Test build #123540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123540/testReport)** for PR 28729 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639026461 **[Test build #123542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123542/testReport)** for PR 28708 at commit

[GitHub] [spark] SparkQA commented on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
SparkQA commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639058135 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/28166/

[GitHub] [spark] AmplabJenkins commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-639137018 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-639137018 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-06-04 Thread GitBox
SparkQA commented on pull request #28729: URL: https://github.com/apache/spark/pull/28729#issuecomment-639137804 **[Test build #123544 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123544/testReport)** for PR 28729 at commit

[GitHub] [spark] holdenk commented on a change in pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
holdenk commented on a change in pull request #28708: URL: https://github.com/apache/spark/pull/28708#discussion_r435575539 ## File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala ## @@ -1790,6 +1822,108 @@ private[spark] class BlockManager( } }

[GitHub] [spark] juliuszsompolski commented on a change in pull request #28729: [SPARK-30808][SQL] Enable Java 8 time API in Thrift server

2020-06-04 Thread GitBox
juliuszsompolski commented on a change in pull request #28729: URL: https://github.com/apache/spark/pull/28729#discussion_r435458068 ## File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperation.scala ## @@ -73,7 +73,7 @@

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28708: [SPARK-20629][CORE][K8S] Copy shuffle data when nodes are being shutdown

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639055033 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-639067532 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA removed a comment on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-638970542 **[Test build #123537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit

[GitHub] [spark] SparkQA commented on pull request #28728: [SPARK-31879][SQL][test-java11] Make week-based pattern invalid for formatting too

2020-06-04 Thread GitBox
SparkQA commented on pull request #28728: URL: https://github.com/apache/spark/pull/28728#issuecomment-639111050 **[Test build #123537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123537/testReport)** for PR 28728 at commit

[GitHub] [spark] SparkQA commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
SparkQA commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639117298 **[Test build #123543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123543/testReport)** for PR 28710 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639117310 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
AmplabJenkins commented on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639116837 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

2020-06-04 Thread GitBox
AmplabJenkins removed a comment on pull request #28710: URL: https://github.com/apache/spark/pull/28710#issuecomment-639116837 This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   3   4   >