gerashegalov commented on a change in pull request #28746:
URL: https://github.com/apache/spark/pull/28746#discussion_r437592878
##
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##
@@ -74,6 +74,10 @@ class LocalSparkCluster(
def stop():
AmplabJenkins removed a comment on pull request #28764:
URL: https://github.com/apache/spark/pull/28764#issuecomment-641454235
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28764:
URL: https://github.com/apache/spark/pull/28764#issuecomment-641454235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28764:
URL: https://github.com/apache/spark/pull/28764#issuecomment-641245723
**[Test build #123694 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123694/testReport)**
for PR 28764 at commit
SparkQA commented on pull request #28764:
URL: https://github.com/apache/spark/pull/28764#issuecomment-641453142
**[Test build #123694 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123694/testReport)**
for PR 28764 at commit
AmplabJenkins removed a comment on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-641450746
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-641450746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-641239491
**[Test build #123693 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123693/testReport)**
for PR 28645 at commit
SparkQA commented on pull request #28645:
URL: https://github.com/apache/spark/pull/28645#issuecomment-641449469
**[Test build #123693 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123693/testReport)**
for PR 28645 at commit
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437581083
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerMemoryManager.scala
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437580626
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437580889
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
cloud-fan closed pull request #28650:
URL: https://github.com/apache/spark/pull/28650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437580420
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on pull request #28650:
URL: https://github.com/apache/spark/pull/28650#issuecomment-641443909
thanks, merging to master!
This is an automated message from the Apache Git Service.
To respond to the
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437578109
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437578179
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437577822
##
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
cloud-fan commented on pull request #28751:
URL: https://github.com/apache/spark/pull/28751#issuecomment-641435280
thanks, merging to master/3.0!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan closed pull request #28751:
URL: https://github.com/apache/spark/pull/28751
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SaurabhChawla100 commented on a change in pull request #28768:
URL: https://github.com/apache/spark/pull/28768#discussion_r437290253
##
File path: core/src/main/scala/org/apache/spark/ui/SparkUI.scala
##
@@ -86,6 +86,7 @@ private[spark] class SparkUI private (
cloud-fan commented on pull request #28745:
URL: https://github.com/apache/spark/pull/28745#issuecomment-641432882
will this cause perf regression? e.g. if grouping expr is expensive, with
the Project we only need to evaluate it once.
cloud-fan closed pull request #27986:
URL: https://github.com/apache/spark/pull/27986
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cloud-fan commented on pull request #27986:
URL: https://github.com/apache/spark/pull/27986#issuecomment-641404167
thanks, merging to master/3.0!
This is an automated message from the Apache Git Service.
To respond to the
cloud-fan closed pull request #28765:
URL: https://github.com/apache/spark/pull/28765
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SparkQA commented on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-641405101
**[Test build #123699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123699/testReport)**
for PR 27246 at commit
sarutak commented on a change in pull request #28768:
URL: https://github.com/apache/spark/pull/28768#discussion_r437537787
##
File path: core/src/main/scala/org/apache/spark/ui/SparkUI.scala
##
@@ -86,7 +86,7 @@ private[spark] class SparkUI private (
AmplabJenkins commented on pull request #28751:
URL: https://github.com/apache/spark/pull/28751#issuecomment-641405232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28751:
URL: https://github.com/apache/spark/pull/28751#issuecomment-641405232
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AngersZh commented on a change in pull request #27983:
URL: https://github.com/apache/spark/pull/27983#discussion_r437558157
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/script/ScriptTransformationExec.scala
##
@@ -0,0 +1,239 @@
+/*
+ * Licensed to
SparkQA commented on pull request #28768:
URL: https://github.com/apache/spark/pull/28768#issuecomment-641406226
**[Test build #123700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123700/testReport)**
for PR 28768 at commit
AmplabJenkins commented on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-641405643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dongjoon-hyun closed pull request #28742:
URL: https://github.com/apache/spark/pull/28742
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AmplabJenkins commented on pull request #28650:
URL: https://github.com/apache/spark/pull/28650#issuecomment-641414274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cloud-fan commented on pull request #28765:
URL: https://github.com/apache/spark/pull/28765#issuecomment-641398316
thanks, merging to master/3.0!
This is an automated message from the Apache Git Service.
To respond to the
SparkQA removed a comment on pull request #28650:
URL: https://github.com/apache/spark/pull/28650#issuecomment-641202467
**[Test build #123689 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123689/testReport)**
for PR 28650 at commit
AmplabJenkins removed a comment on pull request #28650:
URL: https://github.com/apache/spark/pull/28650#issuecomment-641414274
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-641312310
**[Test build #123699 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123699/testReport)**
for PR 27246 at commit
yaooqinn edited a comment on pull request #28751:
URL: https://github.com/apache/spark/pull/28751#issuecomment-640457288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AmplabJenkins removed a comment on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-640957576
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yaooqinn commented on a change in pull request #28650:
URL: https://github.com/apache/spark/pull/28650#discussion_r437232828
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##
@@ -56,6 +54,26 @@ trait
SparkQA commented on pull request #28650:
URL: https://github.com/apache/spark/pull/28650#issuecomment-641412878
**[Test build #123689 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123689/testReport)**
for PR 28650 at commit
jkpl closed pull request #28753:
URL: https://github.com/apache/spark/pull/28753
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
srowen commented on pull request #27805:
URL: https://github.com/apache/spark/pull/27805#issuecomment-640611674
Right, "24 hours" is too simplistic an example. I get that "1 year 2 months"
is just months. I think the arguments still stand: non-standard, limited scope,
and achievable with
wangyum commented on pull request #28734:
URL: https://github.com/apache/spark/pull/28734#issuecomment-641355129
I encountered this issue when inferring from inequality attributes before,
Its order may change:
tgravescs commented on pull request #27636:
URL: https://github.com/apache/spark/pull/27636#issuecomment-640883318
sorry I haven't had time to look at this more. It will not go into spark 3.0
as that is very close to shipping.
AmplabJenkins removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640721541
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cloud-fan closed pull request #28763:
URL: https://github.com/apache/spark/pull/28763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AmplabJenkins commented on pull request #28759:
URL: https://github.com/apache/spark/pull/28759#issuecomment-640931144
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #27246:
URL: https://github.com/apache/spark/pull/27246#discussion_r437068044
##
File path:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java
##
@@ -47,55 +47,48 @@
private int
bart-samwel commented on pull request #24195:
URL: https://github.com/apache/spark/pull/24195#issuecomment-640702776
@MaxGekk How are we on the rebase function ("get me the same date + hands of
the clock in a different timezone") that we talked about at some point?
fqaiser94 commented on pull request #27066:
URL: https://github.com/apache/spark/pull/27066#issuecomment-640747267
@cloud-fan
Thanks for your PR. I've merged your changes into this branch with some
modifications in order to pass the tests.
> Remove the SQL API. It's unclear
srowen commented on pull request #28258:
URL: https://github.com/apache/spark/pull/28258#issuecomment-640626064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
attilapiros commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r436664435
##
File path:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala
##
@@ -148,6 +170,87 @@ private[spark] class
iRakson commented on a change in pull request #28748:
URL: https://github.com/apache/spark/pull/28748#discussion_r437339866
##
File path:
streaming/src/test/scala/org/apache/spark/streaming/UISeleniumSuite.scala
##
@@ -125,24 +125,37 @@ class UISeleniumSuite
//
wangyum commented on pull request #18323:
URL: https://github.com/apache/spark/pull/18323#issuecomment-640956580
@maropu Please take it over. Thank you.
This is an automated message from the Apache Git Service.
To respond to
SaurabhChawla100 commented on pull request #28768:
URL: https://github.com/apache/spark/pull/28768#issuecomment-641181106
cc @HeartSaVioR, @srowen @HyukjinKwon @dongjoon-hyun
Please review this PR
This is an
HeartSaVioR opened a new pull request #28763:
URL: https://github.com/apache/spark/pull/28763
### What changes were proposed in this pull request?
SPARK-28199 (#24996) made the trigger related public API to be exposed only
from static methods of Trigger class. This is backward
SparkQA removed a comment on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640724799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA removed a comment on pull request #28750:
URL: https://github.com/apache/spark/pull/28750#issuecomment-640450409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
prakharjain09 edited a comment on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-641023747
@holdenk @jiangxb1987 @Dooyoung-Hwang Please review the changes.
> LGTM expect 2 minor comments, cc @holdenk @jiangxb1987
HyukjinKwon edited a comment on pull request #28752:
URL: https://github.com/apache/spark/pull/28752#issuecomment-641018513
@gengliangwang too FYI
This is an automated message from the Apache Git Service.
To respond to the
maropu opened a new pull request #28764:
URL: https://github.com/apache/spark/pull/28764
### What changes were proposed in this pull request?
This PR intends to add a build-in SQL function - `WIDTH_BUCKET`.
It is the rework of #28148
Closes #18323
The
HyukjinKwon commented on a change in pull request #24996:
URL: https://github.com/apache/spark/pull/24996#discussion_r437126007
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/Triggers.scala
##
@@ -17,13 +17,94 @@
package
yaooqinn commented on pull request #28751:
URL: https://github.com/apache/spark/pull/28751#issuecomment-641246775
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tgravescs commented on a change in pull request #28742:
URL: https://github.com/apache/spark/pull/28742#discussion_r436746988
##
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##
@@ -715,7 +715,9 @@ private[deploy] class Master(
val
zhengruifeng commented on a change in pull request #28710:
URL: https://github.com/apache/spark/pull/28710#discussion_r437111620
##
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/ClassificationSummary.scala
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the
SparkQA removed a comment on pull request #27986:
URL: https://github.com/apache/spark/pull/27986#issuecomment-640462670
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SparkQA commented on pull request #28742:
URL: https://github.com/apache/spark/pull/28742#issuecomment-640763282
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wangyum closed pull request #18323:
URL: https://github.com/apache/spark/pull/18323
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
SparkQA commented on pull request #28743:
URL: https://github.com/apache/spark/pull/28743#issuecomment-640724799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Ngone51 opened a new pull request #28756:
URL: https://github.com/apache/spark/pull/28756
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
redsanket commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437529862
##
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##
@@ -1197,6 +1213,71 @@ private[history] class
yaooqinn opened a new pull request #28766:
URL: https://github.com/apache/spark/pull/28766
### What changes were proposed in this pull request?
If a datetime pattern contains no year field, the day of year field should
not be ignored if exists
e.g.
```
spark-sql>
AmplabJenkins removed a comment on pull request #28763:
URL: https://github.com/apache/spark/pull/28763#issuecomment-641003776
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA removed a comment on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-640957296
**[Test build #123661 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123661/testReport)**
for PR 28616 at commit
AmplabJenkins removed a comment on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-641313089
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins removed a comment on pull request #28755:
URL: https://github.com/apache/spark/pull/28755#issuecomment-640563320
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #27518:
URL: https://github.com/apache/spark/pull/27518#issuecomment-640641799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gengliangwang commented on a change in pull request #28733:
URL: https://github.com/apache/spark/pull/28733#discussion_r437275039
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##
@@ -198,6 +199,88 @@ trait PredicateHelper
SparkQA commented on pull request #28750:
URL: https://github.com/apache/spark/pull/28750#issuecomment-640582030
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #28616:
URL: https://github.com/apache/spark/pull/28616#issuecomment-640957296
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asfgit closed pull request #28744:
URL: https://github.com/apache/spark/pull/28744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
srowen commented on pull request #25715:
URL: https://github.com/apache/spark/pull/25715#issuecomment-640768812
I'd guess release notes for things like this (and it's marked with release
notes). Migration guide is more for when there is a non-obvious action you need
to take to deal with a
SparkQA commented on pull request #28762:
URL: https://github.com/apache/spark/pull/28762#issuecomment-640964944
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SparkQA commented on pull request #28755:
URL: https://github.com/apache/spark/pull/28755#issuecomment-640950793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AmplabJenkins removed a comment on pull request #28768:
URL: https://github.com/apache/spark/pull/28768#issuecomment-641176523
This is an automated message from the Apache Git Service.
To respond to the message, please log on
SparkQA commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-641022846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
maropu commented on a change in pull request #28750:
URL: https://github.com/apache/spark/pull/28750#discussion_r437059411
##
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##
@@ -3503,6 +3504,25 @@ class SQLQuerySuite extends QueryTest with
cloud-fan commented on pull request #28770:
URL: https://github.com/apache/spark/pull/28770#issuecomment-641244156
OK to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AmplabJenkins commented on pull request #28768:
URL: https://github.com/apache/spark/pull/28768#issuecomment-641176523
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
maropu commented on a change in pull request #28737:
URL: https://github.com/apache/spark/pull/28737#discussion_r437383349
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileScanRDDSuite.scala
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the
amit-hitachi commented on pull request #17953:
URL: https://github.com/apache/spark/pull/17953#issuecomment-641068212
@LantaoJin @gatorsmile
Any plans to merge this fix?
This is an automated message from the Apache Git
wangyum commented on a change in pull request #28733:
URL: https://github.com/apache/spark/pull/28733#discussion_r437528590
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##
@@ -545,6 +545,19 @@ object SQLConf {
.booleanConf
cloud-fan commented on pull request #27246:
URL: https://github.com/apache/spark/pull/27246#issuecomment-641310017
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on
manuzhang opened a new pull request #28770:
URL: https://github.com/apache/spark/pull/28770
### What changes were proposed in this pull request?
This reverts commit
https://github.com/apache/spark/commit/b9737c3c228f465d332e41f1ea0cece2a5f7667e
while keeping following changes
*
prakharjain09 commented on pull request #28619:
URL: https://github.com/apache/spark/pull/28619#issuecomment-641023747
@holdenk @jiangxb1987 Please review the changes.
> LGTM expect 2 minor comments, cc @holdenk @jiangxb1987
Fokko commented on pull request #28754:
URL: https://github.com/apache/spark/pull/28754#issuecomment-640558015
Required for: https://github.com/apache/spark/pull/28754
This is an automated message from the Apache Git
cloud-fan commented on a change in pull request #28645:
URL: https://github.com/apache/spark/pull/28645#discussion_r437349734
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##
@@ -2847,6 +2848,45 @@ class Analyzer(
}
}
HyukjinKwon commented on a change in pull request #27598:
URL: https://github.com/apache/spark/pull/27598#discussion_r437088507
##
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##
@@ -635,7 +635,12 @@ private[spark] class Client(
301 - 400 of 678 matches
Mail list logo