[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474396405 ## File path: core/src/test/scala/org/apache/spark/LocalSparkContext.scala ## @@ -22,12 +22,39 @@ import org.scalatest.BeforeAndAfterAll import

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27908: [SPARK-31000] Add ability to set table description via Catalog.createTable()

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #27908: URL: https://github.com/apache/spark/pull/27908#discussion_r474396096 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala ## @@ -342,6 +342,44 @@ abstract class Catalog {

[GitHub] [spark] HyukjinKwon commented on pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on pull request #29491: URL: https://github.com/apache/spark/pull/29491#issuecomment-678026095 Thank you @srowen and @nchammas. I will try to address them. This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474402625 ## File path: dev/requirements.txt ## @@ -4,3 +4,5 @@ PyGithub==1.26.0 Unidecode==0.04.19 sphinx pydata_sphinx_theme +ipython Review comment:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474402625 ## File path: dev/requirements.txt ## @@ -4,3 +4,5 @@ PyGithub==1.26.0 Unidecode==0.04.19 sphinx pydata_sphinx_theme +ipython Review comment:

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474402625 ## File path: dev/requirements.txt ## @@ -4,3 +4,5 @@ PyGithub==1.26.0 Unidecode==0.04.19 sphinx pydata_sphinx_theme +ipython Review comment:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-678031634 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474404262 ## File path: docs/README.md ## @@ -63,7 +63,7 @@ See also https://github.com/sphinx-doc/sphinx/issues/7551. --> ```sh -$ sudo pip install

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29485: [SPARK-32638][SQL] Corrects references when adding aliases in WidenSetOperationTypes

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29485: URL: https://github.com/apache/spark/pull/29485#issuecomment-678033857 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-678033737 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29485: [SPARK-32638][SQL] Corrects references when adding aliases in WidenSetOperationTypes

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29485: URL: https://github.com/apache/spark/pull/29485#issuecomment-678033857 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] gatorsmile commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
gatorsmile commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678035318 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29501: [SPARK-32676][3.0][ML] Fix double caching in KMeans/BiKMeans

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29501: URL: https://github.com/apache/spark/pull/29501#issuecomment-678019852 **[Test build #127719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127719/testReport)** for PR 29501 at commit

[GitHub] [spark] sunchao commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
sunchao commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474405043 ## File path: core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29501: [SPARK-32676][3.0][ML] Fix double caching in KMeans/BiKMeans

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29501: URL: https://github.com/apache/spark/pull/29501#issuecomment-678035248 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
SparkQA commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-678035333 **[Test build #127713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127713/testReport)** for PR 29228 at commit

[GitHub] [spark] sunchao commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
sunchao commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474405150 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileIndexSuite.scala ## @@ -290,9 +290,9 @@ class FileIndexSuite

[GitHub] [spark] AmplabJenkins commented on pull request #29501: [SPARK-32676][3.0][ML] Fix double caching in KMeans/BiKMeans

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29501: URL: https://github.com/apache/spark/pull/29501#issuecomment-678035248 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation

2020-08-20 Thread GitBox
SparkQA commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678035219 **[Test build #127721 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127721/testReport)** for PR 29484 at commit

[GitHub] [spark] SparkQA commented on pull request #29501: [SPARK-32676][3.0][ML] Fix double caching in KMeans/BiKMeans

2020-08-20 Thread GitBox
SparkQA commented on pull request #29501: URL: https://github.com/apache/spark/pull/29501#issuecomment-678035085 **[Test build #127719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127719/testReport)** for PR 29501 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474406247 ## File path: postBuild ## @@ -0,0 +1,21 @@ +#!/bin/bash Review comment: Same as https://github.com/apache/spark/pull/29491/files#r474403433.

[GitHub] [spark] AmplabJenkins commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678037255 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678037255 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] HyukjinKwon commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678036903 I think it's good to go. It's my old habit to retrigger the Jenkins tests ... This is an automated message

[GitHub] [spark] SparkQA commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
SparkQA commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678036907 **[Test build #127722 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127722/testReport)** for PR 29476 at commit

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474408984 ## File path: dev/lint-python ## @@ -196,6 +196,22 @@ function sphinx_test { return fi +# TODO(SPARK-32666): Install nbsphinx in

[GitHub] [spark] wangyum commented on a change in pull request #29475: [SPARK-32659][SQL] Replace Array with Set in InSubqueryExec

2020-08-20 Thread GitBox
wangyum commented on a change in pull request #29475: URL: https://github.com/apache/spark/pull/29475#discussion_r474412641 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala ## @@ -131,14 +131,15 @@ case class InSubqueryExec( def

[GitHub] [spark] gengliangwang closed pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
gengliangwang closed pull request #29476: URL: https://github.com/apache/spark/pull/29476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] sunchao commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
sunchao commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474413577 ## File path: core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29498: [SPARK-32674][DOC] Add suggestion for parallel directory listing in tuning doc

2020-08-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29498: URL: https://github.com/apache/spark/pull/29498#discussion_r474415183 ## File path: docs/tuning.md ## @@ -264,6 +264,13 @@ parent RDD's number of partitions. You can pass the level of parallelism as a se or set the

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29498: [SPARK-32674][DOC] Add suggestion for parallel directory listing in tuning doc

2020-08-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29498: URL: https://github.com/apache/spark/pull/29498#discussion_r474417462 ## File path: docs/tuning.md ## @@ -264,6 +264,13 @@ parent RDD's number of partitions. You can pass the level of parallelism as a se or set the

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474417504 ## File path: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ## @@ -3242,14 +3241,16 @@ class DAGSchedulerSuite extends

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474417730 ## File path: core/src/test/scala/org/apache/spark/LocalSC.scala ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474417730 ## File path: core/src/test/scala/org/apache/spark/LocalSC.scala ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29498: [SPARK-32674][DOC] Add suggestion for parallel directory listing in tuning doc

2020-08-20 Thread GitBox
dongjoon-hyun commented on a change in pull request #29498: URL: https://github.com/apache/spark/pull/29498#discussion_r474420370 ## File path: docs/tuning.md ## @@ -264,6 +264,13 @@ parent RDD's number of partitions. You can pass the level of parallelism as a se or set the

[GitHub] [spark] viirya commented on a change in pull request #29498: [SPARK-32674][DOC] Add suggestion for parallel directory listing in tuning doc

2020-08-20 Thread GitBox
viirya commented on a change in pull request #29498: URL: https://github.com/apache/spark/pull/29498#discussion_r474424652 ## File path: docs/tuning.md ## @@ -264,6 +264,13 @@ parent RDD's number of partitions. You can pass the level of parallelism as a se or set the config

[GitHub] [spark] Ngone51 commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
Ngone51 commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474392815 ## File path: core/src/test/scala/org/apache/spark/LocalSparkContext.scala ## @@ -22,12 +22,39 @@ import org.scalatest.BeforeAndAfterAll import

[GitHub] [spark] beliefer commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
beliefer commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474393092 ## File path: core/src/test/scala/org/apache/spark/LocalSparkContext.scala ## @@ -22,12 +22,39 @@ import org.scalatest.BeforeAndAfterAll import

[GitHub] [spark] viirya commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
viirya commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474393088 ## File path: core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] beliefer commented on a change in pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
beliefer commented on a change in pull request #29228: URL: https://github.com/apache/spark/pull/29228#discussion_r474392606 ## File path: core/src/test/scala/org/apache/spark/LocalSparkContext.scala ## @@ -22,12 +22,39 @@ import org.scalatest.BeforeAndAfterAll import

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474383002 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala ## @@ -147,32 +142,6 @@ class

[GitHub] [spark] zsxwing commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
zsxwing commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474397299 ## File path: core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474401807 ## File path: apt.txt ## @@ -0,0 +1 @@ +openjdk-8-jre Review comment: I can place is under `binder` directory, see

[GitHub] [spark] SparkQA removed a comment on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-678003548 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-678031692 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-08-20 Thread GitBox
SparkQA commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-678031262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] AmplabJenkins commented on pull request #29054: [SPARK-32243][SQL]HiveSessionCatalog call super.makeFunctionExpression should show error message

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29054: URL: https://github.com/apache/spark/pull/29054#issuecomment-678031634 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474403433 ## File path: apt.txt ## @@ -0,0 +1 @@ +openjdk-8-jre Review comment: It is used for Binder to install the dependencies. They launch a docker

[GitHub] [spark] gengliangwang commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
gengliangwang commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678035967 @HyukjinKwon Shall we merge this one since the github action jobs pass? This is an automated message from

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-678035815 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678035471 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-678035815 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-677997610 **[Test build #127713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127713/testReport)** for PR 29228 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-678035539 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins commented on pull request #29484: [SPARK-32649][SQL] Optimize BHJ/SHJ inner/semi join with empty hashed relation

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29484: URL: https://github.com/apache/spark/pull/29484#issuecomment-678035471 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sunchao commented on a change in pull request #29471: [SPARK-32381][CORE][SQL] Explore allowing parallel listing & non-location sensitive listing in core

2020-08-20 Thread GitBox
sunchao commented on a change in pull request #29471: URL: https://github.com/apache/spark/pull/29471#discussion_r474405605 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/InMemoryFileIndex.scala ## @@ -147,32 +142,6 @@ class

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474401807 ## File path: apt.txt ## @@ -0,0 +1 @@ +openjdk-8-jre Review comment: I can place is under `binder` directory, see

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
HyukjinKwon commented on a change in pull request #29491: URL: https://github.com/apache/spark/pull/29491#discussion_r474409863 ## File path: python/docs/source/conf.py ## @@ -45,8 +45,19 @@ 'sphinx.ext.viewcode', 'sphinx.ext.mathjax', 'sphinx.ext.autosummary',

[GitHub] [spark] HyukjinKwon commented on pull request #29495: [SPARK-32640][SQL] Downgrade Janino to fix a correctness bug

2020-08-20 Thread GitBox
HyukjinKwon commented on pull request #29495: URL: https://github.com/apache/spark/pull/29495#issuecomment-678046394 Nice, LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-678053249 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-678008837 **[Test build #127718 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127718/testReport)** for PR 28685 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-678053249 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-20 Thread GitBox
SparkQA commented on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-678053067 **[Test build #127718 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127718/testReport)** for PR 28685 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28685: [SPARK-27951][SQL] Support ANSI SQL NTH_VALUE window function

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #28685: URL: https://github.com/apache/spark/pull/28685#issuecomment-678053253 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #29487: [SPARK-32608][SQL][3.0] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29487: URL: https://github.com/apache/spark/pull/29487#issuecomment-677446556 **[Test build #127683 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127683/testReport)** for PR 29487 at commit

[GitHub] [spark] SparkQA commented on pull request #29487: [SPARK-32608][SQL][3.0] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-20 Thread GitBox
SparkQA commented on pull request #29487: URL: https://github.com/apache/spark/pull/29487#issuecomment-677667069 **[Test build #127683 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127683/testReport)** for PR 29487 at commit

[GitHub] [spark] SparkQA commented on pull request #29489: [SPARK-28863][SQL][FOLLOWUP] Do not reuse the physical plan

2020-08-20 Thread GitBox
SparkQA commented on pull request #29489: URL: https://github.com/apache/spark/pull/29489#issuecomment-677673857 **[Test build #127685 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127685/testReport)** for PR 29489 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29489: [SPARK-28863][SQL][FOLLOWUP] Do not reuse the physical plan

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29489: URL: https://github.com/apache/spark/pull/29489#issuecomment-677453659 **[Test build #127685 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127685/testReport)** for PR 29489 at commit

[GitHub] [spark] SparkQA commented on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
SparkQA commented on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-677691330 **[Test build #127688 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127688/testReport)** for PR 29476 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-677529613 **[Test build #127688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127688/testReport)** for PR 29476 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-677692144 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29476: [SPARK-32660][SQL][DOC] Show Avro related API in documentation

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29476: URL: https://github.com/apache/spark/pull/29476#issuecomment-677692158 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] LuciferYang commented on a change in pull request #29434: [SPARK-32526][SQL] Pass all test of sql/catalyst module in Scala 2.13

2020-08-20 Thread GitBox
LuciferYang commented on a change in pull request #29434: URL: https://github.com/apache/spark/pull/29434#discussion_r474070475 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/StarJoinCostBasedReorderSuite.scala ## @@ -329,7 +329,7 @@ class

[GitHub] [spark] SparkQA removed a comment on pull request #29491: [SPARK-32204][SPARK-32182][DOCS] Add a quickstart page with Binder integration in PySpark documentation

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29491: URL: https://github.com/apache/spark/pull/29491#issuecomment-677647766 **[Test build #127693 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127693/testReport)** for PR 29491 at commit

[GitHub] [spark] kiszk commented on pull request #29407: [SPARK-32588][CORE][TEST] Fix SizeEstimator initialization in tests

2020-08-20 Thread GitBox
kiszk commented on pull request #29407: URL: https://github.com/apache/spark/pull/29407#issuecomment-677745043 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] AmplabJenkins commented on pull request #29407: [SPARK-32588][CORE][TEST] Fix SizeEstimator initialization in tests

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29407: URL: https://github.com/apache/spark/pull/29407#issuecomment-677745888 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29421: [SPARK-32388][SQL] TRANSFORM with schema-less mode should keep the same with hive

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29421: URL: https://github.com/apache/spark/pull/29421#issuecomment-677538340 **[Test build #127691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127691/testReport)** for PR 29421 at commit

[GitHub] [spark] SparkQA commented on pull request #29421: [SPARK-32388][SQL] TRANSFORM with schema-less mode should keep the same with hive

2020-08-20 Thread GitBox
SparkQA commented on pull request #29421: URL: https://github.com/apache/spark/pull/29421#issuecomment-677755758 **[Test build #127691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127691/testReport)** for PR 29421 at commit

[GitHub] [spark] SparkQA commented on pull request #29364: [SPARK-32548][SQL] - Add Application attemptId support to SQL Rest API

2020-08-20 Thread GitBox
SparkQA commented on pull request #29364: URL: https://github.com/apache/spark/pull/29364#issuecomment-69357 **[Test build #127697 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127697/testReport)** for PR 29364 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29452: [SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-677784533 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29452: [SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-677784533 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] huaxingao commented on a change in pull request #29482: [SPARK-32662][MLLib] CountVectorizerModel: Remove requirement for minimum Vocab size

2020-08-20 Thread GitBox
huaxingao commented on a change in pull request #29482: URL: https://github.com/apache/spark/pull/29482#discussion_r474144300 ## File path: mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ## @@ -305,4 +290,63 @@ class CountVectorizerSuite extends

[GitHub] [spark] andygrove opened a new pull request #29494: Fix race condition in MapOutputTracker.getStatistics

2020-08-20 Thread GitBox
andygrove opened a new pull request #29494: URL: https://github.com/apache/spark/pull/29494 ### What changes were proposed in this pull request? Make MapOutputTracker.getStatistics thread-safe and deterministic. ### Why are the changes needed? We have unit tests such as

[GitHub] [spark] AmplabJenkins commented on pull request #29487: [SPARK-32608][SQL][3.0] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29487: URL: https://github.com/apache/spark/pull/29487#issuecomment-677668273 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29487: [SPARK-32608][SQL][3.0] Script Transform ROW FORMAT DELIMIT value should format value

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29487: URL: https://github.com/apache/spark/pull/29487#issuecomment-677668273 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29489: [SPARK-28863][SQL][FOLLOWUP] Do not reuse the physical plan

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29489: URL: https://github.com/apache/spark/pull/29489#issuecomment-677675308 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29490: [SPARK-32668][SQL] HiveGenericUDTF initialize UDTF should use StructObjectInspector method

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29490: URL: https://github.com/apache/spark/pull/29490#issuecomment-677644291 **[Test build #127692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127692/testReport)** for PR 29490 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29490: [SPARK-32668][SQL] HiveGenericUDTF initialize UDTF should use StructObjectInspector method

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29490: URL: https://github.com/apache/spark/pull/29490#issuecomment-677684620 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29490: [SPARK-32668][SQL] HiveGenericUDTF initialize UDTF should use StructObjectInspector method

2020-08-20 Thread GitBox
SparkQA commented on pull request #29490: URL: https://github.com/apache/spark/pull/29490#issuecomment-677684334 **[Test build #127692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127692/testReport)** for PR 29490 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-677689536 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on pull request #29407: [SPARK-32588][CORE][TEST] Fix SizeEstimator initialization in tests

2020-08-20 Thread GitBox
SparkQA commented on pull request #29407: URL: https://github.com/apache/spark/pull/29407#issuecomment-677749300 **[Test build #127696 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127696/testReport)** for PR 29407 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #29421: [SPARK-32388][SQL] TRANSFORM with schema-less mode should keep the same with hive

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29421: URL: https://github.com/apache/spark/pull/29421#issuecomment-677756960 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29452: [SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-677784554 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #29452: [SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-20 Thread GitBox
SparkQA removed a comment on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-677782901 **[Test build #127699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127699/testReport)** for PR 29452 at commit

[GitHub] [spark] SparkQA commented on pull request #29452: [SPARK-32643][CORE][K8s] Consolidate state decommissioning in the TaskSchedulerImpl realm

2020-08-20 Thread GitBox
SparkQA commented on pull request #29452: URL: https://github.com/apache/spark/pull/29452#issuecomment-677785943 **[Test build #127699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/127699/testReport)** for PR 29452 at commit

[GitHub] [spark] purijatin commented on a change in pull request #29482: [SPARK-32662][ML] CountVectorizerModel: Remove requirement for minimum Vocab size

2020-08-20 Thread GitBox
purijatin commented on a change in pull request #29482: URL: https://github.com/apache/spark/pull/29482#discussion_r474145796 ## File path: mllib/src/main/scala/org/apache/spark/ml/feature/CountVectorizer.scala ## @@ -241,7 +241,9 @@ class CountVectorizer @Since("1.5.0")

[GitHub] [spark] AmplabJenkins commented on pull request #29494: SPARK-32671: [CORE] Fix race condition in MapOutputTracker.getStatistics

2020-08-20 Thread GitBox
AmplabJenkins commented on pull request #29494: URL: https://github.com/apache/spark/pull/29494#issuecomment-677790221 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To

[GitHub] [spark] andygrove commented on pull request #29494: SPARK-32671: [CORE] Fix race condition in MapOutputTracker.getStatistics

2020-08-20 Thread GitBox
andygrove commented on pull request #29494: URL: https://github.com/apache/spark/pull/29494#issuecomment-677790127 @tgravescs fyi This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] kiszk edited a comment on pull request #29486: Typo in ShuffleMapStage.scala

2020-08-20 Thread GitBox
kiszk edited a comment on pull request #29486: URL: https://github.com/apache/spark/pull/29486#issuecomment-677627508 Also, we are sure there is the same typo in other files. This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29228: [SPARK-31847][CORE][TESTS] DAGSchedulerSuite: Rewrite the test framework to support apply specified spark configurations.

2020-08-20 Thread GitBox
AmplabJenkins removed a comment on pull request #29228: URL: https://github.com/apache/spark/pull/29228#issuecomment-677689531 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

  1   2   3   4   5   6   7   >