[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755784540 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -156,9 +156,16 @@ class

[GitHub] [spark] cloud-fan commented on a change in pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

cloud-fan commented on a change in pull request #34060: URL: https://github.com/apache/spark/pull/34060#discussion_r755786855 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala ## @@ -189,17 +190,35 @@ trait

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755788709 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755790090 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala ## @@ -44,7 +45,8 @@ import

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755788709 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

cloud-fan commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755791057 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755792043 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@

[GitHub] [spark] cloud-fan closed pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

cloud-fan closed pull request #34668: URL: https://github.com/apache/spark/pull/34668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

cloud-fan commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977635547 thanks, merging to master/3.2! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #29024: [SPARK-32001][SQL]Create JDBC authentication provider developer API

gaborgsomogyi commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r755792043 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala ## @@ -18,60 +18,45 @@

[GitHub] [spark] cloud-fan commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

cloud-fan commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977636986 @beliefer can you open backport PRs for 3.1/3.0? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] cloud-fan commented on pull request #34694: [MINOR][DOCS] Fix scaladoc for skewed partitions optimization

cloud-fan commented on pull request #34694: URL: https://github.com/apache/spark/pull/34694#issuecomment-977637885 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] cloud-fan closed pull request #34694: [MINOR][DOCS] Fix scaladoc for skewed partitions optimization

cloud-fan closed pull request #34694: URL: https://github.com/apache/spark/pull/34694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] SparkQA commented on pull request #34060: [SPARK-36850][SQL] Migrate CreateTableStatement to v2 command framework

SparkQA commented on pull request #34060: URL: https://github.com/apache/spark/pull/34060#issuecomment-977642156 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50040/ -- This is an automated message from the

[GitHub] [spark] beliefer commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

beliefer commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977647936 > @beliefer can you open backport PRs for 3.1/3.0? thanks! OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] beliefer commented on pull request #34668: [SPARK-37389][SQL] Check unclosed bracketed comments

beliefer commented on pull request #34668: URL: https://github.com/apache/spark/pull/34668#issuecomment-977646762 @cloud-fan Thanks a lot for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] zhengruifeng commented on pull request #34504: [SPARK-37226][SQL] Filter push down through window if partitionSpec isEmpty

zhengruifeng commented on pull request #34504: URL: https://github.com/apache/spark/pull/34504#issuecomment-977648570 > @zhengruifeng can you highlight the differences between your PR and this one? IMHO, there are two main differences: 1, a new node `RankLimit` is introduced,

[GitHub] [spark] SparkQA removed a comment on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

SparkQA removed a comment on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-977559042 **[Test build #145563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145563/testReport)** for PR 34695 at commit

[GitHub] [spark] SparkQA commented on pull request #34695: [WIP][SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

SparkQA commented on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-977653859 **[Test build #145563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145563/testReport)** for PR 34695 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #34684: [SPARK-37442][SQL] InMemoryRelation statistics bug causing broadcast join failures with AQE enabled

cloud-fan commented on a change in pull request #34684: URL: https://github.com/apache/spark/pull/34684#discussion_r755811926 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala ## @@ -259,6 +259,12 @@ case class

[GitHub] [spark] SparkQA commented on pull request #34689: [SPARK-37445][BUILD] Upgrade hadoop profile to hadoop-3.3 since we support hadoop-3.3 as default now

SparkQA commented on pull request #34689: URL: https://github.com/apache/spark/pull/34689#issuecomment-977656998 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50039/ -- This is an automated message from the

[GitHub] [spark] imback82 commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

imback82 commented on a change in pull request #34686: URL: https://github.com/apache/spark/pull/34686#discussion_r755814962 ## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ## @@ -1294,13 +1294,25 @@ class DataSourceV2SQLSuite

<    2   3   4   5   6   7