Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67811183
[Test build #24699 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24699/consoleFull)
for PR 3758 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67811187
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
GitHub user luogankun opened a pull request:
https://github.com/apache/spark/pull/3759
[SPARK-4916][SQL][DOCS]Update SQL programming guide about cache section
`SchemeRDD.cache()` now uses in-memory columnar storage.
You can merge this pull request into a Git repository by running:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3759#issuecomment-67811391
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user maropu opened a pull request:
https://github.com/apache/spark/pull/3760
[SPARK-4917] Add a function to convert into a graph with canonical edges in
GraphOps
Convert bi-directional edges into uni-directional ones instead of
'canonicalOrientation' in
Github user loachli commented on the pull request:
https://github.com/apache/spark/pull/1290#issuecomment-67812105
@avulanov: *Could you write a brief description to the ANN test called
Gradient of ANN to let the reader understand more clearly what we are
testing?*
The test
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3760#issuecomment-67812097
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67814128
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67814308
Ah, sorry, forgot that the golden answer file name is generated by the MD5
of the query string. Then let's revert the last space change. I think this
minor issue
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67814511
[Test build #24700 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24700/consoleFull)
for PR 3758 at commit
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/3761
[SQL] spark-sql aborted if passed in a wrong sql
If we passed in a wrong sql like ```abdcdfsfs```, the spark-sql script
aborted.
You can merge this pull request into a Git repository by running:
Github user FlytxtRnD commented on the pull request:
https://github.com/apache/spark/pull/3022#issuecomment-67816287
Sorry for late reply.predictLabels() and predictMembership() looks fine.But
what about moving the computeSoftAssignments() to GaussianMixtureModelEM
class(in KMeans,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67816416
[Test build #24701 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24701/consoleFull)
for PR 3761 at commit
Github user WangTaoTheTonic commented on the pull request:
https://github.com/apache/spark/pull/3607#issuecomment-67816606
@andrewor14 Ok, I got what you mean. I think I have a misunderstanding
before.
To solve this problem, should we just delete `(--driver-memory,
Github user YanTangZhai commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67816709
@liancheng I will revert the last space change. Thanks for your comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67817199
[Test build #24702 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24702/consoleFull)
for PR 3555 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67818470
[Test build #24703 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24703/consoleFull)
for PR 3761 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3752#discussion_r22159720
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -55,8 +56,60 @@ private[hive] class
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3752#discussion_r22160548
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -55,8 +56,60 @@ private[hive] class
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67822551
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67822544
[Test build #24701 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24701/consoleFull)
for PR 3761 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67822642
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67822635
[Test build #24700 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24700/consoleFull)
for PR 3758 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/3752#discussion_r22161200
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -55,8 +56,60 @@ private[hive] class
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67823381
[Test build #24702 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24702/consoleFull)
for PR 3555 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67823389
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67824715
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3761#issuecomment-67824711
[Test build #24703 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24703/consoleFull)
for PR 3761 at commit
Github user bryanyang0528 commented on the pull request:
https://github.com/apache/spark/pull/3746#issuecomment-67825123
On my opinion, I don't think the parameter of the cost function is 1/m or
1/2m is the critical deference.
Across the cost function L = alpha * 1/2n ||A
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3746#issuecomment-67826137
@bryanyang0528 I don't think anyone's suggesting that the extra factor of
1/2 is more or less correct or desirable per se. The solution doesn't depend on
the absolute
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3555#issuecomment-67827365
Thanks for the update, this now LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user FlytxtRnD commented on a diff in the pull request:
https://github.com/apache/spark/pull/3022#discussion_r22163213
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/DenseGmmEM.scala ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user FlytxtRnD commented on a diff in the pull request:
https://github.com/apache/spark/pull/3022#discussion_r22163250
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala
---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/3762
Reuse Text in saveAsTextFile
Reuse Text in saveAsTextFile to reduce GC.
/cc @rxin
You can merge this pull request into a Git repository by running:
$ git pull
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67832465
[Test build #24704 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24704/consoleFull)
for PR 3762 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67832813
I think it's a small but OK optimization. Hadoop won't save the `Text`
object itself, so it's safe, here in the 'save' method.
---
If your project is set up for it, you
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67834037
Looks there is some issue in HiveThriftServer2 in the branch-1.2?
@liancheng
```
Exception in thread main java.lang.RuntimeException:
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67834393
This is probably caused by SPARK-4914, which is a bug in `dev/run-tests`
and doesn't affect production code. PR #3756 was opened to fix this.
---
If your project is
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3756#issuecomment-67834656
@pwendell @JoshRosen Would you please take a look at this? This issue is
causing random PR build failures. Thanks!
---
If your project is set up for it, you can reply
Github user bryanyang0528 commented on the pull request:
https://github.com/apache/spark/pull/3746#issuecomment-67836176
@srowen I agree on that need a absolute value can be compared with others
software. Maybe it would add a parameter to control the extra factor?
---
If your
Github user helena commented on the pull request:
https://github.com/apache/spark/pull/3631#issuecomment-67836412
@JoshRosen Ticket name updated :) Sorry for the delay, I was away.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67839700
[Test build #24704 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24704/consoleFull)
for PR 3762 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67839708
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/3746#issuecomment-67842962
@bryanyang0528 The learning rate issue here is different story. With modern
optimization algorithms like LBFGS and OWLQN, the learning rate is not
required. The
Github user bryanyang0528 commented on the pull request:
https://github.com/apache/spark/pull/3746#issuecomment-67847818
@dbtsai Thank you for your clear explanation which helps me alot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user witgo commented on a diff in the pull request:
https://github.com/apache/spark/pull/1518#discussion_r22171070
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/Regularizer.scala ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
GitHub user uncleGen opened a pull request:
https://github.com/apache/spark/pull/3763
[SPARK-4920][UI]:current spark version in UI is not striking.
It is not convenient to see the Spark version. We can keep the same style
with Spark website.
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/1518#discussion_r22173571
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/Regularizer.scala ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3763#issuecomment-67852386
[Test build #24705 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24705/consoleFull)
for PR 3763 at commit
GitHub user jbencook opened a pull request:
https://github.com/apache/spark/pull/3764
[SPARK-4860][pyspark][sql] speeding up `sample()` and `takeSample()`
This PR modifies the python `SchemaRDD` to use `sample()` and
`takeSample()` from Scala instead of the slower python
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3764#issuecomment-67860230
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sryza commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67860552
Great idea, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3763#issuecomment-67863235
[Test build #24705 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24705/consoleFull)
for PR 3763 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3763#issuecomment-67863240
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67868189
Hmm, guess I missed this in my testing.
Anyway, I think this is the wrong place for the fix. The right fix in my
view should be in `SparkDeploySchedulerBackend`,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1222#issuecomment-67868333
Thanks Josh!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3686#issuecomment-67869210
It says it's standalone mode only because it's never been implemented
anywhere else. You're now implementing it for Yarn, I don't see a reason why
you wouldn't just reuse
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67870864
Here's what I think is a better approach, feel free to use / adapt it:
https://gist.github.com/vanzin/e1910b11ce00630fe9d4
---
If your project is set up for it, you
Github user ash211 commented on the pull request:
https://github.com/apache/spark/pull/3751#issuecomment-67871664
This is a very minor change -- do we need a Jira ticket for it?
Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/1379#issuecomment-67872100
@dbtsai I did local experiment on mnist and your new implementation seems
to be more than 2x faster than the previous one! I am going to perform bigger
experiments. In
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3764#issuecomment-67875459
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3752#discussion_r22183385
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -55,8 +56,60 @@ private[hive] class HiveMetastoreCatalog(hive:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3764#issuecomment-67875679
[Test build #24706 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24706/consoleFull)
for PR 3764 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3702#discussion_r22183573
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
---
@@ -28,9 +28,23 @@ import
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3702#discussion_r22183579
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetricsSuite.scala
---
@@ -124,4 +124,36 @@ class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3702#discussion_r22183575
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetrics.scala
---
@@ -103,7 +117,37 @@ class
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3702#discussion_r22183580
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/evaluation/BinaryClassificationMetricsSuite.scala
---
@@ -124,4 +124,36 @@ class
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3702#issuecomment-67876179
@srowen The logic test look fine; I just added a couple of comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3752#issuecomment-67876256
[Test build #24707 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24707/consoleFull)
for PR 3752 at commit
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3686#issuecomment-67876245
So, after actually reading the code :-), the current implementation uses
`spark.yarn.am.cores` for both client and cluster mode.
I think that's bad, because if
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3752#discussion_r22183673
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -55,8 +56,60 @@ private[hive] class HiveMetastoreCatalog(hive:
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3752#issuecomment-67876806
[Test build #24708 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24708/consoleFull)
for PR 3752 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3760#issuecomment-67876851
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67876912
I'm merging this since I really only wanted to check for compilation.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67877038
retest this please
@vanzin I believe we separated the definition of `isEventLogEnabled` from
that of `eventLogger` because of the following initialization
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3758#issuecomment-67877226
Alright I've merged this. Do you mind closing the PR? Github doesn't close
it unless the commit is merged into master.
---
If your project is set up for it, you can reply
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67877360
I see. Hmm. That sucks. :-/ A comment there would help at least, but even
better would be to avoid this tight coupling altogether.
---
If your project is set up for it,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3760#issuecomment-67877352
[Test build #24709 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24709/consoleFull)
for PR 3760 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3762#issuecomment-67877459
LGTM. Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67877780
Hey @viirya I believe the right fix here is to change the `eventLogFile`
field back to an `eventLogDir` (because it refers to the base logging
directory, not the
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r22184450
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -77,6 +80,17 @@ class GradientDescent private[mllib]
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3610#issuecomment-67877997
failure in a streaming test...retesting
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3610#issuecomment-67878052
[Test build #551 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/551/consoleFull)
for PR 3610 at commit
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3610#discussion_r22184615
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala ---
@@ -43,13 +43,14 @@ class KMeans private (
private var runs:
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3763#issuecomment-67878388
+1. I also thought the bottom greyed out text is too obscure. @JoshRosen
any thoughts?
---
If your project is set up for it, you can reply to this email and have
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3757#issuecomment-67878534
I'm merging this since this is just docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3757#issuecomment-67878503
[Test build #24710 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24710/consoleFull)
for PR 3757 at commit
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3757#issuecomment-67878474
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3757#issuecomment-67878448
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3022#discussion_r22184915
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModel.scala
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67878956
Andrew's suggestion sounds good. Long term, I think it would be better to
send this log path later (as some sort of application stopping message
maybe?), instead of
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3733#issuecomment-67878993
No worries. Once you make those changes I will merge this. By the way for
issues as minor as this one I don't think filing a JIRA is necessary. I would
just put
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3022#discussion_r22185023
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModelEM.scala
---
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3717#issuecomment-67879567
This looks fine. I'm going to tweak the log format a little bit when I
merge it. Thanks
---
If your project is set up for it, you can reply to this email and have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3717
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3022#discussion_r22185641
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/GaussianMixtureModelEM.scala
---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3022#issuecomment-67880399
@tgaloppo MLUtils.EPSILON is actually private[util]. I think it would be
fine to change it to be private[mllib]. CC: @mengxr
@tgaloppo I strongly recommend
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3755#issuecomment-67880836
For instance...
https://github.com/andrewor14/spark/compare/fix-event-log-suggestion
---
If your project is set up for it, you can reply to this email and have your
1 - 100 of 322 matches
Mail list logo
