[GitHub] spark pull request: Spark-5854 personalized page rank

2015-03-05 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4774#issuecomment-77434500 I think this change actually introduces binary incompatability even though you have only added optional args. It may be source compatible. --- If your project is set up

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread leahmcguire
Github user leahmcguire commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77435497 I made all the inline fixes and integrated the model type fix. If you can provide me with a bit more guidance on the save/load I am happy to do it. --- If your

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4904#issuecomment-77436434 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77439573 [Test build #28306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28306/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77439367 [Test build #28306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28306/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-6175] Fix standalone executor log links...

2015-03-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4903#issuecomment-77439543 @nchammas It's not related; this is concerned with cases where links in the web UI use internal addresses rather than the public addresses configured through the

[GitHub] spark pull request: SPARK-1706: Allow multiple executors per worke...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/731#issuecomment-77430389 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-1892][MLLIB] Adding OWL-QN optimizer fo...

2015-03-05 Thread codedeft
Github user codedeft closed the pull request at: https://github.com/apache/spark/pull/840 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77439577 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4918#issuecomment-77443873 [Test build #28307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28307/consoleFull) for PR 4918 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77435746 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4904#issuecomment-77437439 [Test build #28305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28305/consoleFull) for PR 4904 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77438045 [Test build #28303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28303/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/4918 [SPARK-6145][SQL] fix ORDER BY on nested fields Based on #4904 with style errors fixed. `LogicalPlan#resolve` will not only produce `Attribute`, but also `GetField` chain. So in

[GitHub] spark pull request: SPARK-6182 [BUILD] spark-parent pom needs to b...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4912 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77435740 [Test build #28304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28304/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77435559 [Test build #28304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28304/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4904#issuecomment-77437661 [Test build #28305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28305/consoleFull) for PR 4904 at commit

[GitHub] spark pull request: [SPARK-6175] Fix standalone executor log links...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: Spark-5854 personalized page rank

2015-03-05 Thread dwmclary
Github user dwmclary commented on the pull request: https://github.com/apache/spark/pull/4774#issuecomment-77436963 OK, thanks Sean, that was my reading of it too. On Thu, Mar 5, 2015 at 11:32 AM, Sean Owen notificati...@github.com wrote: I think this change actually

[GitHub] spark pull request: [SPARK-6175] Fix standalone executor log links...

2015-03-05 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4903#issuecomment-77438026 Does this PR relate at all to #4038, which tries to fix `spark-ec2` clusters launched into a private VPC with no public IPs? --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-6090][MLLIB] add a basic BinaryClassifi...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4863 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77438052 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6175] Fix standalone executor log links...

2015-03-05 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4903#issuecomment-77439058 LGTM, feel free to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4904#issuecomment-77437670 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-6090][MLLIB] add a basic BinaryClassifi...

2015-03-05 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4863#issuecomment-77437985 Merged into master:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/4904#issuecomment-77443846 Since I'd really like to include this in the next RC, I've opened #4918 with the style error fixed. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: Spark-5854 personalized page rank

2015-03-05 Thread dwmclary
Github user dwmclary commented on the pull request: https://github.com/apache/spark/pull/4774#issuecomment-77433149 I'm not really sure what to do about this MiMa error. Suggestions? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-6175] Fix standalone executor log links...

2015-03-05 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/4903#issuecomment-77440487 I ran some manual tests, too, using ```scala SPARK_PUBLIC_DNS=helloworld ./bin/spark-shell --master local-cluster[2,2,512] ``` and verified

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4920 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914094 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -540,6 +565,28 @@ private[spark] class Client( amContainer }

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4920#issuecomment-77468665 [Test build #28317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28317/consoleFull) for PR 4920 at commit

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77468934 [Test build #28316 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28316/consoleFull) for PR 4087 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-77468922 [Test build #28314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28314/consoleFull) for PR 4688 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25911554 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -40,7 +40,8 @@ import scala.collection.JavaConversions._ */

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25911695 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -122,6 +126,14 @@ class SparkHadoopUtil extends Logging { }

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913541 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala --- @@ -234,9 +236,14 @@ class

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-77477310 [Test build #28318 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28318/consoleFull) for PR 4688 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913696 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -215,8 +223,10 @@ private[spark] class Client( // and add them as local

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914185 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -17,15 +17,23 @@ package org.apache.spark.deploy.yarn

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914223 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -17,15 +17,23 @@ package org.apache.spark.deploy.yarn

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914682 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914669 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4920#issuecomment-77479829 [Test build #28317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28317/consoleFull) for PR 4920 at commit

[GitHub] spark pull request: Added Companion Object for LogisticRegressionW...

2015-03-05 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4915#issuecomment-77482210 @kazk1018 We try to avoid using static `train` methods, which are hard to maintain. Please use setters and `run` instead. Do you mind closing this PR? --- If your

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/4920#issuecomment-77469474 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25911853 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -372,6 +372,8 @@ object SparkSubmit { OptionAssigner(args.files,

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25911813 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -410,6 +412,14 @@ private[spark] class SparkSubmitArguments(args:

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913763 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -372,6 +372,8 @@ object SparkSubmit {

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914375 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -43,6 +51,18 @@ import org.apache.spark.util.Utils */

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914285 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -43,6 +51,18 @@ import org.apache.spark.util.Utils */

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914519 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914836 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914874 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914735 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25915171 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/4920 [SQL] Make Strategies a public developer API You can merge this pull request into a Git repository by running: $ git pull https://github.com/marmbrus/spark openStrategies Alternatively you

[GitHub] spark pull request: [SPARK-6163][SQL] jsonFile should be backed by...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4896 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4918 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913566 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala --- @@ -256,6 +256,7 @@ private[spark] class ApplicationMaster(

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913622 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -61,12 +64,15 @@ private[spark] class Client( private val

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913605 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -17,12 +17,15 @@ package org.apache.spark.deploy.yarn

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914473 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25914706 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [SQL] Make Strategies a public developer API

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4920#issuecomment-77479836 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25915081 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [GraphX] Improve LiveJournalPageRank example

2015-03-05 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/spark/pull/4917#discussion_r25915980 --- Diff: examples/src/main/scala/org/apache/spark/examples/graphx/LiveJournalPageRank.scala --- @@ -17,11 +17,6 @@ package

[GitHub] spark pull request: [SPARK-6095] [MLLIB] Support model save/load i...

2015-03-05 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/4911#issuecomment-77482527 @yanboliang The model import/export is designed to cross languages. If we save a model in Scala, it should be loadable in Python. This help us lower the maintenance cost.

[GitHub] spark pull request: [core] [minor] Don't pollute source directory ...

2015-03-05 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/4921 [core] [minor] Don't pollute source directory when running UtilsSuite. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vanzin/spark utils-suite

[GitHub] spark pull request: [SPARK-6193] [EC2] Push group filter up to EC2

2015-03-05 Thread nchammas
GitHub user nchammas opened a pull request: https://github.com/apache/spark/pull/4922 [SPARK-6193] [EC2] Push group filter up to EC2 When looking for a cluster, spark-ec2 currently pulls down [info for all

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/4918#discussion_r25918626 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1049,4 +1049,14 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25919873 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-6177][MLlib] LDA should check partition...

2015-03-05 Thread hhbyyh
Github user hhbyyh commented on the pull request: https://github.com/apache/spark/pull/4899#issuecomment-77491892 @srowen @jkbradley Thanks for review. I'm not sure about that `coalesce` always introduce shuffle, given its signature is `def coalesce(numPartitions: Int,

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25920703 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] spark pull request: [SPARK-6122][Core] Upgrade Tachyon client vers...

2015-03-05 Thread haoyuan
Github user haoyuan commented on the pull request: https://github.com/apache/spark/pull/4867#issuecomment-77493071 Ok to test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread CodingCat
Github user CodingCat commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25922492 --- Diff: core/src/test/scala/org/apache/spark/rpc/akka/AkkaRpcEnvSuite.scala --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-5908][SQL] Resolve UdtfsAlias when only...

2015-03-05 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/4692#issuecomment-77513338 @marmbrus, @liancheng May you take a look of this pr? It should be straightforward. Thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4588#issuecomment-77514027 [Test build #28329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28329/consoleFull) for PR 4588 at commit

[GitHub] spark pull request: [SPARK-5205][Streaming]:Inconsistent behaviour...

2015-03-05 Thread uncleGen
Github user uncleGen commented on the pull request: https://github.com/apache/spark/pull/4135#issuecomment-77514182 @pwendell Could you please take a look again, thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25928143 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-6196][build]Add MAPR 4.0.2 support to t...

2015-03-05 Thread trystanleftwich
GitHub user trystanleftwich opened a pull request: https://github.com/apache/spark/pull/4928 [SPARK-6196][build]Add MAPR 4.0.2 support to the build You can merge this pull request into a Git repository by running: $ git pull https://github.com/AtScaleInc/spark master

[GitHub] spark pull request: [SPARK-6196][build]Add MAPR 4.0.2 support to t...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4928#issuecomment-77515114 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4588#issuecomment-77515162 [Test build #28330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28330/consoleFull) for PR 4588 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-77468930 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4894][mllib] Added Bernoulli option to ...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4087#issuecomment-77468944 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25911896 --- Diff: core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala --- @@ -17,6 +17,7 @@ package org.apache.spark.executor

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913894 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -540,6 +565,28 @@ private[spark] class Client( amContainer }

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25913913 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -540,6 +565,28 @@ private[spark] class Client( amContainer }

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/4688#discussion_r25916219 --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala --- @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends

[GitHub] spark pull request: [GraphX] Improve LiveJournalPageRank example

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4917#issuecomment-77482300 [Test build #28319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28319/consoleFull) for PR 4917 at commit

[GitHub] spark pull request: [core] [minor] Don't pollute source directory ...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4921#issuecomment-77485707 [Test build #28320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28320/consoleFull) for PR 4921 at commit

[GitHub] spark pull request: [SPARK-6145][SQL] fix ORDER BY on nested field...

2015-03-05 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/4918#discussion_r25918187 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1049,4 +1049,14 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-6193] [EC2] Push group filter up to EC2

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4922#issuecomment-77486987 [Test build #28321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28321/consoleFull) for PR 4922 at commit

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-77486982 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-5342][YARN] Allow long running Spark ap...

2015-03-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4688#issuecomment-77486977 [Test build #28318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28318/consoleFull) for PR 4688 at commit

[GitHub] spark pull request: [SPARK-6193] [EC2] Push group filter up to EC2

2015-03-05 Thread nchammas
Github user nchammas commented on the pull request: https://github.com/apache/spark/pull/4922#issuecomment-77487835 cc @shivaram --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [GraphX] Improve LiveJournalPageRank example

2015-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4917#issuecomment-77491411 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: Added Companion Object for LogisticRegressionW...

2015-03-05 Thread kazk1018
Github user kazk1018 commented on the pull request: https://github.com/apache/spark/pull/4915#issuecomment-77492665 @mengxr OK, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6145] [SQL] Fix the bug of nested data ...

2015-03-05 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/4892#discussion_r25920561 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -192,14 +193,17 @@ abstract class LogicalPlan

[GitHub] spark pull request: [SPARK-5124][Core] A standard RPC interface an...

2015-03-05 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/4588#discussion_r25920586 --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala --- @@ -0,0 +1,378 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

  1   2   3   4   >