[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121852061 [Test build #37466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37466/consoleFull) for PR 7412 at commit [`b07e20c`](https://gith

[GitHub] spark pull request: [SPARK-9016][ML][WIP] make random forest class...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7432#issuecomment-121852055 [Test build #37465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37465/consoleFull) for PR 7432 at commit [`222a10b`](https://gith

[GitHub] spark pull request: [SPARK-9016][ML][WIP] make random forest class...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7432#issuecomment-121851930 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121851944 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121851933 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9016][ML][WIP] make random forest class...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7432#issuecomment-121851939 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34759954 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -184,6 +199,82 @@ class LocalLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34759969 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -40,13 +40,14 @@ import org.apache.spark.sql.types._

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34759923 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -20,17 +20,21 @@ package org.apache.spark.sql.catalyst.e

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34759850 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -277,15 +276,21 @@ abstract class LogicalPlan extends

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34759860 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -277,15 +276,21 @@ abstract class LogicalPlan extends

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34759808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -96,7 +95,7 @@ case class UnresolvedFunction(name: String,

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34759686 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -184,6 +199,82 @@ class LocalLDAModel private[clustering] (

[GitHub] spark pull request: [Spark-7422][MLLIB] Add argmax to Vector, Spar...

2015-07-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/6112#issuecomment-121849815 @GeorgeDittmar I will try to fix it and send you a PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread sun-rui
Github user sun-rui commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121848726 @viirya, 1. Why pass the lower bound and upper bound in a vector instead of pass separately? They are passed separately in Scala API. and A vector can not hold compl

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-8972][SQL]Incorrect result for rollup

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7343 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121846610 [Test build #37464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37464/consoleFull) for PR 7418 at commit [`b8e274e`](https://gith

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121846456 LGTM, just some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8972][SQL]Incorrect result for rollup

2015-07-15 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/7343#issuecomment-121846486 LGTM. I am merging it to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34759205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121846231 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34759109 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121846213 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34758993 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -180,4 +182,202 @@ object DateTimeUtils { val nan

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/7353#discussion_r34758673 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -86,4 +88,198 @@ class DateTimeUtilsSuite extends Spa

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread shivaram
Github user shivaram commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121844789 Thanks @viirya -- LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] spark pull request: [SPARK-4352][YARN][WIP] Incorporate locality p...

2015-07-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/6394#discussion_r34758587 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -872,6 +872,25 @@ class DAGScheduler( // will be posted, which s

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121844520 [Test build #37463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37463/console) for PR 7356 at commit [`7f51b44`](https://github.

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121844558 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8271][SQL]string function: soundex

2015-07-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/7115#issuecomment-121844421 @HuJiayin you need to rebase the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121843409 [Test build #37461 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37461/console) for PR 7418 at commit [`12d3794`](https://github.

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121843429 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121843303 [Test build #37463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37463/consoleFull) for PR 7356 at commit [`7f51b44`](https://gith

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/7294#issuecomment-121842954 @jkbradley I made one pass: 1. Some of my comments also apply to the old implementation. So I don't think it is necessary to address them in this PR. 2. It is

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121842704 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-8807][SparkR] Add between operator in S...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7356#issuecomment-121842697 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7294#discussion_r34757704 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -0,0 +1,1131 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7294#discussion_r34757701 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -0,0 +1,1131 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7294#discussion_r34757708 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -0,0 +1,1131 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/7294#discussion_r34757721 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala --- @@ -0,0 +1,1131 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] spark pull request: [SPARK-1855] Local checkpointing

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7279#issuecomment-121840805 [Test build #1081 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1081/consoleFull) for PR 7279 at commit [`a92657d`](https://git

[GitHub] spark pull request: [SPARK-4352][YARN][WIP] Incorporate locality p...

2015-07-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/6394#discussion_r34757572 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala --- @@ -24,11 +24,15 @@ package org.apache.spark private[spark] trait Exe

[GitHub] spark pull request: [SPARK-1855] Local checkpointing

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7279#issuecomment-121840800 [Test build #1080 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1080/consoleFull) for PR 7279 at commit [`a92657d`](https://git

[GitHub] spark pull request: [SPARK-1855] Local checkpointing

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7279#issuecomment-121840775 [Test build #1079 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1079/consoleFull) for PR 7279 at commit [`a92657d`](https://git

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757444 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -277,15 +276,21 @@ abstract class LogicalPlan ex

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757450 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala --- @@ -277,15 +276,21 @@ abstract class LogicalPlan ex

[GitHub] spark pull request: [SPARK-7131] [ml] Copy Decision Tree, Random F...

2015-07-15 Thread manishamde
Github user manishamde commented on the pull request: https://github.com/apache/spark/pull/7294#issuecomment-121840575 @jkbradley It looks good to me. It might be a good idea to run the spark.mllib and spark.ml models on a couple of datasets to ensure there are no regressions (in accu

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757416 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -96,7 +95,7 @@ case class UnresolvedFunction(name: Str

[GitHub] spark pull request: [SPARK-4352][YARN][WIP] Incorporate locality p...

2015-07-15 Thread kayousterhout
Github user kayousterhout commented on a diff in the pull request: https://github.com/apache/spark/pull/6394#discussion_r34757342 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -872,6 +872,25 @@ class DAGScheduler( // will be posted, whi

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757289 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -342,7 +342,7 @@ object ConstantFolding extends Rule[L

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7434#issuecomment-121840217 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757259 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -40,13 +40,14 @@ import org.apache.spark.sql.types.

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7434#issuecomment-121840141 [Test build #37458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37458/console) for PR 7434 at commit [`9e8a4de`](https://github.

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757251 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -40,13 +40,14 @@ import org.apache.spark.sql.types.

[GitHub] spark pull request: [SPARK-9085][SQL] Remove LeafNode, UnaryNode, ...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7434#discussion_r34757208 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala --- @@ -20,17 +20,21 @@ package org.apache.spark.sql.catal

[GitHub] spark pull request: [SPARK-4352][YARN][WIP] Incorporate locality p...

2015-07-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/6394#discussion_r34757199 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -872,6 +872,25 @@ class DAGScheduler( // will be posted, which s

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121839582 [Test build #37462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37462/consoleFull) for PR 6638 at commit [`4ab11b7`](https://gith

[GitHub] spark pull request: [SPARK-8791][SQL] Improve the InternalRow.hash...

2015-07-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/7189#issuecomment-121839736 Thank you all for reviewing the code for me, but I think there would be more general way to solve this, closing it for now. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-8791][SQL] Improve the InternalRow.hash...

2015-07-15 Thread chenghao-intel
Github user chenghao-intel closed the pull request at: https://github.com/apache/spark/pull/7189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121838429 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121838423 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-9026] Refactor SimpleFutureAction.onCom...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7385#issuecomment-121838283 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9026] Refactor SimpleFutureAction.onCom...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7385#issuecomment-121838243 **[Test build #37442 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37442/console)** for PR 7385 at commit [`c6fdc21`](https://github

[GitHub] spark pull request: [SPARK-8964] [SQL] [WIP] Use Exchange to perfo...

2015-07-15 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/7334#issuecomment-121838166 @JoshRosen ,seems `execution.CollectLimit` will eventually invoke the code like (in SparkPlan.executeTake): ```scala sc.runJob(childRDD, (it: Iterator[Inte

[GitHub] spark pull request: [SPARK-9068][SQL] refactor the implicit type c...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7420 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9068][SQL] refactor the implicit type c...

2015-07-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7420#issuecomment-121834153 LGTM - @marmbrus and I can't really think of why anymore we needed it - maybe we don't need it anymore. Going to merge this. --- If your project is set up for it, you c

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121834064 Build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] spark pull request: [SPARK-8968] [SQL] shuffled by the partition c...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7336#issuecomment-121834098 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8968] [SQL] shuffled by the partition c...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7336#issuecomment-121834028 [Test build #37459 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37459/console) for PR 7336 at commit [`b5ada0a`](https://github.

[GitHub] spark pull request: [SPARK-8998][MLlib] Collect enough frequent pr...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7412#issuecomment-121833931 [Test build #37452 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37452/console) for PR 7412 at commit [`095aa3a`](https://github.

[GitHub] spark pull request: [SPARK-8682][SQL][WIP] Range Join

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7379#issuecomment-121833017 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8682][SQL][WIP] Range Join

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7379#issuecomment-121832849 [Test build #37456 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37456/console) for PR 7379 at commit [`8204eae`](https://github.

[GitHub] spark pull request: [SPARK-9068][SQL] refactor the implicit type c...

2015-07-15 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/7420#discussion_r34756205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -747,15 +742,9 @@ object HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121830731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-4352][YARN][WIP] Incorporate locality p...

2015-07-15 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/6394#discussion_r34756031 --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala --- @@ -872,6 +872,25 @@ class DAGScheduler( // will be posted, which s

[GitHub] spark pull request: [SPARK-8995][SQL] cast date strings like '2015...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7353#issuecomment-121830665 [Test build #37454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37454/console) for PR 7353 at commit [`ca1ae69`](https://github.

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121827741 [Test build #25 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SlowSparkPullRequestBuilder/25/console) for PR 6638 at commit [`2ee0488`](https://github.co

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121827751 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121827685 [Test build #37461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37461/consoleFull) for PR 7418 at commit [`12d3794`](https://gith

[GitHub] spark pull request: [SPARK-8245][SQL] FormatNumber/Length Support ...

2015-07-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/7034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121827618 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-9058][SQL] Split projectionCode if it i...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7418#issuecomment-121827606 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-8245][SQL] FormatNumber/Length Support ...

2015-07-15 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/7034#issuecomment-121827562 Thanks - merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] spark pull request: [SPARK-8125] [SQL] Accelerates Parquet schema ...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7396#issuecomment-121827555 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-8125] [SQL] Accelerates Parquet schema ...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7396#issuecomment-121827505 [Test build #37441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37441/console) for PR 7396 at commit [`f122f10`](https://github.

[GitHub] spark pull request: [SPARK-9018][MLLIB] add stopwatches

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/7415#discussion_r34755425 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/StopwatchSuite.scala --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/6948#issuecomment-121827311 @MechCoder If you want to manually inspect the Parquet files, reading them back in using Spark SQL is probably the easiest way. You could also save them instead as JS

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121827335 [Test build #37451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/37451/console) for PR 6638 at commit [`2ee0488`](https://github.

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755380 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/LDASuite.scala --- @@ -213,6 +214,46 @@ class LDASuite extends SparkFunSuite with MLlibTes

[GitHub] spark pull request: [SPARK-7119][SQL]Give script a default serde w...

2015-07-15 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6638#issuecomment-121827344 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755377 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755357 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -184,6 +199,82 @@ class LocalLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755364 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -184,6 +199,82 @@ class LocalLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755378 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755376 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755369 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -184,6 +199,82 @@ class LocalLDAModel private[clustering] (

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755375 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755379 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

[GitHub] spark pull request: [SPARK-5989] [MLlib] Model save/load for LDA

2015-07-15 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/6948#discussion_r34755372 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala --- @@ -354,4 +445,140 @@ class DistributedLDAModel private ( // TODO

  1   2   3   4   5   6   7   8   9   10   >