[GitHub] spark pull request: [SPARK-6761][SQL] Approximate quantile for Dat...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6042#issuecomment-186108836 **[Test build #51538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51538/consoleFull)** for PR 6042 at commit

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11262#issuecomment-186108498 **[Test build #51537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51537/consoleFull)** for PR 11262 at commit

[GitHub] spark pull request: [SPARK-13385][MLlib] Enable AssociationRules t...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11263#issuecomment-186107355 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12567][SQL] Add aes_{encrypt,decrypt} U...

2016-02-18 Thread vectorijk
Github user vectorijk commented on a diff in the pull request: https://github.com/apache/spark/pull/10527#discussion_r53431192 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -1931,6 +1931,40 @@ object functions extends LegacyFunctions { new

[GitHub] spark pull request: [SPARK-6761][SQL] Approximate quantile for Dat...

2016-02-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/6042#issuecomment-186106917 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: https://issues.apache.org/jira/browse/SPARK-13...

2016-02-18 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/11263 https://issues.apache.org/jira/browse/SPARK-13385 ## What changes were proposed in this pull request? Enable AssociationRules to generate consequents with user-defined lengths

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11208#issuecomment-186105681 **[Test build #51536 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51536/consoleFull)** for PR 11208 at commit

[GitHub] spark pull request: [SPARK-13186][Streaming]migrate away from Sync...

2016-02-18 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/11250#discussion_r53430913 --- Diff: extras/kinesis-asl/src/test/scala/org/apache/spark/streaming/kinesis/KinesisStreamSuite.scala --- @@ -241,13 +243,13 @@ abstract class

[GitHub] spark pull request: [SPARK-13381][SQL] Support for loading CSV wit...

2016-02-18 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/11262 [SPARK-13381][SQL] Support for loading CSV with a single function call https://issues.apache.org/jira/browse/SPARK-13381 This PR adds the support to load CSV data directly by a single

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-18 Thread jerryshao
Github user jerryshao commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-186103130 So you mean we also need to clean the states in `CoarseGrainedSchedulerBackend` if AM failure occurs, even dynamic allocation is not enabled? What specific

[GitHub] spark pull request: [SPARK-6761][SQL] Approximate quantile for Dat...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6042#issuecomment-186102594 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-18 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-186102602 LGTM pending test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6761][SQL] Approximate quantile for Dat...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6042#issuecomment-186102597 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12864][YARN] initialize executorIdCount...

2016-02-18 Thread lianhuiwang
Github user lianhuiwang commented on the pull request: https://github.com/apache/spark/pull/10794#issuecomment-186102176 @jerryshao I think it needs to reset in CoarseGrainedSchedulerBackend when dynamicAllocation is not enabled. because it can clear information and come back to

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186100567 **[Test build #51534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51534/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13213][SQL] Use CartisianProduct instea...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11251#issuecomment-186098000 **[Test build #51533 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51533/consoleFull)** for PR 11251 at commit

[GitHub] spark pull request: [SPARK-13384][SQL] Keep attribute qualifiers a...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11261#issuecomment-186097375 **[Test build #51532 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51532/consoleFull)** for PR 11261 at commit

[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...

2016-02-18 Thread yanboliang
Github user yanboliang closed the pull request at: https://github.com/apache/spark/pull/10097 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11198#issuecomment-186096228 **[Test build #51530 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51530/consoleFull)** for PR 11198 at commit

[GitHub] spark pull request: [SPARK-13249][SQL] Add Filter checking nullabi...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11235#issuecomment-186095529 **[Test build #51531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51531/consoleFull)** for PR 11235 at commit

[GitHub] spark pull request: [SPARK-13213][SQL] Use CartisianProduct instea...

2016-02-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11251#issuecomment-186094421 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13213][SQL] Use CartisianProduct instea...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11251#issuecomment-186093654 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13384][SQL] Keep attribute qualifiers a...

2016-02-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11261#issuecomment-186093614 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-13213][SQL] Use CartisianProduct instea...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11251#issuecomment-186093658 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13249][SQL] Add Filter checking nullabi...

2016-02-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11235#issuecomment-186092279 @maropu yeah, I think so. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-13384][SQL] Keep attribute qualifiers a...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11261#issuecomment-186091029 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13384][SQL] Keep attribute qualifiers a...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11261#issuecomment-186091033 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11208#discussion_r53427972 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -528,6 +528,14 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11208#discussion_r53427991 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1834,6 +1834,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11260#issuecomment-186089063 **[Test build #51527 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51527/consoleFull)** for PR 11260 at commit

[GitHub] spark pull request: [SPARK-13213][SQL] Use CartisianProduct instea...

2016-02-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11251#discussion_r53427825 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -380,7 +380,12 @@ object ColumnPruning extends

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-18 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/11198#discussion_r53427826 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -927,6 +927,33 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread dbtsai
Github user dbtsai commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186088729 +1 on copying the tests from ML LOR tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/11260#discussion_r53427540 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -432,7 +432,8 @@ class Analyzer( case r

[GitHub] spark pull request: [SPARK-13384][SQL] Keep attribute qualifiers a...

2016-02-18 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/11261 [SPARK-13384][SQL] Keep attribute qualifiers after dedup in Analyzer JIRA: https://issues.apache.org/jira/browse/SPARK-13384 ## What changes were proposed in this pull request?

[GitHub] spark pull request: [SPARK-13383][SQL] Keep broadcast hint after c...

2016-02-18 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/11260 [SPARK-13383][SQL] Keep broadcast hint after column pruning JIRA: https://issues.apache.org/jira/browse/SPARK-13383 ## What changes were proposed in this pull request? When we do

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-186084779 **[Test build #51525 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51525/consoleFull)** for PR 10089 at commit

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186084453 **[Test build #51526 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51526/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-12746][ML] ArrayType(_, true) should al...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11237#issuecomment-186084158 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12746][ML] ArrayType(_, true) should al...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11237#issuecomment-186084152 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12746][ML] ArrayType(_, true) should al...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11237#issuecomment-186083860 **[Test build #51522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51522/consoleFull)** for PR 11237 at commit

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11229#issuecomment-186082895 **[Test build #51524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51524/consoleFull)** for PR 11229 at commit

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2016-02-18 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-186083123 @JasonMWhite thanks, looks great except some nits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13012] [Documentation] Replace example ...

2016-02-18 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/11053#issuecomment-186082803 Thanks again @yinxusen for the review, I have addressed the comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2016-02-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r53426791 --- Diff: external/kafka/src/test/scala/org/apache/spark/streaming/kafka/DirectKafkaStreamSuite.scala --- @@ -430,6 +457,27 @@ class DirectKafkaStreamSuite

[GitHub] spark pull request: [SPARK-13012] [Documentation] Replace example ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11053#issuecomment-186081590 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13012] [Documentation] Replace example ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11053#issuecomment-186081588 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13012] [Documentation] Replace example ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11053#issuecomment-186081512 **[Test build #51523 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51523/consoleFull)** for PR 11053 at commit

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186081215 Yep, I cleaned up the description. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2016-02-18 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/10089#discussion_r53426422 --- Diff: external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaTestUtils.scala --- @@ -152,12 +152,15 @@ private[kafka] class KafkaTestUtils

[GitHub] spark pull request: [SPARK-12073] [Streaming] backpressure rate co...

2016-02-18 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/10089#issuecomment-186080968 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [WIP][SPARK-13332][SQL] Decimal datatype suppo...

2016-02-18 Thread yucai
Github user yucai commented on the pull request: https://github.com/apache/spark/pull/11212#issuecomment-186077126 @rxin I tried your suggestion like creating PowDecimal for Decimal specially like below: ``` case class PowDecimal(left: Expression, right: Expression)

[GitHub] spark pull request: [SPARK-13012] [Documentation] Replace example ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11053#issuecomment-186075925 **[Test build #51523 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51523/consoleFull)** for PR 11053 at commit

[GitHub] spark pull request: [SPARK-13310] [SQL] Resolve Missing Sorting Co...

2016-02-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11198#discussion_r53425790 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala --- @@ -927,6 +927,33 @@ class SQLQuerySuite extends QueryTest

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186073984 **[Test build #2546 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2546/consoleFull)** for PR 11232 at commit

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Elimination by ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10567#issuecomment-186072562 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Elimination by ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/10567#issuecomment-186072566 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Elimination by ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10567#issuecomment-186072033 **[Test build #51520 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51520/consoleFull)** for PR 10567 at commit

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/11208#issuecomment-186071838 Overall LGTM except some comments about tests, thanks for working on it! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-18 Thread devaraj-kavali
Github user devaraj-kavali commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-186070514 Thanks again @yinxusen for the review, I have addressed them. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-5682][Core] Add encrypted shuffle in sp...

2016-02-18 Thread winningsix
Github user winningsix commented on the pull request: https://github.com/apache/spark/pull/8880#issuecomment-186069349 Hi @vanzin, I have a suggestion about the usage of configuration. Currently we convert the Spark crypto related configuration to Chimera configuration by their

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-186067677 **[Test build #51521 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51521/consoleFull)** for PR 11132 at commit

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-186067911 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11208#discussion_r53425152 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -528,6 +528,14 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-186067906 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/11208#discussion_r53425125 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1834,6 +1834,8 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request: [SPARK-12746][ML] ArrayType(_, true) should al...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11237#issuecomment-186066327 **[Test build #51522 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51522/consoleFull)** for PR 11237 at commit

[GitHub] spark pull request: [SPARK-13016] [Documentation] Replace example ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11132#issuecomment-186063429 **[Test build #51521 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51521/consoleFull)** for PR 11132 at commit

[GitHub] spark pull request: [SPARK-13220][Core]deprecate yarn-client and y...

2016-02-18 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/11229#discussion_r53424443 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -245,18 +249,20 @@ object SparkSubmit { // from each other if only

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186057656 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186057653 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13233][SQL][WIP] Python Dataset

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/7#issuecomment-186057527 **[Test build #51518 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51518/consoleFull)** for PR 7 at commit

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/11232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186056112 I'm going to merge this in master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread viirya
Github user viirya commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186054666 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186054750 So this wasn't really tested by unit tests ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-186053470 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-186053474 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186053381 This is due to we don't have excellent test coverage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-12154] Upgrade to Jersey 2

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11223#issuecomment-186053368 **[Test build #51515 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51515/consoleFull)** for PR 11223 at commit

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186052981 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186052982 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052919 Regarding testing: how does this work with unit tests? If the old code passes all the tests ... --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186052860 **[Test build #51519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51519/consoleFull)** for PR 11232 at commit

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052851 Thanks - I was checking to see if the template shows up or not, because a number of pull requests don't follow it. I think it's a good idea to follow this as much as

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread yanboliang
Github user yanboliang commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186052209 @rxin I saw the template, but I think this change is very easy to understand, so ... --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-13369] Make number of consecutive fetch...

2016-02-18 Thread sitalkedia
Github user sitalkedia commented on the pull request: https://github.com/apache/spark/pull/11254#issuecomment-186052095 @markhamstra Ofcourse we want the stage to fail as soon as we detect fetch failure so the recomputation can be done quickly. But the configuration parameter in

[GitHub] spark pull request: [SPARK-13379] [MLlib] Fix MLlib LogisticRegres...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11258#issuecomment-186051411 Question: do you see the pull request template? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/11259#issuecomment-186051360 Question: do you see the pull request template? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-13374][Streaming][wip] make it possible...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11249#issuecomment-186051202 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [Spark-13374][Streaming][wip] make it possible...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11249#issuecomment-186051203 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [Spark-13374][Streaming][wip] make it possible...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11249#issuecomment-186051114 **[Test build #51511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51511/consoleFull)** for PR 11249 at commit

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11259#issuecomment-186049612 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11208#issuecomment-186045431 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-13364] Sort appId as num rather than st...

2016-02-18 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/spark/pull/11259 [SPARK-13364] Sort appId as num rather than str in history page. ## What changes were proposed in this pull request? History page now sorts the appID as a string, which can lead to unexpected

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11208#issuecomment-186045222 **[Test build #51512 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51512/consoleFull)** for PR 11208 at commit

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186046485 **[Test build #2546 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2546/consoleFull)** for PR 11232 at commit

[GitHub] spark pull request: [SPARK-12594] [SQL] Outer Join Elimination by ...

2016-02-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/10567#issuecomment-186045570 **[Test build #51520 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/51520/consoleFull)** for PR 10567 at commit

[GitHub] spark pull request: [SPARK-13320] [SQL] Support Star in CreateStru...

2016-02-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11208#issuecomment-186045432 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-13380] [SQL] [Document] Document Rand(s...

2016-02-18 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/11232#issuecomment-186044605 Opened a separate JIRA for this document issue and changed the PR title. We might need to keep the original JIRA open. Let me know if we can find a better

  1   2   3   4   5   >