[GitHub] spark issue #14625: [SPARK-17045] [SQL] Build/move Join-related test cases i...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64174/ Test PASSed. ---

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Build/move Join-related test cases i...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14625 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Build/move Join-related test cases i...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #64174 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64174/consoleFull)** for PR 14625 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14155 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14744 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14744 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64172/ Test PASSed. ---

[GitHub] spark issue #14737: [SPARK-17171][WEB UI] DAG will list all partitions in th...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14737 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14737: [SPARK-17171][WEB UI] DAG will list all partitions in th...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14737 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64173/ Test PASSed. ---

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14744 **[Test build #64172 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64172/consoleFull)** for PR 14744 at commit

[GitHub] spark issue #14737: [SPARK-17171][WEB UI] DAG will list all partitions in th...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14737 **[Test build #64173 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64173/consoleFull)** for PR 14737 at commit

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread zjffdu
Github user zjffdu commented on the issue: https://github.com/apache/spark/pull/14744 @vanzin Could you help review this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14155: [SPARK-16498][SQL] move hive hack for data source table ...

2016-08-21 Thread yhuai
Github user yhuai commented on the issue: https://github.com/apache/spark/pull/14155 LGTM. There are two things that we need to address in follow-up prs. The first one is if we can consolidate location in CatalogStorageFormat and `path` in options. The second one is to read the conf

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14744 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14744 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64171/ Test PASSed. ---

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14744 **[Test build #64171 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64171/consoleFull)** for PR 14744 at commit

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/14743 @shivaram Thanks for cc me. I will verify it within today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14745: [SPARK-16896][SQL] Handle duplicated field names in head...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14745 **[Test build #64178 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64178/consoleFull)** for PR 14745 at commit

[GitHub] spark pull request #14155: [SPARK-16498][SQL] move hive hack for data source...

2016-08-21 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/14155#discussion_r75617761 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -200,22 +375,77 @@ private[spark] class

[GitHub] spark pull request #14745: [SPARK-16896][SQL] Handle duplicated field names ...

2016-08-21 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/14745 [SPARK-16896][SQL] Handle duplicated field names in header consistently with null or empty strings in CSV ## What changes were proposed in this pull request? Currently, CSV datasource

[GitHub] spark pull request #13837: [SPARK-16126] [SQL] Better Error Message When usi...

2016-08-21 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13837 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #13142: [SPARK-15358] [TEST] Rename HiveDDLCommandSuite a...

2016-08-21 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #13128: [SPARK-15337] [SPARK-15338] [SQL] Enable Run-time...

2016-08-21 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #13122: [SPARK-15331] [SQL] Disallow All the Unsupported ...

2016-08-21 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/13122 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request #11298: [SPARK-13428] [SQL] Pushing Down Aggregate Expres...

2016-08-21 Thread gatorsmile
Github user gatorsmile closed the pull request at: https://github.com/apache/spark/pull/11298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #14521: [SPARK-16935] [SQL] Verification of Function-related Ext...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14521 **[Test build #64177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64177/consoleFull)** for PR 14521 at commit

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14531 **[Test build #64176 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64176/consoleFull)** for PR 14531 at commit

[GitHub] spark issue #14572: [SPARK-16552] [FOLLOW-UP] [SQL] Store the Inferred Schem...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14572 **[Test build #64175 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64175/consoleFull)** for PR 14572 at commit

[GitHub] spark issue #14521: [SPARK-16935] [SQL] Verification of Function-related Ext...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14521 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14572: [SPARK-16552] [FOLLOW-UP] [SQL] Store the Inferred Schem...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14572 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #14531: [SPARK-16943] [SPARK-16942] [SQL] Fix multiple bugs in C...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14531 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark pull request #14692: [SPARK-17115] [SQL] decrease the threshold when s...

2016-08-21 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/14692#discussion_r75615959 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -584,15 +584,18 @@ class CodegenContext {

[GitHub] spark issue #14625: [SPARK-17045] [SQL] Build/move Join-related test cases i...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14625 **[Test build #64174 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64174/consoleFull)** for PR 14625 at commit

[GitHub] spark issue #14547: [SPARK-16718][MLlib] gbm-style treeboost

2016-08-21 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14547 TBH, I'm not certain after having read many of those papers exactly what constitutes "TreeBoost". From the following excerpt, it seems to me like TreeBoost is simply defined by making terminal node

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14743 @HyukjinKwon can you test this on Windows ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #7927: [SPARK-9591][CORE]Job may fail for exception during getti...

2016-08-21 Thread sprite311
Github user sprite311 commented on the issue: https://github.com/apache/spark/pull/7927 i have this problem in spark1.3.0, is there any other solutions? i can't update spark to 1.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14743 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64170/ Test PASSed. ---

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14743 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14737: [SPARK-17171][WEB UI] DAG will list all partitions in th...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14737 **[Test build #64173 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64173/consoleFull)** for PR 14737 at commit

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14743 **[Test build #64170 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64170/consoleFull)** for PR 14743 at commit

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613875 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/AggregateWithObjectAggregateBufferSuite.scala --- @@ -0,0 +1,156 @@ +/* + * Licensed to

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortBasedAggregationIterator.scala --- @@ -90,6 +98,21 @@ class

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14744 **[Test build #64172 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64172/consoleFull)** for PR 14744 at commit

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB][ML] add a chiSquare Selector...

2016-08-21 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r75613576 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -189,11 +228,35 @@ class ChiSqSelector @Since("1.3.0") ( */

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613492 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613439 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75613381 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark issue #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command ...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14744 **[Test build #64171 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64171/consoleFull)** for PR 14744 at commit

[GitHub] spark pull request #14744: [SPARKR][SPARKSUBMIT] Allow to set sparkr shell c...

2016-08-21 Thread zjffdu
GitHub user zjffdu opened a pull request: https://github.com/apache/spark/pull/14744 [SPARKR][SPARKSUBMIT] Allow to set sparkr shell command through --conf ## What changes were proposed in this pull request? Allow user to set sparkr shell command through --conf

[GitHub] spark issue #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14743 **[Test build #64170 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64170/consoleFull)** for PR 14743 at commit

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread clockfly
Github user clockfly commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75612665 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark pull request #14743: [SparkR][Minor] Fix Cache Folder Path in Windows

2016-08-21 Thread junyangq
GitHub user junyangq opened a pull request: https://github.com/apache/spark/pull/14743 [SparkR][Minor] Fix Cache Folder Path in Windows ## What changes were proposed in this pull request? This PR tries to fix the scheme of local cache folder in Windows. The name of the

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75612644 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark pull request #14723: [SQL][WIP][Test] Supports object-based aggregatio...

2016-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14723#discussion_r75612521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/interfaces.scala --- @@ -389,3 +389,89 @@ abstract class

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14712 Great! Will review the new changes when it is ready. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #14431: [SPARK-16258][SparkR] Automatically append the grouping ...

2016-08-21 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/14431 Made a pull request for grouping columns: #14742 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14742: [SPARK-17177][SQL] Make grouping columns accessible from...

2016-08-21 Thread NarineK
Github user NarineK commented on the issue: https://github.com/apache/spark/pull/14742 cc: @shivaram, @liancheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14738: [MINOR][ML]Add expert param support to SharedParamsCodeG...

2016-08-21 Thread hqzizania
Github user hqzizania commented on the issue: https://github.com/apache/spark/pull/14738 Thanks for sethan's comments :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-21 Thread wzhfy
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/14712 @gatorsmile yes, we will support it in this pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14597: [SPARK-17017][MLLIB][ML] add a chiSquare Selector...

2016-08-21 Thread mpjlu
Github user mpjlu commented on a diff in the pull request: https://github.com/apache/spark/pull/14597#discussion_r75610472 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala --- @@ -189,11 +228,35 @@ class ChiSqSelector @Since("1.3.0") ( */

[GitHub] spark issue #14426: [SPARK-16475][SQL] Broadcast Hint for SQL Queries

2016-08-21 Thread watermen
Github user watermen commented on the issue: https://github.com/apache/spark/pull/14426 Do this PR support multiple JOINs(`SELECT * FROM t1 JOIN t2 ON t1.key = t2.key JOIN t3 ON t1.key = t3.key`)? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark issue #14712: [SPARK-17072] [SQL] support table-level statistics gener...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14712 What is our CBO plan for data source tables? Is it implemented in the prototype? It is not mentioned in the design doc. If we want to support `InMemoryCatalog`, we need to provide the support

[GitHub] spark issue #14729: [SPARK-17167] [SQL] Issue Exceptions when Analyze Table ...

2016-08-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14729 @hvanhovell In the current master branch, if we want to support In-Memory cataloged tables, we need to support data source tables. You know, `SimpleCatalogRelation` is converted to

[GitHub] spark issue #14742: [SPARK-17177][SQL] Make grouping columns accessible from...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14742 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14742: [SPARK-17177][SQL] Make grouping columns accessible from...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64169/ Test PASSed. ---

[GitHub] spark issue #14742: [SPARK-17177][SQL] Make grouping columns accessible from...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14742 **[Test build #64169 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64169/consoleFull)** for PR 14742 at commit

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-21 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/1 @hvanhovell, are you suggesting a complete removal of CreateStruct? this can definitely simplify this PR, but it'd still leave the issue I've described at the end of my previous comment, one can

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-21 Thread eyalfa
Github user eyalfa commented on the issue: https://github.com/apache/spark/pull/1 @cloud-fan , I know this has been idle for few weeks now but I'd like to push it forward. I've merged master into it, which eliminated the discussion about ast-builder and inline-tables (thanks

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75604121 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala --- @@ -27,26 +27,87 @@ import

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75603963 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala --- @@ -27,26 +27,87 @@ import

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75603936 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala --- @@ -27,26 +27,87 @@ import

[GitHub] spark issue #14444: [SPARK-16839] [SQL] redundant aliases after cleanupAlias...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/1 @eyalfa we don't need to maintain backwards compatibility for `CreateStruct`, and we can create a factory function for row creator. So I would just remove both `Create*Struct` classes.

[GitHub] spark issue #14742: [SPARK-17177][SQL] Make grouping columns accessible from...

2016-08-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14742 **[Test build #64169 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64169/consoleFull)** for PR 14742 at commit

[GitHub] spark pull request #14742: [SPARK-17177][SQL] Make grouping columns accessib...

2016-08-21 Thread NarineK
GitHub user NarineK opened a pull request: https://github.com/apache/spark/pull/14742 [SPARK-17177][SQL] Make grouping columns accessible from `RelationalGroupedDataset` ## What changes were proposed in this pull request? Currently, once we create

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75603826 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala --- @@ -37,36 +37,58 @@ class PlannerSuite extends SharedSQLContext {

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75603771 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -151,18 +152,39 @@ case class

[GitHub] spark pull request #10896: [SPARK-12978][SQL] Skip unnecessary final group-b...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/10896#discussion_r75603363 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala --- @@ -121,3 +121,6 @@ case class SortAggregateExec(

[GitHub] spark issue #14741: [SPARK-6832][SPARKR][WIP]Handle partial reads in SparkR

2016-08-21 Thread krishnakalyan3
Github user krishnakalyan3 commented on the issue: https://github.com/apache/spark/pull/14741 @shivaram I am not sure on how to go about the retry method. Could you please share some example that I could refer to?. --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #14741: [SPARK-6832][SPARKR][WIP]Handle partial reads in SparkR

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14741 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #14741: [SPARK-6832][SPARKR][WIP]Handle partial reads in ...

2016-08-21 Thread krishnakalyan3
GitHub user krishnakalyan3 opened a pull request: https://github.com/apache/spark/pull/14741 [SPARK-6832][SPARKR][WIP]Handle partial reads in SparkR ## What changes were proposed in this pull request? Handle partial reads in SparkR by implementing a retry method in R that will

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75603123 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14737: [SPARK-17171][WEB UI] DAG will list all partition...

2016-08-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/14737#discussion_r75602737 --- Diff: core/src/main/scala/org/apache/spark/ui/SparkUI.scala --- @@ -141,6 +141,7 @@ private[spark] object SparkUI { val DEFAULT_POOL_NAME =

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14689 Thank you for review and merging, @hvanhovell ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #14737: [SPARK-17171][WEB UI] DAG will list all partition...

2016-08-21 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/14737#discussion_r75602575 --- Diff: core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala --- @@ -119,18 +119,47 @@ private[ui] object RDDOperationGraph extends

[GitHub] spark pull request #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimize...

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14689: [SPARK-17098][SQL] Fix `NullPropagation` optimizer to ha...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14689 LGTM - merging this master/2.0. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75602017 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala --- @@ -72,9 +72,12 @@ case class LogicalRelation(

[GitHub] spark pull request #14712: [SPARK-17072] [SQL] support table-level statistic...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/14712#discussion_r75601984 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala --- @@ -141,7 +142,16 @@ private[hive] case class MetastoreRelation(

[GitHub] spark issue #14722: [SPARK-13286] [SQL] add the next expression of SQLExcept...

2016-08-21 Thread jaceklaskowski
Github user jaceklaskowski commented on the issue: https://github.com/apache/spark/pull/14722 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] spark pull request #14720: SPARK-12868: Allow Add jar to add jars from hdfs/...

2016-08-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14720#discussion_r75601795 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala --- @@ -865,6 +865,16 @@ class HiveQuerySuite extends

[GitHub] spark pull request #14720: SPARK-12868: Allow Add jar to add jars from hdfs/...

2016-08-21 Thread jaceklaskowski
Github user jaceklaskowski commented on a diff in the pull request: https://github.com/apache/spark/pull/14720#discussion_r75601779 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -87,6 +88,9 @@ private[hive] class HiveClientImpl(

[GitHub] spark issue #14738: [MINOR][ML]Add expert param support to SharedParamsCodeG...

2016-08-21 Thread sethah
Github user sethah commented on the issue: https://github.com/apache/spark/pull/14738 @srowen https://github.com/apache/spark/pull/14717 Implemented a change to add a parameter to linear/logistic regression which allows users to control the aggregation depth on `treeAggregate` when

[GitHub] spark issue #14705: [SPARK-16508][SparkR] Fix CRAN undocumented/duplicated a...

2016-08-21 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/14705 I cherry-picked this PR into `branch-2.0` in https://github.com/apache/spark/commit/0297896119e11f23da4b14f62f50ec72b5fac57f -- The merge was a little awkward and but I think I got it to work

[GitHub] spark issue #14700: [SPARK-17127]Make unaligned access in unsafe available f...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14700 LGTM. @srowen how do you feel about this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #14729: [SPARK-17167] [SQL] Issue Exceptions when Analyze Table ...

2016-08-21 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/14729 @gatorsmile shouldn't we do this the other way around? And enable `Analyze Table` for any table? That is the only way CBO can be used anywhere. Temporary tables might be a bit more

[GitHub] spark pull request #14735: [SPARK-17173][SPARKR] R MLlib refactor, cleanup, ...

2016-08-21 Thread junyangq
Github user junyangq commented on a diff in the pull request: https://github.com/apache/spark/pull/14735#discussion_r75599753 --- Diff: R/pkg/inst/tests/testthat/test_mllib.R --- @@ -95,6 +95,10 @@ test_that("spark.glm summary", { expect_equal(stats$df.residual,

[GitHub] spark pull request #14740: [MINOR] [R] add SparkR.Rcheck/ and SparkR_*.tar.g...

2016-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/14740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #14740: [MINOR] [R] add SparkR.Rcheck/ and SparkR_*.tar.gz to R/...

2016-08-21 Thread mengxr
Github user mengxr commented on the issue: https://github.com/apache/spark/pull/14740 Merged into branch-2.0 and master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14740: [MINOR] [R] add SparkR.Rcheck/ and SparkR_*.tar.gz to R/...

2016-08-21 Thread junyangq
Github user junyangq commented on the issue: https://github.com/apache/spark/pull/14740 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #14740: [MINOR] [R] add SparkR.Rcheck/ and SparkR_*.tar.gz to R/...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14740 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64168/ Test PASSed. ---

[GitHub] spark issue #14740: [MINOR] [R] add SparkR.Rcheck/ and SparkR_*.tar.gz to R/...

2016-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14740 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   >