Github user MLnick commented on the issue:
https://github.com/apache/spark/pull/16011
As far as I recall, the idea is that the `Bucketizer` can be used
standalone, and because the `QuantileDiscretizer` itself produced the same
thing as a bucketizer, it was used as the model rather
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15995
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15995
**[Test build #69220 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69220/consoleFull)**
for PR 15995 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15995
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69220/
Test FAILed.
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16008
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16008
Thanks - merging in master/branch-2.1. We should look into the Janino
change in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
I think it is ready to be reviewed - @srowen. Thank you for your close look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/16008
Hmm, it is a great idea, but I think it would be very hard to submit such a
patch (at least for me now).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727420
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
@@ -40,14 +40,9 @@ case class JdbcType(databaseTypeDefinition :
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89727312
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -437,4 +444,38 @@ final class DataFrameNaFunctions
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727297
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/VectorIndexer.scala ---
@@ -41,7 +41,7 @@ private[ml] trait VectorIndexerParams extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727185
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
---
@@ -24,9 +24,7 @@ import org.apache.spark.Partition
/**
*
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727091
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -422,13 +422,8 @@ private[spark] object UIUtils extends Logging {
* the
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727059
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -33,9 +33,9 @@ import org.apache.spark.sql.types.StructType
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89727120
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -41,9 +41,9 @@ private[spark] class JdbcPartition(idx: Int, val lower:
Long, val
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16013
**[Test build #69228 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69228/consoleFull)**
for PR 16013 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15994
**[Test build #69229 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69229/consoleFull)**
for PR 15994 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89726626
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -153,11 +153,9 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16029
**[Test build #69227 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69227/consoleFull)**
for PR 16029 at commit
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/16029
[MINOR][ML] Remove duplicate import in GLR
## What changes were proposed in this pull request?
there were two `import GeneralizedLinearRegression._` in trait
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16028
**[Test build #69226 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69226/consoleFull)**
for PR 16028 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16028
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69226/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16028
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16028
**[Test build #69226 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69226/consoleFull)**
for PR 16028 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69218/
Test PASSed.
---
GitHub user zhengruifeng opened a pull request:
https://github.com/apache/spark/pull/16028
[SPARK-18518][ML] HasSolver supports override
## What changes were proposed in this pull request?
1, make param support non-final with `finalFields` option
2, generate `HasSolver` with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69218 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69218/consoleFull)**
for PR 15986 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89724422
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDCheckpointData.scala
---
@@ -23,7 +23,8 @@ import org.apache.spark.Partition
/**
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16013
**[Test build #69225 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69225/consoleFull)**
for PR 16013 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15983
**[Test build #69223 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69223/consoleFull)**
for PR 15983 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15976
**[Test build #69224 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69224/consoleFull)**
for PR 15976 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15979
retest it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15983
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
@kiszk Do you mean to avoid subexpression elimination?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15976
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15975
LGTM except https://github.com/apache/spark/pull/15975/files#r89722356,
what's the status of it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15975#discussion_r89722356
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -404,6 +425,7 @@ class JDBCSuite extends SparkFunSuite
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/15837
@cloud-fan Sure, no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15837
Sorry for the delay, but I may not have time to review it before the 2.1
release, can you hold it off until 2.1 release? thanks!
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16013
**[Test build #69222 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69222/consoleFull)**
for PR 16013 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89721863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -405,13 +406,14 @@ case class WrapOption(child:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15780
**[Test build #69221 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69221/consoleFull)**
for PR 15780 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89721435
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89721405
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -437,4 +444,38 @@ final class DataFrameNaFunctions
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89721142
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -437,4 +444,38 @@ final class DataFrameNaFunctions
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89721112
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -153,19 +168,20 @@ final class DataFrameNaFunctions
Github user windpiger commented on a diff in the pull request:
https://github.com/apache/spark/pull/15994#discussion_r89721087
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameNaFunctions.scala ---
@@ -128,66 +128,49 @@ final class DataFrameNaFunctions
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16003
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15995
**[Test build #69220 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69220/consoleFull)**
for PR 15995 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/15995
@ericl you are right, I pushed a new commit to do `convertStaticPartitions`
right before we convert `InsertIntoTable` to `InsertIntoHadoopFsRelation`, so
the partitioning information won't be
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/16003
Merging in master/branch-2.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16003
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69217/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16003
**[Test build #69217 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69217/consoleFull)**
for PR 16003 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719801
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/NNLS.scala ---
@@ -53,8 +53,13 @@ private[spark] object NNLS {
* projected
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719600
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/SQLTransformer.scala ---
@@ -32,9 +32,11 @@ import org.apache.spark.sql.types.StructType
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15986
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69216/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69216/consoleFull)**
for PR 15986 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719290
--- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
@@ -41,7 +41,10 @@ private[spark] class JdbcPartition(idx: Int, val lower:
Long,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89719223
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -152,10 +152,10 @@ class DoubleRDDFunctions(self: RDD[Double])
Github user yucai commented on the issue:
https://github.com/apache/spark/pull/10942
@gatorsmile, seems like getBuckets() is removed by below PR, which makes
this feture not work any more, could you kindly help check?
[SPARK-14535][SQL] Remove buildInternalScan from FileFormat
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16013
**[Test build #69219 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69219/consoleFull)**
for PR 16013 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/16013
Let me leave some images that I changed and some comments to double check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/16013#discussion_r89718720
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -57,9 +57,17 @@ import
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718250
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89718035
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/16011
@MLnick Yeah, I think this is the most common case that copying Params from
estimators to models. However, I also found some algorithms do not comply this
rule, such as ```ALS``` which has
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89716676
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69214/
Test PASSed.
---
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89716522
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -350,20 +350,16 @@ private[spark] class TaskSchedulerImpl(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15994
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15994
**[Test build #69214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69214/consoleFull)**
for PR 15994 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16027
Could you add `[SPARK-18604][SQL]` before merging?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15986
**[Test build #69218 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69218/consoleFull)**
for PR 15986 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15994
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16027#discussion_r89716395
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala
---
@@ -46,12 +46,15 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15994
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69213/
Test PASSed.
---
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16027
LGTM. Thank you for correct this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16027#discussion_r89716308
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -545,7 +545,7 @@ object CollapseRepartition
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15994
**[Test build #69213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69213/consoleFull)**
for PR 15994 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89716251
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -350,20 +350,16 @@ private[spark] class TaskSchedulerImpl(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15874
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15874
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69215/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15874
**[Test build #69215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/69215/consoleFull)**
for PR 15874 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89715587
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89715546
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
---
@@ -590,7 +591,11 @@ object ScalaReflection extends
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89712321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89713304
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -177,9 +177,10 @@ case class Invoke(
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15780#discussion_r89712401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -405,13 +406,14 @@ case class WrapOption(child:
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16027
Oh, I missed this. Yep. I'll take a look at this, too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/16026#discussion_r89715298
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -514,6 +514,39 @@ class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/16026
LGTM, @hvanhovell .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/16026
LGTM except a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89715118
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala ---
@@ -350,20 +350,16 @@ private[spark] class TaskSchedulerImpl(
Github user kayousterhout commented on a diff in the pull request:
https://github.com/apache/spark/pull/15986#discussion_r89715211
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala ---
@@ -274,4 +276,70 @@ class TaskSchedulerImplSuite extends
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16017#discussion_r89715218
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -52,33 +52,49 @@ class DecisionTreeClassifier
1 - 100 of 285 matches
Mail list logo
