[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...(l, ...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16719 LGTM except one comment. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16731: [SPARK-19393][SQL] Add `approx_percentile` Dataset/DataF...

2017-01-28 Thread lw-lin
Github user lw-lin commented on the issue: https://github.com/apache/spark/pull/16731 @rxin @hvanhovell could you take a look, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98347203 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -78,14 +78,18 @@ object Canonicalize extends {

[GitHub] spark issue #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...(l, ...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16719 **[Test build #72123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72123/testReport)** for PR 16719 at commit

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346999 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346981 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346741 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346688 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16575 **[Test build #72122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72122/testReport)** for PR 16575 at commit

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread lw-lin
Github user lw-lin commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346453 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark issue #16575: [SPARK-19213] DatasourceScanExec uses runtime sparksessi...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16575 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16710: [SPARK-18872][SQL][TESTS] New test cases for EXISTS subq...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16710 **[Test build #72121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72121/testReport)** for PR 16710 at commit

[GitHub] spark pull request #16710: [SPARK-18872][SQL][TESTS] New test cases for EXIS...

2017-01-28 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/16710#discussion_r98346290 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-basic.sql --- @@ -0,0 +1,115 @@ +-- Tests EXISTS subquery

[GitHub] spark issue #16733: [SPARK-19392][SQL] Fix the bug that throws an exception ...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16733 **[Test build #72120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72120/testReport)** for PR 16733 at commit

[GitHub] spark pull request #16733: [SPARK-19392][SQL] Fix the bug that throws an exc...

2017-01-28 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/16733 [SPARK-19392][SQL] Fix the bug that throws an exception when using numeric types in Oracle JDBC ## What changes were proposed in this pull request? In OracleDialect, if you use Numeric types in

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346104 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -78,14 +78,18 @@ object Canonicalize extends {

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346062 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98346066 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSetSuite.scala --- @@ -32,6 +32,38 @@ class ExpressionSetSuite

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98345869 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -78,14 +78,18 @@ object Canonicalize extends {

[GitHub] spark pull request #16719: [SPARK-19385][SQL] During canonicalization, `NOT(...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16719#discussion_r98345847 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala --- @@ -78,14 +78,18 @@ object Canonicalize extends {

[GitHub] spark issue #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() op...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16732 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request #16732: [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatr...

2017-01-28 Thread uzadude
GitHub user uzadude opened a pull request: https://github.com/apache/spark/pull/16732 [SPARK-19368][MLlib] BlockMatrix.toIndexedRowMatrix() optimization for sparse matrices ## What changes were proposed in this pull request? Optimization [SPARK-12869] was made for dense

[GitHub] spark pull request #16710: [SPARK-18872][SQL][TESTS] New test cases for EXIS...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16710#discussion_r98345474 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-basic.sql --- @@ -0,0 +1,115 @@ +-- Tests EXISTS subquery

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16724 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72119/ Test PASSed. ---

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16724 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16724 **[Test build #72119 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72119/testReport)** for PR 16724 at commit

[GitHub] spark issue #16710: [SPARK-18872][SQL][TESTS] New test cases for EXISTS subq...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16710 Could you update the PR descriptions? Currently, it does not correctly describe the cases you added. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #16712: [SPARK-18873][SQL][TEST] New test cases for scalar subqu...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16712 What is the part-2 for scalar subquery test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request #16712: [SPARK-18873][SQL][TEST] New test cases for scala...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16712#discussion_r98345077 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-select.sql --- @@ -0,0 +1,139 @@ +-- A test suite

[GitHub] spark pull request #16712: [SPARK-18873][SQL][TEST] New test cases for scala...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16712#discussion_r98345076 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-select.sql --- @@ -0,0 +1,139 @@ +-- A test suite

[GitHub] spark pull request #16712: [SPARK-18873][SQL][TEST] New test cases for scala...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/16712#discussion_r98345044 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/scalar-subquery/scalar-subquery-select.sql --- @@ -0,0 +1,139 @@ +-- A test suite

[GitHub] spark issue #16710: [SPARK-18872][SQL][TESTS] New test cases for EXISTS subq...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16710 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72118/ Test PASSed. ---

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16731 **[Test build #72118 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72118/testReport)** for PR 16731 at commit

[GitHub] spark pull request #16693: [SPARK-19152][SQL][followup] simplify CreateHiveT...

2017-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16693 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16693 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16731 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16731 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72117/ Test PASSed. ---

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16731 **[Test build #72117 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72117/testReport)** for PR 16731 at commit

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16724 **[Test build #72119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72119/testReport)** for PR 16724 at commit

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/16724 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16724 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72116/ Test FAILed. ---

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16724 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16724 **[Test build #72116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72116/testReport)** for PR 16724 at commit

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16731 **[Test build #72118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72118/testReport)** for PR 16731 at commit

[GitHub] spark issue #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16731 **[Test build #72117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72117/testReport)** for PR 16731 at commit

[GitHub] spark pull request #16731: [WIP][SPARK-][SQL] Add `approx_percentile` Datafr...

2017-01-28 Thread lw-lin
GitHub user lw-lin opened a pull request: https://github.com/apache/spark/pull/16731 [WIP][SPARK-][SQL] Add `approx_percentile` Dataframe API ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch

[GitHub] spark issue #16724: [SPARK-19352][SQL] Keep sort order of rows after externa...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16724 **[Test build #72116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72116/testReport)** for PR 16724 at commit

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72115/ Test PASSed. ---

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14702 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14702 **[Test build #72115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72115/testReport)** for PR 14702 at commit

[GitHub] spark issue #15279: SPARK-12347 [ML][WIP] Add a script to test Spark ML exam...

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/15279 @ethanluoyc this seems reasonable although I'm not 100% how this go yet. `wordcount.py` in the yml file - does it mean 1 yml for all examples? I think perhaps we need a way for the example to

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98341289 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala --- @@ -143,7 +150,12 @@ private[r] object

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14702 **[Test build #72115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72115/testReport)** for PR 14702 at commit

[GitHub] spark issue #14702: [SPARK-15694] Implement ScriptTransformation in sql/core...

2017-01-28 Thread tejasapatil
Github user tejasapatil commented on the issue: https://github.com/apache/spark/pull/14702 Jenkins retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98341193 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -77,6 +77,18 @@ test_that("spark.glm and predict", { out <-

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16730 thanks, i'd be great if you could add some tests for this - perhaps just to check the correct type and/or a subset of values --- If your project is set up for it, you can reply to this email

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16730 @actuaryzhang since this changes the output, could you open a JIRA for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98341050 --- Diff: mllib/src/main/scala/org/apache/spark/ml/r/GeneralizedLinearRegressionWrapper.scala --- @@ -81,15 +83,20 @@ private[r] object

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98341028 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -77,6 +77,18 @@ test_that("spark.glm and predict", { out <-

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98341000 --- Diff: R/pkg/R/mllib_regression.R --- @@ -109,7 +125,8 @@ setMethod("spark.glm", signature(data = "SparkDataFrame", formula = "formula"),

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98340946 --- Diff: R/pkg/R/mllib_regression.R --- @@ -84,6 +84,12 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' # can also read

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16729 I did look into this... I think it's great if `statmod` is there and we support it, but I'm concerned that we can't enable this `tweedie` family without an external dependency and the fact that

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98340892 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -77,6 +77,18 @@ test_that("spark.glm and predict", { out <-

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98340879 --- Diff: R/pkg/R/mllib_regression.R --- @@ -84,6 +84,12 @@ setClass("IsotonicRegressionModel", representation(jobj = "jobj")) #' # can also read

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/16729#discussion_r98340835 --- Diff: R/pkg/inst/tests/testthat/test_mllib_regression.R --- @@ -77,6 +77,18 @@ test_that("spark.glm and predict", { out <-

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72114/ Test FAILed. ---

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72114/testReport)** for PR 16729 at commit

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16730 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72113/ Test PASSed. ---

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16730 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16730 **[Test build #72113 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72113/testReport)** for PR 16730 at commit

[GitHub] spark issue #16700: [SPARK-19359][SQL]clear useless path after rename a part...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16700 Just revert it. Let us wait for the decision how we plan to deal with the file renaming. My major concern is the errors in file renaming could cause the data loss, unless we can introduce a

[GitHub] spark pull request #16728: [SPARK-19359][SQL] Revert Clear useless path afte...

2017-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #16728: [SPARK-19359][SQL] Revert Clear useless path after renam...

2017-01-28 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/16728 Mergint to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72114/testReport)** for PR 16729 at commit

[GitHub] spark issue #16730: [Minor][SparkR]Convert coefficients in summary to matrix

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16730 **[Test build #72113 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72113/testReport)** for PR 16730 at commit

[GitHub] spark pull request #16730: [Minor][SparkR]Convert coefficients in summary to...

2017-01-28 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/16730 [Minor][SparkR]Convert coefficients in summary to matrix ## What changes were proposed in this pull request? The `coefficients` component in model summary should be 'matrix' but the

[GitHub] spark issue #16728: [SPARK-19359][SQL] Revert Clear useless path after renam...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16728 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72110/ Test PASSed. ---

[GitHub] spark issue #16728: [SPARK-19359][SQL] Revert Clear useless path after renam...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16728 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16728: [SPARK-19359][SQL] Revert Clear useless path after renam...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16728 **[Test build #72110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72110/testReport)** for PR 16728 at commit

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72112/ Test FAILed. ---

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72112/testReport)** for PR 16729 at commit

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72112/testReport)** for PR 16729 at commit

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72111/testReport)** for PR 16729 at commit

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16729 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72111/ Test FAILed. ---

[GitHub] spark issue #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16729 **[Test build #72111 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72111/testReport)** for PR 16729 at commit

[GitHub] spark pull request #16729: [SPARK-19391][SparkR][ML] Tweedie GLM API for Spa...

2017-01-28 Thread actuaryzhang
GitHub user actuaryzhang opened a pull request: https://github.com/apache/spark/pull/16729 [SPARK-19391][SparkR][ML] Tweedie GLM API for SparkR ## What changes were proposed in this pull request? Port Tweedie GLM #16344 to SparkR @felixcheung @yanboliang ##

[GitHub] spark issue #15053: [SPARK-18069][Doc] improve python API docstrings

2017-01-28 Thread mortada
Github user mortada commented on the issue: https://github.com/apache/spark/pull/15053 @HyukjinKwon my apologies for not having been able to follow up on this. I still think this doc improvement would be very helpful to pyspark users. Would you like to take over the PR?

[GitHub] spark issue #16728: [SPARK-19359][SQL] Revert Clear useless path after renam...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16728 **[Test build #72110 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72110/testReport)** for PR 16728 at commit

[GitHub] spark pull request #16728: [SPARK-19359][SQL] Revert Clear useless path afte...

2017-01-28 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/16728 [SPARK-19359][SQL] Revert Clear useless path after rename a partition with upper-case by HiveExternalCatalog ### What changes were proposed in this pull request? This PR is to revert

[GitHub] spark issue #16726: [SPARK-19390][SQL] Replace the unnecessary usages of hiv...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16726 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72108/ Test PASSed. ---

[GitHub] spark issue #16726: [SPARK-19390][SQL] Replace the unnecessary usages of hiv...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16726 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16726: [SPARK-19390][SQL] Replace the unnecessary usages of hiv...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16726 **[Test build #72108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72108/testReport)** for PR 16726 at commit

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16693 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16693 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/72109/ Test PASSed. ---

[GitHub] spark issue #16693: [SPARK-19152][SQL][followup] simplify CreateHiveTableAsS...

2017-01-28 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16693 **[Test build #72109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/72109/testReport)** for PR 16693 at commit

  1   2   >