[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81248/ Test FAILed. ---

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81248 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81248/testReport)** for PR 19082 at commit

[GitHub] spark pull request #18317: [SPARK-21113][CORE] Read ahead input stream to am...

2017-08-29 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/18317#discussion_r135975209 --- Diff: core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java --- @@ -0,0 +1,292 @@ +/* + * Licensed under the Apache License, Version

[GitHub] spark pull request #19079: [SPARK-21859][CORE] Fix SparkFiles.get failed on ...

2017-08-29 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19079#discussion_r135973949 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -481,7 +481,7 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81246/ Test PASSed. ---

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81246/testReport)** for PR 19055 at commit

[GitHub] spark pull request #19079: [SPARK-21859][CORE] Fix SparkFiles.get failed on ...

2017-08-29 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19079#discussion_r135973543 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -481,7 +481,7 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark issue #19069: [MINOR][SQL][TEST]Test shuffle hash join while is not ex...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19069 **[Test build #81250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81250/testReport)** for PR 19069 at commit

[GitHub] spark issue #19069: [MINOR][SQL][TEST]Test shuffle hash join while is not ex...

2017-08-29 Thread sameeragarwal
Github user sameeragarwal commented on the issue: https://github.com/apache/spark/pull/19069 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19074 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81243/ Test PASSed. ---

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81244/ Test PASSed. ---

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19055 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19074 **[Test build #81243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81243/testReport)** for PR 19074 at commit

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81244 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81244/testReport)** for PR 19055 at commit

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19074 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81242/ Test PASSed. ---

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19074 **[Test build #81242 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81242/testReport)** for PR 19074 at commit

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135970632 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -92,7 +92,24 @@ abstract class SparkPlan extends

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135970084 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -153,6 +139,14 @@ case class

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2017-08-29 Thread VigneshMohan1
Github user VigneshMohan1 commented on the issue: https://github.com/apache/spark/pull/16578 @viirya @gatorsmile This pull request will help us improve the performance of nested queries by a larger margin. This pull request performs well with deeper level nests. I would like to have

[GitHub] spark pull request #19079: [SPARK-21859][CORE] Fix SparkFiles.get failed on ...

2017-08-29 Thread lgrcyanny
Github user lgrcyanny commented on a diff in the pull request: https://github.com/apache/spark/pull/19079#discussion_r135968835 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -481,7 +481,7 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark issue #18971: [SPARK-21764][TESTS] Fix tests failures on Windows: reso...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18971 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18971: [SPARK-21764][TESTS] Fix tests failures on Windows: reso...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18971 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81239/ Test PASSed. ---

[GitHub] spark issue #18971: [SPARK-21764][TESTS] Fix tests failures on Windows: reso...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18971 **[Test build #81239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81239/testReport)** for PR 18971 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81245/ Test FAILed. ---

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81245/testReport)** for PR 19083 at commit

[GitHub] spark issue #18317: [SPARK-21113][CORE] Read ahead input stream to amortize ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18317 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18317: [SPARK-21113][CORE] Read ahead input stream to amortize ...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18317 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81238/ Test PASSed. ---

[GitHub] spark issue #18317: [SPARK-21113][CORE] Read ahead input stream to amortize ...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18317 **[Test build #81238 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81238/testReport)** for PR 18317 at commit

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135967051 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -92,7 +92,24 @@ abstract class SparkPlan extends

[GitHub] spark issue #17014: [SPARK-18608][ML] Fix double-caching in ML algorithms

2017-08-29 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17014 @zhengruifeng OK. so the the part of `KMeans` in this PR still works. No need change I think. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135966814 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark issue #18573: [SPARK-21349][CORE] Make TASK_SIZE_TO_WARN_KB configurab...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18573 **[Test build #81249 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81249/testReport)** for PR 18573 at commit

[GitHub] spark issue #18573: [SPARK-21349][CORE] Make TASK_SIZE_TO_WARN_KB configurab...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/18573 Rebased to the master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/18111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol to han...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18111 Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #19069: [MINOR][SQL][TEST]Test shuffle hash join while is not ex...

2017-08-29 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/19069 @gatorsmile good, i have add assert to all the other test cases in this suite. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request #19062: [SPARK-21845] [SQL] Make codegen fallback of expr...

2017-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19062 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark issue #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol to han...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18111 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol to han...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18111 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81237/ Test PASSed. ---

[GitHub] spark issue #18111: [SPARK-20886][CORE] HadoopMapReduceCommitProtocol to han...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18111 **[Test build #81237 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81237/testReport)** for PR 18111 at commit

[GitHub] spark issue #19062: [SPARK-21845] [SQL] Make codegen fallback of expressions...

2017-08-29 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19062 Thanks! Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #18999: [SPARK-21779][PYTHON] Simpler DataFrame.sample API in Py...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/18999 cc @holdenk and @ueshin, could you maybe take a look when you have some time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135964775 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81248 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81248/testReport)** for PR 19082 at commit

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19082 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81247 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81247/testReport)** for PR 19055 at commit

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81235/ Test FAILed. ---

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19082 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19082: [SPARK-21870][SQL] Split aggregation code into small fun...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19082 **[Test build #81235 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81235/testReport)** for PR 19082 at commit

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81246/testReport)** for PR 19055 at commit

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19055 According to your review comments, I updated the comment , too. Thank you again for spending your time to review my PRs! --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135959594 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135959469 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/19084 `MinMaxScalerSuite` fails because `MinMaxScaler` need the behavior of ignoring `NaN`. So I think there are 2 options: 1, `MultivariateOnlineSummarizer/Summarizer` support param

[GitHub] spark pull request #19079: [SPARK-21859][CORE] Fix SparkFiles.get failed on ...

2017-08-29 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/19079#discussion_r135958924 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -481,7 +481,7 @@ object SparkSubmit extends CommandLineUtils {

[GitHub] spark issue #19079: [SPARK-21859][CORE] Fix SparkFiles.get failed on driver ...

2017-08-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19079 Currently for Spark yarn-client application, we don't support fetching files using above `SparkFiles.get` API. Since you already know where the file is in client mode, so may be you don't need to

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81245/testReport)** for PR 19083 at commit

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19084 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19084 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81240/ Test FAILed. ---

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135958401 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19084 **[Test build #81240 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81240/testReport)** for PR 19084 at commit

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135958308 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135957924 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135957834 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19055 **[Test build #81244 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81244/testReport)** for PR 19055 at commit

[GitHub] spark issue #16138: [SPARK-16609] Add to_date/to_timestamp with format funct...

2017-08-29 Thread anabranch
Github user anabranch commented on the issue: https://github.com/apache/spark/pull/16138 I don't think this is necessarily my call but you're effectively writing a hive udf, not a Spark one that depends on this. Writing a Spark UDF would allow this to work just fine and the

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19074 **[Test build #81243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81243/testReport)** for PR 19074 at commit

[GitHub] spark issue #17014: [SPARK-18608][ML] Fix double-caching in ML algorithms

2017-08-29 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/17014 @WeichenXu123 Current impl of `mllib.KMeans` seems do not support caching, it just (log

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135957524 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/19074 @vanzin @srowen pushed another commit to change 2.10 repl code, I tested locally with 2.10 code, please review. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark issue #19055: [SPARK-21839][SQL] Support SQL config for ORC compressio...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/19055 Thank you very much for review, @HyukjinKwon ! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark issue #19074: [SPARK-21714][CORE][BACKPORT-2.2] Avoiding re-uploading ...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19074 **[Test build #81242 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81242/testReport)** for PR 19074 at commit

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135957150 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135956962 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala --- @@ -18,12 +18,13 @@ package

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135956579 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -20,30 +20,33 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark pull request #19055: [SPARK-21839][SQL] Support SQL config for ORC com...

2017-08-29 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/19055#discussion_r135955950 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala --- @@ -18,12 +18,13 @@ package org.apache.spark.sql.hive.orc

[GitHub] spark issue #17014: [SPARK-18608][ML] Fix double-caching in ML algorithms

2017-08-29 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/17014 @WeichenXu123 Agree that we should pass `handlePersistence` to mllib impl. Thanks for pointing it out! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949966 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135950331 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -162,64 +156,40 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949262 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala --- @@ -153,6 +139,14 @@ case class

[GitHub] spark pull request #19080: [SPARK-21865][SQL] remove Partitioning.compatible...

2017-08-29 Thread tejasapatil
Github user tejasapatil commented on a diff in the pull request: https://github.com/apache/spark/pull/19080#discussion_r135949500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala --- @@ -30,18 +30,32 @@ import

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81241 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81241/testReport)** for PR 19083 at commit

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19083 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81241/ Test FAILed. ---

[GitHub] spark issue #17014: [SPARK-18608][ML] Fix double-caching in ML algorithms

2017-08-29 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/17014 cc @zhengruifeng I update my comment you need check again, thanks! I read the PR again, it still do not resolve double-caching issue in KMeans. in KMean, your code

[GitHub] spark issue #18576: [SPARK-21351][SQL] Update nullability based on children'...

2017-08-29 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/18576 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-08-29 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19083#discussion_r135955285 --- Diff: sql/core/src/test/resources/sql-tests/inputs/group-by.sql --- @@ -30,8 +30,15 @@ SELECT a + 2, COUNT(b) FROM testData GROUP BY a + 1; SELECT a

[GitHub] spark issue #19083: [SPARK-21871][SQL] Check actual bytecode size when compi...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19083 **[Test build #81241 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81241/testReport)** for PR 19083 at commit

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19084 **[Test build #81240 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81240/testReport)** for PR 19084 at commit

[GitHub] spark issue #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer/Summarizer...

2017-08-29 Thread zhengruifeng
Github user zhengruifeng commented on the issue: https://github.com/apache/spark/pull/19084 ping @WeichenXu123 @srowen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #19084: [SPARK-20711][ML]MultivariateOnlineSummarizer inc...

2017-08-29 Thread zhengruifeng
GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/19084 [SPARK-20711][ML]MultivariateOnlineSummarizer incorrect min/max for NaN value ## What changes were proposed in this pull request? current impl of min/max ignore `NaN` for a

[GitHub] spark pull request #19083: [SPARK-21871][SQL] Check actual bytecode size whe...

2017-08-29 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/19083 [SPARK-21871][SQL] Check actual bytecode size when compiling generated code ## What changes were proposed in this pull request? This pr added code to check actual bytecode size when compiling

[GitHub] spark pull request #18787: [SPARK-21583][SQL] Create a ColumnarBatch from Ar...

2017-08-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18787#discussion_r135952994 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala --- @@ -111,6 +125,66 @@ private[sql] object ArrowConverters {

[GitHub] spark pull request #18787: [SPARK-21583][SQL] Create a ColumnarBatch from Ar...

2017-08-29 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18787#discussion_r135952996 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/arrow/ArrowConvertersSuite.scala --- @@ -1629,6 +1632,39 @@ class ArrowConvertersSuite

[GitHub] spark issue #18860: [SPARK-21254] [WebUI] History UI performance fixes

2017-08-29 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18860 **[Test build #3911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3911/testReport)** for PR 18860 at commit

  1   2   3   4   5   >