[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20024 I feel it's not the most effcient way to cast array to string by deserializing the catalyst array to java array. Instead, I think we should have a schema-aware string casting function, i.e. using

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19813 To me whole stage codegen compilation fix is less important as we can fallback to non whole stage codegen, so we don't need to rush. > As we don't use such statement as codegen output, I

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158441506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -56,7 +56,36 @@ import

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 @gczsjdy By this, we can easily know what the output is. Is it a global variable, a local variable or a literal? For now, we just get a string. It makes us hard to act according to the type of

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20024 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20052: [SPARK-20694][EXAMPLES]Update SQLDataSourceExample.scala

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20052 Can you printed out the generated doc after the changes? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20025 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85299/ Test PASSed. ---

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #85299 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)** for PR 20025 at commit

[GitHub] spark issue #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Constant ...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20036 **[Test build #85300 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85300/testReport)** for PR 20036 at commit

[GitHub] spark pull request #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over...

2017-12-21 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/20010#discussion_r158440114 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -158,11 +169,6 @@ object TypeCoercion {

[GitHub] spark pull request #20010: [SPARK-22826][SQL] findWiderTypeForTwo Fails over...

2017-12-21 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/20010#discussion_r158440005 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -158,11 +213,8 @@ object TypeCoercion {

[GitHub] spark pull request #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Co...

2017-12-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20036#discussion_r158439773 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -118,9 +118,8 @@ case class Like(left:

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20025 **[Test build #85299 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85299/testReport)** for PR 20025 at commit

[GitHub] spark issue #20025: [SPARK-22837][SQL]Session timeout checker does not work ...

2017-12-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20025 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20025: [SPARK-22837][SQL]Session timeout checker does no...

2017-12-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20025#discussion_r158438561 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java --- @@ -148,6 +148,15 @@ public synchronized

[GitHub] spark pull request #20050: [SPARK-22864][core] Disable allocation schedule i...

2017-12-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20050#discussion_r158438115 --- Diff: core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala --- @@ -1063,6 +1067,9 @@ class ExecutorAllocationManagerSuite

[GitHub] spark issue #19683: [SPARK-21657][SQL] optimize explode quadratic memory con...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19683 the idea LGTM, it's a special column pruning inside Generate operator. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436989 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala --- @@ -474,10 +474,10 @@ abstract class SparkStrategies extends

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436905 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala --- @@ -227,4 +227,31 @@ class MiscBenchmark extends

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436824 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/MiscBenchmark.scala --- @@ -227,4 +227,31 @@ class MiscBenchmark extends

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436801 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -86,10 +96,24 @@ case class GenerateExec(

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436751 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -86,10 +96,24 @@ case class GenerateExec(

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20051 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20051 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85294/ Test PASSed. ---

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20051 **[Test build #85294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85294/testReport)** for PR 20051 at commit

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436519 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -86,10 +96,24 @@ case class GenerateExec(

[GitHub] spark issue #20053: [SPARK-22873] [CORE] Init lastReportTimestamp with syste...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20053 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19683: [SPARK-21657][SQL] optimize explode quadratic mem...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19683#discussion_r158436309 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/GenerateExec.scala --- @@ -59,13 +61,21 @@ case class GenerateExec( generator:

[GitHub] spark pull request #20053: Init lastReportTimestamp with system current time...

2017-12-21 Thread Ngone51
GitHub user Ngone51 opened a pull request: https://github.com/apache/spark/pull/20053 Init lastReportTimestamp with system current time when start() called… … in AsyncEventQueue ## What changes were proposed in this pull request? ``` if

[GitHub] spark pull request #19876: [ML][SPARK-11171][SPARK-11239] Add PMML export to...

2017-12-21 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/19876#discussion_r158434850 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala --- @@ -554,7 +555,49 @@ class LinearRegressionModel private[ml] (

[GitHub] spark pull request #20052: [SPARK-20694][EXAMPLES]Update SQLDataSourceExampl...

2017-12-21 Thread CNRui
GitHub user CNRui opened a pull request: https://github.com/apache/spark/pull/20052 [SPARK-20694][EXAMPLES]Update SQLDataSourceExample.scala ## What changes were proposed in this pull request? Create table using the right DataFrame. peopleDF->usersDF peopleDF:

[GitHub] spark issue #20052: [SPARK-20694][EXAMPLES]Update SQLDataSourceExample.scala

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20052 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread gczsjdy
Github user gczsjdy commented on the issue: https://github.com/apache/spark/pull/20043 @viirya Sorry I didn't quite understand, how do we easily know the value by adding wrappers? Could you explain a little bit? ---

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18754 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85293/ Test PASSed. ---

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18754 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20024: [SPARK-22825][SQL] Fix incorrect results of Casting Arra...

2017-12-21 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20024 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18754 **[Test build #85293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85293/testReport)** for PR 18754 at commit

[GitHub] spark pull request #20048: [SPARK-22862] Docs on lazy elimination of columns...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20048 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20048: [SPARK-22862] Docs on lazy elimination of columns missin...

2017-12-21 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20048 Thanks! Merged to master/2.2./2.1 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Co...

2017-12-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20036#discussion_r158430491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -194,9 +193,8 @@ case class RLike(left:

[GitHub] spark pull request #20036: [SPARK-18016][SQL][FOLLOW-UP] Code Generation: Co...

2017-12-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/20036#discussion_r158430481 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala --- @@ -118,9 +118,8 @@ case class Like(left:

[GitHub] spark issue #20026: [SPARK-22838][Core] Avoid unnecessary copying of data

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20026 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20026: [SPARK-22838][Core] Avoid unnecessary copying of data

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20026 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85292/ Test PASSed. ---

[GitHub] spark issue #20026: [SPARK-22838][Core] Avoid unnecessary copying of data

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20026 **[Test build #85292 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85292/testReport)** for PR 20026 at commit

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19977 **[Test build #85298 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85298/testReport)** for PR 19977 at commit

[GitHub] spark issue #11994: [SPARK-14151] Expose metrics Source and Sink interface

2017-12-21 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/11994 What's our thought on this, @jerryshao ? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19813: [SPARK-22600][SQL] Fix 64kb limit for deeply nested expr...

2017-12-21 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19813 I think that this PR is necessary to fix SPARK-22868 and SPARK-22869 --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes ...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20051 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/20051 Merged, thanks @foxish --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20043 Thanks. If we have forseen this need in near future, do we bother to combine them here and separate it again later? On Dec 22, 2017 12:02 PM, "Kazuaki Ishizaki"

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158429095 --- Diff: sql/core/src/test/resources/sql-tests/results/string-functions.sql.out --- @@ -42,7 +42,7 @@ struct == Analyzed Logical Plan ==

[GitHub] spark pull request #19977: [SPARK-22771][SQL] Concatenate binary inputs into...

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19977#discussion_r158428849 --- Diff: sql/core/src/test/resources/sql-tests/results/string-functions.sql.out --- @@ -42,7 +42,7 @@ struct == Analyzed Logical Plan ==

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20051 **[Test build #85297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85297/testReport)** for PR 20051 at commit

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20051 Done, comments updated. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19977 **[Test build #85296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85296/testReport)** for PR 19977 at commit

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-21 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/19977 ok, all comments addressed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19977: [SPARK-22771][SQL] Concatenate binary inputs into a bina...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19977 **[Test build #85295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85295/testReport)** for PR 19977 at commit

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread foxish
Github user foxish commented on the issue: https://github.com/apache/spark/pull/20051 @mridulm thanks for looking into it! Looks like I missed updating the dockerfile comments. On it. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85291/ Test PASSed. ---

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/20051 A grep indicates this is the full list: * ./resource-managers/kubernetes/docker/src/main/dockerfiles/driver/Dockerfile:# docker build -t spark-driver:latest -f

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20043 **[Test build #85291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85291/testReport)** for PR 20043 at commit

[GitHub] spark pull request #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes ...

2017-12-21 Thread foxish
Github user foxish commented on a diff in the pull request: https://github.com/apache/spark/pull/20051#discussion_r158427619 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/Dockerfile --- @@ -38,7 +38,7 @@ COPY jars /opt/spark/jars COPY bin

[GitHub] spark pull request #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes ...

2017-12-21 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/20051#discussion_r158427437 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark-base/Dockerfile --- @@ -38,7 +38,7 @@ COPY jars /opt/spark/jars COPY bin

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19893 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85290/ Test PASSed. ---

[GitHub] spark issue #19893: [SPARK-16139][TEST] Add logging functionality for leaked...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19893 **[Test build #85290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85290/testReport)** for PR 19893 at commit

[GitHub] spark pull request #20043: [SPARK-22856][SQL] Add wrappers for codegen outpu...

2017-12-21 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20043#discussion_r158426351 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -56,7 +56,36 @@ import

[GitHub] spark pull request #20039: [SPARK-22850][core] Ensure queued events are deli...

2017-12-21 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20039#discussion_r158424923 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -149,7 +158,11 @@ private[spark] class LiveListenerBus(conf:

[GitHub] spark pull request #20039: [SPARK-22850][core] Ensure queued events are deli...

2017-12-21 Thread gczsjdy
Github user gczsjdy commented on a diff in the pull request: https://github.com/apache/spark/pull/20039#discussion_r158424211 --- Diff: core/src/main/scala/org/apache/spark/scheduler/LiveListenerBus.scala --- @@ -124,13 +127,19 @@ private[spark] class LiveListenerBus(conf:

[GitHub] spark issue #19984: [SPARK-22789] Map-only continuous processing execution

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19984 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19984: [SPARK-22789] Map-only continuous processing execution

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19984 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85287/ Test PASSed. ---

[GitHub] spark issue #20013: [SPARK-20657][core] Speed up rendering of the stages pag...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20013 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85289/ Test PASSed. ---

[GitHub] spark issue #19984: [SPARK-22789] Map-only continuous processing execution

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19984 **[Test build #85287 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85287/testReport)** for PR 19984 at commit

[GitHub] spark issue #20013: [SPARK-20657][core] Speed up rendering of the stages pag...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20013 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19872: WIP: [SPARK-22274][PySpark] User-defined aggregat...

2017-12-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/19872#discussion_r158423362 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/python/AggregateInPandasExec.scala --- @@ -0,0 +1,143 @@ +/* + * Licensed to the

[GitHub] spark issue #20013: [SPARK-20657][core] Speed up rendering of the stages pag...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20013 **[Test build #85289 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85289/testReport)** for PR 20013 at commit

[GitHub] spark issue #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerf...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20051 **[Test build #85294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85294/testReport)** for PR 20051 at commit

[GitHub] spark pull request #20051: [SPARK-22866] [K8S] Fix path issue in Kubernetes ...

2017-12-21 Thread foxish
GitHub user foxish opened a pull request: https://github.com/apache/spark/pull/20051 [SPARK-22866] [K8S] Fix path issue in Kubernetes dockerfile ## What changes were proposed in this pull request? The path was recently changed in https://github.com/apache/spark/pull/19946,

[GitHub] spark pull request #18754: [WIP][SPARK-21552][SQL] Add DecimalType support t...

2017-12-21 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/18754#discussion_r158422348 --- Diff: python/pyspark/sql/types.py --- @@ -1617,7 +1617,7 @@ def to_arrow_type(dt): elif type(dt) == DoubleType: arrow_type =

[GitHub] spark issue #18754: [WIP][SPARK-21552][SQL] Add DecimalType support to Arrow...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/18754 **[Test build #85293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85293/testReport)** for PR 18754 at commit

[GitHub] spark pull request #19950: [SPARK-22450][Core][MLLib][FollowUp] safely regis...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19950 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19950: [SPARK-22450][Core][MLLib][FollowUp] safely register cla...

2017-12-21 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19950 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20020: [SPARK-22834][SQL] Make insertion commands have real chi...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20020 @gatorsmile This PR focus on the commands that using `FileFormatWriter`. I will investigate how to resolve the other Insertion commands and create a followup PR, is that OK? ---

[GitHub] spark issue #20050: [SPARK-22864][core] Disable allocation schedule in Execu...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20050 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85286/ Test PASSed. ---

[GitHub] spark issue #20050: [SPARK-22864][core] Disable allocation schedule in Execu...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20050 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20050: [SPARK-22864][core] Disable allocation schedule in Execu...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20050 **[Test build #85286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85286/testReport)** for PR 20050 at commit

[GitHub] spark pull request #19940: [SPARK-22750][SQL] Reuse mutable states when poss...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19940 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19940: [SPARK-22750][SQL] Reuse mutable states when possible

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19940 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20020: [SPARK-22834][SQL] Make insertion commands have r...

2017-12-21 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20020#discussion_r158416541 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -479,14 +468,15 @@ case class DataSource(

[GitHub] spark issue #20026: [SPARK-22838][Core] Avoid unnecessary copying of data

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20026 **[Test build #85292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85292/testReport)** for PR 20026 at commit

[GitHub] spark issue #19884: [SPARK-22324][SQL][PYTHON] Upgrade Arrow to 0.8.0

2017-12-21 Thread zsxwing
Github user zsxwing commented on the issue: https://github.com/apache/spark/pull/19884 @HyukjinKwon yeah, I closed the ticket. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20049: [SPARK-22854][ui] Read Spark version from event l...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20049 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20043: [SPARK-22856][SQL] Add wrappers for codegen output and n...

2017-12-21 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20043 **[Test build #85291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85291/testReport)** for PR 20043 at commit

[GitHub] spark issue #20049: [SPARK-22854][ui] Read Spark version from event logs.

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20049 merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20049: [SPARK-22854][ui] Read Spark version from event logs.

2017-12-21 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20049 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19946: [SPARK-22648] [K8S] Spark on Kubernetes - Documen...

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19946 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19946: [SPARK-22648] [K8S] Spark on Kubernetes - Documentation

2017-12-21 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/19946 Merging in master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20039: [SPARK-22850][core] Ensure queued events are delivered t...

2017-12-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20039 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   4   5   6   >