[GitHub] [spark] SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor.

2020-02-18 Thread GitBox
SparkQA commented on issue #26193: [SPARK-25065][k8s] Allow setting up correct logging configuration on driver and executor. URL: https://github.com/apache/spark/pull/26193#issuecomment-588084045 **[Test build #118665 has

[GitHub] [spark] cloud-fan closed pull request #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
cloud-fan closed pull request #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630 This is an automated message from the

[GitHub] [spark] cloud-fan commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
cloud-fan commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588083598 thanks, merging to master/3.0!

[GitHub] [spark] AmplabJenkins removed a comment on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081768 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081759 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081768 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081759 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
SparkQA commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081239 **[Test build #118664 has

[GitHub] [spark] xuanyuanking commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
xuanyuanking commented on issue #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633#issuecomment-588081209 cc @cloud-fan @gatorsmile

[GitHub] [spark] xuanyuanking opened a new pull request #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured

2020-02-18 Thread GitBox
xuanyuanking opened a new pull request #27633: [SPARK-30556][SQL][BACKPORT-2.4] Reset the status changed in SQLExecution withThreadLocalCaptured URL: https://github.com/apache/spark/pull/27633 ### What changes were proposed in this pull request? Follow up for #27267, reset the status

[GitHub] [spark] beliefer commented on issue #27431: [MINOR][SQL] Improve readability for window execution

2020-02-18 Thread GitBox
beliefer commented on issue #27431: [MINOR][SQL] Improve readability for window execution URL: https://github.com/apache/spark/pull/27431#issuecomment-588075144 @cloud-fan @hvanhovell @HyukjinKwon @dongjoon-hyun Thanks for all your help.

[GitHub] [spark] prakharjain09 edited a comment on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager

2020-02-18 Thread GitBox
prakharjain09 edited a comment on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-588066491 @Ngone51 @cloud-fan Can you please approve and merge the changes if everything looks

[GitHub] [spark] cloud-fan commented on issue #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table

2020-02-18 Thread GitBox
cloud-fan commented on issue #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table URL: https://github.com/apache/spark/pull/27538#issuecomment-588067924 thanks, merging to master/3.0!

[GitHub] [spark] cloud-fan closed pull request #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table

2020-02-18 Thread GitBox
cloud-fan closed pull request #27538: [SPARK-30785][SQL] Create table like should keep tracksPartitionsInCatalog same with source table URL: https://github.com/apache/spark/pull/27538 This is an automated message from the

[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager

2020-02-18 Thread GitBox
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-588066491 @Ngone51 @cloud-fan Can you please review and merge the changes if everything looks good.

[GitHub] [spark] prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager

2020-02-18 Thread GitBox
prakharjain09 commented on issue #27539: [SPARK-30786] [CORE] Fix Block replication failure propogation issue in BlockManager URL: https://github.com/apache/spark/pull/27539#issuecomment-588066239 > @prakharjain09 actually, you could also try "Jenkins, retest this please" when you want to

[GitHub] [spark] HeartSaVioR commented on issue #27398: [SPARK-30481][DOCS][FOLLOWUP] Document event log compaction into new section of monitoring.md

2020-02-18 Thread GitBox
HeartSaVioR commented on issue #27398: [SPARK-30481][DOCS][FOLLOWUP] Document event log compaction into new section of monitoring.md URL: https://github.com/apache/spark/pull/27398#issuecomment-588065574 @dongjoon-hyun @tgravescs Kindly reminder.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632#issuecomment-588059400 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632#issuecomment-588059392 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632#issuecomment-588059400 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632#issuecomment-588059392 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
SparkQA commented on issue #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632#issuecomment-588058965 **[Test build #118663 has

[GitHub] [spark] wangyum opened a new pull request #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes

2020-02-18 Thread GitBox
wangyum opened a new pull request #27632: [WIP][SPARK-30872][SQL] Constraints inferred from inferred attributes URL: https://github.com/apache/spark/pull/27632 ### What changes were proposed in this pull request? This PR fix a special case about infer additional constraints. How to

[GitHub] [spark] cloud-fan commented on issue #27431: [MINOR][SQL] Improve readability for window execution

2020-02-18 Thread GitBox
cloud-fan commented on issue #27431: [MINOR][SQL] Improve readability for window execution URL: https://github.com/apache/spark/pull/27431#issuecomment-588057354 thanks, merging to master/3.0! This is an automated message

[GitHub] [spark] cloud-fan closed pull request #27431: [MINOR][SQL] Improve readability for window execution

2020-02-18 Thread GitBox
cloud-fan closed pull request #27431: [MINOR][SQL] Improve readability for window execution URL: https://github.com/apache/spark/pull/27431 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588049830 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588049843 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588049843 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588049830 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
SparkQA removed a comment on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-587991700 **[Test build #118660 has

[GitHub] [spark] SparkQA commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization"

2020-02-18 Thread GitBox
SparkQA commented on issue #27630: [SPARK-30812] [SQL] update the skew join configs by adding the prefix "skewedJoinOptimization" URL: https://github.com/apache/spark/pull/27630#issuecomment-588049265 **[Test build #118660 has

[GitHub] [spark] cloud-fan commented on a change in pull request #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
cloud-fan commented on a change in pull request #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#discussion_r381090086 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-588047727 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047672 Test PASSed. Refer to this link for build results (access rights to

[GitHub] [spark] AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-588047720 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047668 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-588047727 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-588047720 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047672 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] [spark] AmplabJenkins commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047668 Merged build finished. Test PASSed.

[GitHub] [spark] cloud-fan commented on a change in pull request #27622: [SPARK-27528][followup] improve migration guide

2020-02-18 Thread GitBox
cloud-fan commented on a change in pull request #27622: [SPARK-27528][followup] improve migration guide URL: https://github.com/apache/spark/pull/27622#discussion_r381088243 ## File path: docs/sql-migration-guide.md ## @@ -87,7 +87,7 @@ license: | - In Spark version

[GitHub] [spark] SparkQA commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
SparkQA commented on issue #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#issuecomment-588047393 **[Test build #118662 has

[GitHub] [spark] SparkQA commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
SparkQA commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047374 **[Test build #118661 has

[GitHub] [spark] iRakson commented on a change in pull request #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions

2020-02-18 Thread GitBox
iRakson commented on a change in pull request #27580: [SPARK-27619][SQL]MapType should be prohibited in hash expressions URL: https://github.com/apache/spark/pull/27580#discussion_r381088173 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala ##

[GitHub] [spark] beliefer commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
beliefer commented on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047099 cc @cloud-fan

[GitHub] [spark] beliefer edited a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
beliefer edited a comment on issue #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631#issuecomment-588047099 cc @cloud-fan @maropu

[GitHub] [spark] beliefer opened a new pull request #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
beliefer opened a new pull request #27631: [SPARK-30763][SQL][FOLLOWUP] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27631 ### What changes were proposed in this pull request? This PR follows

[GitHub] [spark] cloud-fan commented on issue #27624: [SPARK-30814][SQL][3.0] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added

2020-02-18 Thread GitBox
cloud-fan commented on issue #27624: [SPARK-30814][SQL][3.0] ALTER TABLE ... ADD COLUMN position should be able to reference columns being added URL: https://github.com/apache/spark/pull/27624#issuecomment-588046095 thanks, merging to 3.0!

[GitHub] [spark] jiangxb1987 commented on a change in pull request #27072: [SPARK-30404][Core] Fix wrong log for FetchFailed task's successful speculation

2020-02-18 Thread GitBox
jiangxb1987 commented on a change in pull request #27072: [SPARK-30404][Core] Fix wrong log for FetchFailed task's successful speculation URL: https://github.com/apache/spark/pull/27072#discussion_r381084318 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27550: [SPARK-30799][SQL] "spark_catalog.t" should not be resolved to temp view

2020-02-18 Thread GitBox
cloud-fan commented on a change in pull request #27550: [SPARK-30799][SQL] "spark_catalog.t" should not be resolved to temp view URL: https://github.com/apache/spark/pull/27550#discussion_r381082389 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year

2020-02-18 Thread GitBox
cloud-fan commented on a change in pull request #27596: [SPARK-30843][SQL] Fix getting of time components before 1582 year URL: https://github.com/apache/spark/pull/27596#discussion_r381081926 ## File path: sql/core/benchmarks/DateTimeBenchmark-results.txt ## @@ -2,428

[GitHub] [spark] cloud-fan commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688

2020-02-18 Thread GitBox
cloud-fan commented on a change in pull request #27619: revert SPARK-29663 and SPARK-29688 URL: https://github.com/apache/spark/pull/27619#discussion_r381081689 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ## @@ -957,17 +957,4

[GitHub] [spark] wangyum commented on issue #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint

2020-02-18 Thread GitBox
wangyum commented on issue #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint URL: https://github.com/apache/spark/pull/27252#issuecomment-588039419 @gatorsmile Done This is an automated

[GitHub] [spark] beliefer edited a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
beliefer edited a comment on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27508#issuecomment-588030529 @gatorsmile OK. Let me take a look.

[GitHub] [spark] beliefer commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract

2020-02-18 Thread GitBox
beliefer commented on issue #27508: [SPARK-30763][SQL] Fix java.lang.IndexOutOfBoundsException No group 1 for regexp_extract URL: https://github.com/apache/spark/pull/27508#issuecomment-588030529 @gatorsmile OK This is an

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27610: [SPARK-30856][SQL][PySpark] Fix SQLContext.getOrCreate() when SparkContext is restarted

2020-02-18 Thread GitBox
HyukjinKwon commented on a change in pull request #27610: [SPARK-30856][SQL][PySpark] Fix SQLContext.getOrCreate() when SparkContext is restarted URL: https://github.com/apache/spark/pull/27610#discussion_r381072105 ## File path: python/pyspark/sql/session.py ## @@

[GitHub] [spark] liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2020-02-18 Thread GitBox
liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#discussion_r381071658 ## File path:

[GitHub] [spark] liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2020-02-18 Thread GitBox
liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#discussion_r381070895 ## File path:

[GitHub] [spark] liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats

2020-02-18 Thread GitBox
liupc commented on a change in pull request #26016: [SPARK-24914][SQL] New statistic to improve data size estimate for columnar storage formats URL: https://github.com/apache/spark/pull/26016#discussion_r381069711 ## File path:

[GitHub] [spark] gatorsmile commented on issue #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint

2020-02-18 Thread GitBox
gatorsmile commented on issue #27252: [SPARK-29231][SQL] Constraints should be inferred from cast equality constraint URL: https://github.com/apache/spark/pull/27252#issuecomment-588026713 @wangyum Could you update the PR description with the perf measurement?

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381063994 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTest.scala ## @@ -0,0 +1,100 @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381068169 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTestResult.scala ## @@ -0,0

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381064590 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTest.scala ## @@ -0,0 +1,100 @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381065990 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTest.scala ## @@ -0,0 +1,100 @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381067119 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTest.scala ## @@ -0,0 +1,100 @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27623: [SPARK-30867][ML] Add FValueRegressionTest URL: https://github.com/apache/spark/pull/27623#discussion_r381066633 ## File path: mllib/src/main/scala/org/apache/spark/ml/stat/SelectionTest.scala ## @@ -0,0 +1,100 @@

[GitHub] [spark] zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup

2020-02-18 Thread GitBox
zhengruifeng commented on a change in pull request #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#discussion_r381063088 ## File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala ## @@ -1049,7 +1049,7 @@ object ALS

[GitHub] [spark] zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup

2020-02-18 Thread GitBox
zhengruifeng commented on issue #27600: [MINOR][ML] ML cleanup URL: https://github.com/apache/spark/pull/27600#issuecomment-588020643 This should be a bug in scala-plugin of IDEA, it can not correctly infer the types if `.view` is used.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588018833 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588018827 Merged build finished. Test FAILed. This

[GitHub] [spark] AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588018827 Merged build finished. Test FAILed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588018833 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
SparkQA removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-587987972 **[Test build #118658 has

[GitHub] [spark] SparkQA commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
SparkQA commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588018592 **[Test build #118658 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-588016520 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-588016525 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-588016520 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588016060 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-588016525 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
SparkQA removed a comment on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-58798 **[Test build #118657 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588016051 Merged build finished. Test FAILed. This

[GitHub] [spark] SparkQA removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
SparkQA removed a comment on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-587989886 **[Test build #118659 has

[GitHub] [spark] SparkQA commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder

2020-02-18 Thread GitBox
SparkQA commented on issue #27592: [SPARK-30840][CORE][SQL] Add version property for ConfigEntry and ConfigBuilder URL: https://github.com/apache/spark/pull/27592#issuecomment-588016046 **[Test build #118657 has

[GitHub] [spark] AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588016060 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588016051 Merged build finished. Test FAILed. This is an

[GitHub] [spark] SparkQA commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext

2020-02-18 Thread GitBox
SparkQA commented on issue #27395: [SPARK-30667][CORE] Add allGather method to BarrierTaskContext URL: https://github.com/apache/spark/pull/27395#issuecomment-588015784 **[Test build #118659 has

[GitHub] [spark] HyukjinKwon commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped

2020-02-18 Thread GitBox
HyukjinKwon commented on issue #27002: [SPARK-30346][CORE]Improve logging when events dropped URL: https://github.com/apache/spark/pull/27002#issuecomment-588013199 also merged to branch-3.0. This is an automated message

[GitHub] [spark] gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-18 Thread GitBox
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r381050531 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] HyukjinKwon closed pull request #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark

2020-02-18 Thread GitBox
HyukjinKwon closed pull request #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark URL: https://github.com/apache/spark/pull/27614 This is an automated message

[GitHub] [spark] HyukjinKwon commented on issue #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark

2020-02-18 Thread GitBox
HyukjinKwon commented on issue #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark URL: https://github.com/apache/spark/pull/27614#issuecomment-588000534 Let me merge this one first - seems #27610 needs some more reviews.

[GitHub] [spark] HyukjinKwon commented on issue #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark

2020-02-18 Thread GitBox
HyukjinKwon commented on issue #27614: [SPARK-30861][PYTHON][SQL] Deprecate constructor of SQLContext and getOrCreate in SQLContext at PySpark URL: https://github.com/apache/spark/pull/27614#issuecomment-588000593 Merged to master and branch-3.0.

[GitHub] [spark] beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-18 Thread GitBox
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r381040836 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-18 Thread GitBox
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r381040836 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-18 Thread GitBox
beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r381040836 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] AmplabJenkins removed a comment on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#issuecomment-587995183 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] [spark] AmplabJenkins removed a comment on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
AmplabJenkins removed a comment on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#issuecomment-587995180 Merged build finished. Test PASSed.

[GitHub] [spark] gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments

2020-02-18 Thread GitBox
gengliangwang commented on a change in pull request #27495: [SPARK-28880][SQL] Support ANSI nested bracketed comments URL: https://github.com/apache/spark/pull/27495#discussion_r381038067 ## File path: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4

[GitHub] [spark] AmplabJenkins commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#issuecomment-587995183 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
AmplabJenkins commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#issuecomment-587995180 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes

2020-02-18 Thread GitBox
SparkQA commented on issue #27628: [SPARK-30858][SQL] Make IntegralDivide's dataType independent from SQL config changes URL: https://github.com/apache/spark/pull/27628#issuecomment-587994723 **[Test build #118654 has

  1   2   3   4   5   6   7   8   >