[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-16 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-55827933 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-16 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-55833607 @mengxr, do you know what this mima issue is by any chance? What do I have to fix? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-17 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-55982010 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-17 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2294#discussion_r17709652 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala --- @@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-17 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2294#discussion_r17709785 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -36,9 +37,42 @@ trait Matrix extends Serializable { /** Converts

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-18 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2294#discussion_r17746583 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala --- @@ -197,4 +201,368 @@ private[mllib] object BLAS extends Serializable

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-18 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-56089214 Tests for the Level 2 operations (gemv): nativeBLAS was faster across the board. Here are the results (in ms): m | n | f2j | native

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-18 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/2451 [WIP][SPARK-1486][MLlib] Multi Model Training with Gradient Descent **Note: This is still a work in progress** This is the first of the pull requests to support multi-model training

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-18 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-56116462 @ScrapCodes, I have some mima incompatibility issues here. I've added a few methods to the trait Matrix in MLlib, and that causes a MissingMethodProblem. I sealed

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-18 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-56123894 @ScrapCodes THANKS A LOT! That fixed it! I didn't realize I didn't update my local repo for such a long time. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-18 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17764905 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala --- @@ -197,4 +201,452 @@ private[mllib] object BLAS extends Serializable

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-18 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17765187 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala --- @@ -197,4 +201,452 @@ private[mllib] object BLAS extends Serializable

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2451#issuecomment-56202513 @anantasty: If you could look through the code and mark places where you're like What the heck is going on here, it would be easier for me to write up proper comments

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17802982 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -57,13 +250,709 @@ trait Matrix extends Serializable { * @param

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17803111 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -37,11 +44,197 @@ trait Matrix extends Serializable { private[mllib

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17803169 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -57,13 +250,709 @@ trait Matrix extends Serializable { * @param

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17803825 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -57,13 +250,709 @@ trait Matrix extends Serializable { * @param

[GitHub] spark pull request: [WIP][SPARK-1486][MLlib] Multi Model Training ...

2014-09-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2451#discussion_r17804577 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -93,9 +1000,310 @@ object Matrices { require(dm.majorStride

[GitHub] spark pull request: [SPARK-2434][MLlib]: Warning messages that poi...

2014-07-21 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/1515 [SPARK-2434][MLlib]: Warning messages that point users to original MLlib implementations added to Examples [SPARK-2434][MLlib]: Warning messages that refer users to the original MLlib

[GitHub] spark pull request: [SPARK-2434][MLlib]: Warning messages that poi...

2014-07-21 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/1515#discussion_r15204194 --- Diff: examples/src/main/python/logistic_regression.py --- @@ -47,9 +47,15 @@ def readPointBatch(iterator): return [matrix] if __name__

[GitHub] spark pull request: [SPARK-2801][MLlib]: DistributionGenerator ren...

2014-08-01 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/1732 [SPARK-2801][MLlib]: DistributionGenerator renamed to RandomDataGenerator. RandomRDD is now of generic type The RandomRDDGenerators used to only output RDD[Double]. Now

[GitHub] spark pull request: [SPARK-2852][MLLIB] API consistency for `mllib...

2014-08-06 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/1807#issuecomment-51397316 Looks good to me! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2995][MLLIB] add ALS.setIntermediateDat...

2014-08-13 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/1913#issuecomment-52145683 @mengxr: I would prefer setIntermediateRDDStorageLevel. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-3081][MLLIB] rename RandomRDDGenerators...

2014-08-16 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/1979#issuecomment-52405587 It's a shorter name, and I understand the concern about the confusion. Looks good to me! --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-3136][MLLIB] Create Java-friendly metho...

2014-08-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2041#discussion_r16442838 --- Diff: docs/mllib-stats.md --- @@ -25,7 +25,79 @@ displayTitle: a href=mllib-guide.htmlMLlib/a - Statistics Functionality \newcommand{\zero}{\mathbf{0

[GitHub] spark pull request: [SPARK-3136][MLLIB] Create Java-friendly metho...

2014-08-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2041#discussion_r16443218 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/random/RandomRDDs.scala --- @@ -42,213 +42,165 @@ object RandomRDDs { * * @param sc

[GitHub] spark pull request: [SPARK-3136][MLLIB] Create Java-friendly metho...

2014-08-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2041#discussion_r16443485 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/random/RandomRDDs.scala --- @@ -42,213 +42,165 @@ object RandomRDDs { * * @param sc

[GitHub] spark pull request: [SPARK-3136][MLLIB] Create Java-friendly metho...

2014-08-19 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2041#issuecomment-52713008 LGTM! Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-25 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/2123 [SPARK-2839][MLlib] Stats Toolkit documentation updated Documentation updated for the Statistics Toolkit of MLlib. @mengxr @atalwalkar https://issues.apache.org/jira/browse/SPARK-2839 You

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-25 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/2123#discussion_r16695832 --- Diff: docs/mllib-stats.md --- @@ -99,69 +99,336 @@ v = u.map(lambda x: 1.0 + 2.0 * x) /div -## Stratified Sampling

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-26 Thread brkyvz
Github user brkyvz closed the pull request at: https://github.com/apache/spark/pull/2123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2123#issuecomment-53381256 ?? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-26 Thread brkyvz
GitHub user brkyvz reopened a pull request: https://github.com/apache/spark/pull/2123 [SPARK-2839][MLlib] Stats Toolkit documentation updated Documentation updated for the Statistics Toolkit of MLlib. @mengxr @atalwalkar https://issues.apache.org/jira/browse/SPARK-2839

[GitHub] spark pull request: [SPARK-2839][MLlib] Stats Toolkit documentatio...

2014-08-26 Thread brkyvz
Github user brkyvz closed the pull request at: https://github.com/apache/spark/pull/2123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-05 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/2294 [SPARK-3418] Sparse Matrix support (CCS) and additional native BLAS operations added Local `SparseMatrix` support added in Compressed Column Storage (CCS) format in addition to Level-2 and Level-3

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-05 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-54696200 The following tests were run on a Mac OS X 10.9.3 2.8 GHz Intel Core i7 8 GB 1600 MHz DDR3. Hyper-threading was disabled and turbo boost was turned off

[GitHub] spark pull request: [SPARK-3418] Sparse Matrix support (CCS) and a...

2014-09-09 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/2294#issuecomment-54932214 Performance results on commit eeb13eb ![colb](https://cloud.githubusercontent.com/assets/5243515/4197640/4df94c2a-37ed-11e4-94b9-0c88303f40d0.png) ![colsa

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2014-11-10 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/3200 [SPARK-3974][MLlib] Distributed Block Matrix Abstractions This pull request includes the abstractions for the distributed BlockMatrix representation. `BlockMatrix` will allow users to store

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2014-11-13 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3200#issuecomment-62982228 @mengxr If we have two block matrices, A and B, and A's column block partitioning matches B's row block partitioning, can we take advantage of this fact

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2014-11-14 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r20378789 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,331 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-11-17 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/3319 [SPARK-4409][MLlib] Additional Linear Algebra Utils Addition of a very limited number of local matrix manipulation and generation methods that would be helpful in the further development

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-11-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3319#issuecomment-64505065 @mengxr: Thanks for the feedback. Added the Java tests! horzcat and vertcat are in fact MATLAB methods: http://www.mathworks.com/help/matlab/ref/horzcat.html

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3468#discussion_r20916331 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala --- @@ -112,4 +116,50 @@ class MatricesSuite extends FunSuite

[GitHub] spark pull request: [SPARK-4614][MLLIB] Slight API changes in Matr...

2014-11-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3468#issuecomment-64515054 Looks good to me! Just made one comment, no biggie though, it's fine as is (but if you decide to change it, there are 4 exact copies of it). One comment/question about

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-11-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3319#issuecomment-64713893 I checked MATLAB's webpage, I didn't see any copyright mentions for the method names. It's best to triple check though. Since numPy and sciPy share method names

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-15 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r21881450 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -313,15 +593,145 @@ object Matrices { * @return Square `DenseMatrix

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-15 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r21881510 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -197,6 +295,171 @@ class SparseMatrix( } override def

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-15 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r21881678 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -197,6 +295,171 @@ class SparseMatrix( } override def

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r21929684 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -313,15 +593,145 @@ object Matrices { * @return Square `DenseMatrix

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-17 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r22026283 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -256,72 +524,297 @@ object Matrices { * Generate a `DenseMatrix

[GitHub] spark pull request: [SPARK-4409][MLlib] Additional Linear Algebra ...

2014-12-19 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3319#discussion_r22094195 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -197,6 +331,145 @@ class SparseMatrix( } override def

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-02 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23972143 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-02 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23985067 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -475,6 +501,195 @@ object SparkSubmit { } } +/** Provides

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-02 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-72598548 @JoshRosen I actually don't know what we are missing. I think it only requires testing, because the directory structure (backslashes instead of slashes) and command-line

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-03 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-72674385 @pwendell, I think this is in good shape to go in right before you cut the branch. Having the community test it out under many different settings and setups would help

[GitHub] spark pull request: [SPARK-5660] [mllib] Make Matrix apply public

2015-02-08 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4447#issuecomment-73355639 LGTM, I'm perfectly okay with this. Put those there before just in case --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-03 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r24047567 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -25,6 +25,18 @@ import scala.collection.mutable.{ArrayBuffer, HashMap, Map

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-02-03 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r24047115 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -25,6 +25,18 @@ import scala.collection.mutable.{ArrayBuffer, HashMap, Map

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-16 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23118561 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-5321] Support for transposing local mat...

2015-01-19 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4109 [SPARK-5321] Support for transposing local matrices Support for transposing local matrices added. The `.transpose` function creates a new object re-using the backing array(s) but switches `numRows

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23241236 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23271303 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23271456 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-5321] Support for transposing local mat...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4109#discussion_r23278231 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -114,21 +106,47 @@ class DenseMatrix(val numRows: Int, val numCols: Int

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23271097 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-20 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23271028 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-5811] Added documentation for maven coo...

2015-02-17 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4662#issuecomment-74770805 Adding spark-packages as a repo broke one test. Pushing update once I make sure it passes it locally. --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-5507] Added documentation for BlockMatr...

2015-02-17 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4664 [SPARK-5507] Added documentation for BlockMatrix Docs for BlockMatrix. @mengxr You can merge this pull request into a Git repository by running: $ git pull https://github.com/brkyvz/spark

[GitHub] spark pull request: [SPARK-5864] [PySpark] support .jar as python ...

2015-02-17 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4652#issuecomment-74727279 @pwendell this is not enough to support Spark Packages with pyspark but solves the harder half of the problem. I have a follow up patch that adds jars in `--packages

[GitHub] spark pull request: [SPARK-5811] Added documentation for maven coo...

2015-02-17 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4662 [SPARK-5811] Added documentation for maven coordinates and added Spark Packages support Documentation for maven coordinates + Spark Package support. Added pyspark tests for `--packages` You can

[GitHub] spark pull request: [SPARK-5321] Support for transposing local mat...

2015-01-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4109#discussion_r23583664 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -34,6 +34,9 @@ sealed trait Matrix extends Serializable { /** Number

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/3200#discussion_r23589329 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -0,0 +1,242 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [WIP][SPARK-5341] Use maven coordinates as dep...

2015-01-26 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4215 [WIP][SPARK-5341] Use maven coordinates as dependencies in spark-shell and spark-submit This PR adds support for using maven coordinates as dependencies to spark-shell. Coordinates can

[GitHub] spark pull request: [SPARK-5321] Support for transposing local mat...

2015-01-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4109#discussion_r23591427 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/linalg/MatricesSuite.scala --- @@ -212,6 +284,17 @@ class MatricesSuite extends FunSuite

[GitHub] spark pull request: [SPARK-3977] Conversion methods for BlockMatri...

2015-01-28 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4256 [SPARK-3977] Conversion methods for BlockMatrix to other Distributed Matrices The conversion methods for `BlockMatrix`. Conversions go through `CoordinateMatrix` in order to cause a shuffle so

[GitHub] spark pull request: [SPARK-3974][MLlib] Distributed Block Matrix A...

2015-01-28 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/3200#issuecomment-71859402 @mengxr I don't know if `rows` and `cols` will be confusing in terms of naming in GridPartitioner... However, since it is private and internal, maybe it's

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-28 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-71929196 @pwendell @mateiz I think the PR is ready for code review. I would appreciate your comments! --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-3975] Added support for BlockMatrix add...

2015-01-29 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4274 [SPARK-3975] Added support for BlockMatrix addition and multiplication Support for multiplying and adding large distributed matrices! You can merge this pull request into a Git repository by running

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23879684 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala --- @@ -123,6 +126,7 @@ private[spark] class SparkSubmitArguments(args: Seq

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-72282474 @JoshRosen thank you very much for the time and comments. I'll fix things immediately --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23879289 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala --- @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-3975] Added support for BlockMatrix add...

2015-01-30 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4274#discussion_r23862043 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala --- @@ -237,4 +239,88 @@ class BlockMatrix( val localMat

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-72283499 I will add documentation during the QA period --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23877788 --- Diff: core/pom.xml --- @@ -225,6 +225,16 @@ scopetest/scope /dependency dependency + groupIdorg.apache.ivy/groupId

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-30 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4215#discussion_r23879232 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -431,6 +458,155 @@ object SparkSubmit { } } +/** Provides

[GitHub] spark pull request: [SPARK-5341] Use maven coordinates as dependen...

2015-01-31 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4215#issuecomment-72326441 Interesting... The tests are successful on my local computer but fails in Jenkins... The end to end test that downloads spark-avro and spark-csv succeeds which is nice

[GitHub] spark pull request: [SPARK-5321] Support for transposing local mat...

2015-01-26 Thread brkyvz
Github user brkyvz commented on a diff in the pull request: https://github.com/apache/spark/pull/4109#discussion_r23573354 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Matrices.scala --- @@ -92,6 +84,16 @@ sealed trait Matrix extends Serializable

[GitHub] spark pull request: [SPARK-2313] Use socket to communicate Gateway...

2015-02-14 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4603#issuecomment-74388179 This fixes the problem! looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-5979][SPARK-6031][SPARK-6032][SPARK-604...

2015-02-27 Thread brkyvz
Github user brkyvz closed the pull request at: https://github.com/apache/spark/pull/4754 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-5979][SPARK-6031][SPARK-6032] Refactori...

2015-02-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76289777 Flaky test this time... @tdas, can you have this retested please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76019148 @tdas I think that's returning an error now, because the class in fact doesn't really exist in the jar. Not because it's not in the classpath --- If your project is set

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76019805 nvm, it should be in spark-streaming-kafka_2.10.jar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5958][MLLIB][DOC] update block matrix u...

2015-02-23 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4737#issuecomment-75684685 LGTM. I thought it would be nice to show how people can go back to `RowMatrix` and call SVD after some operations, but we can keep it simple. I apologize for missing

[GitHub] spark pull request: [SPARK-5979][SPARK-6031][SPARK-6032] Refactori...

2015-02-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76215606 This passed locally. What the... On Feb 26, 2015 8:39 AM, UCB AMPLab notificati...@github.com wrote: Test FAILed. Refer to this link for build results

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76108899 @tdas @pwendell @andrewor14 This is ready for code review. Moved the resolve method to DriverBootstrapper. In case the DriverBootstrapper is not called

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76118756 It might not be a flaky test. I might have broken some Yarn feature. I'm going to check once I get home. On Feb 25, 2015 8:01 PM, Tathagata Das notificati

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-25 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76123576 @tdas The latest commit fixed the issue, feel free to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-24 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-75912004 @tdas added a hack to include the jars on --driver-extra-classpath. Can you try your test now? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-5979] Made --package exclusions more re...

2015-02-24 Thread brkyvz
GitHub user brkyvz opened a pull request: https://github.com/apache/spark/pull/4754 [SPARK-5979] Made --package exclusions more refined @tdas Would you care to try this? I think it should solve your problem You can merge this pull request into a Git repository by running

[GitHub] spark pull request: [SPARK-5979][SPARK-6031][SPARK-6032][SPARK-604...

2015-02-26 Thread brkyvz
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/4754#issuecomment-76304574 @srowen Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   3   4   5   6   7   8   9   10   >