GitHub user hunglin opened a pull request:
https://github.com/apache/spark/pull/4464
[SPARK-5472][SQL] Fix Scala code style
Fix Scala code style.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hunglin/spark SPARK-5472
GitHub user hunglin opened a pull request:
https://github.com/apache/spark/pull/5124
SPARK-6414: Spark driver failed with NPE on job cancelation
Use Option for ActiveJob.properties to avoid NPE bug
You can merge this pull request into a Git repository by running:
$ git pull
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r26900122
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -805,7 +806,7 @@ class DAGScheduler(
}
val
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r27448459
--- Diff: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ---
@@ -173,4 +176,21 @@ class SparkContextSuite extends FunSuite
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r27448572
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -675,7 +675,7 @@ class DAGScheduler(
// Cancel all jobs belonging
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r27315656
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -474,13 +477,13 @@ class SparkContext(config: SparkConf) extends Logging
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r27305215
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -474,13 +477,13 @@ class SparkContext(config: SparkConf) extends Logging
Github user hunglin commented on the pull request:
https://github.com/apache/spark/pull/5124#issuecomment-86769103
@JoshRosen , thanks for the help. I updated this PR with
1. regression test
2. use Option[Properties] for the value of SparkContext.localProperties
3. add
Github user hunglin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5124#discussion_r26977523
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -805,7 +806,7 @@ class DAGScheduler(
}
val
Github user hunglin commented on the pull request:
https://github.com/apache/spark/pull/5124#issuecomment-87142944
@JoshRosen I updated PR, please review. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hunglin commented on the pull request:
https://github.com/apache/spark/pull/5124#issuecomment-85186794
@JoshRosen thanks for the suggestions. Let's me work on those tonight.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user hunglin commented on the pull request:
https://github.com/apache/spark/pull/5124#issuecomment-89140693
@JoshRosen, no problem. I'm happy to contribute.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hunglin commented on the pull request:
https://github.com/apache/spark/pull/5124#issuecomment-88995927
@JoshRosen, thanks for the help. I just rebased this PR against master.
It should also fix the conflict.
---
If your project is set up for it, you can reply
13 matches
Mail list logo
