[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179174442 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179191524 --- Diff: core/src/test/scala/org/apache/spark/CacheRecoveryManagerSuite.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-04 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r179179616 --- Diff: core/src/test/scala/org/apache/spark/scheduler/CacheRecoveryIntegrationSuite.scala --- @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20640#discussion_r179013270 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -108,6

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20640#discussion_r179012299 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -648,14 +645,8

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20640#discussion_r179012891 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -571,7 +568,7

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178967925 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178966943 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178967087 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178964472 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -250,6 +255,44 @@ class BlockManagerMasterEndpoint

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178968393 --- Diff: core/src/main/scala/org/apache/spark/CacheRecoveryManager.scala --- @@ -0,0 +1,201 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-04-03 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r178959007 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -246,6 +251,38 @@ class BlockManagerMasterEndpoint

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-23 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 ah ok, yes when run in isolation, the stage will be 0, so your change makes sense. But that is not what is making it flaky in a full test run

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 > if I execute the test on my machine alone it never pass. you mean it never fails on your machine, right? its only flaky when you run everything on jenk

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 hmm you're right, I was looking at a different branch in my editor and didn't pay attention that it was reset in the code I linked to on master, oops. I still dont' understand your proposed

[GitHub] spark issue #20888: [SPARK-23775][TEST] DataFrameRangeSuite should wait for ...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20888 I think you're right about killing the wrong stage, but I don't think its exactly what you've outlined. The original code doesn't try to kill a stage with ID == 0 -- instead its just waiting until

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-03-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20604 @vanzin @sitalkedia @jiangxb1987 I was looking at this code again, and I'd appreciate your thoughts on how this relates to [SPARK-21834](https://issues.apache.org/jira/browse/SPARK-21834) https

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20657 @jerryshao I know you said you wanted to take a deeper look, but its been a while. otherwise I'll merge in the next day or two

[GitHub] spark issue #20853: [SPARK-23729][SS] Glob resolution is done without the fr...

2018-03-19 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20853 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20770: [SPARK-23626][CORE] DAGScheduler blocked due to JobSubmi...

2018-03-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20770 took a quick look, agree with shivaram's observations, you've got to handle `shuffleIdToMapStage` which will not be so easy

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20742 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r175171592 --- Diff: docs/security.md --- @@ -3,47 +3,291 @@ layout: global displayTitle: Spark Security title: Security --- +* This will become

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r175173523 --- Diff: docs/security.md --- @@ -182,54 +582,70 @@ configure those ports. -### HTTP Security Headers -Apache Spark can

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r175170426 --- Diff: docs/security.md --- @@ -3,47 +3,291 @@ layout: global displayTitle: Spark Security title: Security --- +* This will become

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-03-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19041 Thanks @brad-kaiser -- want to re-iterate my comment from Feb 2nd, I think that is really the most important part to address before getting into the details of the current implementation

[GitHub] spark pull request #19041: [SPARK-21097][CORE] Add option to recover cached ...

2018-03-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/19041#discussion_r175164254 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala --- @@ -246,6 +251,38 @@ class BlockManagerMasterEndpoint

[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-03-07 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20685 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-03-07 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20685 I agree with @cloud-fan . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-07 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20657 btw I took a look at the code in `MesosHadoopDelegationTokenManager`, there seems to be a lot of duplication that could probably be factored out, and I wonder if the things that are different really

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-07 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172954706 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -93,11 +93,24 @@ private[spark] class Client

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-07 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172963955 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala --- @@ -18,221 +18,156 @@ package

[GitHub] spark issue #20685: [SPARK-23524] Big local shuffle blocks should not be che...

2018-03-06 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20685 it'll also help with disk corruption ... from the stack traces in SPARK-4105 you can't really tell what the source of the problem is. it'll be pretty hard to determine what the source of corruption

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172581601 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -144,7 +145,8 @@ class SparkHadoopUtil extends Logging { private

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172579936 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -520,4 +520,16 @@ package object config { .checkValue(v =>

[GitHub] spark pull request #20685: [SPARK-23524] Big local shuffle blocks should not...

2018-03-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20685#discussion_r172579121 --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala --- @@ -352,6 +352,63 @@ class

[GitHub] spark issue #20740: [SPARK-23604][SQL] Change Statistics.isEmpty to !Statist...

2018-03-05 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20740 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172319244 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala --- @@ -18,221 +18,156 @@ package

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172322650 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -520,4 +520,16 @@ package object config { .checkValue(v =>

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172323592 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala --- @@ -18,221 +18,156 @@ package

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172325576 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -144,7 +145,8 @@ class SparkHadoopUtil extends Logging { private

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r172321966 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala --- @@ -1009,7 +987,7 @@ private[spark] class Client

[GitHub] spark pull request #20685: [SPARK-23524] Big local shuffle blocks should not...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20685#discussion_r172226910 --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala --- @@ -352,6 +352,63 @@ class

[GitHub] spark pull request #20685: [SPARK-23524] Big local shuffle blocks should not...

2018-03-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20685#discussion_r172232973 --- Diff: core/src/test/scala/org/apache/spark/storage/ShuffleBlockFetcherIteratorSuite.scala --- @@ -352,6 +352,63 @@ class

[GitHub] spark pull request #20604: [SPARK-23365][CORE] Do not adjust num executors w...

2018-02-23 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20604#discussion_r170383918 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala --- @@ -55,18 +55,18 @@ private[spark] trait ExecutorAllocationClient

[GitHub] spark issue #20645: SPARK-23472: Add defaultJavaOptions for drivers and exec...

2018-02-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20645 I agree it would be nicer to have this be a more general feature. I would prefer an approach which didn't require a different configuration name, just as its more to document & for users to

[GitHub] spark issue #20652: [SPARK-23476][CORE] Generate secret in local mode when a...

2018-02-22 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20652 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 sure @skonto, great to have somebody more knowledgable on mesos taking a closer look at this. sorry @IgorBerman I promised a quick fix here, but have realized this is more complicated than

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 cc @attilapiros , you may be interested b/c of how this relates to SPARK-16630 --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 ok hmm ... so actually this change would lose some important functionality then. unfortunately I don't have a clear picture yet of how to solve SPARK-16630 along with the other blacklisting

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 @susanxhuynh good point about changing default behavior. I'd rather have the change so we have more unified behavior between mesos and other cluster managers. But I have never run spark on mesos

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 thanks @IgorBerman, description looks fine to me now, maybe I saw it wrong before. your test sounds pretty good to me ... you could turn on debug logging

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20604 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-21 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20604 known flaky test: https://issues.apache.org/jira/browse/SPARK-23458 --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20635 thanks @ivoson , merged! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #17619: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17619 for anyone watching this: @IgorBerman submitted an updated version of this here https://github.com/apache/spark/pull/20640 which I plan to merge unless there are any objections

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 lgtm @IgorBerman can you cleanup the PR description a little? headers got duplicated. And I'd reword a bit to something like > This updates the Mesos scheduler to integr

[GitHub] spark pull request #17619: [SPARK-19755][Mesos] Blacklist is always active f...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17619#discussion_r169458952 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -484,7 +481,6

[GitHub] spark pull request #20604: [SPARK-23365][CORE] Do not adjust num executors w...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20604#discussion_r169438419 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -455,7 +461,12 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #20604: [SPARK-23365][CORE] Do not adjust num executors w...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20604#discussion_r169437530 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1643,7 +1646,10 @@ class SparkContext(config: SparkConf) extends Logging

[GitHub] spark pull request #20604: [SPARK-23365][CORE] Do not adjust num executors w...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20604#discussion_r169436456 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -334,6 +336,10 @@ private[spark] class ExecutorAllocationManager

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20640#discussion_r169413261 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -108,6

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 thanks for updating. can you also update the PR description? yeah its fine to just update this one. You can't in general update others' prs, unless they give you push permissions

[GitHub] spark pull request #20640: [SPARK-19755][Mesos] Blacklist is always active f...

2018-02-20 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20640#discussion_r169391079 --- Diff: resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala --- @@ -108,6

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 I understand if you want to do something like this for yourself to unblock, but I think I'm -1 on merging this because of adding more configs just for a stopgap. but I think we agree

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 @IgorBerman I actually think that https://github.com/apache/spark/pull/17619 is the right approach. As @timout pointed out on that one, this functionality doesn't need to be covered in mesos

[GitHub] spark issue #20640: [SPARK-19755][Mesos] Blacklist is always active for Meso...

2018-02-20 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20640 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20635 Jenkins, Ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #20635: [SPARK-23053][CORE][BRANCH-2.1] taskBinarySerialization ...

2018-02-18 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20635 lgtm assuming tests pass --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-02-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20604 @tgravescs @vanzin @zsxwing could you take a look? thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20424: [Spark-23240][python] Better error message when extraneo...

2018-02-16 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20424 still lgtm, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20623: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-15 Thread squito
Github user squito closed the pull request at: https://github.com/apache/spark/pull/20623 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Executor I...

2018-02-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20601 ack I merged to master but screwed up on 2.3 -- fixing that here: https://github.com/apache/spark/pull/20623

[GitHub] spark pull request #20623: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-15 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/20623 [SPARK-23413][UI] Fix sorting tasks by Host / Executor ID at the Stag… …e page ## What changes were proposed in this pull request? Fixing exception got at sorting tasks by Host

[GitHub] spark issue #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Executor I...

2018-02-15 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20601 Everything that might have changed from this has passed, the failures are known flaky tests: https://issues.apache.org/jira/browse/SPARK-23369 https://issues.apache.org/jira/browse

[GitHub] spark pull request #17619: [SPARK-19755][Mesos] Blacklist is always active f...

2018-02-15 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17619#discussion_r168509141 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -484,7 +481,6

[GitHub] spark issue #17208: [SPARK-19868] conflict TasksetManager lead to spark stop...

2018-02-14 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17208 hmm I think you're right @zsxwing that we should be updating `isZombie` before `sched.dagScheduler.taskEnded` and `sched.dagScheduler.taskSetFailed` is called, just to keep state consistent. I

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168313710 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private object

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-14 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r168211371 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private object

[GitHub] spark issue #20596: [SPARK-23404][CORE]When the underlying buffers are direc...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20596 Have you seen a case where you actually have an off-heap buffer passed in, though the desire storage is on-heap? Eg. if its comes from the block transfer service than I think it will always

[GitHub] spark issue #20474: [SPARK-23235][Core] Add executor Threaddump to api

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20474 merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #20604: [WIP][SPARK-23365][CORE] Do not adjust num execut...

2018-02-13 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/20604 [WIP][SPARK-23365][CORE] Do not adjust num executors when killing idle executors. The ExecutorAllocationManager should not adjust the target number of executors when killing idle executors

[GitHub] spark issue #20532: [SPARK-23353][CORE] Allow ExecutorMetricsUpdate events t...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20532 I agree with @jiangxb1987 ... we already have issues with event logs being too big, as it the driver gets backlogged even writing them out, and then the history server takes a long time to parse

[GitHub] spark pull request #20601: [SPARK-23413][UI] Fix sorting tasks by Host / Exe...

2018-02-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20601#discussion_r167991914 --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala --- @@ -963,33 +965,60 @@ private[ui] class TaskPagedTable( private object

[GitHub] spark issue #20424: [Spark-23240][python] Better error message when extraneo...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20424 ah got it. sounds good to me, I will defer to @HyukjinKwon 's judgement. I think this change looks fine --- - To unsubscribe

[GitHub] spark issue #20474: [SPARK-23235][Core] Add executor Threaddump to api

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20474 lgtm --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #19788: [SPARK-9853][Core] Optimize shuffle fetch of contiguous ...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/19788 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #20424: [Spark-23240][python] Better error message when extraneo...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20424 lgtm @bersprockets you mentioned wanting to try the other route as well -- whats the status on that? shoudl we still wait on this one

[GitHub] spark pull request #20474: [SPARK-23235][Core] Add executor Threaddump to ap...

2018-02-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20474#discussion_r167917613 --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala --- @@ -51,6 +51,29 @@ private[v1] class

[GitHub] spark pull request #20474: [SPARK-23235][Core] Add executor Threaddump to ap...

2018-02-13 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20474#discussion_r167917733 --- Diff: docs/monitoring.md --- @@ -347,6 +347,10 @@ can be identified by their `[attempt-id]`. In the API listed below, when running

[GitHub] spark issue #20244: [SPARK-23053][CORE] taskBinarySerialization and task par...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20244 merged to master / 2.3 / 2.2 I hit a merge conflict trying to merge to 2.1 -- feel free to open another PR for that version

[GitHub] spark issue #20408: [SPARK-23189][Core][Web UI] Reflect stage level blacklis...

2018-02-13 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20408 merged to master, thanks everyone --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #20532: [SPARK-23353][CORE] Allow ExecutorMetricsUpdate events t...

2018-02-08 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20532 I can see why you want this sometimes, but I'm trying to figure out if its really valuable for users in general. You could always add a custom listener to log this info. It would go into separate

[GitHub] spark pull request #20244: [SPARK-23053][CORE] taskBinarySerialization and t...

2018-02-08 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20244#discussion_r167138603 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -2399,6 +2424,121 @@ class DAGSchedulerSuite extends SparkFunSuite

[GitHub] spark issue #20408: [SPARK-23189][Core][Web UI] Reflect stage level blacklis...

2018-02-08 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20408 just a quick note -- I realized I was confused about one part of the inner workings of the history server which I want to confirm before I merge this, but got sick and now have a bit of a backlog

[GitHub] spark pull request #20244: [SPARK-23053][CORE] taskBinarySerialization and t...

2018-02-06 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20244#discussion_r166458357 --- Diff: core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala --- @@ -2399,6 +2424,121 @@ class DAGSchedulerSuite extends SparkFunSuite

[GitHub] spark pull request #20451: [SPARK-23146][WIP] Support client mode for Kubern...

2018-02-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20451#discussion_r166087229 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/OptionRequirements.scala --- @@ -0,0 +1,40

[GitHub] spark pull request #20493: [SPARK-23326][WEBUI]schedulerDelay should return ...

2018-02-05 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/20493#discussion_r166068708 --- Diff: core/src/test/scala/org/apache/spark/status/AppStatusUtilsSuite.scala --- @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #17422: [SPARK-20087] Attach accumulators / metrics to 'T...

2018-02-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17422#discussion_r165772194 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -429,15 +429,42 @@ private[spark] class Executor( case t

[GitHub] spark pull request #17422: [SPARK-20087] Attach accumulators / metrics to 'T...

2018-02-02 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/17422#discussion_r165772055 --- Diff: core/src/main/scala/org/apache/spark/TaskEndReason.scala --- @@ -212,9 +212,19 @@ case object TaskResultLost extends TaskFailedReason

[GitHub] spark issue #17422: [SPARK-20087] Attach accumulators / metrics to 'TaskKill...

2018-02-02 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/17422 @advancedxy this has been quiet for a long time, so I suggest you just take it over. I actually think this is so close to complete that very little would need to be done, and credit would most

<    3   4   5   6   7   8   9   10   11   12   >