Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/5471#issuecomment-92098429
Thanks for fixing this @srowen. I am not familiar with the SBT system and
the change looks good w.r.t maven (except that the file needs to be moved to
the dev
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1076#issuecomment-50825980
Hi @andrewor14, you are right. But I thought this would be a nice addition
(although out of scope for this change). Using the new method applications
(possibly
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15675679
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -357,6 +357,7 @@ private[spark] class Worker
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15681558
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -154,6 +154,8 @@ private[spark] class Master
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15626358
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -91,6 +91,10 @@ private[spark] class MetricsSystem private (val
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15626384
--- Diff: core/src/main/scala/org/apache/spark/metrics/sink/Sink.scala ---
@@ -20,4 +20,5 @@ package org.apache.spark.metrics.sink
private[spark
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15626682
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -154,6 +154,8 @@ private[spark] class Master
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1076#issuecomment-50545834
Hi Matei, yes, the report() call is blocking. The time it takes will depend
on the underlying reporter. For e.g., the CsvReporter which updates files on
local
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1550#issuecomment-50299232
The default maven phase for this plugin was `verify` which would have been
ideal since it is not run as part of `package` but is part of `install`. But I
wanted
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1550#discussion_r15387188
--- Diff: pom.xml ---
@@ -957,6 +957,30 @@
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-source-plugin/artifactId
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/1550
SPARK-2651: Add maven scalastyle plugin
Can be run as: mvn scalastyle:check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Guavus
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49828457
@tgravescs No problem at all. Updated patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49830504
@tgravescs There does not seem to be a maven goal to check scalastyle,
isn't this something we want?
---
If your project is set up for it, you can reply
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1094#discussion_r15206722
--- Diff:
yarn/alpha/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala
---
@@ -289,7 +289,7 @@ class ExecutorLauncher(args
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49572410
@tgravescs updated according to your comments and rebased to current HEAD
of master branch.
---
If your project is set up for it, you can reply to this email
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-49133859
@tgravescs updated according to your comments and rebased to current HEAD
of master branch. Thanks for following up on this PR.
---
If your project is set up
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1112#issuecomment-47306598
Tested successfully that the UI URL is correctly displayed in RM UI and
that the spark UI is correctly rendered.
---
If your project is set up for it, you can
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1112#discussion_r14279134
--- Diff: core/src/main/scala/org/apache/spark/ui/UIUtils.scala ---
@@ -135,7 +135,16 @@ private[spark] object UIUtils extends Logging
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1112#discussion_r14279155
--- Diff:
yarn/stable/src/main/scala/org/apache/spark/deploy/yarn/ExecutorLauncher.scala
---
@@ -142,9 +149,20 @@ class ExecutorLauncher(args
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47064230
@vanzin I was only referring to how the UI URL is passed around. I have
used the longer way of passing it around using command line arguments whereas
the other
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-47184407
Am I supposed to resolve the conflicts or will they be resolved by the
admin who merges this change?
---
If your project is set up for it, you can reply
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46804664
@sryza thanks for the thumbs up.
Although I wonder if the approach in
https://github.com/apache/spark/pull/1112 is better for passing the UI address
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/1094#issuecomment-46213984
Hi @vanzin,
I don't have any preference as to how the URL is formatted and I think that
changing the URL can be a separate activity. I am hoping
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/1094
SPARK-2150: Provide direct link to finished application UI in yarn resou...
...rce manager UI
Use the event logger directory to provide a direct link to finished
application UI
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1067#discussion_r13741193
--- Diff: core/src/main/scala/org/apache/spark/metrics/sink/CsvSink.scala
---
@@ -53,11 +53,14 @@ private[spark] class CsvSink(val property
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/1076
SPARK-2134: Report metrics before application finishes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Guavus/spark SPARK-2134
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r13750359
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -154,6 +154,8 @@ private[spark] class Master
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/1067
SPARK-2127: Use application specific folders to dump metrics via CsvSink
Generate an unique app name which is used to create events and metric
folders.
You can merge this pull request
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/1067#discussion_r13701712
--- Diff: core/src/main/scala/org/apache/spark/metrics/sink/CsvSink.scala
---
@@ -53,11 +53,14 @@ private[spark] class CsvSink(val property
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/580#issuecomment-41597857
Seems to be a unit test failure but that should be not be related to this
change.
---
If your project is set up for it, you can reply to this email and have
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/572
SPARK-1650: Correctly identify maven project version
Better account for various side-effect outputs while executing
mvn help:evaluate -Dexpression=project.version
You can merge
GitHub user rahulsinghaliitd opened a pull request:
https://github.com/apache/spark/pull/573
SPARK-1651: Delete existing deployment directory
Small bug fix to make sure the spark contents are copied to the
deployment directory correctly.
You can merge this pull request
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/572#discussion_r12031345
--- Diff: make-distribution.sh ---
@@ -43,7 +43,7 @@
FWDIR=$(cd `dirname $0`; pwd)
DISTDIR=$FWDIR/dist
-VERSION=$(mvn
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/572#issuecomment-41508778
Thanks, I had recently used a maven build and encountered this problem. I
even had a local commit to add the maven build to make-distribution.sh but you
beat me
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/572#issuecomment-41509168
I am noob to GitHub and Spark upstream procedures, so confused about what
happens when a pull request is accepted.
1. Is the PR merged or rebased
Github user rahulsinghaliitd commented on the pull request:
https://github.com/apache/spark/pull/573#issuecomment-41522625
Thanks @pwendell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11917001
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging
Github user rahulsinghaliitd commented on a diff in the pull request:
https://github.com/apache/spark/pull/433#discussion_r11920472
--- Diff:
yarn/common/src/main/scala/org/apache/spark/deploy/yarn/ClientBase.scala ---
@@ -354,63 +354,85 @@ trait ClientBase extends Logging
38 matches
Mail list logo
