[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466767625 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -353,4 +353,8 @@ object AggUtils {

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466765987 ## File path: sql/core/src/main/java/org/apache/spark/sql/execution/UnsafeFixedWidthAggregationMap.java ## @@ -63,6 +63,14 @@ */ private final

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466765488 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala ## @@ -353,4 +353,8 @@ object AggUtils {

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466757897 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -409,6 +411,12 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466760439 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466760439 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466758218 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466757897 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -409,6 +411,12 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466756945 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466440577 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,29 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r466377228 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -680,6 +688,16 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r451882430 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,25 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r451880238 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,25 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r451879710 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,25 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r447512443 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r447512443 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r446720097 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r446571681 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r443119807 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2196,6 +2196,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r443119418 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -879,42 +901,53 @@ case class

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r441932845 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -2173,6 +2173,13 @@ object SQLConf { .checkValue(bit

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r441932524 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala ## @@ -72,6 +74,8 @@ case class HashAggregateExec(

[GitHub] [spark] maropu commented on a change in pull request #28804: [SPARK-31973][SQL] Add ability to disable Sort,Spill in Partial aggregation

maropu commented on a change in pull request #28804: URL: https://github.com/apache/spark/pull/28804#discussion_r439160476 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala ## @@ -165,6 +166,26 @@ class WholeStageCodegenSuite