Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82138 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82138/testReport)**
for PR 19222 at commit
[`0714ddc`](https://github.com/apache/spark/commit/07
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82132/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82132 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82132/testReport)**
for PR 19222 at commit
[`7ec26f6`](https://github.com/apache/spark/commit/7
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82132 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82132/testReport)**
for PR 19222 at commit
[`7ec26f6`](https://github.com/apache/spark/commit/7e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82118/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82118/testReport)**
for PR 19222 at commit
[`8ec08ba`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82118/testReport)**
for PR 19222 at commit
[`8ec08ba`](https://github.com/apache/spark/commit/8e
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82116/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82116 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82116/testReport)**
for PR 19222 at commit
[`8ec08ba`](https://github.com/apache/spark/commit/8
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82116 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82116/testReport)**
for PR 19222 at commit
[`8ec08ba`](https://github.com/apache/spark/commit/8e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82100/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82100 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82100/testReport)**
for PR 19222 at commit
[`66bfbfc`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82100 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82100/testReport)**
for PR 19222 at commit
[`66bfbfc`](https://github.com/apache/spark/commit/66
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: rev
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82080/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82080 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82080/testReport)**
for PR 19222 at commit
[`61d506e`](https://github.com/apache/spark/commit/6
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82089 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82089/testReport)**
for PR 19222 at commit
[`66bfbfc`](https://github.com/apache/spark/commit/66
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82078/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82078 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82078/testReport)**
for PR 19222 at commit
[`e4779d0`](https://github.com/apache/spark/commit/e
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82087 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82087/testReport)**
for PR 19222 at commit
[`24ad970`](https://github.com/apache/spark/commit/24
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19222
Ok, I missed that you had moved these into the base class. I still look
forward to the benchmark :)...
I still think that the hierarchy does give any benefit. All block
subclasses implem
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/19222
As @hvanhovell pointed out, the first implementation introduced a lot
polymorphic call sites in very performance critical code (e.g.
`getBaseObject()` or `getBaseOffset()`. While `MemoryBlock` class h
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/19222
Circling back to the inheritance discussion. My worry is that this will
introduce a lot polymorphic call sites in very performance critical code. Even
if you tag on final to each method, the call
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82083 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82083/testReport)**
for PR 19222 at commit
[`51d9935`](https://github.com/apache/spark/commit/51
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19222
(I have been following this out of my curiosity but I think this should be
credit to @kiszk ...)
---
-
To unsubscribe, e-mai
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82080 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82080/testReport)**
for PR 19222 at commit
[`61d506e`](https://github.com/apache/spark/commit/61
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82078 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82078/testReport)**
for PR 19222 at commit
[`e4779d0`](https://github.com/apache/spark/commit/e4
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82044/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82044 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82044/testReport)**
for PR 19222 at commit
[`4606ecf`](https://github.com/apache/spark/commit/4
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #82044 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82044/testReport)**
for PR 19222 at commit
[`4606ecf`](https://github.com/apache/spark/commit/46
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81889 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81889/testReport)**
for PR 19222 at commit
[`7c2c0cb`](https://github.com/apache/spark/commit/7
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81889/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81889 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81889/testReport)**
for PR 19222 at commit
[`7c2c0cb`](https://github.com/apache/spark/commit/7c
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81793/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81793 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81793/testReport)**
for PR 19222 at commit
[`9711251`](https://github.com/apache/spark/commit/9
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81793 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81793/testReport)**
for PR 19222 at commit
[`9711251`](https://github.com/apache/spark/commit/97
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19222
BTW, mind adding `Closes #11494` in the PR description so that that one can
be closed automatically when this one is merged?
---
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81731/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19222
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional comma
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81731 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81731/testReport)**
for PR 19222 at commit
[`b7ffa10`](https://github.com/apache/spark/commit/b
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19222
**[Test build #81731 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81731/testReport)**
for PR 19222 at commit
[`b7ffa10`](https://github.com/apache/spark/commit/b7
401 - 451 of 451 matches
Mail list logo
