Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14834
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79518247
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79517559
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515456
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -67,11 +105,15 @@ class LogisticRegressionSuite
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515439
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -22,28 +22,49 @@ import scala.language.existentials
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515424
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1103,6 +1382,7 @@ class BinaryLogisticRegressionSummary
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515434
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -430,8 +431,9 @@ class LogisticRegressionWithLBFGS
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515057
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -66,11 +69,37 @@ private[classification] trait
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79515040
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79509186
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -676,39 +941,53 @@ object LogisticRegressionModel extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79507627
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79510132
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/OneVsRestSuite.scala ---
@@ -60,7 +60,8 @@ class OneVsRestSuite extends SparkFunSuite with
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79510068
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/CrossValidatorSuite.scala ---
@@ -244,7 +244,8 @@ class CrossValidatorSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79509747
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -67,11 +105,15 @@ class LogisticRegressionSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79510095
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tuning/TrainValidationSplitSuite.scala
---
@@ -133,7 +133,8 @@ class TrainValidationSplitSuite
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79509600
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -22,28 +22,49 @@ import scala.language.existentials
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79507486
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79508998
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -1103,6 +1382,7 @@ class BinaryLogisticRegressionSummary
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79506294
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -66,11 +69,37 @@ private[classification] trait
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79509539
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/classification/LogisticRegression.scala
---
@@ -430,8 +431,9 @@ class LogisticRegressionWithLBFGS
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r79507775
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,51 @@ object LogisticRegression extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78774078
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -676,39 +936,54 @@ object LogisticRegressionModel extends
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78688637
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -595,55 +831,104 @@ class LogisticRegressionModel
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78688210
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,42 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78674556
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala
---
@@ -201,11 +201,24 @@ abstract class
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r7867
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -676,39 +936,54 @@ object LogisticRegressionModel extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78674092
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -595,55 +831,104 @@ class LogisticRegressionModel
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78673689
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -508,11 +680,42 @@ object LogisticRegression extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78483816
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -460,33 +577,74 @@ class LogisticRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78464458
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -323,32 +382,33 @@ class LogisticRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78464517
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -460,33 +577,74 @@ class LogisticRegression
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78464438
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78420053
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -460,33 +577,74 @@ class LogisticRegression
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78419383
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78389388
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")
Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r7839
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -460,33 +577,74 @@ class LogisticRegression
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78321887
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -460,33 +577,74 @@ class LogisticRegression
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78321247
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -323,32 +382,33 @@ class LogisticRegression
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78321146
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78316060
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -311,8 +350,28 @@ class LogisticRegression @Since("1.2.0")
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14834#discussion_r78315600
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -261,6 +299,7 @@ class LogisticRegression @Since("1.2.0")
41 matches
Mail list logo
