[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r417036409 ## File path: R/pkg/R/DataFrame.R ## @@ -2609,18 +2608,17 @@ setMethod("join", if (is.null(joinType)) { sdf <- call

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r416468623 ## File path: R/pkg/R/utils.R ## @@ -804,7 +807,7 @@ handledCallJMethod <- function(obj, method, ...) { captureJVMException <- function(e, metho

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415704429 ## File path: R/pkg/R/DataFrame.R ## @@ -2587,18 +2589,18 @@ setMethod("join", if (is.null(joinType)) { sdf <- call

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415687299 ## File path: R/pkg/R/install.R ## @@ -293,7 +289,7 @@ sparkCachePath <- function() { Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("H

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415683919 ## File path: R/pkg/R/install.R ## @@ -293,7 +289,7 @@ sparkCachePath <- function() { Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("H

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] Overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415680667 ## File path: R/pkg/R/install.R ## @@ -293,7 +289,7 @@ sparkCachePath <- function() { Sys.getenv("XDG_CACHE_HOME", file.path(Sys.getenv("H

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415607129 ## File path: R/pkg/R/client.R ## @@ -102,10 +102,17 @@ checkJavaVersion <- function() { javaVersionNum <- as.integer(versions[1]) } if

[GitHub] [spark] MichaelChirico commented on a change in pull request #28365: [SPARK-31571][R] overhaul stop/message/warning calls to be more translation-friendly/canonical

MichaelChirico commented on a change in pull request #28365: URL: https://github.com/apache/spark/pull/28365#discussion_r415605354 ## File path: R/pkg/R/DataFrame.R ## @@ -431,7 +431,7 @@ setMethod("coltypes", if (is.null(type)) { specialtype