[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-491158626 > @hehuiyuan That said in my previous comment my concerns are resolved and I have no further things to mention.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-491145696 @srowen I clone the `apach/spark`,but the branch of master has problems.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-491140847 The branch of hehuiyuan-patch-9 has some problems ,which needs to be rebuilt.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-491137460 @srowen Hi, some problems have happened.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-491135813 @srowen Hi, I have deleted that NETWORK_TIMEOUT in this pr , but that looks wring.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-490958482 > > > Closing this. No feedback from its author. Sorry, some things have happened

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-490957492 > > > @gaborgsomogyi do you have any other comments besides the one above and the two at [#24270

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-490957188 > capacity In spark streaming kafka, this parameter `spark.streaming.kafka.consumer.cache.maxCapacity` is

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-09 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-490946741 > > > @hehuiyuan this will need a rebase as your spark.network.timeout change was made separately in another

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-05-05 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-489484927 > Ping @hehuiyuan ? This is an automated

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-18 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-48450 @srowen ``` private[kafka010] val PRODUCER_CACHE_TIMEOUT =

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-18 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-484378461 @srowen actually I realize now that the package statement at the top is wrong! I can't understand what you

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-12 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-482570405 @gaborgsomogyi Hi, I have delete the variable of `MIN_PARTITIONS ` that is useless . ```scala

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-08 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-481100585 > @hehuiyuan I see 2 ways: > > * MAX_OFFSET_PER_TRIGGER.toLowerCase > * Find out whether

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-08 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-481096710 @gaborgsomogyi ```scala new KafkaSource( sqlContext, kafkaOffsetReader,

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-08 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-480814440 @gaborgsomogyi ` private val MAX_OFFSET_PER_TRIGGER_OPTION_KEY = "maxoffsetspertrigger"` ` val

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-03 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-479437518 @attilapiros Thank you very much. I learned a lot.

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-02 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-479349854 > ok to test Hi, this patch fails Scala style tests. [update

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-02 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-479346638 > **[Test build #104231 has

[GitHub] [spark] hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10

2019-04-02 Thread GitBox
hehuiyuan commented on issue #24270: [SPARK-27343][KAFKA][SS]Avoid hardcoded for spark-sql-kafka-0-10 URL: https://github.com/apache/spark/pull/24270#issuecomment-479344872 > **[Test build #104231 has